11345 2006-10-18 01:50:09 -0700 1 fewer shouldChangeSelection delegate call for fast/forms/focus-control-to-page 2006-10-20 12:26:46 -0700 1 1 1 Unclassified WebKit Forms 420+ Mac OS X 10.4 RESOLVED FIXED http://build.webkit.org/results/post-commit-powerpc-mac-os-x/3898/fast/forms/focus-control-to-page-diffs.txt LayoutTestFailure, Regression P2 Normal --- 1 aroben ggaren aroben timothy oldest_to_newest 52021 0 aroben 2006-10-18 01:50:09 -0700 The new listbox control (landed in r16718) broke fast/forms/display-none-in-onchange-keyboard 52020 1 aroben 2006-10-18 01:51:03 -0700 Looking at the test page and tabbing among the controls manually, it seems that the "two" item in the second <select> doesn't get focused. Perhaps this is the problem? 51922 2 aroben 2006-10-18 12:57:39 -0700 I was clearly too tired when filing these bugs. The test broken by this change is actually fast/forms/focus-control-to-page 51923 3 aroben 2006-10-18 12:58:29 -0700 To be clear, r16718 (new RenderListBox) broke fast/forms/focus-control-to-page. 51932 4 adele 2006-10-18 14:19:11 -0700 I rolled out the list box change, and the test still fails 51711 5 ggaren 2006-10-19 15:01:05 -0700 I'll take this one. 51712 6 ggaren 2006-10-19 15:09:52 -0700 Nightlies confirm that this regression happened from r16710 to 16729. 51713 7 ggaren 2006-10-19 15:43:30 -0700 Surprisingly, rolling out 16718 and 16719 doesn't fix the bug. 51719 8 ggaren 2006-10-19 16:57:46 -0700 Narrowed down to 16710:16720. 51720 9 ggaren 2006-10-19 17:15:05 -0700 Narrowed down to 16714:16717. 51721 10 ggaren 2006-10-19 17:27:42 -0700 Narrowed down to 16715:16717, which by the way is impossible, so... ? 51726 11 aroben 2006-10-19 17:59:38 -0700 Did you narrow this down by rolling out changes, or actually going back to those revisions and testing? 51660 12 ggaren 2006-10-20 09:57:52 -0700 Some of each. New data: r16718 has the regression. Rolling back to r16717 fixes the regression. However, Rolling r16718 out of TOT does not fix the regression. 51621 13 11169 ggaren 2006-10-20 12:18:26 -0700 Created attachment 11169 fix Beth reviewed this. 11169 2006-10-20 12:18:26 -0700 2006-10-20 12:18:26 -0700 fix patch-focus-control-to-page.txt text/plain 3938 ggaren SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDE3MTYz KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMzIgQEAKKzIwMDYtMTAt MjAgIEdlb2ZmcmV5IEdhcmVuICA8Z2dhcmVuQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAgIEZpeGVkIGh0dHA6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMzQ1CisgICAgICAgIDEgZmV3ZXIgc2hvdWxk Q2hhbmdlU2VsZWN0aW9uIGRlbGVnYXRlIGNhbGwgZm9yIGZhc3QvZm9ybXMvZm9jdXMtY29udHJv bC10by1wYWdlCisgICAgICAgIAorICAgICAgICBJIHVwZGF0ZWQgdGhpcyB0ZXN0IHRvIHVzZSA8 aW5wdXQgdHlwZT0ic2VhcmNoIj4gYmVjYXVzZSB0aGF0J3MgdGhlIG9ubHkKKyAgICAgICAgcmVt YWluaW5nIEFwcEtpdCBjb250cm9sLCBhbmQgdGhlIHRlc3QncyBpbnRlbnRpb24gaXMgdmVyaWZ5 IHRhYmJpbmcKKyAgICAgICAgYmV0d2VlbiBBcHBLaXQgYW5kIG5vbi1BcHBLaXQgY29udHJvbHMu CisgICAgICAgIAorICAgICAgICBJIHVwZGF0ZWQgdGhlIHJlc3VsdHMgYmVjYXVzZSB0aGUgYmVo YXZpb3IgY2hhbmdlIGlzIGdvb2QuCisgICAgICAgIAorICAgICAgICBIZXJlJ3Mgd2h5IHRoZSB0 ZXN0IHJlZ3Jlc3NlZDoKKyAgICAgICAgCisgICAgICAgIE91ciBlZGl0aW5nIGNvZGUgaXMgY3Jh LXpheS4gV2hlbiBBcHBLaXQgY2FsbHMgbmV4dEtleVZpZXcsIHdlIG5vdCBvbmx5CisgICAgICAg IGNhbGN1bGF0ZSB0aGUgbmV4dCBrZXkgZWxlbWVudCBpbiB0aGUgcGFnZSwgd2UgYWxzbyBmb2N1 cyBpdCBhcyBhIHNpZGUtZWZmZWN0LiAKKyAgICAgICAgQXMgYSByZXN1bHQsIHdlIHVzZWQgdG8g ZmlyZSBhIGZvY3VzIGRlbGVnYXRlIHR3aWNlLCBiZWNhdXNlIEFwcEtpdCBoYXBwZW5lZAorICAg ICAgICB0byBjYWxsIG5leHRLZXlWaWV3IHR3aWNlLgorICAgICAgICAKKyAgICAgICAgVGhpcyB0 ZXN0IGZpcnN0IHJlZ3Jlc3NlZCB3aGVuIEFkZWxlIGNoYW5nZWQgbGlzdGJveGVzIHRvIGJlIG5v bi1BcHBLaXQKKyAgICAgICAgY29udHJvbHMgKHIxNjcxOCkuIFRoYXQgY2hhbmdlIHRvb2sgQXBw S2l0IG91dCBvZiB0ZXN0LgorICAgICAgICAKKyAgICAgICAgVGhlIHJlZ3Jlc3Npb24gcmVkb3Vi bGVkIGl0c2VsZiB3aGVuIEFkYW0gbW92ZWQgVEFCIGhhbmRsaW5nIGludG8gdGhlIERPTQorICAg ICAgICAocjE2NzQxKSwgdGFraW5nIEFwcEtpdCBvdXQgb2YgVEFCaW5nIGNvbXBsZXRlbHkuCisK KyAgICAgICAgKiBmYXN0L2Zvcm1zL2ZvY3VzLWNvbnRyb2wtdG8tcGFnZS1leHBlY3RlZC50eHQ6 CisgICAgICAgICogZmFzdC9mb3Jtcy9mb2N1cy1jb250cm9sLXRvLXBhZ2UuaHRtbDoKKwogMjAw Ni0xMC0xOSAgSnVzdGluIEdhcmNpYSAgPGp1c3Rpbi5nYXJjaWFAYXBwbGUuY29tPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IGxldmkKSW5kZXg6IGZhc3QvZm9ybXMvZm9jdXMtY29udHJvbC10by1w YWdlLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBmYXN0L2Zvcm1zL2ZvY3VzLWNvbnRyb2wt dG8tcGFnZS1leHBlY3RlZC50eHQJKHJldmlzaW9uIDE3MTYzKQorKysgZmFzdC9mb3Jtcy9mb2N1 cy1jb250cm9sLXRvLXBhZ2UtZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC00LDcgKzQs NiBAQCBFRElUSU5HIERFTEVHQVRFOiBzaG91bGRCZWdpbkVkaXRpbmdJbkRPCiBFRElUSU5HIERF TEVHQVRFOiB3ZWJWaWV3RGlkQmVnaW5FZGl0aW5nOldlYlZpZXdEaWRCZWdpbkVkaXRpbmdOb3Rp ZmljYXRpb24KIEVESVRJTkcgREVMRUdBVEU6IHNob3VsZENoYW5nZVNlbGVjdGVkRE9NUmFuZ2U6 KG51bGwpIHRvRE9NUmFuZ2U6cmFuZ2UgZnJvbSAwIG9mICN0ZXh0ID4gRElWID4gQk9EWSA+IEhU TUwgPiAjZG9jdW1lbnQgdG8gMTkgb2YgI3RleHQgPiBESVYgPiBCT0RZID4gSFRNTCA+ICNkb2N1 bWVudCBhZmZpbml0eTpOU1NlbGVjdGlvbkFmZmluaXR5RG93bnN0cmVhbSBzdGlsbFNlbGVjdGlu ZzpGQUxTRQogRURJVElORyBERUxFR0FURTogd2ViVmlld0RpZENoYW5nZVNlbGVjdGlvbjpXZWJW aWV3RGlkQ2hhbmdlU2VsZWN0aW9uTm90aWZpY2F0aW9uCi1FRElUSU5HIERFTEVHQVRFOiBzaG91 bGRDaGFuZ2VTZWxlY3RlZERPTVJhbmdlOnJhbmdlIGZyb20gMCBvZiAjdGV4dCA+IERJViA+IEJP RFkgPiBIVE1MID4gI2RvY3VtZW50IHRvIDE5IG9mICN0ZXh0ID4gRElWID4gQk9EWSA+IEhUTUwg PiAjZG9jdW1lbnQgdG9ET01SYW5nZTpyYW5nZSBmcm9tIDAgb2YgI3RleHQgPiBESVYgPiBCT0RZ ID4gSFRNTCA+ICNkb2N1bWVudCB0byAxOSBvZiAjdGV4dCA+IERJViA+IEJPRFkgPiBIVE1MID4g I2RvY3VtZW50IGFmZmluaXR5Ok5TU2VsZWN0aW9uQWZmaW5pdHlEb3duc3RyZWFtIHN0aWxsU2Vs ZWN0aW5nOkZBTFNFCiBUaGlzIHRlc3QgY2hlY2tzIHdoZXRoZXIgeW91IGNhbiB0YWIgYmV0d2Vl biBBcHBLaXQgY29udHJvbHMgYW5kIGVuZ2luZS1yZW5kZXJlZCBjb250cm9scyBvciBvdGhlciBm b2N1c2FibGUgb2JqZWN0IGluIHRoZSBwYWdlIGxpa2UgY29udGVudEVkaXRhYmxlIGFyZWFzLiBB cyB5b3UgdGFiIHRocm91Z2gsIHNlbGVjdCBvbmUsIHRleHQsIHNlbGVjdCB0d28gYW5kIGNvbnRl bnRFZGl0YWJsZSBkaXYgc2hvdWxkIGZvY3VzLCBpbiB0aGF0IG9yZGVyLgogCiAgICBjb250ZW50 RWRpdGFibGUgZGl2CkluZGV4OiBmYXN0L2Zvcm1zL2ZvY3VzLWNvbnRyb2wtdG8tcGFnZS5odG1s Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIGZhc3QvZm9ybXMvZm9jdXMtY29udHJvbC10by1wYWdlLmh0bWwJKHJl dmlzaW9uIDE3MTYzKQorKysgZmFzdC9mb3Jtcy9mb2N1cy1jb250cm9sLXRvLXBhZ2UuaHRtbAko d29ya2luZyBjb3B5KQpAQCAtMjAsMTMgKzIwLDkgQEAgZnVuY3Rpb24gdGFiQ3ljbGUoKQogPC9o ZWFkPgogPGJvZHkgb25sb2FkPSJ0YWJDeWNsZSgpIj4KIDxwPlRoaXMgdGVzdCBjaGVja3Mgd2hl dGhlciB5b3UgY2FuIHRhYiBiZXR3ZWVuIEFwcEtpdCBjb250cm9scyBhbmQgZW5naW5lLXJlbmRl cmVkIGNvbnRyb2xzIG9yIG90aGVyIGZvY3VzYWJsZSBvYmplY3QgaW4gdGhlIHBhZ2UgbGlrZSBj b250ZW50RWRpdGFibGUgYXJlYXMuIEFzIHlvdSB0YWIgdGhyb3VnaCwgc2VsZWN0IG9uZSwgdGV4 dCwgc2VsZWN0IHR3byBhbmQgY29udGVudEVkaXRhYmxlIGRpdiBzaG91bGQgZm9jdXMsIGluIHRo YXQgb3JkZXIuPC9wPgotPHNlbGVjdCBtdWx0aXBsZSBvbmZvY3VzPSJsb2coJ0ZPQ1VTOiBzZWxl Y3Qgb25lJykiPgotPG9wdGlvbj5vbmU8L29wdGlvbj4KLTwvc2VsZWN0PgorPGlucHV0IHR5cGU9 InNlYXJjaCIgb25mb2N1cz0ibG9nKCdGT0NVUzogc2VsZWN0IG9uZScpIj4KIDxpbnB1dCB0eXBl PXRleHQgb25mb2N1cz0ibG9nKCdGT0NVUzogdGV4dCcpIiB2YWx1ZT0idGV4dCI+Ci08c2VsZWN0 IG11bHRpcGxlIG9uZm9jdXM9ImxvZygnRk9DVVM6IHNlbGVjdCB0d28nKSI+Ci08b3B0aW9uPnR3 bzwvb3B0aW9uPgotPC9zZWxlY3Q+Cis8aW5wdXQgdHlwZT0ic2VhcmNoIiBvbmZvY3VzPSJsb2co J0ZPQ1VTOiBzZWxlY3QgdHdvJykiPgogPGRpdiBzdHlsZT0iZGlzcGxheTogaW5saW5lLWJsb2Nr IiBjb250ZW50RWRpdGFibGU9InRydWUiIG9uZm9jdXM9ImxvZygnRk9DVVM6IGNvbnRlbnRFZGl0 YWJsZSBkaXYnKSI+Y29udGVudEVkaXRhYmxlIGRpdjwvZGl2PgogPHByZSBpZD0ibG9nIj4KIDwv cHJlPgo=