113440 2013-03-27 13:59:24 -0700 [WinCE] Add workaround for UNUSED_PARAM() 2013-04-29 06:20:29 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 115350 1 paroga paroga benjamin cmarcelo commit-queue ojan.autocc webkit.review.bot oldest_to_newest 864841 0 paroga 2013-03-27 13:59:24 -0700 [WinCE] Add workaround for UNUSED_PARAM() 864843 1 195390 paroga 2013-03-27 14:03:54 -0700 Created attachment 195390 Patch 870554 2 195390 benjamin 2013-04-07 14:31:07 -0700 Comment on attachment 195390 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=195390&action=review > Source/WTF/wtf/UnusedParam.h:31 > +#define UNUSED_PARAM(variable) (void)&variable Can you please check if (void*)&variable works? It would make more sense. 870555 3 195390 paroga 2013-04-07 14:39:46 -0700 Comment on attachment 195390 Patch notbenjamin: paroga: ignore my comment on the patch. 870561 4 195390 commit-queue 2013-04-07 15:08:12 -0700 Comment on attachment 195390 Patch Clearing flags on attachment: 195390 Committed r147882: <http://trac.webkit.org/changeset/147882> 870562 5 commit-queue 2013-04-07 15:08:15 -0700 All reviewed patches have been landed. Closing bug. 195390 2013-03-27 14:03:54 -0700 2013-04-07 15:08:12 -0700 Patch bug-113440.patch text/plain 1159 paroga ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK aW5kZXggY2M5OTg3NC4uNjIyZjQxYiAxMDA2NDQKLS0tIGEvU291cmNlL1dURi9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dURi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMy0wMy0yNyAg UGF0cmljayBHYW5zdGVyZXIgIDxwYXJvZ2FAd2Via2l0Lm9yZz4KKworICAgICAgICBbV2luQ0Vd IEFkZCB3b3JrYXJvdW5kIGZvciBVTlVTRURfUEFSQU0oKQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEzNDQwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIE1TVkMgY29tcGlsZXIgZm9yIFdpbmR3b3Mg Q0UgdGhyb3dzIGFuIGVycm9yIHdoZW4KKyAgICAgICAgYW4gZnVuY3Rpb24gcGFyYW1ldGVyIGlz IHBhc3NlZCB0byBVTlVTRURfUEFSQU0oKSBhbmQKKyAgICAgICAgaXRzIHR5cGUgaXMgb25seSBm b3J3YXJkIGRlY2xhcmVkLgorCisgICAgICAgICogd3RmL1VudXNlZFBhcmFtLmg6CisKIDIwMTMt MDMtMjIgIEJlbmphbWluIFBvdWxhaW4gIDxicG91bGFpbkBhcHBsZS5jb20+CiAKICAgICAgICAg UmVtb3ZlIDIgYmFkIGJyYW5jaGVzIGZyb20gU3RyaW5nSGFzaDo6ZXF1YWwoKSBhbmQgQ2FzZUZv bGRpbmdIYXNoOjplcXVhbCgpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9VbnVzZWRQYXJh bS5oIGIvU291cmNlL1dURi93dGYvVW51c2VkUGFyYW0uaAppbmRleCAzMWQ3MGU3Li40NjAxMDQ0 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9VbnVzZWRQYXJhbS5oCisrKyBiL1NvdXJjZS9X VEYvd3RmL1VudXNlZFBhcmFtLmgKQEAgLTI3LDYgKzI3LDggQEAKIHRlbXBsYXRlPHR5cGVuYW1l IFQ+CiBpbmxpbmUgdm9pZCB1bnVzZWRQYXJhbShUJiB4KSB7ICh2b2lkKXg7IH0KICNkZWZpbmUg VU5VU0VEX1BBUkFNKHZhcmlhYmxlKSB1bnVzZWRQYXJhbSh2YXJpYWJsZSkKKyNlbGlmIENPTVBJ TEVSKE1TVkMpICYmIE9TKFdJTkNFKQorI2RlZmluZSBVTlVTRURfUEFSQU0odmFyaWFibGUpICh2 b2lkKSZ2YXJpYWJsZQogI2Vsc2UKICNkZWZpbmUgVU5VU0VEX1BBUkFNKHZhcmlhYmxlKSAodm9p ZCl2YXJpYWJsZQogI2VuZGlmCg==