113416 2013-03-27 09:03:41 -0700 [BlackBerry] Show compositing on the Inspector timeline properly 2013-03-27 17:16:25 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kpiascik kpiascik mifenton rwlbuis tonikitoo webkit.review.bot oldest_to_newest 864597 0 kpiascik 2013-03-27 09:03:41 -0700 [BlackBerry] Show compositing on the Inspector timeline properly 864612 1 195340 kpiascik 2013-03-27 09:22:21 -0700 Created attachment 195340 Patch 864618 2 195340 rwlbuis 2013-03-27 09:28:07 -0700 Comment on attachment 195340 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=195340&action=review Commit message can be improved upon. > Source/WebKit/blackberry/ChangeLog:8 > + Change the call to willComposite to the correct location This seems a bit terse, and won't make clear why the change was needed when looking at this patch later. 864624 3 195342 kpiascik 2013-03-27 09:31:01 -0700 Created attachment 195342 Patch 864646 4 195342 rwlbuis 2013-03-27 10:15:41 -0700 Comment on attachment 195342 Patch LGTM. 865030 5 195342 webkit.review.bot 2013-03-27 17:16:22 -0700 Comment on attachment 195342 Patch Clearing flags on attachment: 195342 Committed r147032: <http://trac.webkit.org/changeset/147032> 865031 6 webkit.review.bot 2013-03-27 17:16:25 -0700 All reviewed patches have been landed. Closing bug. 195340 2013-03-27 09:22:21 -0700 2013-03-27 09:30:58 -0700 Patch bug-113416-20130327122222.patch text/plain 1769 kpiascik U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ2OTg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCAzYjgxOTM5MWQwMTBlMzQ5NjRiN2FiNzc3YTU3NmVhZDhlYjg0N2JjLi5mYTBjZGYxMjkz M2FmNWQ3MDlhMDE5NWZlNWNlNDM3MWE4ZTkyZTg0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMy0wMy0yNyAgRWxpIEZpZGxlciA8ZWZpZGxlckBi bGFja2JlcnJ5LmNvbT4KKworICAgICAgICBbQmxhY2tCZXJyeV0gU2hvdyBjb21wb3NpdGluZyBv biB0aGUgSW5zcGVjdG9yIHRpbWVsaW5lIHByb3Blcmx5CisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTM0MTYKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDaGFuZ2UgdGhlIGNhbGwgdG8gd2lsbENvbXBvc2l0 ZSB0byB0aGUgY29ycmVjdCBsb2NhdGlvbgorCisgICAgICAgICogQXBpL1dlYlBhZ2UuY3BwOgor ICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpXZWJQYWdlUHJpdmF0ZTo6Y29tbWl0Um9vdExh eWVySWZOZWVkZWQpOgorCiAyMDEzLTAzLTI2ICBIYXlhdG8gSXRvICA8aGF5YXRvQGNocm9taXVt Lm9yZz4KIAogICAgICAgICBBbGxvdyBTaGFkb3dDb250ZW50cyBpbiBIaXRUZXN0cyBieSBkZWZh dWx0LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNw cCBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5jcHAKaW5kZXggZDM4ZmE1 ZGIxOThhYjM2ZGY2N2Y4OGJmYzhmMGQ1NzQ4OTc4MzBhNy4uYjQ0ODUyYjQyNGZiMTU3ZDBkMzdl N2VhNDA2YmM4ZDhlOTFhODMxZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5 L0FwaS9XZWJQYWdlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBh Z2UuY3BwCkBAIC01NTEzLDcgKzU1MTMsNiBAQCBib29sIFdlYlBhZ2VQcml2YXRlOjpjb21taXRS b290TGF5ZXJJZk5lZWRlZCgpCiAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICB9CiAKLSAgICB3 aWxsQ29tcG9zaXRlKCk7CiAgICAgbV9uZWVkc0NvbW1pdCA9IGZhbHNlOwogICAgIC8vIFdlIGdl dCBoZXJlIGVpdGhlciBkdWUgdG8gdGhlIGNvbW1pdCB0aW1lciwgd2hpY2ggd291bGQgaGF2ZSBj YWxsZWQKICAgICAvLyByZW5kZXIgaWYgYSBvbmUgc2hvdCBzeW5jIHdhcyBuZWVkZWQuIE9yIHdl IGdldCBjYWxsZWQgZnJvbSByZW5kZXIKQEAgLTU1MzAsNiArNTUyOSw3IEBAIGJvb2wgV2ViUGFn ZVByaXZhdGU6OmNvbW1pdFJvb3RMYXllcklmTmVlZGVkKCkKICAgICBpZiAobV9vdmVybGF5TGF5 ZXIpCiAgICAgICAgIG1fb3ZlcmxheUxheWVyLT5wbGF0Zm9ybUxheWVyKCktPmNvbW1pdE9uV2Vi S2l0VGhyZWFkKHNjYWxlKTsKIAorICAgIHdpbGxDb21wb3NpdGUoKTsKICAgICAvLyBTdGFzaCB0 aGUgdmlzaWJsZSBjb250ZW50IHJlY3QgYWNjb3JkaW5nIHRvIHdlYmtpdCB0aHJlYWQKICAgICAv LyBUaGlzIGlzIHRoZSByZWN0YW5nbGUgdXNlZCB0byBsYXlvdXQgZml4ZWQgcG9zaXRpb25lZCBl bGVtZW50cywKICAgICAvLyBhbmQgdGhhdCdzIHdoYXQgdGhlIGxheWVyIHJlbmRlcmVyIHdhbnRz Lgo= 195342 2013-03-27 09:31:01 -0700 2013-03-27 17:16:22 -0700 Patch bug-113416-20130327123102.patch text/plain 1855 kpiascik U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ2OTg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCAzYjgxOTM5MWQwMTBlMzQ5NjRiN2FiNzc3YTU3NmVhZDhlYjg0N2JjLi41MDMwYmE3ZjJl MWI2ODQ0ZDA0MjIyZTliMzI2NzJmZWYxM2JhYTA4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMy0wMy0yNyAgRWxpIEZpZGxlciA8ZWZpZGxlckBi bGFja2JlcnJ5LmNvbT4KKworICAgICAgICBbQmxhY2tCZXJyeV0gU2hvdyBjb21wb3NpdGluZyBv biB0aGUgSW5zcGVjdG9yIHRpbWVsaW5lIHByb3Blcmx5CisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTM0MTYKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgY2FsbCB0byB3aWxsQ29tcG9zaXRlIHdhcyB0 b28gZWFybHkgYW5kIGVuY29tcGFzZWQgdGhlIHBhaW50IGNhbGxzCisgICAgICAgIGFzIHdlbGwu ICBNb3ZpbmcgaXQgbG93ZXIgd2lsbCBubyBsb25nZXIgZW5jb21wYXNzIHRoZSBwYWludHMuCisK KyAgICAgICAgKiBBcGkvV2ViUGFnZS5jcHA6CisgICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6 OldlYlBhZ2VQcml2YXRlOjpjb21taXRSb290TGF5ZXJJZk5lZWRlZCk6CisKIDIwMTMtMDMtMjYg IEhheWF0byBJdG8gIDxoYXlhdG9AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIEFsbG93IFNoYWRv d0NvbnRlbnRzIGluIEhpdFRlc3RzIGJ5IGRlZmF1bHQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2UuY3BwIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5 L0FwaS9XZWJQYWdlLmNwcAppbmRleCBkMzhmYTVkYjE5OGFiMzZkZjY3Zjg4YmZjOGYwZDU3NDg5 NzgzMGE3Li5iNDQ4NTJiNDI0ZmIxNTdkMGQzN2U3ZWE0MDZiYzhkOGU5MWE4MzFkIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2UuY3BwCisrKyBiL1NvdXJj ZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5jcHAKQEAgLTU1MTMsNyArNTUxMyw2IEBA IGJvb2wgV2ViUGFnZVByaXZhdGU6OmNvbW1pdFJvb3RMYXllcklmTmVlZGVkKCkKICAgICAgICAg cmV0dXJuIGZhbHNlOwogICAgIH0KIAotICAgIHdpbGxDb21wb3NpdGUoKTsKICAgICBtX25lZWRz Q29tbWl0ID0gZmFsc2U7CiAgICAgLy8gV2UgZ2V0IGhlcmUgZWl0aGVyIGR1ZSB0byB0aGUgY29t bWl0IHRpbWVyLCB3aGljaCB3b3VsZCBoYXZlIGNhbGxlZAogICAgIC8vIHJlbmRlciBpZiBhIG9u ZSBzaG90IHN5bmMgd2FzIG5lZWRlZC4gT3Igd2UgZ2V0IGNhbGxlZCBmcm9tIHJlbmRlcgpAQCAt NTUzMCw2ICs1NTI5LDcgQEAgYm9vbCBXZWJQYWdlUHJpdmF0ZTo6Y29tbWl0Um9vdExheWVySWZO ZWVkZWQoKQogICAgIGlmIChtX292ZXJsYXlMYXllcikKICAgICAgICAgbV9vdmVybGF5TGF5ZXIt PnBsYXRmb3JtTGF5ZXIoKS0+Y29tbWl0T25XZWJLaXRUaHJlYWQoc2NhbGUpOwogCisgICAgd2ls bENvbXBvc2l0ZSgpOwogICAgIC8vIFN0YXNoIHRoZSB2aXNpYmxlIGNvbnRlbnQgcmVjdCBhY2Nv cmRpbmcgdG8gd2Via2l0IHRocmVhZAogICAgIC8vIFRoaXMgaXMgdGhlIHJlY3RhbmdsZSB1c2Vk IHRvIGxheW91dCBmaXhlZCBwb3NpdGlvbmVkIGVsZW1lbnRzLAogICAgIC8vIGFuZCB0aGF0J3Mg d2hhdCB0aGUgbGF5ZXIgcmVuZGVyZXIgd2FudHMuCg==