113401 2013-03-27 06:21:01 -0700 Web Inspector: Enable CSS logging 2013-05-28 00:21:01 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED BlinkMergeCandidate P2 Normal --- 112880 113142 115157 115709 1 serya serya achicu apavlov benjamin commit-queue darin esprehn+autocc glenn keishi kling loislo macpherson menard pfeldman pmuellr rniwa svillar syoichi vsevik web-inspector-bugs yurys oldest_to_newest 864467 0 serya 2013-03-27 06:21:01 -0700 I'm going to disable error logging to fix regression (https://bugs.webkit.org/show_bug.cgi?id=113142) because correct logging requires grammar refactoring. 893310 1 svillar 2013-05-24 08:17:10 -0700 We might want consider importing: Restored error logging. https://src.chromium.org/viewvc/blink?view=rev&revision=149265 893972 2 202970 svillar 2013-05-27 04:33:57 -0700 Created attachment 202970 Patch 894238 3 202970 svillar 2013-05-28 00:20:54 -0700 Comment on attachment 202970 Patch Clearing flags on attachment: 202970 Committed r150791: <http://trac.webkit.org/changeset/150791> 894239 4 svillar 2013-05-28 00:21:01 -0700 All reviewed patches have been landed. Closing bug. 202970 2013-05-27 04:33:57 -0700 2013-05-28 00:20:53 -0700 Patch bug-113401-20130527133236.patch text/plain 7127 svillar U3VidmVyc2lvbiBSZXZpc2lvbjogMTUwNzM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjc5OGJhNDE2NGM5Y2Vi MTRmYWVjNDljZjFkOTdiM2RjY2MxOGJhZC4uYTQ0MTg5NWE2ZjE4Y2JjNzExZWVkNmMxYzExNzJj ZjJjZDdiODM5OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDM1IEBACisyMDEzLTA1LTI3ICBTZXJn aW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgorCisgICAgICAgIFdlYiBJbnNw ZWN0b3I6IEVuYWJsZSBDU1MgbG9nZ2luZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTEzNDAxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgRnJvbSBCbGluayByMTQ5MjY1IGJ5IDxzZXJ5YUBjaHJvbWl1bS5v cmc+CisKKyAgICAgICAgQ1NTIGxvZ2dpbmcgd2FzIGRpc2FibGVkIGluIHIxNDcwMjggdG8gcHJl dmVudCBtZXNzYWdlIG92ZXJmbG93IGluCisgICAgICAgIHRoZSBpbnNwZWN0b3IgY29uc29sZS4g VGhpcyBjaGFuZ2UgcmVzdG9yZXMgaXQgYnkgbW9kaWZ5aW5nIHRoZQorICAgICAgICBDU1MgZ3Jh bW1hciBpbiBvcmRlciB0byByZWR1Y2UgYXMgbXVjaCBjb25zZWN1dGl2ZSBlcnJvcnMgYXMKKyAg ICAgICAgcG9zc2libGUgaW4gJ2RlY2xhcmF0aW9uX2xpc3QnIGFuZCAnZGVjbF9saXN0JyBydWxl cy4KKworICAgICAgICBUaGlzIHdheSwgZm9yIHJ1bGVzIGxpa2UgJ3ggeyBjb2xvcjogIyMjIH0n IG9ubHkgdGhlIGZpcnN0ICcjJworICAgICAgICB3aWxsIGJlIHJlcG9ydGVkIGFzIGVycm9yIChp bnN0ZWFkIG9mIDMgaWRlbnRpY2FsIGVycm9ycykuCisKKyAgICAgICAgVGhlIHJ1bGUgJ2RlY2xh cmF0aW9uJyBzdGlsbCBwcm9kdWNlcyBtdWx0aXBsZSBlcnJvcnMsIGJlY2F1c2UgaXQKKyAgICAg ICAgZG9lcyBub3QgZWF0IGFzIG11Y2ggZXJyb3JzIGFzIHBvc3NpYmxlLiBTbyBpbiBvcmRlciBu b3QgdG8gY3JlYXRlCisgICAgICAgIGEgY29tcGxleCByaXNreSBwYXRjaCB3ZSBqdXN0IGRpc2Fi bGUgbG9nZ2luZyBpbiB0aGUgcGFyc2VyIGZvcgorICAgICAgICB0aGF0IHJ1bGUuCisKKyAgICAg ICAgKiBjc3MvQ1NTR3JhbW1hci55LmluOgorICAgICAgICAqIGNzcy9DU1NQYXJzZXIuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6Q1NTUGFyc2VyOjpDU1NQYXJzZXIpOgorICAgICAgICAoV2ViQ29y ZTo6Q1NTUGFyc2VyOjpwYXJzZVNoZWV0KToKKyAgICAgICAgKFdlYkNvcmU6OkNTU1BhcnNlcjo6 c3ludGF4RXJyb3IpOgorICAgICAgICAoV2ViQ29yZTo6Q1NTUGFyc2VyOjppc0xvZ2dpbmdFcnJv cnMpOgorICAgICAgICAoV2ViQ29yZTo6Q1NTUGFyc2VyOjpyZXdyaXRlU3BlY2lmaWVycyk6Cisg ICAgICAgICogY3NzL0NTU1BhcnNlci5oOgorICAgICAgICAoQ1NTUGFyc2VyKToKKwogMjAxMy0w NS0yNyAgQW5kcmVhcyBLbGluZyAgPGFrbGluZ0BhcHBsZS5jb20+CiAKICAgICAgICAgV2luQ0Ug YnVpbGQgVExDOiBOb2RlOjphY3RpdmUoKSBtb3ZlZCB0byBFbGVtZW50LgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvY3NzL0NTU0dyYW1tYXIueS5pbiBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9D U1NHcmFtbWFyLnkuaW4KaW5kZXggYTIxMjQ5MjMwZjI1ZjYxNTM3MGI0YjhkNWFkODBjN2Q1ZmMz NmZkOS4uMzdiM2YyMzMyMTIzZTk4NGViMTNiNDRhZTcyYzliMGE1ZjUwOWEyMiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU0dyYW1tYXIueS5pbgorKysgYi9Tb3VyY2UvV2ViQ29y ZS9jc3MvQ1NTR3JhbW1hci55LmluCkBAIC0xNTMyLDEyICsxNTMyLDEwIEBAIGRlY2xhcmF0aW9u X2xpc3Q6CiAgICAgfCBkZWNsX2xpc3QgewogICAgICAgICAkJCA9ICQxOwogICAgIH0KLSAgICB8 IGVycm9ycyBkZWNsX2xpc3RfcmVjb3ZlcnkgewotICAgICAgICBwYXJzZXItPnN5bnRheEVycm9y KCQxLCBDU1NQYXJzZXI6OlByb3BlcnR5RGVjbGFyYXRpb25FcnJvcik7CisgICAgfCBkZWNsX2xp c3RfcmVjb3ZlcnkgewogICAgICAgICAkJCA9IGZhbHNlOwogICAgIH0KLSAgICB8IGRlY2xfbGlz dCBlcnJvcnMgZGVjbF9saXN0X3JlY292ZXJ5IHsKLSAgICAgICAgcGFyc2VyLT5zeW50YXhFcnJv cigkMiwgQ1NTUGFyc2VyOjpQcm9wZXJ0eURlY2xhcmF0aW9uRXJyb3IpOworICAgIHwgZGVjbF9s aXN0IGRlY2xfbGlzdF9yZWNvdmVyeSB7CiAgICAgICAgICQkID0gJDE7CiAgICAgfQogICAgIDsK QEAgLTE1NTUsOCArMTU1Myw3IEBAIGRlY2xfbGlzdDoKICAgICAgICAgcGFyc2VyLT5zeW50YXhF cnJvcigkMik7CiAgICAgICAgICQkID0gZmFsc2U7CiAgICAgfQotICAgIHwgZXJyb3JzIGRlY2xf bGlzdF9yZWNvdmVyeSAnOycgbWF5YmVfc3BhY2UgewotICAgICAgICBwYXJzZXItPnN5bnRheEVy cm9yKCQxLCBDU1NQYXJzZXI6OlByb3BlcnR5RGVjbGFyYXRpb25FcnJvcik7CisgICAgfCBkZWNs X2xpc3RfcmVjb3ZlcnkgJzsnIG1heWJlX3NwYWNlIHsKICAgICAgICAgcGFyc2VyLT5tYXJrUHJv cGVydHlTdGFydCgpOwogICAgICAgICAkJCA9IGZhbHNlOwogICAgIH0KQEAgLTE1NjYsMTYgKzE1 NjMsMTggQEAgZGVjbF9saXN0OgogICAgICAgICBpZiAoJDIpCiAgICAgICAgICAgICAkJCA9ICQy OwogICAgIH0KLSAgICB8IGRlY2xfbGlzdCBlcnJvcnMgZGVjbF9saXN0X3JlY292ZXJ5ICc7JyBt YXliZV9zcGFjZSB7Ci0gICAgICAgIHBhcnNlci0+c3ludGF4RXJyb3IoJDIsIENTU1BhcnNlcjo6 UHJvcGVydHlEZWNsYXJhdGlvbkVycm9yKTsKKyAgICB8IGRlY2xfbGlzdCBkZWNsX2xpc3RfcmVj b3ZlcnkgJzsnIG1heWJlX3NwYWNlIHsKICAgICAgICAgcGFyc2VyLT5tYXJrUHJvcGVydHlTdGFy dCgpOwogICAgICAgICAkJCA9ICQxOwogICAgIH0KICAgICA7CiAKIGRlY2xfbGlzdF9yZWNvdmVy eToKLSAgICBpbnZhbGlkX2Jsb2NrX2xpc3QgZXJyb3IKLSAgICB8IC8qIGVtcHR5ICovCisgICAg ZXJyb3IgZXJyb3JfbG9jYXRpb24geworICAgICAgICBwYXJzZXItPnN5bnRheEVycm9yKCQyLCBD U1NQYXJzZXI6OlByb3BlcnR5RGVjbGFyYXRpb25FcnJvcik7CisgICAgfQorICAgIHwgZGVjbF9s aXN0X3JlY292ZXJ5IGludmFsaWRfYmxvY2sKKyAgICB8IGRlY2xfbGlzdF9yZWNvdmVyeSBlcnJv cgogICAgIDsKIAogZGVjbGFyYXRpb246CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3Mv Q1NTUGFyc2VyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3BwCmluZGV4IGUx NzUwODg0ZmZiZjU5ODliMTM2NmRjNzNjMzY3NmJiZmRhNzNkYzkuLjFlMDIwNjA4NDEzOTE1YmU3 MTE2ZjgzNTU3MDQ3OTMxMzgyNTVmNjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9D U1NQYXJzZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3BwCkBAIC0z MjQsNiArMzI0LDcgQEAgQ1NTUGFyc2VyOjpDU1NQYXJzZXIoY29uc3QgQ1NTUGFyc2VyQ29udGV4 dCYgY29udGV4dCkKICAgICAsIG1faGFzRm9udEZhY2VPbmx5VmFsdWVzKGZhbHNlKQogICAgICwg bV9oYWRTeW50YWN0aWNhbGx5VmFsaWRDU1NSdWxlKGZhbHNlKQogICAgICwgbV9sb2dFcnJvcnMo ZmFsc2UpCisgICAgLCBtX2lnbm9yZUVycm9yc0luRGVjbGFyYXRpb24oZmFsc2UpCiAjaWYgRU5B QkxFKENTU19TSEFERVJTKQogICAgICwgbV9pbkZpbHRlclJ1bGUoZmFsc2UpCiAjZW5kaWYKQEAg LTQ2MCw2ICs0NjEsNyBAQCB2b2lkIENTU1BhcnNlcjo6cGFyc2VTaGVldChTdHlsZVNoZWV0Q29u dGVudHMqIHNoZWV0LCBjb25zdCBTdHJpbmcmIHN0cmluZywgaW50CiAgICAgbV9ydWxlU291cmNl RGF0YVJlc3VsdCA9IHJ1bGVTb3VyY2VEYXRhUmVzdWx0OwogCiAgICAgbV9sb2dFcnJvcnMgPSBs b2dFcnJvcnMgJiYgc2hlZXQtPnNpbmdsZU93bmVyRG9jdW1lbnQoKSAmJiAhc2hlZXQtPmJhc2VV UkwoKS5pc0VtcHR5KCkgJiYgc2hlZXQtPnNpbmdsZU93bmVyRG9jdW1lbnQoKS0+cGFnZSgpOwor ICAgIG1faWdub3JlRXJyb3JzSW5EZWNsYXJhdGlvbiA9IGZhbHNlOwogICAgIG1fbGluZU51bWJl ciA9IHN0YXJ0TGluZU51bWJlcjsKICAgICBzZXR1cFBhcnNlcigiIiwgc3RyaW5nLCAiIik7CiAg ICAgY3NzeXlwYXJzZSh0aGlzKTsKQEAgLTQ2Nyw2ICs0NjksNyBAQCB2b2lkIENTU1BhcnNlcjo6 cGFyc2VTaGVldChTdHlsZVNoZWV0Q29udGVudHMqIHNoZWV0LCBjb25zdCBTdHJpbmcmIHN0cmlu ZywgaW50CiAgICAgbV9jdXJyZW50UnVsZURhdGFTdGFjay5jbGVhcigpOwogICAgIG1fcnVsZVNv dXJjZURhdGFSZXN1bHQgPSAwOwogICAgIG1fcnVsZSA9IDA7CisgICAgbV9pZ25vcmVFcnJvcnNJ bkRlY2xhcmF0aW9uID0gZmFsc2U7CiAgICAgbV9sb2dFcnJvcnMgPSBmYWxzZTsKIH0KIApAQCAt MTE0ODgsMTIgKzExNDkxLDEzIEBAIHZvaWQgQ1NTUGFyc2VyOjpzeW50YXhFcnJvcihjb25zdCBM b2NhdGlvbiYgbG9jYXRpb24sIFN5bnRheEVycm9yVHlwZSBlcnJvcikKICAgICAgICAgYnVpbGRl ci5hcHBlbmQobG9jYXRpb24udG9rZW4uY2hhcmFjdGVyczE2KCksIGxvY2F0aW9uLnRva2VuLmxl bmd0aCgpKTsKIAogICAgIGxvZ0Vycm9yKGJ1aWxkZXIudG9TdHJpbmcoKSwgbG9jYXRpb24ubGlu ZU51bWJlcik7CisKKyAgICBtX2lnbm9yZUVycm9yc0luRGVjbGFyYXRpb24gPSB0cnVlOwogfQog CiBib29sIENTU1BhcnNlcjo6aXNMb2dnaW5nRXJyb3JzKCkKIHsKLSAgICAvLyBGSVhNRTogcmV0 dXJuIGxvZ2dpbmcgYmFjayAoaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTExMzQwMSkuCi0gICAgcmV0dXJuIGZhbHNlOworICAgIHJldHVybiBtX2xvZ0Vycm9ycyAmJiAh bV9pZ25vcmVFcnJvcnNJbkRlY2xhcmF0aW9uOwogfQogCiB2b2lkIENTU1BhcnNlcjo6bG9nRXJy b3IoY29uc3QgU3RyaW5nJiBtZXNzYWdlLCBpbnQgbGluZU51bWJlcikKQEAgLTExOTM5LDYgKzEx OTQzLDcgQEAgdm9pZCBDU1NQYXJzZXI6Om1hcmtSdWxlQm9keUVuZCgpCiAKIHZvaWQgQ1NTUGFy c2VyOjptYXJrUHJvcGVydHlTdGFydCgpCiB7CisgICAgbV9pZ25vcmVFcnJvcnNJbkRlY2xhcmF0 aW9uID0gZmFsc2U7CiAgICAgaWYgKCFpc0V4dHJhY3RpbmdTb3VyY2VEYXRhKCkpCiAgICAgICAg IHJldHVybjsKICAgICBpZiAobV9jdXJyZW50UnVsZURhdGFTdGFjay0+aXNFbXB0eSgpIHx8ICFt X2N1cnJlbnRSdWxlRGF0YVN0YWNrLT5sYXN0KCktPnN0eWxlU291cmNlRGF0YSkKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIuaCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9D U1NQYXJzZXIuaAppbmRleCBiMmYyZDJiMGQwNTYzNzcyZGJiMzQ3MmQyYjQ2YWJlM2UwOGQ0MTYy Li4zMDllMGRmNjIwYjJjM2ZiNjc2NGRjMDU5ZjEyNTU1MjMzNTExMGZjIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL0NT U1BhcnNlci5oCkBAIC0zOTcsNiArMzk3LDcgQEAgcHVibGljOgogICAgIGJvb2wgbV9oYXNGb250 RmFjZU9ubHlWYWx1ZXM7CiAgICAgYm9vbCBtX2hhZFN5bnRhY3RpY2FsbHlWYWxpZENTU1J1bGU7 CiAgICAgYm9vbCBtX2xvZ0Vycm9yczsKKyAgICBib29sIG1faWdub3JlRXJyb3JzSW5EZWNsYXJh dGlvbjsKIAogI2lmIEVOQUJMRShDU1NfU0hBREVSUykKICAgICBib29sIG1faW5GaWx0ZXJSdWxl OwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdl TG9nCmluZGV4IGRjZTg5ODgyNGVjZjU2OGZiZGMwYjY2OWIwM2NiMjVjMTE0ODU5NjIuLjJiMDU4 MWQxNTRlN2VkOTI2YzU4ODI0MGE5NDcyYTE1ZWNlYTRkNzEgMTAwNjQ0Ci0tLSBhL0xheW91dFRl c3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBA QAorMjAxMy0wNS0yNyAgU2VyZ2lvIFZpbGxhciBTZW5pbiAgPHN2aWxsYXJAaWdhbGlhLmNvbT4K KworICAgICAgICBXZWIgSW5zcGVjdG9yOiBFbmFibGUgQ1NTIGxvZ2dpbmcKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMzQwMQorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZyb20gQmxpbmsgcjE0OTI2NSBi eSA8c2VyeWFAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFVuc2tpcHBlZCBjb25zb2xlLWNzcy13 YXJuaW5ncy5odG1sIG5vdyB0aGF0IGl0J3Mgd29ya2luZy4KKworICAgICAgICAqIFRlc3RFeHBl Y3RhdGlvbnM6CisKIDIwMTMtMDUtMjcgIFphbiBEb2JlcnNlayAgPHpkb2JlcnNla0BpZ2FsaWEu Y29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQgR1RLIGdhcmRlbmluZy4KZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9UZXN0RXhwZWN0YXRpb25z CmluZGV4IDA0NTM2ZmZlODI4M2E1N2NiZTcwY2UxYzBjOTQ4MjYwMzZjYjczMTMuLjJjN2Q4NzEy N2E3M2YyYjAzOWIzNDJmZTU2OTY5YTI1ZmY2ODg0MDAgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMvVGVzdEV4cGVjdGF0aW9ucwpAQCAt OCw5ICs4LDYgQEAgd2Via2l0Lm9yZy9iLzEwOTk1NCBjc3MzL2xpbmUtYnJlYWsgWyBTa2lwIF0K ICMgcGVuZGluZyBpbXBsZW1lbnRhdGlvbiBjb21wbGV0aW9uIGFuZCBmZWF0dXJlIGVuYWJsaW5n CiB3ZWJraXQub3JnL2IvMTA5NTcwIG1lZGlhL3RyYWNrL3JlZ2lvbnMtd2VidnR0IFsgU2tpcCBd CiAKLSMgcGVuZGluZyBDU1MgZ3JhbW1hciByZWZhY3RvcmluZwotd2Via2l0Lm9yZy9iLzExMzQw MSBpbnNwZWN0b3IvY29uc29sZS9jb25zb2xlLWNzcy13YXJuaW5ncy5odG1sIFsgU2tpcCBdCi0K ICMgbWVkaWEvdmlkZW8tc2Vlay1hZnRlci1lbmQuaHRtbCBpcyBmbGFreQogd2Via2l0Lm9yZy9i LzExNjI5MyBtZWRpYS92aWRlby1zZWVrLWFmdGVyLWVuZC5odG1sIFsgUGFzcyBGYWlsdXJlIF0K IAo=