113392 2013-03-27 04:52:15 -0700 [Mac] Use fontName rather than familyName for internal fonts 2013-03-27 10:52:08 -0700 1 1 1 Unclassified WebKit Text 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dino dino eric esprehn+autocc mitz ojan.autocc webkit.review.bot oldest_to_newest 864418 0 dino 2013-03-27 04:52:15 -0700 Some internal fonts for OS X are not listed in availableFontFamilies, which means that WebCore fails to find them. In these cases we should look for the fontName, rather than the familyName. <rdar://problem/13474743> 864420 1 195279 dino 2013-03-27 04:56:32 -0700 Created attachment 195279 Patch 864480 2 195279 buildbot 2013-03-27 06:40:02 -0700 Comment on attachment 195279 Patch Attachment 195279 did not pass win-ews (win): Output: http://webkit-commit-queue.appspot.com/results/17257428 864551 3 195279 enrica 2013-03-27 08:04:55 -0700 Comment on attachment 195279 Patch Looks good 864674 4 dino 2013-03-27 10:43:30 -0700 Not sure what is up with the windows tests: svg/dom/SVGScriptElement/script-change-externalResourcesRequired-while-loading.svg -> failed 864680 5 dino 2013-03-27 10:48:19 -0700 Since the files changed here aren't even compiled on Windows, it seems like a misleading result. I'll keep an eye on the test bots. 864686 6 dino 2013-03-27 10:52:08 -0700 Committed r146995: <http://trac.webkit.org/changeset/146995> 195279 2013-03-27 04:56:32 -0700 2013-03-27 08:04:54 -0700 Patch bug-113392-20130327225213.patch text/plain 4622 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ2OTUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzFhZTYzNmEwYWY0NzM4 OWQwNGRlOTM5MDdlNGVkZWI0ZGFkODZjMy4uMTVhNjBiMDA0Yzg3ZDM2MjAyYjAyZjVmNDRiODM2 YTRmNzVlN2FlMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDEzLTAzLTI3ICBEZWFu IEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KKworICAgICAgICBbTWFjXSBVc2UgZm9udE5hbWUg cmF0aGVyIHRoYW4gZmFtaWx5TmFtZSBmb3IgaW50ZXJuYWwgZm9udHMKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMzM5MgorICAgICAgICA8cmRhcjov L3Byb2JsZW0vMTM0NzQ3NDM+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgU29tZSBpbnRlcm5hbCBmb250cyBvbiBPUyBYIGhhdmUgYSBmYW1pbHkgbmFt ZSB0aGF0CisgICAgICAgIGlzbid0IGxpc3RlZCBpbiBhdmFpbGFibGVGb250RmFtaWxpZXMuIElu IHRoaXMgY2FzZQorICAgICAgICB3ZSBzaG91bGQgdXNlIHRoZSBmb250IG5hbWUgcmF0aGVyIHRo YW4gdGhlIGZhbWlseQorICAgICAgICBuYW1lIHdoZW4gbG9va2luZyBmb3IgYSBtYXRjaC4KKwor ICAgICAgICAqIHBsYXRmb3JtL21hYy9UaGVtZU1hYy5oOiBOU0ZvbnQgY2F0ZWdvcnkgdG8gcHJv dmlkZSBhIHdlYi1mcmllbmRseSBmYW1pbHkgbmFtZS4KKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMv VGhlbWVNYWMubW06CisgICAgICAgICgtW05TRm9udCB3ZWJDb3JlRmFtaWx5TmFtZV0pOiBSZXR1 cm5zIHRoZSBmb250IG5hbWUgZm9yIGludGVybmFsIGZvbnRzLCBvdGhlcndpc2UgdGhlIGZhbWls eSBuYW1lLgorICAgICAgICAoV2ViQ29yZTo6VGhlbWVNYWM6OmNvbnRyb2xGb250KToKKyAgICAg ICAgKiByZW5kZXJpbmcvUmVuZGVyVGhlbWVNYWNTaGFyZWQubW06IFVzZSB0aGUgd2ViQ29yZUZh bWlseU5hbWUuCisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJUaGVtZU1hY1NoYXJlZDo6c3lzdGVt Rm9udCk6IERpdHRvLgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVGhlbWVNYWNTaGFyZWQ6OnNl dEZvbnRGcm9tQ29udHJvbFNpemUpOiBEaXR0by4KKwogMjAxMy0wMy0yNiAgS2VudCBUYW11cmEg IDx0a2VudEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgTWFrZSBIVE1MUHJvZ3Jlc3NFbGVtZW50 Ojppc0RldGVybWluYXRlIHByaXZhdGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL21hYy9UaGVtZU1hYy5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL1RoZW1lTWFj LmgKaW5kZXggZDkyNDRjN2ExM2U1NzUyZTk4OTJiZGRjNjY1ZDAxODYzZjQ3MDM4Mi4uYmQ2ZTlj MmMzNzcwYjQ4YjEyYzMyZDE2NDA0ZmE4NTBmMjUzOGNmZCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vbWFjL1RoZW1lTWFjLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vbWFjL1RoZW1lTWFjLmgKQEAgLTI4LDYgKzI4LDEwIEBACiAKICNpbmNsdWRlICJUaGVtZS5o IgogCitAaW50ZXJmYWNlIE5TRm9udChXZWJDb3JlVGhlbWUpCistIChOU1N0cmluZyopd2ViQ29y ZUZhbWlseU5hbWU7CitAZW5kCisKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogY2xhc3MgVGhlbWVN YWMgOiBwdWJsaWMgVGhlbWUgewpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v bWFjL1RoZW1lTWFjLm1tIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL1RoZW1lTWFjLm1t CmluZGV4IDFjN2RhNmFmMjg2NTRjMTJiYmVmZTcyN2IzMTFlN2E3NjIxZThjNTkuLmYyNGQ0ZGE2 NmRjMmQ3YmY0ZjhmODY4NzZmZjhhYmE2NTY1YTViZGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL21hYy9UaGVtZU1hYy5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9tYWMvVGhlbWVNYWMubW0KQEAgLTc4LDYgKzc4LDE4IEBAIE5TUmVjdCBmb2N1c1JpbmdDbGlw UmVjdDsKIAogQGVuZAogCitAaW1wbGVtZW50YXRpb24gTlNGb250IChXZWJDb3JlVGhlbWUpCisK Ky0gKE5TU3RyaW5nKil3ZWJDb3JlRmFtaWx5TmFtZQoreworICAgIGlmIChbW3NlbGYgZmFtaWx5 TmFtZV0gaGFzUHJlZml4OkAiLiJdKQorICAgICAgICByZXR1cm4gW3NlbGYgZm9udE5hbWVdOwor CisgICAgcmV0dXJuIFtzZWxmIGZhbWlseU5hbWVdOworfQorCitAZW5kCisKIC8vIEZJWE1FOiBE ZWZhdWx0IGJ1dHRvbnMgcmVhbGx5IHNob3VsZCBiZSBtb3JlIGxpa2UgcHVzaCBidXR0b25zIGFu ZCBub3QgbGlrZSBidXR0b25zLgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CkBAIC01OTUsNyArNjA3 LDcgQEAgRm9udERlc2NyaXB0aW9uIFRoZW1lTWFjOjpjb250cm9sRm9udChDb250cm9sUGFydCBw YXJ0LCBjb25zdCBGb250JiBmb250LCBmbG9hdAogICAgICAgICAgICAgZm9udERlc2NyaXB0aW9u LnNldEdlbmVyaWNGYW1pbHkoRm9udERlc2NyaXB0aW9uOjpTZXJpZkZhbWlseSk7CiAKICAgICAg ICAgICAgIE5TRm9udCogbnNGb250ID0gW05TRm9udCBzeXN0ZW1Gb250T2ZTaXplOltOU0ZvbnQg c3lzdGVtRm9udFNpemVGb3JDb250cm9sU2l6ZTpjb250cm9sU2l6ZUZvckZvbnQoZm9udCldXTsK LSAgICAgICAgICAgIGZvbnREZXNjcmlwdGlvbi5maXJzdEZhbWlseSgpLnNldEZhbWlseShbbnNG b250IGZhbWlseU5hbWVdKTsKKyAgICAgICAgICAgIGZvbnREZXNjcmlwdGlvbi5maXJzdEZhbWls eSgpLnNldEZhbWlseShbbnNGb250IHdlYkNvcmVGYW1pbHlOYW1lXSk7CiAgICAgICAgICAgICBm b250RGVzY3JpcHRpb24uc2V0Q29tcHV0ZWRTaXplKFtuc0ZvbnQgcG9pbnRTaXplXSAqIHpvb21G YWN0b3IpOwogICAgICAgICAgICAgZm9udERlc2NyaXB0aW9uLnNldFNwZWNpZmllZFNpemUoW25z Rm9udCBwb2ludFNpemVdICogem9vbUZhY3Rvcik7CiAgICAgICAgICAgICByZXR1cm4gZm9udERl c2NyaXB0aW9uOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRo ZW1lTWFjU2hhcmVkLm1tIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lTWFj U2hhcmVkLm1tCmluZGV4IDk2N2NmOWE1YzRlMTIwZGZhMmZhYThhYzBjMDU0ZTVhOGRiYTVmM2Uu LjMzMzEwNjI0YTY4NjM4YmI2NmViNWIzN2FiZGQ1ZjM1NTRjYWE3ZmQgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZU1hY1NoYXJlZC5tbQorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVNYWNTaGFyZWQubW0KQEAgLTI4Miw3ICsy ODIsNyBAQCB2b2lkIFJlbmRlclRoZW1lTWFjU2hhcmVkOjpzeXN0ZW1Gb250KGludCBjc3NWYWx1 ZUlkLCBGb250RGVzY3JpcHRpb24mIGZvbnREZXNjcgogICAgICAgICBOU0ZvbnRNYW5hZ2VyICpm b250TWFuYWdlciA9IFtOU0ZvbnRNYW5hZ2VyIHNoYXJlZEZvbnRNYW5hZ2VyXTsKICAgICAgICAg Y2FjaGVkRGVzYy0+c2V0SXNBYnNvbHV0ZVNpemUodHJ1ZSk7CiAgICAgICAgIGNhY2hlZERlc2Mt PnNldEdlbmVyaWNGYW1pbHkoRm9udERlc2NyaXB0aW9uOjpOb0ZhbWlseSk7Ci0gICAgICAgIGNh Y2hlZERlc2MtPmZpcnN0RmFtaWx5KCkuc2V0RmFtaWx5KFtmb250IGZhbWlseU5hbWVdKTsKKyAg ICAgICAgY2FjaGVkRGVzYy0+Zmlyc3RGYW1pbHkoKS5zZXRGYW1pbHkoW2ZvbnQgd2ViQ29yZUZh bWlseU5hbWVdKTsKICAgICAgICAgY2FjaGVkRGVzYy0+c2V0U3BlY2lmaWVkU2l6ZShbZm9udCBw b2ludFNpemVdKTsKICAgICAgICAgY2FjaGVkRGVzYy0+c2V0V2VpZ2h0KHRvRm9udFdlaWdodChb Zm9udE1hbmFnZXIgd2VpZ2h0T2ZGb250OmZvbnRdKSk7CiAgICAgICAgIGNhY2hlZERlc2MtPnNl dEl0YWxpYyhbZm9udE1hbmFnZXIgdHJhaXRzT2ZGb250OmZvbnRdICYgTlNJdGFsaWNGb250TWFz ayk7CkBAIC02ODksNyArNjg5LDcgQEAgdm9pZCBSZW5kZXJUaGVtZU1hY1NoYXJlZDo6c2V0Rm9u dEZyb21Db250cm9sU2l6ZShTdHlsZVJlc29sdmVyKiwgUmVuZGVyU3R5bGUqIHMKICAgICBmb250 RGVzY3JpcHRpb24uc2V0R2VuZXJpY0ZhbWlseShGb250RGVzY3JpcHRpb246OlNlcmlmRmFtaWx5 KTsKIAogICAgIE5TRm9udCogZm9udCA9IFtOU0ZvbnQgc3lzdGVtRm9udE9mU2l6ZTpbTlNGb250 IHN5c3RlbUZvbnRTaXplRm9yQ29udHJvbFNpemU6Y29udHJvbFNpemVdXTsKLSAgICBmb250RGVz Y3JpcHRpb24uZmlyc3RGYW1pbHkoKS5zZXRGYW1pbHkoW2ZvbnQgZmFtaWx5TmFtZV0pOworICAg IGZvbnREZXNjcmlwdGlvbi5maXJzdEZhbWlseSgpLnNldEZhbWlseShbZm9udCB3ZWJDb3JlRmFt aWx5TmFtZV0pOwogICAgIGZvbnREZXNjcmlwdGlvbi5zZXRDb21wdXRlZFNpemUoW2ZvbnQgcG9p bnRTaXplXSAqIHN0eWxlLT5lZmZlY3RpdmVab29tKCkpOwogICAgIGZvbnREZXNjcmlwdGlvbi5z ZXRTcGVjaWZpZWRTaXplKFtmb250IHBvaW50U2l6ZV0gKiBzdHlsZS0+ZWZmZWN0aXZlWm9vbSgp KTsKIAo=