113384 2013-03-27 03:25:40 -0700 [GTK] Toggle OverWrite mode when pressing the Insert key 2013-04-08 09:04:29 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 svillar svillar cgarcia gustavo mrobinson svillar oldest_to_newest 864354 0 svillar 2013-03-27 03:25:40 -0700 [GTK] Toggle OverWrite mode when pressing the Insert key 864357 1 195258 svillar 2013-03-27 03:31:20 -0700 Created attachment 195258 Patch 864547 2 195258 mrobinson 2013-03-27 08:03:44 -0700 Comment on attachment 195258 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=195258&action=review > Source/WebCore/platform/gtk/KeyBindingTranslator.cpp:238 > + if (event->keyval == GDK_Insert && type == KeyDown) { > + commandList.append("OverWrite"); > + return; > + } > + Why KeyDown and not KeyPress? 864582 3 svillar 2013-03-27 08:45:24 -0700 (In reply to comment #2) > (From update of attachment 195258 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=195258&action=review > > > Source/WebCore/platform/gtk/KeyBindingTranslator.cpp:238 > > + if (event->keyval == GDK_Insert && type == KeyDown) { > > + commandList.append("OverWrite"); > > + return; > > + } > > + > > Why KeyDown and not KeyPress? We don't apparently get KeyPress for the insert key. 864614 4 195258 mrobinson 2013-03-27 09:26:22 -0700 Comment on attachment 195258 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=195258&action=review >>> Source/WebCore/platform/gtk/KeyBindingTranslator.cpp:238 >>> + >> >> Why KeyDown and not KeyPress? > > We don't apparently get KeyPress for the insert key. Okay, that's reasonable. Another question is why not simply add this to keyPressEntries? By doing this without respect to modifiers you are breaking Shift+Insert. 864720 5 svillar 2013-03-27 11:18:16 -0700 (In reply to comment #4) > (From update of attachment 195258 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=195258&action=review > > >>> Source/WebCore/platform/gtk/KeyBindingTranslator.cpp:238 > >>> + > >> > >> Why KeyDown and not KeyPress? > > > > We don't apparently get KeyPress for the insert key. > > Okay, that's reasonable. Another question is why not simply add this to keyPressEntries? By doing this without respect to modifiers you are breaking Shift+Insert. I thought about that but the problem with modifiers is that the Insert won't be detected for example if the BloqNum is active (unless we register all the possible combinations). BTW what's shift+insert for? 864965 6 mrobinson 2013-03-27 16:22:00 -0700 (In reply to comment #5) > (In reply to comment #4) > > (From update of attachment 195258 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=195258&action=review > > > > >>> Source/WebCore/platform/gtk/KeyBindingTranslator.cpp:238 > > >>> + > > >> > > >> Why KeyDown and not KeyPress? > > > > > > We don't apparently get KeyPress for the insert key. > > > > Okay, that's reasonable. Another question is why not simply add this to keyPressEntries? By doing this without respect to modifiers you are breaking Shift+Insert. > > I thought about that but the problem with modifiers is that the Insert won't be detected for example if the BloqNum is active (unless we register all the possible combinations). BTW what's shift+insert for? Is NumLock detected as a modifier? Typically modifiers are keys like Shift and Control that you chord with. Even so, if there is a chord combination that should be active too, you should just add all applicable ones to keyPressEntries. I'm almost certain we don't want to treat Shift+Insert as a switch to overtype mode. 864967 7 mrobinson 2013-03-27 16:23:41 -0700 Looking at this again, instead of adding a special keybinding, you should likely just add your logic to the toggle-overwrite signal! :) Take a look at toggleOverwriteCallback in that file. 870797 8 196860 svillar 2013-04-08 08:56:14 -0700 Created attachment 196860 Patch 870799 9 196860 mrobinson 2013-04-08 08:59:10 -0700 Comment on attachment 196860 Patch This is a lot nicer. :) 870800 10 svillar 2013-04-08 09:04:29 -0700 Committed r147916: <http://trac.webkit.org/changeset/147916> 195258 2013-03-27 03:31:20 -0700 2013-04-08 08:56:09 -0700 Patch bug-113384-20130327112701.patch text/plain 1693 svillar U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ2OTA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDYzYTNiOTM0YzE5MGZi ZmZlZGJhZjdlNzI0MmIwMjY1ZDAwNTc2OS4uOTA1ZDBjZmE5OTg5MGJkMWViNjFmMTY1MDFjZjk4 MTIzMjVmM2RhNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTAzLTI3ICBTZXJn aW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIFRv Z2dsZSBPdmVyV3JpdGUgbW9kZSB3aGVuIHByZXNzaW5nIHRoZSBJbnNlcnQga2V5CisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTMzODQKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGRlZCBhIG5ldyBrZXli aW5kaW5nIGZvciB0aGUgSW5zZXJ0IGtleS4gSXQgd2lsbCBpc3N1ZSBhIE92ZXJ3cml0ZQorICAg ICAgICBjb21tYW5kIGFzIHJlc3BvbnNlIHRvIHRoYXQgYWN0aW9uLiBEdWUgdG8gdGhlIG5hdHVy ZSBvZiB0aGUgY29tbWFuZAorICAgICAgICBpdCB3aWxsIG9ubHkgZG8gdGhhdCB3aGVuIGJlaW5n IG9uIGEgcmljaGx5IGVkaXRhYmxlIHdlYiBjb250ZW50LgorCisgICAgICAgICogcGxhdGZvcm0v Z3RrL0tleUJpbmRpbmdUcmFuc2xhdG9yLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OktleUJpbmRp bmdUcmFuc2xhdG9yOjpnZXRFZGl0b3JDb21tYW5kc0ZvcktleUV2ZW50KToKKwogMjAxMy0wMy0y NiAgU2VyZ2lvIFZpbGxhciBTZW5pbiAgPHN2aWxsYXJAaWdhbGlhLmNvbT4KIAogICAgICAgICBJ bXBsZW1lbnQgb3ZlcnR5cGUgbW9kZSBmb3IgZWRpdGFibGUgY29udGVudApkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL0tleUJpbmRpbmdUcmFuc2xhdG9yLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9LZXlCaW5kaW5nVHJhbnNsYXRvci5jcHAKaW5kZXgg ZTM1YmJkNjI2M2ZmNTk1ODBjYWIwN2I1NmZjZDM5NDRmZTAwOWEwZS4uZDg3NWI2ZGMzNjEwMjVl MTAxZGQ3YTZjOGQ3NWM3ZTJhOTA1YTQ5NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3RrL0tleUJpbmRpbmdUcmFuc2xhdG9yLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ndGsvS2V5QmluZGluZ1RyYW5zbGF0b3IuY3BwCkBAIC0yMzEsNiArMjMxLDExIEBA IHZvaWQgS2V5QmluZGluZ1RyYW5zbGF0b3I6OmdldEVkaXRvckNvbW1hbmRzRm9yS2V5RXZlbnQo R2RrRXZlbnRLZXkqIGV2ZW50LCBFdmVuCiAgICAgICAgIHJldHVybjsKICAgICB9CiAKKyAgICBp ZiAoZXZlbnQtPmtleXZhbCA9PSBHREtfSW5zZXJ0ICYmIHR5cGUgPT0gS2V5RG93bikgeworICAg ICAgICBjb21tYW5kTGlzdC5hcHBlbmQoIk92ZXJXcml0ZSIpOworICAgICAgICByZXR1cm47Cisg ICAgfQorCiAgICAgLy8gRm9yIGtleXByZXNzIGV2ZW50cywgd2Ugd2FudCBjaGFyQ29kZSgpLCBi dXQga2V5Q29kZSgpIGRvZXMgdGhhdC4KICAgICBpbnQgbWFwS2V5ID0gZXZlbnQtPnN0YXRlIDw8 IDE2IHwgZXZlbnQtPmtleXZhbDsKICAgICBpZiAobWFwS2V5KSB7Cg== 196860 2013-04-08 08:56:14 -0700 2013-04-08 08:59:09 -0700 Patch bug-113384-20130408175557.patch text/plain 1950 svillar U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ3OTA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDZmZDliODBlNDJlM2Mw ZjZiYTZmMGU1M2VjYzJiNzY1M2ZjNGI1Ni4uN2U3OGM4YTllNzcxN2ExNzkwMjM4ZDQ0Y2JhZDEz MzA4YzNkMjRlNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTA0LTA4ICBTZXJn aW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIFRv Z2dsZSBPdmVyV3JpdGUgbW9kZSB3aGVuIHByZXNzaW5nIHRoZSBJbnNlcnQga2V5CisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTMzODQKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBQZXJmb3JtIGFuIE92ZXJX cml0ZSBjb21tYW5kIGFzIGEgcmVzcG9uc2UgdG8gdGhlIGVtaXNzaW9uIG9mIHRoZQorICAgICAg ICB0b2dnbGUtb3ZlcndyaXRlIHNpZ25hbC4gRHVlIHRvIHRoZSBuYXR1cmUgb2YgdGhlIGNvbW1h bmQgaXQgd2lsbAorICAgICAgICBvbmx5IGRvIHRoYXQgd2hlbiBiZWluZyBvbiBhIHJpY2hseSBl ZGl0YWJsZSB3ZWIgY29udGVudC4KKworICAgICAgICAqIHBsYXRmb3JtL2d0ay9LZXlCaW5kaW5n VHJhbnNsYXRvci5jcHA6CisgICAgICAgIChXZWJDb3JlOjp0b2dnbGVPdmVyd3JpdGVDYWxsYmFj ayk6CisKIDIwMTMtMDQtMDcgIEJlbmphbWluIFBvdWxhaW4gIDxiZW5qYW1pbkB3ZWJraXQub3Jn PgogCiAgICAgICAgIFJlbW92ZSB0aGUgYW5kcm9pZCBjb2RlIGZyb20gV2ViQ29yZQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL0tleUJpbmRpbmdUcmFuc2xhdG9yLmNw cCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9LZXlCaW5kaW5nVHJhbnNsYXRvci5jcHAK aW5kZXggZTM1YmJkNjI2M2ZmNTk1ODBjYWIwN2I1NmZjZDM5NDRmZTAwOWEwZS4uNjg2NGY1M2I2 NjNjMzVmMDZiYmNlN2M2YzZmMjc0MDkxMGUwMTBhNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3RrL0tleUJpbmRpbmdUcmFuc2xhdG9yLmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ndGsvS2V5QmluZGluZ1RyYW5zbGF0b3IuY3BwCkBAIC01NywxMSArNTcs MTAgQEAgc3RhdGljIHZvaWQgcGFzdGVDbGlwYm9hcmRDYWxsYmFjayhHdGtXaWRnZXQqIHdpZGdl dCwgS2V5QmluZGluZ1RyYW5zbGF0b3IqIHRyYW4KICAgICB0cmFuc2xhdG9yLT5hZGRQZW5kaW5n RWRpdG9yQ29tbWFuZCgiUGFzdGUiKTsKIH0KIAotc3RhdGljIHZvaWQgdG9nZ2xlT3ZlcndyaXRl Q2FsbGJhY2soR3RrV2lkZ2V0KiB3aWRnZXQsIEtleUJpbmRpbmdUcmFuc2xhdG9yKikKK3N0YXRp YyB2b2lkIHRvZ2dsZU92ZXJ3cml0ZUNhbGxiYWNrKEd0a1dpZGdldCogd2lkZ2V0LCBLZXlCaW5k aW5nVHJhbnNsYXRvciogdHJhbnNsYXRvcikKIHsKLSAgICAvLyBXZSBkb24ndCBzdXBwb3J0IHRv Z2dsaW5nIHRoZSBvdmVyd3JpdGUgbW9kZSwgYnV0IHRoZSBkZWZhdWx0IGNhbGxiYWNrIGV4cGVj dHMKLSAgICAvLyB0aGUgR3RrVGV4dFZpZXcgdG8gaGF2ZSBhIGxheW91dCwgc28gd2UgaGFuZGxl IHRoaXMgc2lnbmFsIGp1c3QgdG8gc3RvcCBpdC4KICAgICBnX3NpZ25hbF9zdG9wX2VtaXNzaW9u X2J5X25hbWUod2lkZ2V0LCAidG9nZ2xlLW92ZXJ3cml0ZSIpOworICAgIHRyYW5zbGF0b3ItPmFk ZFBlbmRpbmdFZGl0b3JDb21tYW5kKCJPdmVyV3JpdGUiKTsKIH0KIAogLy8gR1RLKyB3aWxsIHN0 aWxsIHNlbmQgdGhlc2Ugc2lnbmFscyB0byB0aGUgd2ViIHZpZXcuIFNvIHdlIGNhbiBzYWZlbHkg c3RvcCBzaWduYWwK