113382 2013-03-27 03:05:40 -0700 [EFL][WK2] Empty tooltip shown when hovering over popup menu items 2013-04-02 02:48:38 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 naginenis naginenis gyuyoung.kim lucas.de.marchi webkit.review.bot oldest_to_newest 864346 0 naginenis 2013-03-27 03:05:40 -0700 Useless empty tooltip box shown when hovering over popup menu items. 864429 1 195284 naginenis 2013-03-27 05:13:55 -0700 Created attachment 195284 Patch 867641 2 195284 gyuyoung.kim 2013-04-02 01:11:56 -0700 Comment on attachment 195284 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=195284&action=review > Tools/MiniBrowser/efl/main.c:932 > + const char* tooltipText = ewk_popup_menu_item_tooltip_get(ewk_item); Wrong * place. And, please follow EFL variable name style in MiniBrowser, tooltip_text ? 867651 3 196100 naginenis 2013-04-02 01:23:30 -0700 Created attachment 196100 Patch Take Gyuyoung's feedback into consideration. 867653 4 196100 cdumez 2013-04-02 01:24:12 -0700 Comment on attachment 196100 Patch LGTM. Thanks. 867665 5 196100 gyuyoung.kim 2013-04-02 01:54:24 -0700 Comment on attachment 196100 Patch Chrome and Safari browsers also don't show tooltip box when tooltip text is null. So, this patch allows MiniBrowser to follow their behavior. LGTM. 867684 6 196100 webkit.review.bot 2013-04-02 02:48:34 -0700 Comment on attachment 196100 Patch Clearing flags on attachment: 196100 Committed r147410: <http://trac.webkit.org/changeset/147410> 867685 7 webkit.review.bot 2013-04-02 02:48:38 -0700 All reviewed patches have been landed. Closing bug. 195284 2013-03-27 05:13:55 -0700 2013-04-02 01:23:30 -0700 Patch 113382.patch text/plain 1668 naginenis ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBhMTU1 OWY2Li5mMzYzN2M5IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTMtMDMtMjcgIFN1ZGFyc2FuYSBOYWdpbmVuaSAg PHN1ZGFyc2FuYS5uYWdpbmVuaUBpbnRlbC5jb20+CisKKyAgICAgICAgW0VGTF1bV0syXSBFbXB0 eSB0b29sdGlwIHNob3duIHdoZW4gaG92ZXJpbmcgb3ZlciBwb3B1cCBtZW51IGl0ZW1zCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTMzODIKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEbyBub3Qgc2hvdyB0 aGUgZW1wdHkgdG9vbHRpcCBib3ggaWYgdGhlIHRleHQgaXMgbnVsbC4KKworICAgICAgICAqIE1p bmlCcm93c2VyL2VmbC9tYWluLmM6CisgICAgICAgIChwb3B1cF9tZW51X3BvcHVsYXRlKToKKwog MjAxMy0wMy0yNyAgWmVubyBBbGJpc3NlciAgPHplbm9Ad2Via2l0Lm9yZz4KIAogICAgICAgICBb UXRdIFJlbW92ZSBRdCBzcGVjaWZpYyBXb3JrUXVldWVJdGVtIGRlZmluaXRpb25zLgpkaWZmIC0t Z2l0IGEvVG9vbHMvTWluaUJyb3dzZXIvZWZsL21haW4uYyBiL1Rvb2xzL01pbmlCcm93c2VyL2Vm bC9tYWluLmMKaW5kZXggNTdjOGVmZC4uNzUxYzljNiAxMDA2NDQKLS0tIGEvVG9vbHMvTWluaUJy b3dzZXIvZWZsL21haW4uYworKysgYi9Ub29scy9NaW5pQnJvd3Nlci9lZmwvbWFpbi5jCkBAIC05 MjksNyArOTI5LDkgQEAgcG9wdXBfbWVudV9wb3B1bGF0ZShFdmFzX09iamVjdCAqZWxtX21lbnUs IEV3a19Qb3B1cF9NZW51ICpld2tfbWVudSwgdm9pZCAqdXNlcl8KICAgICAgICAgICAgICAgICBl bG1fb2JqZWN0X2l0ZW1fZGlzYWJsZWRfc2V0KGl0ZW0sIEVJTkFfVFJVRSk7CiAgICAgICAgICAg ICB9IGVsc2UgewogICAgICAgICAgICAgICAgIEVsbV9PYmplY3RfSXRlbSAqaXRlbSA9IGVsbV9t ZW51X2l0ZW1fYWRkKGVsbV9tZW51LCBOVUxMLCBOVUxMLCBld2tfcG9wdXBfbWVudV9pdGVtX3Rl eHRfZ2V0KGV3a19pdGVtKSwgb25fcG9wdXBfbWVudV9pdGVtX2NsaWNrZWQsIHVzZXJfZGF0YSk7 Ci0gICAgICAgICAgICAgICAgZWxtX29iamVjdF9pdGVtX3Rvb2x0aXBfdGV4dF9zZXQoaXRlbSwg ZXdrX3BvcHVwX21lbnVfaXRlbV90b29sdGlwX2dldChld2tfaXRlbSkpOworICAgICAgICAgICAg ICAgIGNvbnN0IGNoYXIqIHRvb2x0aXBUZXh0ID0gZXdrX3BvcHVwX21lbnVfaXRlbV90b29sdGlw X2dldChld2tfaXRlbSk7CisgICAgICAgICAgICAgICAgaWYgKHRvb2x0aXBUZXh0ICYmIHRvb2x0 aXBUZXh0WzBdICE9ICdcMCcpCisgICAgICAgICAgICAgICAgICAgIGVsbV9vYmplY3RfaXRlbV90 b29sdGlwX3RleHRfc2V0KGl0ZW0sIHRvb2x0aXBUZXh0KTsKICAgICAgICAgICAgICAgICBlbG1f b2JqZWN0X2l0ZW1fZGlzYWJsZWRfc2V0KGl0ZW0sICFld2tfcG9wdXBfbWVudV9pdGVtX2VuYWJs ZWRfZ2V0KGV3a19pdGVtKSk7CiAgICAgICAgICAgICAgICAgZWxtX21lbnVfaXRlbV9zZWxlY3Rl ZF9zZXQoaXRlbSwgZXdrX3BvcHVwX21lbnVfaXRlbV9zZWxlY3RlZF9nZXQoZXdrX2l0ZW0pKTsK ICAgICAgICAgICAgIH0K 196100 2013-04-02 01:23:30 -0700 2013-04-02 02:48:34 -0700 Patch 113382.patch text/plain 1664 naginenis ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA4YTNl NGI2Li42OWNiMzljIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTMtMDQtMDIgIFN1ZGFyc2FuYSBOYWdpbmVuaSAg PHN1ZGFyc2FuYS5uYWdpbmVuaUBpbnRlbC5jb20+CisKKyAgICAgICAgW0VGTF1bV0syXSBFbXB0 eSB0b29sdGlwIHNob3duIHdoZW4gaG92ZXJpbmcgb3ZlciBwb3B1cCBtZW51IGl0ZW1zCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTMzODIKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEbyBub3Qgc2hvdyB0 aGUgZW1wdHkgdG9vbHRpcCBib3ggaWYgdGhlIHRleHQgaXMgbnVsbC4KKworICAgICAgICAqIE1p bmlCcm93c2VyL2VmbC9tYWluLmM6CisgICAgICAgIChwb3B1cF9tZW51X3BvcHVsYXRlKToKKwog MjAxMy0wNC0wMSAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CiAK ICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjE0NzMxOS4KZGlmZiAtLWdpdCBhL1Rv b2xzL01pbmlCcm93c2VyL2VmbC9tYWluLmMgYi9Ub29scy9NaW5pQnJvd3Nlci9lZmwvbWFpbi5j CmluZGV4IDU3YzhlZmQuLmQ1MzVmNGYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL01pbmlCcm93c2VyL2Vm bC9tYWluLmMKKysrIGIvVG9vbHMvTWluaUJyb3dzZXIvZWZsL21haW4uYwpAQCAtOTI5LDcgKzky OSw5IEBAIHBvcHVwX21lbnVfcG9wdWxhdGUoRXZhc19PYmplY3QgKmVsbV9tZW51LCBFd2tfUG9w dXBfTWVudSAqZXdrX21lbnUsIHZvaWQgKnVzZXJfCiAgICAgICAgICAgICAgICAgZWxtX29iamVj dF9pdGVtX2Rpc2FibGVkX3NldChpdGVtLCBFSU5BX1RSVUUpOwogICAgICAgICAgICAgfSBlbHNl IHsKICAgICAgICAgICAgICAgICBFbG1fT2JqZWN0X0l0ZW0gKml0ZW0gPSBlbG1fbWVudV9pdGVt X2FkZChlbG1fbWVudSwgTlVMTCwgTlVMTCwgZXdrX3BvcHVwX21lbnVfaXRlbV90ZXh0X2dldChl d2tfaXRlbSksIG9uX3BvcHVwX21lbnVfaXRlbV9jbGlja2VkLCB1c2VyX2RhdGEpOwotICAgICAg ICAgICAgICAgIGVsbV9vYmplY3RfaXRlbV90b29sdGlwX3RleHRfc2V0KGl0ZW0sIGV3a19wb3B1 cF9tZW51X2l0ZW1fdG9vbHRpcF9nZXQoZXdrX2l0ZW0pKTsKKyAgICAgICAgICAgICAgICBjb25z dCBjaGFyICp0b29sdGlwX3RleHQgPSBld2tfcG9wdXBfbWVudV9pdGVtX3Rvb2x0aXBfZ2V0KGV3 a19pdGVtKTsKKyAgICAgICAgICAgICAgICBpZiAodG9vbHRpcF90ZXh0ICYmIHRvb2x0aXBfdGV4 dFswXSAhPSAnXDAnKQorICAgICAgICAgICAgICAgICAgICBlbG1fb2JqZWN0X2l0ZW1fdG9vbHRp cF90ZXh0X3NldChpdGVtLCB0b29sdGlwX3RleHQpOwogICAgICAgICAgICAgICAgIGVsbV9vYmpl Y3RfaXRlbV9kaXNhYmxlZF9zZXQoaXRlbSwgIWV3a19wb3B1cF9tZW51X2l0ZW1fZW5hYmxlZF9n ZXQoZXdrX2l0ZW0pKTsKICAgICAgICAgICAgICAgICBlbG1fbWVudV9pdGVtX3NlbGVjdGVkX3Nl dChpdGVtLCBld2tfcG9wdXBfbWVudV9pdGVtX3NlbGVjdGVkX2dldChld2tfaXRlbSkpOwogICAg ICAgICAgICAgfQo=