113375 2013-03-27 01:57:59 -0700 Web Inspector: [Settings] "previouslyViewedFiles" exceeds local storage quota. 2013-03-28 06:07:32 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 eustas eustas apavlov keishi loislo pfeldman pmuellr vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 864312 0 eustas 2013-03-27 01:57:59 -0700 Original issue: [devtools] previouslyViewedFiles exceeds local storage quota https://code.google.com/p/chromium/issues/detail?id=222542 Details: WebInspector.TabbedEditorContainer history length is limited to 30 entries. But in case of data-urls serialized history could become really huge. Given that restoring tabs specified by large data URLs is not essential we can avoid serializing/saving them. 864348 1 eustas 2013-03-27 03:14:40 -0700 One more thing to fix: history log is unlimited. 864356 2 195257 eustas 2013-03-27 03:27:40 -0700 Created attachment 195257 Patch 864530 3 195257 pfeldman 2013-03-27 07:30:46 -0700 Comment on attachment 195257 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=195257&action=review > Source/WebCore/inspector/front-end/TabbedEditorContainer.js:601 > + if (serializedHistory.length === WebInspector.TabbedEditorContainer.maximalPreviouslyViewedFilesCount) What if it already was larger than maximum? 864531 4 pfeldman 2013-03-27 07:31:01 -0700 (This also needs a test) 865205 5 195257 eustas 2013-03-27 23:49:22 -0700 Comment on attachment 195257 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=195257&action=review >> Source/WebCore/inspector/front-end/TabbedEditorContainer.js:601 >> + if (serializedHistory.length === WebInspector.TabbedEditorContainer.maximalPreviouslyViewedFilesCount) > > What if it already was larger than maximum? serializedHistory is initially clear and we add at most one item per loop. So this is possible only in if maximalPreviouslyViewedFilesCount <= 0. 865420 6 195257 webkit.review.bot 2013-03-28 06:07:27 -0700 Comment on attachment 195257 Patch Clearing flags on attachment: 195257 Committed r147104: <http://trac.webkit.org/changeset/147104> 865421 7 webkit.review.bot 2013-03-28 06:07:32 -0700 All reviewed patches have been landed. Closing bug. 195257 2013-03-27 03:27:40 -0700 2013-03-28 06:07:27 -0700 Patch bug-113375-20130327142321.patch text/plain 3830 eustas U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ2OTY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWI1M2RiNDcxYjNjNzkw OTNhZTU3OTA5OTc3ZDRmMjk4ODQ4Y2IzMy4uZDMyMTQxOTI1NzRmY2JlODk5YWYzOTlkZjliMDU5 NWY2MzE1YWNkYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEzLTAzLTI3ICBFdWdl bmUgS2x5dWNobmlrb3YgIDxldXN0YXNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNw ZWN0b3I6IFtTZXR0aW5nc10gInByZXZpb3VzbHlWaWV3ZWRGaWxlcyIgZXhjZWVkcyBsb2NhbCBz dG9yYWdlIHF1b3RhLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTEzMzc1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgU2VyaWFsaXplZCAicHJldmlvdXNseVZpZXdlZEZpbGVzIiBtYXkgbWFrZSBsb2NhbCBz dG9yYWdlIG92ZXJmbG93LgorICAgICAgICBUd28gZml4ZWQgYXBwbGllZDoKKyAgICAgICAgLSBs aW1pdCBudW1iZXIgb2YgaGlzdG9yeSBsb2cgaXRlbXMKKyAgICAgICAgLSBsaW1pdCBsZW5ndGgg b2YgVVJJcyB0aGF0IGdldCBzZXJpYWxpemVkOworICAgICAgICAgIHRoaXMgd291bGQgYWZmZWN0 IG9ubHkgZGF0YS11cmwgVVJJcy4KKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvVGFi YmVkRWRpdG9yQ29udGFpbmVyLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRhYmJlZEVkaXRv ckNvbnRhaW5lci5IaXN0b3J5SXRlbS5wcm90b3R5cGUuc2VyaWFsaXplVG9PYmplY3QpOgorICAg ICAgICBBZGRlZCBsZW5ndGggY2hlY2suCisgICAgICAgIChXZWJJbnNwZWN0b3IuVGFiYmVkRWRp dG9yQ29udGFpbmVyLkhpc3RvcnkucHJvdG90eXBlLnNldCBfc2VyaWFsaXplVG9PYmplY3QpOgor ICAgICAgICBBZGRlZCBvdXRwdXQgYXJyYXkgbGVuZ3RoIGxpbWl0LgorCiAyMDEzLTAzLTI2ICBU YWtlc2hpIFlvc2hpbm8gIDx0eW9zaGlub0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgTWFrZSBT b2NrZXRTdHJlYW1IYW5kbGUgKENocm9taXVtIHBvcnQpIGZ1bGx5IHVzZSBJUEMgd2luZG93IGlu IHNlbmQoKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9U YWJiZWRFZGl0b3JDb250YWluZXIuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQt ZW5kL1RhYmJlZEVkaXRvckNvbnRhaW5lci5qcwppbmRleCAxMjFhMTZjMzNhOTBhZmViMWFmMTYy M2U0NDg3MTJiNjEyM2RhODgzLi44NDE3YWM2Yjc0MmNlMzdkZGQzMTE5Yjc1MjRiYzYwZDUwZjA4 ZDM1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1RhYmJl ZEVkaXRvckNvbnRhaW5lci5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQt ZW5kL1RhYmJlZEVkaXRvckNvbnRhaW5lci5qcwpAQCAtNDI0LDExICs0MjQsMTQgQEAgV2ViSW5z cGVjdG9yLlRhYmJlZEVkaXRvckNvbnRhaW5lci5wcm90b3R5cGUgPSB7CiAgKi8KIFdlYkluc3Bl Y3Rvci5UYWJiZWRFZGl0b3JDb250YWluZXIuSGlzdG9yeUl0ZW0gPSBmdW5jdGlvbih1cmwsIHNl bGVjdGlvblJhbmdlLCBzY3JvbGxMaW5lTnVtYmVyKQogewotICAgIHRoaXMudXJsID0gdXJsOwor ICAgIC8qKiBAY29uc3QgKi8gdGhpcy51cmwgPSB1cmw7CisgICAgLyoqIEBjb25zdCAqLyB0aGlz Ll9pc1NlcmlhbGl6YWJsZSA9IHVybC5sZW5ndGggPCBXZWJJbnNwZWN0b3IuVGFiYmVkRWRpdG9y Q29udGFpbmVyLkhpc3RvcnlJdGVtLnNlcmlhbGl6YWJsZVVybExlbmd0aExpbWl0OwogICAgIHRo aXMuc2VsZWN0aW9uUmFuZ2UgPSBzZWxlY3Rpb25SYW5nZTsKICAgICB0aGlzLnNjcm9sbExpbmVO dW1iZXIgPSBzY3JvbGxMaW5lTnVtYmVyOwogfQogCitXZWJJbnNwZWN0b3IuVGFiYmVkRWRpdG9y Q29udGFpbmVyLkhpc3RvcnlJdGVtLnNlcmlhbGl6YWJsZVVybExlbmd0aExpbWl0ID0gNDA5NjsK KwogLyoqCiAgKiBAcGFyYW0ge09iamVjdH0gc2VyaWFsaXplZEhpc3RvcnlJdGVtCiAgKiBAcmV0 dXJuIHtXZWJJbnNwZWN0b3IuVGFiYmVkRWRpdG9yQ29udGFpbmVyLkhpc3RvcnlJdGVtfQpAQCAt NDQxLDEwICs0NDQsMTIgQEAgV2ViSW5zcGVjdG9yLlRhYmJlZEVkaXRvckNvbnRhaW5lci5IaXN0 b3J5SXRlbS5mcm9tT2JqZWN0ID0gZnVuY3Rpb24gKHNlcmlhbGl6ZWQKIAogV2ViSW5zcGVjdG9y LlRhYmJlZEVkaXRvckNvbnRhaW5lci5IaXN0b3J5SXRlbS5wcm90b3R5cGUgPSB7CiAgICAgLyoq Ci0gICAgICogQHJldHVybiB7T2JqZWN0fQorICAgICAqIEByZXR1cm4gez9PYmplY3R9CiAgICAg ICovCiAgICAgc2VyaWFsaXplVG9PYmplY3Q6IGZ1bmN0aW9uKCkKICAgICB7CisgICAgICAgIGlm ICghdGhpcy5faXNTZXJpYWxpemFibGUpCisgICAgICAgICAgICByZXR1cm4gbnVsbDsKICAgICAg ICAgdmFyIHNlcmlhbGl6ZWRIaXN0b3J5SXRlbSA9IHt9OwogICAgICAgICBzZXJpYWxpemVkSGlz dG9yeUl0ZW0udXJsID0gdGhpcy51cmw7CiAgICAgICAgIHNlcmlhbGl6ZWRIaXN0b3J5SXRlbS5z ZWxlY3Rpb25SYW5nZSA9IHRoaXMuc2VsZWN0aW9uUmFuZ2U7CkBAIC00NjYsNyArNDcxLDcgQEAg V2ViSW5zcGVjdG9yLlRhYmJlZEVkaXRvckNvbnRhaW5lci5IaXN0b3J5ID0gZnVuY3Rpb24oaXRl bXMpCiB9CiAKIC8qKgotICogQHBhcmFtIHtPYmplY3R9IHNlcmlhbGl6ZWRIaXN0b3J5CisgKiBA cGFyYW0geyFBcnJheS48IU9iamVjdD59IHNlcmlhbGl6ZWRIaXN0b3J5CiAgKiBAcmV0dXJuIHtX ZWJJbnNwZWN0b3IuVGFiYmVkRWRpdG9yQ29udGFpbmVyLkhpc3Rvcnl9CiAgKi8KIFdlYkluc3Bl Y3Rvci5UYWJiZWRFZGl0b3JDb250YWluZXIuSGlzdG9yeS5mcm9tT2JqZWN0ID0gZnVuY3Rpb24o c2VyaWFsaXplZEhpc3RvcnkpCkBAIC01ODQsMTMgKzU4OSwxOCBAQCBXZWJJbnNwZWN0b3IuVGFi YmVkRWRpdG9yQ29udGFpbmVyLkhpc3RvcnkucHJvdG90eXBlID0gewogICAgIH0sCiAgICAgCiAg ICAgLyoqCi0gICAgICogQHJldHVybiB7T2JqZWN0fQorICAgICAqIEByZXR1cm4geyFBcnJheS48 IU9iamVjdD59CiAgICAgICovCiAgICAgX3NlcmlhbGl6ZVRvT2JqZWN0OiBmdW5jdGlvbigpCiAg ICAgewogICAgICAgICB2YXIgc2VyaWFsaXplZEhpc3RvcnkgPSBbXTsKLSAgICAgICAgZm9yICh2 YXIgaSA9IDA7IGkgPCB0aGlzLl9pdGVtcy5sZW5ndGg7ICsraSkKLSAgICAgICAgICAgIHNlcmlh bGl6ZWRIaXN0b3J5LnB1c2godGhpcy5faXRlbXNbaV0uc2VyaWFsaXplVG9PYmplY3QoKSk7Cisg ICAgICAgIGZvciAodmFyIGkgPSAwOyBpIDwgdGhpcy5faXRlbXMubGVuZ3RoOyArK2kpIHsKKyAg ICAgICAgICAgIHZhciBzZXJpYWxpemVkSXRlbSA9IHRoaXMuX2l0ZW1zW2ldLnNlcmlhbGl6ZVRv T2JqZWN0KCk7CisgICAgICAgICAgICBpZiAoc2VyaWFsaXplZEl0ZW0pCisgICAgICAgICAgICAg ICAgc2VyaWFsaXplZEhpc3RvcnkucHVzaChzZXJpYWxpemVkSXRlbSk7CisgICAgICAgICAgICBp ZiAoc2VyaWFsaXplZEhpc3RvcnkubGVuZ3RoID09PSBXZWJJbnNwZWN0b3IuVGFiYmVkRWRpdG9y Q29udGFpbmVyLm1heGltYWxQcmV2aW91c2x5Vmlld2VkRmlsZXNDb3VudCkKKyAgICAgICAgICAg ICAgICBicmVhazsKKyAgICAgICAgfQogICAgICAgICByZXR1cm4gc2VyaWFsaXplZEhpc3Rvcnk7 CiAgICAgfSwKIAo=