113360 2013-03-26 18:18:02 -0700 [GTK] [gyp] Improve support for rerunning gyp automatically 2013-03-28 09:38:45 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mrobinson mrobinson gustavo oldest_to_newest 864167 0 mrobinson 2013-03-26 18:18:02 -0700 When the gyp files change, the build should rerun gyp automatically. Because of bugs in gyp, this is broken. The suggestion on the gyp list was to simply write this ourselves. 864178 1 195206 mrobinson 2013-03-26 18:54:18 -0700 Created attachment 195206 Patch 864964 2 195206 gustavo 2013-03-27 16:20:59 -0700 Comment on attachment 195206 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=195206&action=review > Source/WebKit/gtk/gyp/GNUmakefile:16 > + @echo "Rerunning gyp..." && ./run-gyp && here is unnecessary I'd say, there is no way for echo to fail, is there? ; should do, but that's just a nit > Source/WebKit/gtk/gyp/autogen.sh:19 > + ln -s "$SCRIPT_DIRECTORY/GNUmakefile" Just thinking out loud here: I'm wondering after rereading this if we shouldn't just ln -sf, guess that can break if $SCRIPT_DIRECTORY == ., hrm 865580 3 mrobinson 2013-03-28 09:38:45 -0700 Committed r147125: <http://trac.webkit.org/changeset/147125> 195206 2013-03-26 18:54:18 -0700 2013-03-27 16:20:59 -0700 Patch bug-113360-20130326185000.patch text/plain 4510 mrobinson U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ2OTE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2d0 ay9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKaW5kZXggOGFjMWU2YTlh OGE2YTg2MzUzMGM3MjA3YjdhNGQ3NzE5OWZlZGI2My4uMjQ5MjRlZTg0YWMzOWZlM2U3NjRjOWVj ZmQ0ZGIyMDgwODZmZTUxNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEz LTAzLTI2ICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KKworICAgICAg ICBbR1RLXSBbZ3lwXSBJbXByb3ZlIHN1cHBvcnQgZm9yIHJlcnVubmluZyBneXAgYXV0b21hdGlj YWxseQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEz MzYwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRk IHN1cHBvcnQgZm9yIGF1dG9tYXRpY2FsbHkgcmVydW5uaW5nIGd5cCB3aGVuIGlucHV0IGZpbGUg Y2hhbmdlcyBhcmUgZGV0ZWN0ZWQKKyAgICAgICAgd2hpbGUgcnVubmluZyBtYWtlLgorCisgICAg ICAgICogZ3lwL0dOVW1ha2VmaWxlOiBBZGRlZC4gQSB3cmFwcGVyIHRoYXQgaW52b2tlcyB0aGUg Z2VuZXJhdGVkIG1ha2VmaWxlLgorICAgICAgICAqIGd5cC9hdXRvZ2VuLnNoOiBBZGQgYSBzeW1s aW5rIHRvIHRoZSB3cmFwcGVyIHNjcmlwdC4KKyAgICAgICAgKiBneXAvY29uZmlndXJlLmFjOiAi RnJlZXplIiB0aGUgVE9QTEVWRUxfRElSRUNUT1JZIGNvbW1hbmQtbGluZSBhcmd1bWVudCBzbyB0 aGF0CisgICAgICAgIHJ1bi1neXAgcmVhZHMgaXQgcHJvcGVybHkgd2hlbiBjb25maWd1cmUgaXMg cnVuIGluZGVwZW5kZW50bHkgb2YgYXV0b2dlbi5zaC4KKyAgICAgICAgKiBneXAvcnVuLWd5cDog UHJldmVudCBnZW5lcmF0aW9uIG9mIGF1dG8tcmVnZW5lcmF0aW9uIHJ1bGVzIGluIGd5cC4gVGhl eSBhcmUgYnVnZ3kuCisKIDIwMTMtMDMtMjMgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNp YUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdW1JlZ3Jlc3Npb25dIHdlYmtpdF9kb21faHRt bF90YWJsZV9lbGVtZW50X2luc2VydF9yb3cgcmV0dXJucyB2YWx1ZSB0aGF0IGRvZXNuJ3QgcGFz cyBXRUJLSVRfRE9NX0lTX0hUTUxfVEFCTEVfUk9XX0VMRU1FTlQgbWFjcm8KZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvZ3RrL2d5cC9HTlVtYWtlZmlsZSBiL1NvdXJjZS9XZWJLaXQvZ3RrL2d5 cC9HTlVtYWtlZmlsZQpuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi40YTE4M2RjN2RjMDBhNzQzODE2OTQwN2YwZjA2MzM1 OWI2ODI4MTYwCi0tLSAvZGV2L251bGwKKysrIGIvU291cmNlL1dlYktpdC9ndGsvZ3lwL0dOVW1h a2VmaWxlCkBAIC0wLDAgKzEsMTYgQEAKKyMgVGhpcyBpcyBhIHdyYXBwZXIgbWFrZWZpbGUgZm9y IHRoZSBneXAtZ2VuZXJhdGVkIG9uZSB3aGljaCBzdXBwb3J0cyByZXJ1bm5pbmcgZ3lwIHdoZW4g dGhlIGlucHV0IGNoYW5nZXMuCitpbmNsdWRlIE1ha2VmaWxlCisKK01ha2VmaWxlOiAkKHNyY2Rp cikvU291cmNlL1dURi9XVEYuZ3lwaSBcCisJCSAgJChzcmNkaXIpL1NvdXJjZS9XZWJDb3JlL1dl YkNvcmUuZ3lwL1dlYkNvcmVHVEsuZ3lwIFwKKwkJICAkKHNyY2RpcikvU291cmNlL1dlYkNvcmUv V2ViQ29yZS5neXAvQ29udmVydEZpbGVUb0hlYWRlcldpdGhDaGFyYWN0ZXJBcnJheS5neXBpIFwK KwkJICAkKHNyY2RpcikvU291cmNlL1dlYkNvcmUvV2ViQ29yZS5neXAvTWFrZU5hbWVzLmd5cGkg XAorCQkgICQoc3JjZGlyKS9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9BTkdMRS5neXAvQU5HTEUu Z3lwIFwKKwkJICAkKHNyY2RpcikvU291cmNlL0phdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3Jl Lmd5cGkgXAorCQkgICQoc3JjZGlyKS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvSmF2YVNjcmlwdENv cmUuZ3lwL0phdmFTY3JpcHRDb3JlR1RLLmd5cCBcCisJCSAgJChzcmNkaXIpL1NvdXJjZS9XZWJD b3JlL1dlYkNvcmUuZ3lwaSBcCisJCSAgJChzcmNkaXIpL1NvdXJjZS9XVEYvV1RGLmd5cC9XVEZH VEsuZ3lwIFwKKwkJICAkKHNyY2RpcikvU291cmNlL1dlYktpdC9ndGsvZ3lwL0RlcGVuZGVuY2ll cy5neXAgXAorCQkgICQoc3JjZGlyKS9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9BTkdMRS5neXBp IFwKKwkJICAkKHNyY2RpcikvYnVpbGQvQ29uZmlndXJhdGlvbi5neXBpCisJQGVjaG8gIlJlcnVu bmluZyBneXAuLi4iICYmIC4vcnVuLWd5cApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ndGsv Z3lwL2F1dG9nZW4uc2ggYi9Tb3VyY2UvV2ViS2l0L2d0ay9neXAvYXV0b2dlbi5zaAppbmRleCAz MjkzNGE3NjViY2MxMWU5MmVjY2ExODFlNDM4MjBiMGIzOThjMWI4Li40NjQ3ZmRhNGY3NWVjYWY3 MmUxYTM4ODMwOWEzYWJhYjY4ZjU1NWIwIDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViS2l0L2d0ay9n eXAvYXV0b2dlbi5zaAorKysgYi9Tb3VyY2UvV2ViS2l0L2d0ay9neXAvYXV0b2dlbi5zaApAQCAt MTUsNiArMTUsMTAgQEAgaWYgWyAhIC1lIGNvbmZpZ3VyZS5hYyBdOyB0aGVuCiAgICAgbG4gLXMg IiRTQ1JJUFRfRElSRUNUT1JZL2NvbmZpZ3VyZS5hYyIKIGZpCiAKK2lmIFsgISAtZSBHTlVtYWtl ZmlsZSBdOyB0aGVuCisgICAgbG4gLXMgIiRTQ1JJUFRfRElSRUNUT1JZL0dOVW1ha2VmaWxlIgor ZmkKKwogaWYgWyAhIC1lIFdlYktpdE1hY3JvcyBdOyB0aGVuCiAgICAgbG4gLXMgIiRUT1BMRVZF TF9ESVJFQ1RPUlkvU291cmNlL2F1dG90b29scyIgV2ViS2l0TWFjcm9zCiBmaQpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC9ndGsvZ3lwL2NvbmZpZ3VyZS5hYyBiL1NvdXJjZS9XZWJLaXQvZ3Rr L2d5cC9jb25maWd1cmUuYWMKaW5kZXggMGJlNDQzMDA5ZDFkN2Q5ZTYxNmZlNGU5OGY5YzAyOWVm YjQ1ODY5MS4uYTc3MjQ4ZWRmMDhjYjg2MWZiODIxNjBhMDZiYjUzNDZhMmI4ZmVjYyAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdC9ndGsvZ3lwL2NvbmZpZ3VyZS5hYworKysgYi9Tb3VyY2UvV2Vi S2l0L2d0ay9neXAvY29uZmlndXJlLmFjCkBAIC0yOSw5ICsyOSwxMyBAQCBtNF9pbmNsdWRlKFtX ZWJLaXRNYWNyb3MvU2V0dXBXZWJLaXRGZWF0dXJlcy5tNF0pCiBXRUJLSVRfRkVBVFVSRVM9YGNh dCBXZWJLaXRGZWF0dXJlcy50eHQgfCB0ciAnXG4nICcgJ2AKIEFDX1NVQlNUKFdFQktJVF9GRUFU VVJFUykKIAorIyBUaGlzIGlzIGhvdyB3ZSBwcmVzZXJ2ZSBhIHZhcmlhYmxlIHNldCBkdXJpbmcg YXV0b2dlbi5zaCBpbnRvIHRoZSBjb25maWd1cmUgcGhhc2UsIGFsbG93aW5nCisjIHVzIHRvIHBy ZXNlcnZlIHRoZSB2YWx1ZSBvZiBUT1BMRVZFTF9ESVJFQ1RPUlkgZXZlbiB3aGVuIHJ1bm5pbmcg Y29uZmlndXJlIHN0YW5kYWxvbmUuCittNF9kZWZpbmUoW3RvcGxldmVsX2RpcmVjdG9yeV0sIGVz eXNjbWQoW2VjaG8gLW4gJFRPUExFVkVMX0RJUkVDVE9SWV0pKQorVE9QTEVWRUxfRElSRUNUT1JZ PSJ0b3BsZXZlbF9kaXJlY3RvcnkiCiBBQ19TVUJTVChUT1BMRVZFTF9ESVJFQ1RPUlkpCi1BQ19D T05GSUdfRklMRVMoW0NvbmZpZ3VyYXRpb24uZ3lwaTpDb25maWd1cmF0aW9uLmd5cGkuaW5dKQog CitBQ19DT05GSUdfRklMRVMoW0NvbmZpZ3VyYXRpb24uZ3lwaTpDb25maWd1cmF0aW9uLmd5cGku aW5dKQogQUNfQ09ORklHX0NPTU1BTkRTKFtneXBdLCBbLi9ydW4tZ3lwXSkKIAogbTRfaW5jbHVk ZShbV2ViS2l0TWFjcm9zL1ByaW50QnVpbGRDb25maWd1cmF0aW9uLm00XSkKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvZ3RrL2d5cC9ydW4tZ3lwIGIvU291cmNlL1dlYktpdC9ndGsvZ3lwL3J1 bi1neXAKaW5kZXggZGM4MTE1NjFkN2U0NTMzOWZlY2U4ZDVlNGNhYjE3MWJiNGYzMDI5OC4uZWY4 NGQyZjJiZTMzOTYyZWI4MzcxOTE0YjYwZWJkNWViZGM2OTFiZiAxMDA3NTUKLS0tIGEvU291cmNl L1dlYktpdC9ndGsvZ3lwL3J1bi1neXAKKysrIGIvU291cmNlL1dlYktpdC9ndGsvZ3lwL3J1bi1n eXAKQEAgLTE5LDUgKzE5LDYgQEAgb3MuY2hkaXIodG9wbGV2ZWxfZGlyZWN0b3J5KQogc3lzLmV4 aXQoc3VicHJvY2Vzcy5jYWxsKFsnZ3lwJywKICAgICAgICAgICAgICAgICAgICAgICAgICAgJy0t ZGVwdGg9LicsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICctLWdlbmVyYXRvci1vdXRwdXQ9 JXMnICUgYnVpbGRfZGlyZWN0b3J5LAorICAgICAgICAgICAgICAgICAgICAgICAgICAnLUdhdXRv X3JlZ2VuZXJhdGlvbj0wJywKICAgICAgICAgICAgICAgICAgICAgICAgICAgJ1NvdXJjZS9XZWJD b3JlL1dlYkNvcmUuZ3lwL1dlYkNvcmVHVEsuZ3lwJywKICAgICAgICAgICAgICAgICAgICAgICAg ICAgJy1JJywgb3MucGF0aC5qb2luKGJ1aWxkX2RpcmVjdG9yeSwgJ0NvbmZpZ3VyYXRpb24uZ3lw aScpXSkpCg==