113348 2013-03-26 15:05:29 -0700 Web Inspector: [CodeMirror] CodeMirrorTextEditor.highlightRange has bugs 2013-03-27 01:15:06 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 lushnikov lushnikov apavlov keishi loislo pfeldman pmuellr vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 864039 0 lushnikov 2013-03-26 15:05:29 -0700 CodeMirrorTextEditor.highlightRange has bugs: - it doesn't highlight last letter of selection (because the it assumes the range to be exclusive on the right end) - it doesn't provide any way to set up some css class with border 864044 1 195172 lushnikov 2013-03-26 15:09:17 -0700 Created attachment 195172 Patch 864282 2 195172 webkit.review.bot 2013-03-27 01:15:03 -0700 Comment on attachment 195172 Patch Clearing flags on attachment: 195172 Committed r146972: <http://trac.webkit.org/changeset/146972> 864283 3 webkit.review.bot 2013-03-27 01:15:06 -0700 All reviewed patches have been landed. Closing bug. 195172 2013-03-26 15:09:17 -0700 2013-03-27 01:15:03 -0700 Patch bug-113348-20130327020459.patch text/plain 1933 lushnikov U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ2OTIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmI1NTAwODhiMzYzZDVi M2U2MjJmOTg0ZmRkYWRiZjg3ODBlMDYzZS4uYTI1ZWJiNjgzYTU4YTNmODEyMjVhNTAzYWRiY2Jk MWI1ZmQ5OTYzMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEzLTAzLTI2ICBBbmRy ZXkgTHVzaG5pa292ICA8bHVzaG5pa292QGNocm9taXVtLm9yZz4KKworICAgICAgICBXZWIgSW5z cGVjdG9yOiBbQ29kZU1pcnJvcl0gQ29kZU1pcnJvclRleHRFZGl0b3IuaGlnaGxpZ2h0UmFuZ2Ug aGFzIGJ1Z3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTExMzM0OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IE5vIG5ldyB0ZXN0cy4KKworICAgICAgICAtIEFwcGVuZCBhZGRpdGlvbmFsICI8Y2xhc3M+LXN0 YXJ0IiBjbGFzcyB0byB0aGUgZmlyc3QgaGlnaGxpZ2h0ZWQgc3BhbgorICAgICAgICBhbmQgIjxj bGFzcz4tZW5kIiBjbGFzcyB0byB0aGUgbGFzdCBoaWdobGlnaHRlZCBzcGFuIHRvIHByb3ZpZGUg YSB3YXkKKyAgICAgICAgdG8gc2V0IHVwIGEgY3NzIGNsYXNzZXMgd2l0aCBib3JkZXJzLgorICAg ICAgICAtIEluY3JlbWVudCBlbmQgY29sdW1uIG9mIHRoZSBtYXJrdXAgcmFuZ2UgdG8gc2ltdWxh dGUgaW5jbHVzaXZlIHJhbmdlLgorCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9Db2Rl TWlycm9yVGV4dEVkaXRvci5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5Db2RlTWlycm9yVGV4 dEVkaXRvci5wcm90b3R5cGUuaGlnaGxpZ2h0UmFuZ2UpOgorCiAyMDEzLTAzLTI2ICBKb2UgTWFz b24gIDxqbWFzb25AYmxhY2tiZXJyeS5jb20+CiAKICAgICAgICAgW0JsYWNrQmVycnldIEluIFJT U0ZpbHRlclN0cmVhbSwgZG9uJ3Qgc3dhbGxvdyBoZWFkZXJzIHdoZW4gdGhlcmUncyBubyBib2R5 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0NvZGVNaXJy b3JUZXh0RWRpdG9yLmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9Db2Rl TWlycm9yVGV4dEVkaXRvci5qcwppbmRleCA2OGUxMmE1Nzg3YWM0MTQ5MTViZjA0ZTcyOTNlOTgx ZTdkM2U0NzRlLi45NzM2ZThkYjJkYjhkMjIwZjI5ZmM3Mzc4OTg2YzFjYmFmNmNiZjU0IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0NvZGVNaXJyb3JUZXh0 RWRpdG9yLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvQ29kZU1p cnJvclRleHRFZGl0b3IuanMKQEAgLTE0Niw3ICsxNDYsMTIgQEAgV2ViSW5zcGVjdG9yLkNvZGVN aXJyb3JUZXh0RWRpdG9yLnByb3RvdHlwZSA9IHsKICAgICBoaWdobGlnaHRSYW5nZTogZnVuY3Rp b24ocmFuZ2UsIGNzc0NsYXNzKQogICAgIHsKICAgICAgICAgdmFyIHBvcyA9IHRoaXMuX3RvUG9z KHJhbmdlKTsKLSAgICAgICAgcmV0dXJuIHRoaXMuX2NvZGVNaXJyb3IubWFya1RleHQocG9zLnN0 YXJ0LCBwb3MuZW5kLCB7IGNsYXNzTmFtZTogY3NzQ2xhc3MgfSk7CisgICAgICAgICsrcG9zLmVu ZC5jaDsKKyAgICAgICAgcmV0dXJuIHRoaXMuX2NvZGVNaXJyb3IubWFya1RleHQocG9zLnN0YXJ0 LCBwb3MuZW5kLCB7CisgICAgICAgICAgICBjbGFzc05hbWU6IGNzc0NsYXNzLAorICAgICAgICAg ICAgc3RhcnRTdHlsZTogY3NzQ2xhc3MgKyAiLXN0YXJ0IiwKKyAgICAgICAgICAgIGVuZFN0eWxl OiBjc3NDbGFzcyArICItZW5kIgorICAgICAgICB9KTsKICAgICB9LAogCiAgICAgLyoqCg==