<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>113345</bug_id>
          
          <creation_ts>2013-03-26 14:47:16 -0700</creation_ts>
          <short_desc>View-source iframes are dangerous (and not very useful).</short_desc>
          <delta_ts>2013-04-18 16:04:32 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Thomas Sepez">tsepez</reporter>
          <assigned_to name="Thomas Sepez">tsepez</assigned_to>
          <cc>abarth</cc>
    
    <cc>benjamin</cc>
    
    <cc>cevans</cc>
    
    <cc>cmarcelo</cc>
    
    <cc>esprehn+autocc</cc>
    
    <cc>esprehn</cc>
    
    <cc>jschuh</cc>
    
    <cc>ojan.autocc</cc>
    
    <cc>timothy</cc>
    
    <cc>tsepez</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>864023</commentid>
    <comment_count>0</comment_count>
    <who name="Thomas Sepez">tsepez</who>
    <bug_when>2013-03-26 14:47:16 -0700</bug_when>
    <thetext>Upstreamed from https://code.google.com/p/chromium/issues/detail?id=196636.

Memorable comments from that bug:
Collin: &quot;View-source iframes seem dangerous in general; create a &quot;captcha&quot; that steals CSRF tokens, for example.&quot;
Justin: &quot;We specifically disallow navigation to view-source URLs because we consider them unsafe. So allowing them via an iframe attribute is just a short trip to crazytown, population Chrome.&quot;
Adam: &quot;It&apos;s non-standard and not supported by other browsers, AFAIK.&quot;

Platforms should have the option of excluding them, if they so desire.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>866358</commentid>
    <comment_count>1</comment_count>
      <attachid>195795</attachid>
    <who name="Thomas Sepez">tsepez</who>
    <bug_when>2013-03-29 14:05:10 -0700</bug_when>
    <thetext>Created attachment 195795
Patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>866361</commentid>
    <comment_count>2</comment_count>
      <attachid>195797</attachid>
    <who name="Thomas Sepez">tsepez</who>
    <bug_when>2013-03-29 14:07:55 -0700</bug_when>
    <thetext>Created attachment 195797
Patch, fix blank line.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>866627</commentid>
    <comment_count>3</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2013-03-30 10:51:58 -0700</bug_when>
    <thetext>We might run into compat trouble, but I doubt it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>866641</commentid>
    <comment_count>4</comment_count>
      <attachid>195797</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2013-03-30 11:21:13 -0700</bug_when>
    <thetext>Comment on attachment 195797
Patch, fix blank line.

Clearing flags on attachment: 195797

Committed r147280: &lt;http://trac.webkit.org/changeset/147280&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>866642</commentid>
    <comment_count>5</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2013-03-30 11:21:16 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>878104</commentid>
    <comment_count>6</comment_count>
    <who name="Elliott Sprehn">esprehn</who>
    <bug_when>2013-04-18 15:06:54 -0700</bug_when>
    <thetext>How do we know this didn&apos;t break real pages using viewsource? It seems like we should have restricted this to same origin iframes (and data urls). It&apos;s a pretty useful feature.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>878105</commentid>
    <comment_count>7</comment_count>
    <who name="Chris Evans">cevans</who>
    <bug_when>2013-04-18 15:11:19 -0700</bug_when>
    <thetext>We don&apos;t believe it&apos;s used by pages, because we believe it&apos;s not supported by other browsers (IE, FireFox)?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>878111</commentid>
    <comment_count>8</comment_count>
    <who name="Elliott Sprehn">esprehn</who>
    <bug_when>2013-04-18 15:18:09 -0700</bug_when>
    <thetext>(In reply to comment #7)
&gt; We don&apos;t believe it&apos;s used by pages, because we believe it&apos;s not supported by other browsers (IE, FireFox)?

That logic has never been true. :) Lots of Webkit only features appear in pages, ex. custom scrollbars. 

This feature _was_ useful for showing the contents of a contenteditable area in a syntax highlighted way, or showing the source of a blog post. Ex. your blog can show the post HTML to you.

I&apos;d prefer if we could histogram this first, or restrict it to same origin iframes.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>878129</commentid>
    <comment_count>9</comment_count>
    <who name="Elliott Sprehn">esprehn</who>
    <bug_when>2013-04-18 16:04:32 -0700</bug_when>
    <thetext>I discussed with ojan and adamk and they both think no one uses this feature, so lets let it die! :)</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>195795</attachid>
            <date>2013-03-29 14:05:10 -0700</date>
            <delta_ts>2013-03-29 14:07:55 -0700</delta_ts>
            <desc>Patch.</desc>
            <filename>patch_113345.txt</filename>
            <type>text/plain</type>
            <size>6162</size>
            <attacher name="Thomas Sepez">tsepez</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh
bmdlTG9nCShyZXZpc2lvbiAxNDcyNDkpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu
ZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEzLTAzLTI5ICBUb20gU2VwZXogIDx0c2VwZXpA
Y2hyb21pdW0ub3JnPgorCisgICAgICAgIFZpZXctc291cmNlIGlmcmFtZXMgYXJlIGRhbmdlcm91
cyAoYW5kIG5vdCB2ZXJ5IHVzZWZ1bCkuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn
L3Nob3dfYnVnLmNnaT9pZD0xMTMzNDUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P
UFMhKS4KKworICAgICAgICAqIHd0Zi9GZWF0dXJlRGVmaW5lcy5oOgorICAgICAgICBEZWZhdWx0
IGRlZmluaXRpb24gb2YgRU5BQkxFX1ZJRVdTT1VSQ0VfQVRUUklCVVRFIGlzIGVuYWJsZWQuCisK
IDIwMTMtMDMtMjcgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+CiAKICAg
ICAgICAgU2V0IFdURl9BUk1fQVJDSF9WRVJTSU9OIHRvIGNvcnJlY3QgdmFsdWUgd2hlbiB1c2Vk
IHdpdGggTVNWQwpJbmRleDogU291cmNlL1dURi93dGYvRmVhdHVyZURlZmluZXMuaAo9PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09Ci0tLSBTb3VyY2UvV1RGL3d0Zi9GZWF0dXJlRGVmaW5lcy5oCShyZXZpc2lvbiAxNDcyMzYp
CisrKyBTb3VyY2UvV1RGL3d0Zi9GZWF0dXJlRGVmaW5lcy5oCSh3b3JraW5nIGNvcHkpCkBAIC04
NDMsNiArODQzLDEwIEBACiAjZGVmaW5lIEVOQUJMRV9WSUVXUE9SVCAwCiAjZW5kaWYKIAorI2lm
ICFkZWZpbmVkKEVOQUJMRV9WSUVXU09VUkNFX0FUVFJJQlVURSkKKyNkZWZpbmUgRU5BQkxFX1ZJ
RVdTT1VSQ0VfQVRUUklCVVRFIDEKKyNlbmRpZgorCiAjaWYgIWRlZmluZWQoRU5BQkxFX1ZJRVdf
TU9ERV9DU1NfTUVESUEpCiAjZGVmaW5lIEVOQUJMRV9WSUVXX01PREVfQ1NTX01FRElBIDEKICNl
bmRpZgpJbmRleDogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj
ZS9XZWJDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTQ3MjQ5KQorKysgU291cmNlL1dlYkNvcmUv
Q2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTMtMDMtMjkgIFRv
bSBTZXBleiAgPHRzZXBlekBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgVmlldy1zb3VyY2UgaWZy
YW1lcyBhcmUgZGFuZ2Vyb3VzIChhbmQgbm90IHZlcnkgdXNlZnVsKS4KKyAgICAgICAgaHR0cHM6
Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMzM0NQorCisgICAgICAgIFJldmll
d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogaHRtbC9IVE1MRnJhbWVFbGVtZW50
QmFzZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MRnJhbWVFbGVtZW50QmFzZTo6cGFyc2VB
dHRyaWJ1dGUpOgorICAgICAgICBDb25kaXRpb25hbGl6ZSB2aWV3c291cmNlIGF0dHJpYnV0ZSBv
biBFTkFCTEUoVklFV1NPVVJDRV9BVFRSSUJVVEUpLgorCiAyMDEzLTAzLTI5ICBIYW5zIE11bGxl
ciAgPGhtdWxsZXJAYWRvYmUuY29tPgogCiAgICAgICAgIFtDU1MgRXhjbHVzaW9uc10gSW5jb3Jy
ZWN0IG1hcmdpbiBjb3JuZXIgcmFkaWkgZm9ybXVsYQpJbmRleDogU291cmNlL1dlYkNvcmUvaHRt
bC9IVE1MRnJhbWVFbGVtZW50QmFzZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUv
aHRtbC9IVE1MRnJhbWVFbGVtZW50QmFzZS5jcHAJKHJldmlzaW9uIDE0NzIzNikKKysrIFNvdXJj
ZS9XZWJDb3JlL2h0bWwvSFRNTEZyYW1lRWxlbWVudEJhc2UuY3BwCSh3b3JraW5nIGNvcHkpCkBA
IC0xMTgsMTAgKzExOCwxMiBAQCB2b2lkIEhUTUxGcmFtZUVsZW1lbnRCYXNlOjpwYXJzZUF0dHJp
YnV0CiAgICAgICAgIGVsc2UgaWYgKGVxdWFsSWdub3JpbmdDYXNlKHZhbHVlLCAibm8iKSkKICAg
ICAgICAgICAgIG1fc2Nyb2xsaW5nID0gU2Nyb2xsYmFyQWx3YXlzT2ZmOwogICAgICAgICAvLyBG
SVhNRTogSWYgd2UgYXJlIGFscmVhZHkgYXR0YWNoZWQsIHRoaXMgaGFzIG5vIGVmZmVjdC4KKyNp
ZiBFTkFCTEUoVklFV1NPVVJDRV9BVFRSSUJVVEUpCiAgICAgfSBlbHNlIGlmIChuYW1lID09IHZp
ZXdzb3VyY2VBdHRyKSB7CiAgICAgICAgIG1fdmlld1NvdXJjZSA9ICF2YWx1ZS5pc051bGwoKTsK
ICAgICAgICAgaWYgKGNvbnRlbnRGcmFtZSgpKQogICAgICAgICAgICAgY29udGVudEZyYW1lKCkt
PnNldEluVmlld1NvdXJjZU1vZGUodmlld1NvdXJjZU1vZGUoKSk7CisjZW5kaWYKICAgICB9IGVs
c2UgaWYgKG5hbWUgPT0gb25iZWZvcmVsb2FkQXR0cikKICAgICAgICAgc2V0QXR0cmlidXRlRXZl
bnRMaXN0ZW5lcihldmVudE5hbWVzKCkuYmVmb3JlbG9hZEV2ZW50LCBjcmVhdGVBdHRyaWJ1dGVF
dmVudExpc3RlbmVyKHRoaXMsIG5hbWUsIHZhbHVlKSk7CiAgICAgZWxzZSBpZiAobmFtZSA9PSBv
bmJlZm9yZXVubG9hZEF0dHIpIHsKSW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdl
TG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZp
c2lvbiAxNDcyNDkpCisrKyBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwkod29ya2lu
ZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEzLTAzLTI5ICBUb20gU2VwZXogIDx0c2VwZXpA
Y2hyb21pdW0ub3JnPgorCisgICAgICAgIFZpZXctc291cmNlIGlmcmFtZXMgYXJlIGRhbmdlcm91
cyAoYW5kIG5vdCB2ZXJ5IHVzZWZ1bCkuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn
L3Nob3dfYnVnLmNnaT9pZD0xMTMzNDUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P
UFMhKS4KKworICAgICAgICAqIGZlYXR1cmVzLmd5cGk6CisgICAgICAgIERpc2FibGUgVklFV1NP
VVJDRV9BVFRSSUJVVEUgZm9yIGNocm9taXVtLgorCiAyMDEzLTAzLTI5ICBKb3NodWEgQmVsbCAg
PGpzYmVsbEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgSW5kZXhlZERCOiBCaW5kIGxpZmV0aW1l
IG9mIGluLW1lbW9yeSBiYWNraW5nIHN0b3JlcyB0byBJREJGYWN0b3J5IGJhY2tlbmQKSW5kZXg6
IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vZmVhdHVyZXMuZ3lwaQo9PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy
Y2UvV2ViS2l0L2Nocm9taXVtL2ZlYXR1cmVzLmd5cGkJKHJldmlzaW9uIDE0NzIzNikKKysrIFNv
dXJjZS9XZWJLaXQvY2hyb21pdW0vZmVhdHVyZXMuZ3lwaQkod29ya2luZyBjb3B5KQpAQCAtMTMy
LDYgKzEzMiw3IEBACiAgICAgICAnRU5BQkxFX1ZJREVPPTEnLAogICAgICAgJ0VOQUJMRV9WSURF
T19UUkFDSz0xJywKICAgICAgICdFTkFCTEVfVklFV1BPUlQ9MScsCisgICAgICAnRU5BQkxFX1ZJ
RVdTT1VSQ0VfQVRUUklCVVRFPTAnLAogICAgICAgJ0VOQUJMRV9WSUVXX01PREVfQ1NTX01FRElB
PTEnLAogICAgICAgJ0VOQUJMRV9XRUJHTD0xJywKICAgICAgICdFTkFCTEVfV0VCX1NPQ0tFVFM9
MScsCkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVz
dHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAxNDcyNDkpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJ
KHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAxMy0wMy0yOSAgVG9tIFNlcGV6ICA8
dHNlcGV6QGNocm9taXVtLm9yZz4KKworICAgICAgICBWaWV3LXNvdXJjZSBpZnJhbWVzIGFyZSBk
YW5nZXJvdXMgKGFuZCBub3QgdmVyeSB1c2VmdWwpLgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi
a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEzMzQ1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C
T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9jaHJvbWl1bS9UZXN0RXhwZWN0YXRp
b25zOgorICAgICAgICBVcGRhdGUgZXhwZWN0YXRpb25zIG5vdyB0aGF0IGNocm9taXVtIGV4Y2x1
ZGVzIGlmcmFtZSdzIHZpZXdzb3VyY2UgYXR0cmlidXRlLgorICAgICAgICAKIDIwMTMtMDMtMjkg
IEhhbnMgTXVsbGVyICA8aG11bGxlckBhZG9iZS5jb20+CiAKICAgICAgICAgW0NTUyBFeGNsdXNp
b25zXSBJbmNvcnJlY3QgbWFyZ2luIGNvcm5lciByYWRpaSBmb3JtdWxhCkluZGV4OiBMYXlvdXRU
ZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS9UZXN0RXhwZWN0YXRpb25zCj09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExh
eW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL1Rlc3RFeHBlY3RhdGlvbnMJKHJldmlzaW9uIDE0
NzIzNikKKysrIExheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL1Rlc3RFeHBlY3RhdGlvbnMJ
KHdvcmtpbmcgY29weSkKQEAgLTkzNSw2ICs5MzUsMTcgQEAgZmFzdC9kb20vdGltZXItdGhyb3R0
bGluZy1oaWRkZW4tcGFnZS5odAogIyBDaHJvbWl1bSBkaXNhYmxlZCBNQVRITUwKIGNyYnVnLmNv
bS8yMjU1NCBtYXRobWwgWyBTa2lwIF0KIAorIyBDaHJvbWl1bSBkaXNhYmxlZCBpZnJhbWUgdmll
d3NvdXJjZSBhdHRyaWJ1dGUuCitmYXN0L2ZyYW1lcy92aWV3c291cmNlLWF0dHJpYnV0ZS5odG1s
IFsgV29udEZpeCBdCitmYXN0L2ZyYW1lcy92aWV3c291cmNlLWVtcHR5LWF0dHJpYnV0ZS12YWx1
ZS5odG1sIFsgV29udEZpeCBdCitmYXN0L2ZyYW1lcy92aWV3c291cmNlLWxpbmVicmVhay5odG1s
IFsgV29udEZpeCBdCitmYXN0L2ZyYW1lcy92aWV3c291cmNlLWxpbmstb24taHJlZi12YWx1ZS5o
dG1sIFsgV29udEZpeCBdCitmYXN0L2ZyYW1lcy92aWV3c291cmNlLW9uLWltYWdlLWZpbGUuaHRt
bCBbIFdvbnRGaXggXQorZmFzdC9mcmFtZXMvdmlld3NvdXJjZS1wbGFpbi10ZXh0LXRhZ3MuaHRt
bCBbIFdvbnRGaXggXQorZmFzdC9mcmFtZXMvdmlld3NvdXJjZS14bWwuaHRtbCBbIFdvbnRGaXgg
XQoraHR0cC90ZXN0cy9zZWN1cml0eS92aWV3LXNvdXJjZS1uby1qYXZhc2NyaXB0LXVybC5odG1s
IFsgV29udEZpeCBdCitodHRwL3Rlc3RzL3NlY3VyaXR5L3ZpZXctc291cmNlLW5vLXJlZnJlc2gu
aHRtbCBbIFdvbnRGaXggXQorCiAjIElOUFVUX1RZUEVfREFURVRJTUVfSU5DT01QTEVURSBpcyBk
aXNhYmxlZCBhY3Jvc3MgQ2hyb21pdW0gdW50aWwgYSBiZXR0ZXIgQW5kcm9pZCBVSSBpcyB3b3Jr
ZWQgb3V0LiAgU2VlIGNyYnVnLmNvbS8xNjQ1NjEuCiB3ZWJraXQub3JnL2IvMTA5MjcyIGZhc3Qv
Zm9ybXMvZGF0ZXRpbWUgWyBTa2lwIF0KIHdlYmtpdC5vcmcvYi8xMDkyNzIgZmFzdC9mb3Jtcy9k
YXRldGltZS1tdWx0aXBsZS1maWVsZHMgWyBTa2lwIF0KQEAgLTk1Nyw2ICs5NjgsNyBAQCB3ZWJr
aXQub3JnL2IvMTEyOTIzIHBsYXRmb3JtL2Nocm9taXVtL2ZhCiAjd2Via2l0Lm9yZy9iLzEwOTUy
OCBwbGF0Zm9ybS9jaHJvbWl1bS9mYXN0L2Zvcm1zL3N1Z2dlc3Rpb24tcGlja2VyL21vbnRoLXN1
Z2dlc3Rpb24tcGlja2VyLWFwcGVhcmFuY2Utd2l0aC1zY3JvbGwtYmFyLmh0bWwgWyBTa2lwIF0K
ICN3ZWJraXQub3JnL2IvMTA5NTI4IHBsYXRmb3JtL2Nocm9taXVtL2Zhc3QvZm9ybXMvc3VnZ2Vz
dGlvbi1waWNrZXIvd2Vlay1zdWdnZXN0aW9uLXBpY2tlci1hcHBlYXJhbmNlLXdpdGgtc2Nyb2xs
LWJhci5odG1sIFsgU2tpcCBdCiAKKwogIyAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQogIyBURVNUUyBUTyBGSVgKICMgLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0K
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>195797</attachid>
            <date>2013-03-29 14:07:55 -0700</date>
            <delta_ts>2013-03-30 11:21:13 -0700</delta_ts>
            <desc>Patch, fix blank line.</desc>
            <filename>patch_113345.txt</filename>
            <type>text/plain</type>
            <size>5676</size>
            <attacher name="Thomas Sepez">tsepez</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh
bmdlTG9nCShyZXZpc2lvbiAxNDcyNDkpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu
ZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEzLTAzLTI5ICBUb20gU2VwZXogIDx0c2VwZXpA
Y2hyb21pdW0ub3JnPgorCisgICAgICAgIFZpZXctc291cmNlIGlmcmFtZXMgYXJlIGRhbmdlcm91
cyAoYW5kIG5vdCB2ZXJ5IHVzZWZ1bCkuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn
L3Nob3dfYnVnLmNnaT9pZD0xMTMzNDUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P
UFMhKS4KKworICAgICAgICAqIHd0Zi9GZWF0dXJlRGVmaW5lcy5oOgorICAgICAgICBEZWZhdWx0
IGRlZmluaXRpb24gb2YgRU5BQkxFX1ZJRVdTT1VSQ0VfQVRUUklCVVRFIGlzIGVuYWJsZWQuCisK
IDIwMTMtMDMtMjcgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+CiAKICAg
ICAgICAgU2V0IFdURl9BUk1fQVJDSF9WRVJTSU9OIHRvIGNvcnJlY3QgdmFsdWUgd2hlbiB1c2Vk
IHdpdGggTVNWQwpJbmRleDogU291cmNlL1dURi93dGYvRmVhdHVyZURlZmluZXMuaAo9PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09Ci0tLSBTb3VyY2UvV1RGL3d0Zi9GZWF0dXJlRGVmaW5lcy5oCShyZXZpc2lvbiAxNDcyMzYp
CisrKyBTb3VyY2UvV1RGL3d0Zi9GZWF0dXJlRGVmaW5lcy5oCSh3b3JraW5nIGNvcHkpCkBAIC04
NDMsNiArODQzLDEwIEBACiAjZGVmaW5lIEVOQUJMRV9WSUVXUE9SVCAwCiAjZW5kaWYKIAorI2lm
ICFkZWZpbmVkKEVOQUJMRV9WSUVXU09VUkNFX0FUVFJJQlVURSkKKyNkZWZpbmUgRU5BQkxFX1ZJ
RVdTT1VSQ0VfQVRUUklCVVRFIDEKKyNlbmRpZgorCiAjaWYgIWRlZmluZWQoRU5BQkxFX1ZJRVdf
TU9ERV9DU1NfTUVESUEpCiAjZGVmaW5lIEVOQUJMRV9WSUVXX01PREVfQ1NTX01FRElBIDEKICNl
bmRpZgpJbmRleDogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj
ZS9XZWJDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTQ3MjQ5KQorKysgU291cmNlL1dlYkNvcmUv
Q2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTMtMDMtMjkgIFRv
bSBTZXBleiAgPHRzZXBlekBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgVmlldy1zb3VyY2UgaWZy
YW1lcyBhcmUgZGFuZ2Vyb3VzIChhbmQgbm90IHZlcnkgdXNlZnVsKS4KKyAgICAgICAgaHR0cHM6
Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMzM0NQorCisgICAgICAgIFJldmll
d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogaHRtbC9IVE1MRnJhbWVFbGVtZW50
QmFzZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MRnJhbWVFbGVtZW50QmFzZTo6cGFyc2VB
dHRyaWJ1dGUpOgorICAgICAgICBDb25kaXRpb25hbGl6ZSB2aWV3c291cmNlIGF0dHJpYnV0ZSBv
biBFTkFCTEUoVklFV1NPVVJDRV9BVFRSSUJVVEUpLgorCiAyMDEzLTAzLTI5ICBIYW5zIE11bGxl
ciAgPGhtdWxsZXJAYWRvYmUuY29tPgogCiAgICAgICAgIFtDU1MgRXhjbHVzaW9uc10gSW5jb3Jy
ZWN0IG1hcmdpbiBjb3JuZXIgcmFkaWkgZm9ybXVsYQpJbmRleDogU291cmNlL1dlYkNvcmUvaHRt
bC9IVE1MRnJhbWVFbGVtZW50QmFzZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUv
aHRtbC9IVE1MRnJhbWVFbGVtZW50QmFzZS5jcHAJKHJldmlzaW9uIDE0NzIzNikKKysrIFNvdXJj
ZS9XZWJDb3JlL2h0bWwvSFRNTEZyYW1lRWxlbWVudEJhc2UuY3BwCSh3b3JraW5nIGNvcHkpCkBA
IC0xMTgsMTAgKzExOCwxMiBAQCB2b2lkIEhUTUxGcmFtZUVsZW1lbnRCYXNlOjpwYXJzZUF0dHJp
YnV0CiAgICAgICAgIGVsc2UgaWYgKGVxdWFsSWdub3JpbmdDYXNlKHZhbHVlLCAibm8iKSkKICAg
ICAgICAgICAgIG1fc2Nyb2xsaW5nID0gU2Nyb2xsYmFyQWx3YXlzT2ZmOwogICAgICAgICAvLyBG
SVhNRTogSWYgd2UgYXJlIGFscmVhZHkgYXR0YWNoZWQsIHRoaXMgaGFzIG5vIGVmZmVjdC4KKyNp
ZiBFTkFCTEUoVklFV1NPVVJDRV9BVFRSSUJVVEUpCiAgICAgfSBlbHNlIGlmIChuYW1lID09IHZp
ZXdzb3VyY2VBdHRyKSB7CiAgICAgICAgIG1fdmlld1NvdXJjZSA9ICF2YWx1ZS5pc051bGwoKTsK
ICAgICAgICAgaWYgKGNvbnRlbnRGcmFtZSgpKQogICAgICAgICAgICAgY29udGVudEZyYW1lKCkt
PnNldEluVmlld1NvdXJjZU1vZGUodmlld1NvdXJjZU1vZGUoKSk7CisjZW5kaWYKICAgICB9IGVs
c2UgaWYgKG5hbWUgPT0gb25iZWZvcmVsb2FkQXR0cikKICAgICAgICAgc2V0QXR0cmlidXRlRXZl
bnRMaXN0ZW5lcihldmVudE5hbWVzKCkuYmVmb3JlbG9hZEV2ZW50LCBjcmVhdGVBdHRyaWJ1dGVF
dmVudExpc3RlbmVyKHRoaXMsIG5hbWUsIHZhbHVlKSk7CiAgICAgZWxzZSBpZiAobmFtZSA9PSBv
bmJlZm9yZXVubG9hZEF0dHIpIHsKSW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdl
TG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZp
c2lvbiAxNDcyNDkpCisrKyBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwkod29ya2lu
ZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEzLTAzLTI5ICBUb20gU2VwZXogIDx0c2VwZXpA
Y2hyb21pdW0ub3JnPgorCisgICAgICAgIFZpZXctc291cmNlIGlmcmFtZXMgYXJlIGRhbmdlcm91
cyAoYW5kIG5vdCB2ZXJ5IHVzZWZ1bCkuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn
L3Nob3dfYnVnLmNnaT9pZD0xMTMzNDUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P
UFMhKS4KKworICAgICAgICAqIGZlYXR1cmVzLmd5cGk6CisgICAgICAgIERpc2FibGUgVklFV1NP
VVJDRV9BVFRSSUJVVEUgZm9yIGNocm9taXVtLgorCiAyMDEzLTAzLTI5ICBKb3NodWEgQmVsbCAg
PGpzYmVsbEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgSW5kZXhlZERCOiBCaW5kIGxpZmV0aW1l
IG9mIGluLW1lbW9yeSBiYWNraW5nIHN0b3JlcyB0byBJREJGYWN0b3J5IGJhY2tlbmQKSW5kZXg6
IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vZmVhdHVyZXMuZ3lwaQo9PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy
Y2UvV2ViS2l0L2Nocm9taXVtL2ZlYXR1cmVzLmd5cGkJKHJldmlzaW9uIDE0NzIzNikKKysrIFNv
dXJjZS9XZWJLaXQvY2hyb21pdW0vZmVhdHVyZXMuZ3lwaQkod29ya2luZyBjb3B5KQpAQCAtMTMy
LDYgKzEzMiw3IEBACiAgICAgICAnRU5BQkxFX1ZJREVPPTEnLAogICAgICAgJ0VOQUJMRV9WSURF
T19UUkFDSz0xJywKICAgICAgICdFTkFCTEVfVklFV1BPUlQ9MScsCisgICAgICAnRU5BQkxFX1ZJ
RVdTT1VSQ0VfQVRUUklCVVRFPTAnLAogICAgICAgJ0VOQUJMRV9WSUVXX01PREVfQ1NTX01FRElB
PTEnLAogICAgICAgJ0VOQUJMRV9XRUJHTD0xJywKICAgICAgICdFTkFCTEVfV0VCX1NPQ0tFVFM9
MScsCkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVz
dHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAxNDcyNDkpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJ
KHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAxMy0wMy0yOSAgVG9tIFNlcGV6ICA8
dHNlcGV6QGNocm9taXVtLm9yZz4KKworICAgICAgICBWaWV3LXNvdXJjZSBpZnJhbWVzIGFyZSBk
YW5nZXJvdXMgKGFuZCBub3QgdmVyeSB1c2VmdWwpLgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi
a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEzMzQ1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C
T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9jaHJvbWl1bS9UZXN0RXhwZWN0YXRp
b25zOgorICAgICAgICBVcGRhdGUgZXhwZWN0YXRpb25zIG5vdyB0aGF0IGNocm9taXVtIGV4Y2x1
ZGVzIGlmcmFtZSdzIHZpZXdzb3VyY2UgYXR0cmlidXRlLgorICAgICAgICAKIDIwMTMtMDMtMjkg
IEhhbnMgTXVsbGVyICA8aG11bGxlckBhZG9iZS5jb20+CiAKICAgICAgICAgW0NTUyBFeGNsdXNp
b25zXSBJbmNvcnJlY3QgbWFyZ2luIGNvcm5lciByYWRpaSBmb3JtdWxhCkluZGV4OiBMYXlvdXRU
ZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS9UZXN0RXhwZWN0YXRpb25zCj09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExh
eW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL1Rlc3RFeHBlY3RhdGlvbnMJKHJldmlzaW9uIDE0
NzIzNikKKysrIExheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL1Rlc3RFeHBlY3RhdGlvbnMJ
KHdvcmtpbmcgY29weSkKQEAgLTkzNSw2ICs5MzUsMTcgQEAgZmFzdC9kb20vdGltZXItdGhyb3R0
bGluZy1oaWRkZW4tcGFnZS5odAogIyBDaHJvbWl1bSBkaXNhYmxlZCBNQVRITUwKIGNyYnVnLmNv
bS8yMjU1NCBtYXRobWwgWyBTa2lwIF0KIAorIyBDaHJvbWl1bSBkaXNhYmxlZCBpZnJhbWUgdmll
d3NvdXJjZSBhdHRyaWJ1dGUuCitmYXN0L2ZyYW1lcy92aWV3c291cmNlLWF0dHJpYnV0ZS5odG1s
IFsgV29udEZpeCBdCitmYXN0L2ZyYW1lcy92aWV3c291cmNlLWVtcHR5LWF0dHJpYnV0ZS12YWx1
ZS5odG1sIFsgV29udEZpeCBdCitmYXN0L2ZyYW1lcy92aWV3c291cmNlLWxpbmVicmVhay5odG1s
IFsgV29udEZpeCBdCitmYXN0L2ZyYW1lcy92aWV3c291cmNlLWxpbmstb24taHJlZi12YWx1ZS5o
dG1sIFsgV29udEZpeCBdCitmYXN0L2ZyYW1lcy92aWV3c291cmNlLW9uLWltYWdlLWZpbGUuaHRt
bCBbIFdvbnRGaXggXQorZmFzdC9mcmFtZXMvdmlld3NvdXJjZS1wbGFpbi10ZXh0LXRhZ3MuaHRt
bCBbIFdvbnRGaXggXQorZmFzdC9mcmFtZXMvdmlld3NvdXJjZS14bWwuaHRtbCBbIFdvbnRGaXgg
XQoraHR0cC90ZXN0cy9zZWN1cml0eS92aWV3LXNvdXJjZS1uby1qYXZhc2NyaXB0LXVybC5odG1s
IFsgV29udEZpeCBdCitodHRwL3Rlc3RzL3NlY3VyaXR5L3ZpZXctc291cmNlLW5vLXJlZnJlc2gu
aHRtbCBbIFdvbnRGaXggXQorCiAjIElOUFVUX1RZUEVfREFURVRJTUVfSU5DT01QTEVURSBpcyBk
aXNhYmxlZCBhY3Jvc3MgQ2hyb21pdW0gdW50aWwgYSBiZXR0ZXIgQW5kcm9pZCBVSSBpcyB3b3Jr
ZWQgb3V0LiAgU2VlIGNyYnVnLmNvbS8xNjQ1NjEuCiB3ZWJraXQub3JnL2IvMTA5MjcyIGZhc3Qv
Zm9ybXMvZGF0ZXRpbWUgWyBTa2lwIF0KIHdlYmtpdC5vcmcvYi8xMDkyNzIgZmFzdC9mb3Jtcy9k
YXRldGltZS1tdWx0aXBsZS1maWVsZHMgWyBTa2lwIF0K
</data>

          </attachment>
      

    </bug>

</bugzilla>