113343 2013-03-26 14:41:50 -0700 border-radius clipping a canvas does not always clip 2013-05-02 16:32:22 -0700 1 1 1 Unclassified WebKit Canvas 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rafael.lobo a.renevier a.renevier commit-queue esprehn+autocc glenn hugo.lima jesus luis.gabriel noam simon.fraser oldest_to_newest 864015 0 195167 rafael.lobo 2013-03-26 14:41:50 -0700 Created attachment 195167 test case, second render done after a timeout does not clip. When we paint the canvas area, if there's an element as parent that overflows and clips using a border-radius, then the clip does not respect the radius on following render calls. I have a test case that shows this issue on Chrome, Qt and Nix. It may be an issue in other ports. 864024 1 simon.fraser 2013-03-26 14:47:40 -0700 Possibly related to the fact that composited elements don't respect border-radius clipping. 864097 2 rafael.lobo 2013-03-26 16:42:14 -0700 If I change the test to do the following, then the second render clips as expected: render = function() { ctx.fillStyle = "#ff0000"; ctx.fillRect(0, 0, 400, 300); } render2 = function() { render(); document.getElementById("box").style.overflow = "hidden"; } render(); setTimeout("render2()", 2000); 864098 3 rafael.lobo 2013-03-26 16:43:38 -0700 A small correction: it only properly clips on the second render if the box initially not set "overflow: hidden". It looks like the clip only happens in the first render after "overflow: hidden" is set. 883618 4 200260 a.renevier 2013-05-01 17:28:49 -0700 Created attachment 200260 patch proposal 884010 5 200260 commit-queue 2013-05-02 16:32:20 -0700 Comment on attachment 200260 patch proposal Clearing flags on attachment: 200260 Committed r149504: <http://trac.webkit.org/changeset/149504> 884011 6 commit-queue 2013-05-02 16:32:22 -0700 All reviewed patches have been landed. Closing bug. 195167 2013-03-26 14:41:50 -0700 2013-03-26 14:41:50 -0700 test case, second render done after a timeout does not clip. canvas-bug.html text/html 552 rafael.lobo PGh0bWw+CjxoZWFkPjx0aXRsZT5idWcgb24gb3ZlcmZsb3c8L3RpdGxlPjwvaGVhZD4KPGJvZHk+ Cgo8ZGl2IGlkPSJib3giIHN0eWxlPSJwb3NpdGlvbjogYWJzb2x1dGU7IGRpc3BsYXk6IGJsb2Nr OyB3aWR0aDogMzAwcHg7IGhlaWdodDogMjAwcHg7IHRvcDogMDsgbGVmdDogMDsgYm9yZGVyLXJh ZGl1czogNDBweDsgb3ZlcmZsb3c6IGhpZGRlbjsiPgo8Y2FudmFzIGlkPSJjbnYiIHdpZHRoPSI1 MDBweCIgaGVpZ2h0PSI4MDBweCI+CjwvY2FudmFzPgo8L2Rpdj4KCjxzY3JpcHQ+CnZhciBjbnYg PSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiY252Iik7CnZhciBib3ggPSBkb2N1bWVudC5nZXRF bGVtZW50QnlJZCgiYm94Iik7CnZhciBjdHggPSBjbnYuZ2V0Q29udGV4dCgiMmQiKTsKCnJlbmRl ciA9IGZ1bmN0aW9uKCkgewogICAgY3R4LmZpbGxTdHlsZSA9ICIjZmYwMDAwIjsKICAgIGN0eC5m aWxsUmVjdCgwLCAwLCA0MDAsIDMwMCk7Cn0KCnJlbmRlcigpOwpzZXRUaW1lb3V0KCJyZW5kZXIo KSIsIDIwMDApOwo8L3NjcmlwdD4KCgo8L2JvZHk+CjwvaHRtbD4K 200260 2013-05-01 17:28:49 -0700 2013-05-02 16:32:20 -0700 patch proposal bug-113343-20130501172800.patch text/plain 5269 a.renevier U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ5NDM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2I2NThmMWVjMDcxMmMy MjBkMGMxZjg4MTExZWFlMDMzZmJjYzdmYS4uOGE3NjYyY2JmMzJiNTAzMzdlN2I0ZDI3Nzg2MmRh MmQ5ZWIxY2YxNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI0IEBACiAyMDEzLTA1LTAxICBBcm5h dWQgUmVuZXZpZXIgIDxhLnJlbmV2aWVyQHNpc2Euc2Ftc3VuZy5jb20+CiAKKyAgICAgICAgYm9y ZGVyLXJhZGl1cyBjbGlwcGluZyBhIGNhbnZhcyBkb2VzIG5vdCBhbHdheXMgY2xpcAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEzMzQzCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgY2xpcFRvUmVjdCBtZXRo b2QgY2xpcCBjb250ZXh0IHRvIGNsaXBSZWN0LCBhbmQgdGhlbiBjbGlwIHRvIHJvdW5kZWQKKyAg ICAgICAgcmVjdCBpZiBjbGlwUmVjdCBoYXMgYSByYWRpdXMuIEJ1dCBjdXJyZW50bHksIGNsaXBU b1JlY3QgZXhpdCBlYXJseSBpZgorICAgICAgICBjbGlwVG9SZWN0IGlzIGVxdWFsIHRvIHBhaW50 RGlydHlSZWN0LgorCisgICAgICAgIFRoaXMgcGF0Y2ggYWxsb3dzIGNsaXBwaW5nIHRvIHJvdW5k ZWQgY29ybmVyIGV2ZXIgaWYgY2xpcFRvUmVjdCBpcworICAgICAgICBlcXVhbCB0byBwYWludERp cnR5UmVjdC4KKworICAgICAgICBUZXN0OiBmYXN0L292ZXJmbG93L2JvcmRlci1yYWRpdXMtY2xp cHBpbmctMi5odG1sCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXI6OmNsaXBUb1JlY3QpOgorCisyMDEzLTA1LTAxICBB cm5hdWQgUmVuZXZpZXIgIDxhLnJlbmV2aWVyQHNpc2Euc2Ftc3VuZy5jb20+CisKICAgICAgICAg aGFuZGxlIGVudW0gaW4gb3ZlcmxvYWRlZCBtZXRob2RzCiAgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTU0NzcKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJMYXllci5jcHAKaW5kZXggY2M2YTljOTg5NmU0MzZkOGIzYWRmMmFhYTQzNGJiNzA5 NTcxOWI3Zi4uYzg2ZjdiYjI1MjljMjRkOWIzMjNkZDZkOTdlYTRiOGJiOGVmNmMzNiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwCkBAIC0zNTE0LDE1ICszNTE0LDE1 IEBAIHN0YXRpYyBib29sIGluQ29udGFpbmluZ0Jsb2NrQ2hhaW4oUmVuZGVyTGF5ZXIqIHN0YXJ0 TGF5ZXIsIFJlbmRlckxheWVyKiBlbmRMYXllCiB2b2lkIFJlbmRlckxheWVyOjpjbGlwVG9SZWN0 KFJlbmRlckxheWVyKiByb290TGF5ZXIsIEdyYXBoaWNzQ29udGV4dCogY29udGV4dCwgY29uc3Qg TGF5b3V0UmVjdCYgcGFpbnREaXJ0eVJlY3QsIGNvbnN0IENsaXBSZWN0JiBjbGlwUmVjdCwKICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgQm9yZGVyUmFkaXVzQ2xpcHBpbmdSdWxlIHJ1bGUp CiB7Ci0gICAgaWYgKGNsaXBSZWN0LnJlY3QoKSA9PSBwYWludERpcnR5UmVjdCkKLSAgICAgICAg cmV0dXJuOwotICAgIGNvbnRleHQtPnNhdmUoKTsKLSAgICBjb250ZXh0LT5jbGlwKHBpeGVsU25h cHBlZEludFJlY3QoY2xpcFJlY3QucmVjdCgpKSk7CisgICAgaWYgKGNsaXBSZWN0LnJlY3QoKSAh PSBwYWludERpcnR5UmVjdCkgeworICAgICAgICBjb250ZXh0LT5zYXZlKCk7CisgICAgICAgIGNv bnRleHQtPmNsaXAocGl4ZWxTbmFwcGVkSW50UmVjdChjbGlwUmVjdC5yZWN0KCkpKTsKKyAgICB9 CiAgICAgCisjaWZuZGVmIERJU0FCTEVfUk9VTkRFRF9DT1JORVJfQ0xJUFBJTkcKICAgICBpZiAo IWNsaXBSZWN0Lmhhc1JhZGl1cygpKQogICAgICAgICByZXR1cm47CiAKLSNpZm5kZWYgRElTQUJM RV9ST1VOREVEX0NPUk5FUl9DTElQUElORwogICAgIC8vIElmIHRoZSBjbGlwIHJlY3QgaGFzIGJl ZW4gdGFpbnRlZCBieSBhIGJvcmRlciByYWRpdXMsIHRoZW4gd2UgaGF2ZSB0byB3YWxrIHVwIG91 ciBsYXllciBjaGFpbiBhcHBseWluZyB0aGUgY2xpcHMgZnJvbQogICAgIC8vIGFueSBsYXllcnMg d2l0aCBvdmVyZmxvdy4gVGhlIGNvbmRpdGlvbiBmb3IgYmVpbmcgYWJsZSB0byBhcHBseSB0aGVz ZSBjbGlwcyBpcyB0aGF0IHRoZSBvdmVyZmxvdyBvYmplY3QgYmUgaW4gb3VyCiAgICAgLy8gY29u dGFpbmluZyBibG9jayBjaGFpbiBzbyB3ZSBjaGVjayB0aGF0IGFsc28uCmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggY2RhZDdh NzUwNzQ1MzNlMWViN2ZmMjBjOGYyMDUzMTdhZTFkNWY5Ni4uODFlYTY4YWFjNTcyYjE1MDJhNGIw ZjQ3N2E0NjU3MmY1NzAzOTNhOCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisr KyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTA1LTAxICBB cm5hdWQgUmVuZXZpZXIgIDxhLnJlbmV2aWVyQHNpc2Euc2Ftc3VuZy5jb20+CisKKyAgICAgICAg Ym9yZGVyLXJhZGl1cyBjbGlwcGluZyBhIGNhbnZhcyBkb2VzIG5vdCBhbHdheXMgY2xpcAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEzMzQzCisKKyAg ICAgICAgQ3JlYXRlIGEgdGVzdCB0aGF0IGRyYXdzIGEgY2FudmFzIGludG8gYSBjbGlwcGVkIG92 ZXJmbG93biBkaXYgd2l0aAorICAgICAgICByYWRpdXMgY29ybmVyLiBUaGVuIHJlZHJhdyB0aGF0 IHNhbWUgdGhpbmcgYSBtb21lbnQgbGF0ZXIuIFRoZSBjYW52YXMKKyAgICAgICAgc2hvdWxkIHN0 YXkgY29ycmVjdGx5IGNsaXBwZWQgdGhlIHNlY29uZCB0aW1lLgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZmFzdC9vdmVyZmxvdy9ib3JkZXItcmFk aXVzLWNsaXBwaW5nLTItZXhwZWN0ZWQuaHRtbDogQWRkZWQuCisgICAgICAgICogZmFzdC9vdmVy Zmxvdy9ib3JkZXItcmFkaXVzLWNsaXBwaW5nLTIuaHRtbDogQWRkZWQuCisKIDIwMTMtMDMtMjgg IEFybmF1ZCBSZW5ldmllciAgPGEucmVuZXZpZXJAc2lzYS5zYW1zdW5nLmNvbT4KIAogICAgICAg ICBtZWFzdXJlVGV4dCgpIGltcHJvdmVtZW50cwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFz dC9vdmVyZmxvdy9ib3JkZXItcmFkaXVzLWNsaXBwaW5nLTItZXhwZWN0ZWQuaHRtbCBiL0xheW91 dFRlc3RzL2Zhc3Qvb3ZlcmZsb3cvYm9yZGVyLXJhZGl1cy1jbGlwcGluZy0yLWV4cGVjdGVkLmh0 bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMC4uY2I5ZTUxNDA4ZGYyOTE2NGUzMjVlZDYwZTRlMzhlNzM2ODg5NzViYgot LS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3Qvb3ZlcmZsb3cvYm9yZGVyLXJhZGl1 cy1jbGlwcGluZy0yLWV4cGVjdGVkLmh0bWwKQEAgLTAsMCArMSwyMSBAQAorPCFET0NUWVBFIGh0 bWw+Cis8aHRtbD4KKzxoZWFkPgorICAgIDxzY3JpcHQ+CisgICAgZnVuY3Rpb24gc3RhcnQoKSB7 CisgICAgICAgIHZhciBjYW52YXMgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiY252Iik7Cisg ICAgICAgIHZhciBjdHggPSBjYW52YXMuZ2V0Q29udGV4dCgiMmQiKTsKKyAgICAgICAgY3R4LmZp bGxTdHlsZSA9ICIjZmYwMDAwIjsKKyAgICAgICAgY3R4LmZpbGxSZWN0KDAsIDAsIGNhbnZhcy53 aWR0aCwgY2FudmFzLmhlaWdodCk7CisgICAgfQorICAgIDwvc2NyaXB0PgorPC9oZWFkPgorPGJv ZHkgb25sb2FkPSJzdGFydCgpIj4KKworPGRpdiBpZD0iYm94IiBzdHlsZT0icG9zaXRpb246IGFi c29sdXRlOyB3aWR0aDogMzAwcHg7IGhlaWdodDogMjAwcHg7IGJvcmRlci1yYWRpdXM6IDQwcHg7 IG92ZXJmbG93OiBoaWRkZW47Ij4KKzxjYW52YXMgaWQ9ImNudiIgd2lkdGg9IjQwMHB4IiBoZWln aHQ9IjQwMHB4Ij48L2NhbnZhcz4KKzwvZGl2PgorCis8L2JvZHk+Cis8L2h0bWw+CisKZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL2Zhc3Qvb3ZlcmZsb3cvYm9yZGVyLXJhZGl1cy1jbGlwcGluZy0y Lmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L292ZXJmbG93L2JvcmRlci1yYWRpdXMtY2xpcHBpbmct Mi5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAuLjk4NDJiYWNkYzhlMzBiM2QxZmYzMTI3M2QyZjUxMjY5MDE5NTRl ZDQKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L292ZXJmbG93L2JvcmRlci1y YWRpdXMtY2xpcHBpbmctMi5odG1sCkBAIC0wLDAgKzEsMjkgQEAKKzwhRE9DVFlQRSBodG1sPgor PGh0bWw+Cis8aGVhZD4KKyAgICA8c2NyaXB0PgorICAgIGlmICh3aW5kb3cudGVzdFJ1bm5lcikK KyAgICAgICAgdGVzdFJ1bm5lci53YWl0VW50aWxEb25lKCk7CisKKyAgICBmdW5jdGlvbiBzdGFy dCgpIHsKKyAgICAgICAgdmFyIGNhbnZhcyA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJjbnYi KTsKKyAgICAgICAgdmFyIGN0eCA9IGNhbnZhcy5nZXRDb250ZXh0KCIyZCIpOworCisgICAgICAg IHNldFRpbWVvdXQoZnVuY3Rpb24oKSB7CisgICAgICAgICAgICBjdHguZmlsbFN0eWxlID0gIiNm ZjAwMDAiOworICAgICAgICAgICAgY3R4LmZpbGxSZWN0KDAsIDAsIGNhbnZhcy53aWR0aCwgY2Fu dmFzLmhlaWdodCk7CisgICAgICAgICAgICBpZiAod2luZG93LnRlc3RSdW5uZXIpIAorICAgICAg ICAgICAgICAgIHRlc3RSdW5uZXIubm90aWZ5RG9uZSgpOworICAgICAgICB9LCA1MDApOworICAg IH0KKworICAgIDwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHkgb25sb2FkPSJzdGFydCgpIj4KKwor PGRpdiBpZD0iYm94IiBzdHlsZT0icG9zaXRpb246IGFic29sdXRlOyB3aWR0aDogMzAwcHg7IGhl aWdodDogMjAwcHg7IGJvcmRlci1yYWRpdXM6IDQwcHg7IG92ZXJmbG93OiBoaWRkZW47Ij4KKzxj YW52YXMgaWQ9ImNudiIgd2lkdGg9IjQwMHB4IiBoZWlnaHQ9IjQwMHB4Ij48L2NhbnZhcz4KKzwv ZGl2PgorCis8L2JvZHk+Cis8L2h0bWw+Cg==