113334 2013-03-26 12:30:31 -0700 [BlackBerry] RSS reader filter swallows headers when there is no body 2013-03-26 13:07:01 -0700 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Other Unspecified RESOLVED FIXED P2 Normal --- 1 joenotcharles joenotcharles mifenton rwlbuis tonikitoo webkit.review.bot oldest_to_newest 863917 0 joenotcharles 2013-03-26 12:30:31 -0700 When receiving an HTTP response that has a Content-Type header such as text/xml, but no body, RSSFilterStream::notifyHeadersReceived reads the Content-Type as "potential RSS", and calls saveHeaders. It expects to sniff the body in notifyDataReceived to see if it's RSS, and then call sendSavedHeaders to pass on the headers. But notifyDataReceived is never called since there's no body, so neither is sendSavedHeaders. The result is that NetworkJob sees "notifyStatusReceived; notifyClose" instead of "notifyStatusReceived; notifyHeadersReceived; notifyClose". 863931 1 195145 joenotcharles 2013-03-26 12:41:17 -0700 Created attachment 195145 fix 863933 2 195146 joenotcharles 2013-03-26 12:43:55 -0700 Created attachment 195146 fix Right patch this time 863937 3 195146 rwlbuis 2013-03-26 12:47:18 -0700 Comment on attachment 195146 fix LGTM. 863947 4 195146 webkit.review.bot 2013-03-26 13:06:58 -0700 Comment on attachment 195146 fix Clearing flags on attachment: 195146 Committed r146922: <http://trac.webkit.org/changeset/146922> 863948 5 webkit.review.bot 2013-03-26 13:07:01 -0700 All reviewed patches have been landed. Closing bug. 195145 2013-03-26 12:41:17 -0700 2013-03-26 12:43:55 -0700 fix 0001-2013-03-13-Joe-Mason-jmason-blackberry.com.patch text/plain 1307 joenotcharles RnJvbSA3MDcyNGQwNGQ5ZjRiZmFmOGRkNDBlNTQ3NDlhZmZjNjNiZGIwOTY2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKb2UgTWFzb24gPGptYXNvbkBibGFja2JlcnJ5LmNvbT4KRGF0 ZTogV2VkLCAxMyBNYXIgMjAxMyAxODo0MzowMiAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIDIwMTMt MDMtMTMgIEpvZSBNYXNvbiAgPGptYXNvbkBibGFja2JlcnJ5LmNvbT4KCiAgICAgICAgRml4IGZs aXBwZWQgYXNzZXJ0IGluIGRhdGFiYXNlIHVwZ3JhZGUgY29kZQogICAgICAgIFBSIDMxMDQxMwoK ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCiAgICAgICAgZXhpc3RpbmdEYXRh YmFzZVZlcnNpb24gaXMgY2FsbGVkIGFmdGVyIHRoZSBEQiBpcyBvcGVuZWQuCgogICAgICAgICog cGxhdGZvcm0vbmV0d29yay9ibGFja2JlcnJ5L0NyZWRlbnRpYWxCYWNraW5nU3RvcmUuY3BwOgog ICAgICAgIChXZWJDb3JlOjpDcmVkZW50aWFsQmFja2luZ1N0b3JlOjpleGlzdGluZ0RhdGFiYXNl VmVyc2lvbik6Ci0tLQogLi4uL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9ibGFja2JlcnJ5L0Ny ZWRlbnRpYWxCYWNraW5nU3RvcmUuY3BwICAgfCAgICAyICstCiAxIGZpbGUgY2hhbmdlZCwgMSBp bnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9uZXR3b3JrL2JsYWNrYmVycnkvQ3JlZGVudGlhbEJhY2tpbmdTdG9yZS5jcHAgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2JsYWNrYmVycnkvQ3JlZGVudGlhbEJhY2tp bmdTdG9yZS5jcHAKaW5kZXggM2VlZDQ2ZC4uY2UxNWQ3OCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vbmV0d29yay9ibGFja2JlcnJ5L0NyZWRlbnRpYWxCYWNraW5nU3RvcmUu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvYmxhY2tiZXJyeS9DcmVk ZW50aWFsQmFja2luZ1N0b3JlLmNwcApAQCAtMjUwLDcgKzI1MCw3IEBAIHVuc2lnbmVkIENyZWRl bnRpYWxCYWNraW5nU3RvcmU6OmN1cnJlbnREYXRhYmFzZVZlcnNpb24oKSBjb25zdAogCiB1bnNp Z25lZCBDcmVkZW50aWFsQmFja2luZ1N0b3JlOjpleGlzdGluZ0RhdGFiYXNlVmVyc2lvbigpCiB7 Ci0gICAgQVNTRVJUKCFtX2RhdGFiYXNlLmlzT3BlbigpKTsKKyAgICBBU1NFUlQobV9kYXRhYmFz ZS5pc09wZW4oKSk7CiAKICAgICAvLyBGb3IgU1FMaXRlLCBwcmFnbWEgdGFibGVfaW5mbyBzaG91 bGQgcmV0dXJuIGRhdGEgbGlrZSBmb2xsb3dpbmcuCiAgICAgLy8KLS0gCjEuNy4xMC40Cgo= 195146 2013-03-26 12:43:55 -0700 2013-03-26 13:06:57 -0700 fix 0001-BlackBerry-In-RSSFilterStream-don-t-swallow-headers-.patch text/plain 3259 joenotcharles RnJvbSA2YzBjMDhhNjkzNDRiMDg0YWVkNWU4Mzg3NzdhZjhhNmNiNjk5YWNhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKb2UgTWFzb24gPGptYXNvbkBibGFja2JlcnJ5LmNvbT4KRGF0 ZTogVHVlLCAyNiBNYXIgMjAxMyAxNTozODo1NyAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIFtCbGFj a0JlcnJ5XSBJbiBSU1NGaWx0ZXJTdHJlYW0sIGRvbid0IHN3YWxsb3cgaGVhZGVycyB3aGVuCiB0 aGVyZSdzIG5vIGJvZHkKIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MTMzMzQKClJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKUklNIFBSIDMxNjM0NQoKV2hlbiBy ZWNlaXZpbmcgYW4gSFRUUCByZXNwb25zZSB0aGF0IGhhcyBhIENvbnRlbnQtVHlwZSBoZWFkZXIg c3VjaCBhcyB0ZXh0L3htbCwgYnV0IG5vCmJvZHksIFJTU0ZpbHRlclN0cmVhbTo6bm90aWZ5SGVh ZGVyc1JlY2VpdmVkIHJlYWRzIHRoZSBDb250ZW50LVR5cGUgYXMgInBvdGVudGlhbCBSU1MiLCBh bmQKY2FsbHMgc2F2ZUhlYWRlcnMuIEl0IGV4cGVjdHMgdG8gc25pZmYgdGhlIGJvZHkgaW4gbm90 aWZ5RGF0YVJlY2VpdmVkIHRvIHNlZSBpZiBpdCdzIFJTUywKYW5kIHRoZW4gY2FsbCBzZW5kU2F2 ZWRIZWFkZXJzIHRvIHBhc3Mgb24gdGhlIGhlYWRlcnMuIEJ1dCBzaW5jZSB0aGVyZSBpcyBubyBi b2R5LApub3RpZnlEYXRhUmVjZWl2ZWQgaXMgbmV2ZXIgY2FsbGVkLiBTbyBjYWxsIHNlbmRTYXZl ZEhlYWRlcnMgaW4gbm90aWZ5Q2xvc2UgdG9vIChpdCB3aWxsIG5vdApzZW5kIHRoZW0gYWdhaW4g aWYgdGhleSB3ZXJlIGFscmVhZHkgc2VudC4pCgoqIHBsYXRmb3JtL25ldHdvcmsvYmxhY2tiZXJy eS9yc3MvUlNTRmlsdGVyU3RyZWFtLmNwcDoKKFdlYkNvcmU6OlJTU0ZpbHRlclN0cmVhbTo6bm90 aWZ5Q2xvc2UpOgotLS0KIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAg ICAgICAgICAgICB8ICAgMTkgKysrKysrKysrKysrKysrKysrKwogLi4uL25ldHdvcmsvYmxhY2ti ZXJyeS9yc3MvUlNTRmlsdGVyU3RyZWFtLmNwcCAgICAgIHwgICAgOSArKysrKysrKy0KIDIgZmls ZXMgY2hhbmdlZCwgMjcgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRl eCBlYzZlOWU2Li5lMGY4MDFhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTMtMDMt MjYgIEpvZSBNYXNvbiAgPGptYXNvbkBibGFja2JlcnJ5LmNvbT4KKworICAgICAgICBbQmxhY2tC ZXJyeV0gSW4gUlNTRmlsdGVyU3RyZWFtLCBkb24ndCBzd2FsbG93IGhlYWRlcnMgd2hlbiB0aGVy ZSdzIG5vIGJvZHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTExMzMzNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFJJTSBQUiAzMTYzNDUKKworICAgICAgICBXaGVuIHJlY2VpdmluZyBhbiBIVFRQIHJlc3Bv bnNlIHRoYXQgaGFzIGEgQ29udGVudC1UeXBlIGhlYWRlciBzdWNoIGFzIHRleHQveG1sLCBidXQg bm8KKyAgICAgICAgYm9keSwgUlNTRmlsdGVyU3RyZWFtOjpub3RpZnlIZWFkZXJzUmVjZWl2ZWQg cmVhZHMgdGhlIENvbnRlbnQtVHlwZSBhcyAicG90ZW50aWFsIFJTUyIsIGFuZAorICAgICAgICBj YWxscyBzYXZlSGVhZGVycy4gSXQgZXhwZWN0cyB0byBzbmlmZiB0aGUgYm9keSBpbiBub3RpZnlE YXRhUmVjZWl2ZWQgdG8gc2VlIGlmIGl0J3MgUlNTLAorICAgICAgICBhbmQgdGhlbiBjYWxsIHNl bmRTYXZlZEhlYWRlcnMgdG8gcGFzcyBvbiB0aGUgaGVhZGVycy4gQnV0IHNpbmNlIHRoZXJlIGlz IG5vIGJvZHksCisgICAgICAgIG5vdGlmeURhdGFSZWNlaXZlZCBpcyBuZXZlciBjYWxsZWQuIFNv IGNhbGwgc2VuZFNhdmVkSGVhZGVycyBpbiBub3RpZnlDbG9zZSB0b28gKGl0IHdpbGwgbm90Cisg ICAgICAgIHNlbmQgdGhlbSBhZ2FpbiBpZiB0aGV5IHdlcmUgYWxyZWFkeSBzZW50LikKKworICAg ICAgICAqIHBsYXRmb3JtL25ldHdvcmsvYmxhY2tiZXJyeS9yc3MvUlNTRmlsdGVyU3RyZWFtLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OlJTU0ZpbHRlclN0cmVhbTo6bm90aWZ5Q2xvc2UpOgorCiAy MDEzLTAzLTIyICBUaWFuY2hlbmcgSmlhbmcgIDx0aWppYW5nQHJpbS5jb20+CiAKICAgICAgICAg W0JsYWNrQmVycnldIFVwZGF0ZSBJbnB1dCBmaWVsZCBCYWNrZ3JvdW5kIENvbG9yCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2JsYWNrYmVycnkvcnNzL1JTU0Zp bHRlclN0cmVhbS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2JsYWNrYmVy cnkvcnNzL1JTU0ZpbHRlclN0cmVhbS5jcHAKaW5kZXggOGI4NDQ2YS4uYmQ1ODE0NSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9ibGFja2JlcnJ5L3Jzcy9SU1NG aWx0ZXJTdHJlYW0uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvYmxh Y2tiZXJyeS9yc3MvUlNTRmlsdGVyU3RyZWFtLmNwcApAQCAtNTAxLDEwICs1MDEsMTcgQEAgdm9p ZCBSU1NGaWx0ZXJTdHJlYW06Om5vdGlmeURhdGFSZWNlaXZlZChCbGFja0JlcnJ5OjpQbGF0Zm9y bTo6TmV0d29ya0J1ZmZlciogYnUKIAogdm9pZCBSU1NGaWx0ZXJTdHJlYW06Om5vdGlmeUNsb3Nl KGludCBzdGF0dXMpCiB7CisgICAgLy8gSWYgdGhlcmUgd2FzIG5vIGRhdGEsIHdlIG1pZ2h0IGdl dCBoZXJlIHdpdGggdGhlIHR5cGUgc3RpbGwgdW5rbm93bi4gTm8gZGF0YSBhdCBhbGwgLT4gbm8g UlNTCisgICAgLy8gZGF0YS4KKyAgICBpZiAobV9yZXNvdXJjZVR5cGUgPT0gVHlwZVVua25vd24p CisgICAgICAgIG1fcmVzb3VyY2VUeXBlID0gVHlwZU5vdFJTUzsKKwogICAgIGlmIChpc1JTU0Nv bnRlbnQobV9yZXNvdXJjZVR5cGUpKQogICAgICAgICBoYW5kbGVSU1NDb250ZW50KCk7Ci0gICAg ZWxzZQorICAgIGVsc2UgeworICAgICAgICBzZW5kU2F2ZWRIZWFkZXJzKCk7CiAgICAgICAgIEZp bHRlclN0cmVhbTo6bm90aWZ5Q2xvc2Uoc3RhdHVzKTsKKyAgICB9CiB9CiAKIGJvb2wgUlNTRmls dGVyU3RyZWFtOjpjb252ZXJ0Q29udGVudFRvSHRtbChzdGQ6OnN0cmluZyYgcmVzdWx0KQotLSAK MS43LjEwLjQKCg==