113324 2013-03-26 10:40:02 -0700 Revision for the internal jhbuild is too old 2013-03-27 17:00:08 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mario mario d-r gustavo mrobinson webkit.review.bot oldest_to_newest 863818 0 mario 2013-03-26 10:40:02 -0700 Today I found WebKitGTK is using a pretty old version of jhbuild for the internal libs, which has an important bug that makes the process to fail during the "make install" stage, in case it founds a symlink to a directory after moving it from the temporary place under _jhbuild/ to the final destination. The problem comes from this part of the code in jhbuild (revision 1eedc423f75c605224b430579e4c303292199507). In file jhbuild/jhbuild/modtypes/__initi__.py: if os.path.isdir(src_path): if os.path.exists(dest_path): if not os.path.isdir(dest_path): os.unlink(dest_path) os.mkdir(dest_path) else: os.mkdir(dest_path) num_copied += self._process_install_files(installroot, src_path, prefix) os.rmdir(src_path) That will fail if src_path is a symlink to a dir, since os.path.isdir() follows links, but os.rmdir() does not. So I think we should update the minimum required revision to some point where that issue is fixed, and I suggest ddb8b4e64bede55212c7590e2104daff92b72ce0 for that, since it's properly fixed there. 863828 1 195116 mario 2013-03-26 10:45:45 -0700 Created attachment 195116 Patch proposal Here comes the patch 864289 2 d-r 2013-03-27 01:27:07 -0700 Thanks, Mario. 864363 3 195116 mario 2013-03-27 03:37:39 -0700 Comment on attachment 195116 Patch proposal Thanks for the review. Setting cq+, since I'm not able to push it myself, for some weird reason 864998 4 195116 webkit.review.bot 2013-03-27 17:00:03 -0700 Comment on attachment 195116 Patch proposal Clearing flags on attachment: 195116 Committed r147023: <http://trac.webkit.org/changeset/147023> 864999 5 webkit.review.bot 2013-03-27 17:00:08 -0700 All reviewed patches have been landed. Closing bug. 195116 2013-03-26 10:45:45 -0700 2013-03-27 17:00:03 -0700 Patch proposal bug-113324-20130326174221.patch text/plain 1374 mario U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ2Nzg1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZTNiODM5YWZkZjhlNDM5ZWQzMWM4MjU0Y2QyZThiNDI4 N2M2NjdjYy4uOTc3M2ExMjJiNGZhZWNhYTRkOTIwNDQ2YmJkYjA1MjJhNWI2YjkzMyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEzLTAzLTI2ICBNYXJpbyBTYW5jaGV6IFByYWRhICA8bWFyaW8ucHJhZGFAc2Ftc3Vu Zy5jb20+CisKKyAgICAgICAgUmV2aXNpb24gZm9yIHRoZSBpbnRlcm5hbCBqaGJ1aWxkIGlzIHRv byBvbGQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEx MzMyNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVw ZGF0ZSB0aGUgbWluaW11bSByZXF1aXJlZCB2ZXJzaW9uIHRvIGEgcG9pbnQgd2hlcmUgamhidWls ZCB3b24ndAorICAgICAgICBmYWlsIGluc3RhbGxpbmcgcGFja2FnZXMgd2hlbiB0cnlpbmcgdG8g cmVtb3ZlIGEgc3ltbGluayB0byBhIGRpcmVjdG9yeS4KKworICAgICAgICAqIGpoYnVpbGQvamhi dWlsZC13cmFwcGVyOiBVcGRhdGVkIHJldmlzaW9uLgorCiAyMDEzLTAzLTI1ICBEb21pbmlrIFLD tnR0c2NoZXMgIDxkb21pbmlrLnJvdHRzY2hlc0BpbnRlbC5jb20+CiAKICAgICAgICAgW0hhcmZC dXp6XSBJQ1UgZGV0ZWN0aW9uIGZpeCBpbiBIYXJmQnV6eiBvYnNvbGV0ZXMgb3VyIHdvcmthcm91 bmQKZGlmZiAtLWdpdCBhL1Rvb2xzL2poYnVpbGQvamhidWlsZC13cmFwcGVyIGIvVG9vbHMvamhi dWlsZC9qaGJ1aWxkLXdyYXBwZXIKaW5kZXggNDBiYmIwMTAxY2E0N2M3ZDZhYjZkZDA3MTc0OGFi NjEwYWRhM2JkOS4uNWQzZWFjMWEyZDJkMjgwOGY3MTIzNjk1NzRjYzlmYjQ1NWI4NWQ5MiAxMDA3 NTUKLS0tIGEvVG9vbHMvamhidWlsZC9qaGJ1aWxkLXdyYXBwZXIKKysrIGIvVG9vbHMvamhidWls ZC9qaGJ1aWxkLXdyYXBwZXIKQEAgLTIzLDcgKzIzLDcgQEAgaW1wb3J0IHNobGV4CiBpbXBvcnQg c3VicHJvY2VzcwogaW1wb3J0IHN5cwogCi1qaGJ1aWxkX3JldmlzaW9uID0gJzFlZWRjNDIzZjc1 YzYwNTIyNGI0MzA1NzllNGMzMDMyOTIxOTk1MDcnCitqaGJ1aWxkX3JldmlzaW9uID0gJ2RkYjhi NGU2NGJlZGU1NTIxMmM3NTkwZTIxMDRkYWZmOTJiNzJjZTAnCiAKIGRlcGVuZGVuY2llc19wYXRo ID0gamhidWlsZHV0aWxzLmdldF9kZXBlbmRlbmNpZXNfcGF0aCgpCiBpbnN0YWxsYXRpb25fcHJl Zml4ID0gb3MucGF0aC5hYnNwYXRoKG9zLnBhdGguam9pbihkZXBlbmRlbmNpZXNfcGF0aCwgJ1Jv b3QnKSkK