113309 2013-03-26 07:22:27 -0700 FormData::deepCopy() could use Vector::uncheckedAppend() 2013-03-26 08:20:18 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez ap benjamin laszlo.gombos webkit.review.bot oldest_to_newest 863649 0 cdumez 2013-03-26 07:22:27 -0700 FormData::deepCopy() currently calls reserveInitialCapacity() on the Vector but then uses the regular append() method. We could use uncheckedAppend() instead and bypass capacity checks since we already know the capacity is sufficient. 863652 1 195084 cdumez 2013-03-26 07:26:10 -0700 Created attachment 195084 Patch 863691 2 195084 webkit.review.bot 2013-03-26 08:20:15 -0700 Comment on attachment 195084 Patch Clearing flags on attachment: 195084 Committed r146884: <http://trac.webkit.org/changeset/146884> 863692 3 webkit.review.bot 2013-03-26 08:20:18 -0700 All reviewed patches have been landed. Closing bug. 195084 2013-03-26 07:26:10 -0700 2013-03-26 08:20:14 -0700 Patch 113309_deepCopy_uncheckedAppend.patch text/plain 2782 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAyNjA5NWI0Li44OGYxN2ZlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTMtMDMtMjYgIENocmlzdG9waGUgRHVtZXogIDxjaC5kdW1lekBzaXNhLnNhbXN1bmcu Y29tPgorCisgICAgICAgIEZvcm1EYXRhOjpkZWVwQ29weSgpIGNvdWxkIHVzZSBWZWN0b3I6OnVu Y2hlY2tlZEFwcGVuZCgpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMTMzMDkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBGb3JtRGF0YTo6ZGVlcENvcHkoKSBjYWxscyByZXNlcnZlSW5pdGlhbENhcGFjaXR5 KCkgb24gdGhlIFZlY3RvciBidXQgdGhlbiB1c2VzIHRoZQorICAgICAgICByZWd1bGFyIGFwcGVu ZCgpIG1ldGhvZC4gVGhpcyBwYXRjaCBzd2l0Y2hlcyB0byB1c2luZyB1bmNoZWNrZWRBcHBlbmQo KSBtZXRob2QKKyAgICAgICAgaW5zdGVhZCB0byBieXBhc3MgY2FwYWNpdHkgY2hlY2tzIGFzIHdl IGFscmVhZHkga25vdyBpdCBpcyBzdWZmaWNpZW50LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywg bm8gYmVoYXZpb3IgY2hhbmdlLgorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9Gb3JtRGF0 YS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGb3JtRGF0YTo6ZGVlcENvcHkpOgorCiAyMDEzLTAz LTI2ICBWc2V2b2xvZCBWbGFzb3YgIDx2c2V2aWtAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFdl YiBJbnNwZWN0b3I6IERlY29yYXRpb25zIGluIHNldmVyYWwgY29uc2VjdXRpdmUgbGluZXMgYXJl IG5vdCBtb3ZlZCBjb3JyZWN0bHkgaW4gRFRFLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vbmV0d29yay9Gb3JtRGF0YS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9u ZXR3b3JrL0Zvcm1EYXRhLmNwcAppbmRleCBmNmQ0NTg4Li4wZmIzMTNkIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL0Zvcm1EYXRhLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL0Zvcm1EYXRhLmNwcApAQCAtMTM2LDIzICsxMzYsMjMg QEAgUGFzc1JlZlB0cjxGb3JtRGF0YT4gRm9ybURhdGE6OmRlZXBDb3B5KCkgY29uc3QKICAgICAg ICAgY29uc3QgRm9ybURhdGFFbGVtZW50JiBlID0gbV9lbGVtZW50c1tpXTsKICAgICAgICAgc3dp dGNoIChlLm1fdHlwZSkgewogICAgICAgICBjYXNlIEZvcm1EYXRhRWxlbWVudDo6ZGF0YToKLSAg ICAgICAgICAgIGZvcm1EYXRhLT5tX2VsZW1lbnRzLmFwcGVuZChGb3JtRGF0YUVsZW1lbnQoZS5t X2RhdGEpKTsKKyAgICAgICAgICAgIGZvcm1EYXRhLT5tX2VsZW1lbnRzLnVuY2hlY2tlZEFwcGVu ZChGb3JtRGF0YUVsZW1lbnQoZS5tX2RhdGEpKTsKICAgICAgICAgICAgIGJyZWFrOwogICAgICAg ICBjYXNlIEZvcm1EYXRhRWxlbWVudDo6ZW5jb2RlZEZpbGU6CiAjaWYgRU5BQkxFKEJMT0IpCi0g ICAgICAgICAgICBmb3JtRGF0YS0+bV9lbGVtZW50cy5hcHBlbmQoRm9ybURhdGFFbGVtZW50KGUu bV9maWxlbmFtZSwgZS5tX2ZpbGVTdGFydCwgZS5tX2ZpbGVMZW5ndGgsIGUubV9leHBlY3RlZEZp bGVNb2RpZmljYXRpb25UaW1lLCBlLm1fc2hvdWxkR2VuZXJhdGVGaWxlKSk7CisgICAgICAgICAg ICBmb3JtRGF0YS0+bV9lbGVtZW50cy51bmNoZWNrZWRBcHBlbmQoRm9ybURhdGFFbGVtZW50KGUu bV9maWxlbmFtZSwgZS5tX2ZpbGVTdGFydCwgZS5tX2ZpbGVMZW5ndGgsIGUubV9leHBlY3RlZEZp bGVNb2RpZmljYXRpb25UaW1lLCBlLm1fc2hvdWxkR2VuZXJhdGVGaWxlKSk7CiAjZWxzZQotICAg ICAgICAgICAgZm9ybURhdGEtPm1fZWxlbWVudHMuYXBwZW5kKEZvcm1EYXRhRWxlbWVudChlLm1f ZmlsZW5hbWUsIGUubV9zaG91bGRHZW5lcmF0ZUZpbGUpKTsKKyAgICAgICAgICAgIGZvcm1EYXRh LT5tX2VsZW1lbnRzLnVuY2hlY2tlZEFwcGVuZChGb3JtRGF0YUVsZW1lbnQoZS5tX2ZpbGVuYW1l LCBlLm1fc2hvdWxkR2VuZXJhdGVGaWxlKSk7CiAjZW5kaWYKICAgICAgICAgICAgIGJyZWFrOwog I2lmIEVOQUJMRShCTE9CKQogICAgICAgICBjYXNlIEZvcm1EYXRhRWxlbWVudDo6ZW5jb2RlZEJs b2I6Ci0gICAgICAgICAgICBmb3JtRGF0YS0+bV9lbGVtZW50cy5hcHBlbmQoRm9ybURhdGFFbGVt ZW50KGUubV91cmwpKTsKKyAgICAgICAgICAgIGZvcm1EYXRhLT5tX2VsZW1lbnRzLnVuY2hlY2tl ZEFwcGVuZChGb3JtRGF0YUVsZW1lbnQoZS5tX3VybCkpOwogICAgICAgICAgICAgYnJlYWs7CiAj ZW5kaWYKICNpZiBFTkFCTEUoRklMRV9TWVNURU0pCiAgICAgICAgIGNhc2UgRm9ybURhdGFFbGVt ZW50OjplbmNvZGVkVVJMOgotICAgICAgICAgICAgZm9ybURhdGEtPm1fZWxlbWVudHMuYXBwZW5k KEZvcm1EYXRhRWxlbWVudChlLm1fdXJsLCBlLm1fZmlsZVN0YXJ0LCBlLm1fZmlsZUxlbmd0aCwg ZS5tX2V4cGVjdGVkRmlsZU1vZGlmaWNhdGlvblRpbWUpKTsKKyAgICAgICAgICAgIGZvcm1EYXRh LT5tX2VsZW1lbnRzLnVuY2hlY2tlZEFwcGVuZChGb3JtRGF0YUVsZW1lbnQoZS5tX3VybCwgZS5t X2ZpbGVTdGFydCwgZS5tX2ZpbGVMZW5ndGgsIGUubV9leHBlY3RlZEZpbGVNb2RpZmljYXRpb25U aW1lKSk7CiAgICAgICAgICAgICBicmVhazsKICNlbmRpZgogICAgICAgICB9Cg==