113279 2013-03-26 01:01:36 -0700 HTTPHeaderMap::copyData() could call uncheckedAppend() 2013-03-26 10:07:26 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez ap benjamin kenneth laszlo.gombos webkit.review.bot oldest_to_newest 863431 0 cdumez 2013-03-26 01:01:36 -0700 HTTPHeaderMap::copyData() calls reserveInitialCapacity() on the Vector but then uses append() instead of uncheckedAppend(). Since the capacity was previously reserved, we can call uncheckedAppend() to bypass capacity checks. 863462 1 195031 cdumez 2013-03-26 01:51:38 -0700 Created attachment 195031 Patch 863762 2 195031 webkit.review.bot 2013-03-26 10:07:22 -0700 Comment on attachment 195031 Patch Clearing flags on attachment: 195031 Committed r146899: <http://trac.webkit.org/changeset/146899> 863763 3 webkit.review.bot 2013-03-26 10:07:26 -0700 All reviewed patches have been landed. Closing bug. 195031 2013-03-26 01:51:38 -0700 2013-03-26 10:07:22 -0700 Patch 113279_httpheadermap_uncheckedAppend.patch text/plain 1772 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBiZDM2ZjAyLi4zMzJhOWNmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAg QEAKKzIwMTMtMDMtMjYgIENocmlzdG9waGUgRHVtZXogIDxjaC5kdW1lekBzaXNhLnNhbXN1bmcu Y29tPgorCisgICAgICAgIEhUVFBIZWFkZXJNYXA6OmNvcHlEYXRhKCkgY291bGQgY2FsbCB1bmNo ZWNrZWRBcHBlbmQoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTEzMjc5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgSFRUUEhlYWRlck1hcDo6Y29weURhdGEoKSBjYWxscyByZXNlcnZlSW5pdGlhbENhcGFj aXR5KCkgb24gdGhlIFZlY3RvcgorICAgICAgICBidXQgdGhlbiBhcHBlbmRzIGl0ZW1zIHVzaW5n IGFwcGVuZCgpIGZ1bmN0aW9uLiBTaW5jZSB3ZSBhbHJlYWR5IGtub3cKKyAgICAgICAgdGhlIGNh cGFjaXR5IGlzIHN1ZmZpY2llbnQsIGl0IGlzIG1vcmUgZWZmaWNpZW50IHRvIGNhbGwgdW5jaGVj a2VkQXBwZW5kKCkKKyAgICAgICAgaW5zdGVhZCB0byBieXBhc3MgY2FwYWNpdHkgY2hlY2tzLgor CisgICAgICAgIE5vIG5ldyB0ZXN0cywgbm8gYmVoYXZpb3IgY2hhbmdlIGZvciBsYXlvdXQgdGVz dHMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL0hUVFBIZWFkZXJNYXAuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6SFRUUEhlYWRlck1hcDo6Y29weURhdGEpOgorCiAyMDEzLTAzLTI2ICBE b21pbmlrIFLDtnR0c2NoZXMgIDxkb21pbmlrLnJvdHRzY2hlc0BpbnRlbC5jb20+CiAKICAgICAg ICAgUmVtb3ZlIEhhcmZCdXp6U2hhcGVyQmFzZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vbmV0d29yay9IVFRQSGVhZGVyTWFwLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL25ldHdvcmsvSFRUUEhlYWRlck1hcC5jcHAKaW5kZXggZGVmZTFhZS4uNjQ1YTg1YiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9IVFRQSGVhZGVyTWFwLmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL0hUVFBIZWFkZXJNYXAuY3Bw CkBAIC01MSw5ICs1MSw5IEBAIFBhc3NPd25QdHI8Q3Jvc3NUaHJlYWRIVFRQSGVhZGVyTWFwRGF0 YT4gSFRUUEhlYWRlck1hcDo6Y29weURhdGEoKSBjb25zdAogICAgIGRhdGEtPnJlc2VydmVJbml0 aWFsQ2FwYWNpdHkoc2l6ZSgpKTsKIAogICAgIEhUVFBIZWFkZXJNYXA6OmNvbnN0X2l0ZXJhdG9y IGVuZF9pdCA9IGVuZCgpOwotICAgIGZvciAoSFRUUEhlYWRlck1hcDo6Y29uc3RfaXRlcmF0b3Ig aXQgPSBiZWdpbigpOyBpdCAhPSBlbmRfaXQ7ICsraXQpIHsKLSAgICAgICAgZGF0YS0+YXBwZW5k KG1ha2VfcGFpcihpdC0+a2V5LnN0cmluZygpLmlzb2xhdGVkQ29weSgpLCBpdC0+dmFsdWUuaXNv bGF0ZWRDb3B5KCkpKTsKLSAgICB9CisgICAgZm9yIChIVFRQSGVhZGVyTWFwOjpjb25zdF9pdGVy YXRvciBpdCA9IGJlZ2luKCk7IGl0ICE9IGVuZF9pdDsgKytpdCkKKyAgICAgICAgZGF0YS0+dW5j aGVja2VkQXBwZW5kKG1ha2VfcGFpcihpdC0+a2V5LnN0cmluZygpLmlzb2xhdGVkQ29weSgpLCBp dC0+dmFsdWUuaXNvbGF0ZWRDb3B5KCkpKTsKKwogICAgIHJldHVybiBkYXRhLnJlbGVhc2UoKTsK IH0KIAo=