113277 2013-03-25 23:16:55 -0700 RefCountedArray needs a size based constructor 2013-03-26 20:52:45 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 oliver oliver benjamin cmarcelo ojan.autocc webkit.review.bot oldest_to_newest 863388 0 oliver 2013-03-25 23:16:55 -0700 RefCountedArray needs a size based constructor 863391 1 195011 oliver 2013-03-25 23:23:58 -0700 Created attachment 195011 Patch 863419 2 195011 benjamin 2013-03-26 00:25:25 -0700 Comment on attachment 195011 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=195011&action=review > Source/WTF/wtf/RefCountedArray.h:71 > + m_data = (static_cast<Header*>(fastMalloc(Header::size() + sizeof(T) * size)))->payload(); > + Header::fromPayload(m_data)->refCount = 1; > + Header::fromPayload(m_data)->length = size; > + ASSERT(Header::fromPayload(m_data)->length == size); You also need to call VectorTypeOperations::initialize() on the new data. Alternatively, by symmetry with Vector, you could have a reserveInitialCapacity() on RefCountedArray that does not do any initialization. 863460 3 195029 oliver 2013-03-26 01:50:46 -0700 Created attachment 195029 Patch 863961 4 195029 benjamin 2013-03-26 13:35:50 -0700 Comment on attachment 195029 Patch LGTM. 864201 5 oliver 2013-03-26 20:52:45 -0700 Committed r146964: <http://trac.webkit.org/changeset/146964> 195011 2013-03-25 23:23:58 -0700 2013-03-26 01:50:15 -0700 Patch bug-113277-20130326191936.patch text/plain 1671 oliver U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ2ODQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDUxNzc0Nzk4MGJmMTQ2MDg5YzcxODM1 M2IxYmU2OTg5MTE2NjQzZmUuLjZhN2MxMTg2NzZjYWU3OGZkYjIzNmIyYjk5ZDYzOThmMTgyMzcw NWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTMtMDMtMjUgIE9saXZlciBIdW50ICA8b2xpdmVy QGFwcGxlLmNvbT4KKworICAgICAgICBSZWZDb3VudGVkQXJyYXkgbmVlZHMgYSBzaXplIGJhc2Vk IGNvbnN0cnVjdG9yCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMTMyNzcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBTaW1wbGUgcGF0Y2ggdG8gYWRkIGEgc2l6ZSBiYXNlZCBjb25zdHJ1Y3RvciBmb3IgUmVm Q291bnRlZEFycmF5CisgICAgICAgIHNvIHRoYXQgd2UgY2FuIGNyZWF0ZSBhbiBzaGFyYWJsZSBh cnJheSB3aXRob3V0IGEgY29weS4KKworICAgICAgICAqIHd0Zi9SZWZDb3VudGVkQXJyYXkuaDoK KyAgICAgICAgKFJlZkNvdW50ZWRBcnJheSk6CisgICAgICAgIChXVEY6OlJlZkNvdW50ZWRBcnJh eTo6UmVmQ291bnRlZEFycmF5KToKKwogMjAxMy0wMy0yNSAgS2VudCBUYW11cmEgIDx0a2VudEBj aHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmVuYW1lIEVOQUJMRV9JTlBVVF9UWVBFX0RBVEVUSU1F CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9SZWZDb3VudGVkQXJyYXkuaCBiL1NvdXJjZS9X VEYvd3RmL1JlZkNvdW50ZWRBcnJheS5oCmluZGV4IDI3NGFmOTg5NzA5YTJjZmJiZDY3MGZhZGZl ZTEwZTFiYjZmNmM4NmYuLmJjMzkxNjAxYzAzNTdkMTFkNDc3MTE4ZTM5MTEwOGEwYTJmYTk5NDMg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL1JlZkNvdW50ZWRBcnJheS5oCisrKyBiL1NvdXJj ZS9XVEYvd3RmL1JlZkNvdW50ZWRBcnJheS5oCkBAIC01Nyw3ICs1NywyMCBAQCBwdWJsaWM6CiAg ICAgICAgIGlmIChtX2RhdGEpCiAgICAgICAgICAgICBIZWFkZXI6OmZyb21QYXlsb2FkKG1fZGF0 YSktPnJlZkNvdW50Kys7CiAgICAgfQotICAgIAorCisgICAgZXhwbGljaXQgUmVmQ291bnRlZEFy cmF5KHNpemVfdCBzaXplKQorICAgIHsKKyAgICAgICAgaWYgKCFzaXplKSB7CisgICAgICAgICAg ICBtX2RhdGEgPSAwOworICAgICAgICAgICAgcmV0dXJuOworICAgICAgICB9CisKKyAgICAgICAg bV9kYXRhID0gKHN0YXRpY19jYXN0PEhlYWRlcio+KGZhc3RNYWxsb2MoSGVhZGVyOjpzaXplKCkg KyBzaXplb2YoVCkgKiBzaXplKSkpLT5wYXlsb2FkKCk7CisgICAgICAgIEhlYWRlcjo6ZnJvbVBh eWxvYWQobV9kYXRhKS0+cmVmQ291bnQgPSAxOworICAgICAgICBIZWFkZXI6OmZyb21QYXlsb2Fk KG1fZGF0YSktPmxlbmd0aCA9IHNpemU7CisgICAgICAgIEFTU0VSVChIZWFkZXI6OmZyb21QYXls b2FkKG1fZGF0YSktPmxlbmd0aCA9PSBzaXplKTsKKyAgICB9CisKICAgICBleHBsaWNpdCBSZWZD b3VudGVkQXJyYXkoY29uc3QgVmVjdG9yPFQ+JiBvdGhlcikKICAgICB7CiAgICAgICAgIGlmIChv dGhlci5pc0VtcHR5KCkpIHsK 195029 2013-03-26 01:50:46 -0700 2013-03-26 13:35:49 -0700 Patch bug-113277-20130326214619.patch text/plain 1733 oliver U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ2ODQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDUxNzc0Nzk4MGJmMTQ2MDg5YzcxODM1 M2IxYmU2OTg5MTE2NjQzZmUuLjZhN2MxMTg2NzZjYWU3OGZkYjIzNmIyYjk5ZDYzOThmMTgyMzcw NWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTMtMDMtMjUgIE9saXZlciBIdW50ICA8b2xpdmVy QGFwcGxlLmNvbT4KKworICAgICAgICBSZWZDb3VudGVkQXJyYXkgbmVlZHMgYSBzaXplIGJhc2Vk IGNvbnN0cnVjdG9yCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMTMyNzcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBTaW1wbGUgcGF0Y2ggdG8gYWRkIGEgc2l6ZSBiYXNlZCBjb25zdHJ1Y3RvciBmb3IgUmVm Q291bnRlZEFycmF5CisgICAgICAgIHNvIHRoYXQgd2UgY2FuIGNyZWF0ZSBhbiBzaGFyYWJsZSBh cnJheSB3aXRob3V0IGEgY29weS4KKworICAgICAgICAqIHd0Zi9SZWZDb3VudGVkQXJyYXkuaDoK KyAgICAgICAgKFJlZkNvdW50ZWRBcnJheSk6CisgICAgICAgIChXVEY6OlJlZkNvdW50ZWRBcnJh eTo6UmVmQ291bnRlZEFycmF5KToKKwogMjAxMy0wMy0yNSAgS2VudCBUYW11cmEgIDx0a2VudEBj aHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmVuYW1lIEVOQUJMRV9JTlBVVF9UWVBFX0RBVEVUSU1F CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9SZWZDb3VudGVkQXJyYXkuaCBiL1NvdXJjZS9X VEYvd3RmL1JlZkNvdW50ZWRBcnJheS5oCmluZGV4IDI3NGFmOTg5NzA5YTJjZmJiZDY3MGZhZGZl ZTEwZTFiYjZmNmM4NmYuLmQxZWI4ZDUyNDk3ZGQ0M2NmZmU3ZTM4YmZiNDNjODcyOTFlZGUzMWIg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL1JlZkNvdW50ZWRBcnJheS5oCisrKyBiL1NvdXJj ZS9XVEYvd3RmL1JlZkNvdW50ZWRBcnJheS5oCkBAIC01Nyw3ICs1NywyMSBAQCBwdWJsaWM6CiAg ICAgICAgIGlmIChtX2RhdGEpCiAgICAgICAgICAgICBIZWFkZXI6OmZyb21QYXlsb2FkKG1fZGF0 YSktPnJlZkNvdW50Kys7CiAgICAgfQotICAgIAorCisgICAgZXhwbGljaXQgUmVmQ291bnRlZEFy cmF5KHNpemVfdCBzaXplKQorICAgIHsKKyAgICAgICAgaWYgKCFzaXplKSB7CisgICAgICAgICAg ICBtX2RhdGEgPSAwOworICAgICAgICAgICAgcmV0dXJuOworICAgICAgICB9CisKKyAgICAgICAg bV9kYXRhID0gKHN0YXRpY19jYXN0PEhlYWRlcio+KGZhc3RNYWxsb2MoSGVhZGVyOjpzaXplKCkg KyBzaXplb2YoVCkgKiBzaXplKSkpLT5wYXlsb2FkKCk7CisgICAgICAgIEhlYWRlcjo6ZnJvbVBh eWxvYWQobV9kYXRhKS0+cmVmQ291bnQgPSAxOworICAgICAgICBIZWFkZXI6OmZyb21QYXlsb2Fk KG1fZGF0YSktPmxlbmd0aCA9IHNpemU7CisgICAgICAgIEFTU0VSVChIZWFkZXI6OmZyb21QYXls b2FkKG1fZGF0YSktPmxlbmd0aCA9PSBzaXplKTsKKyAgICAgICAgVmVjdG9yVHlwZU9wZXJhdGlv bnM8VD46OmluaXRpYWxpemUoYmVnaW4oKSwgZW5kKCkpOworICAgIH0KKwogICAgIGV4cGxpY2l0 IFJlZkNvdW50ZWRBcnJheShjb25zdCBWZWN0b3I8VD4mIG90aGVyKQogICAgIHsKICAgICAgICAg aWYgKG90aGVyLmlzRW1wdHkoKSkgewo=