113264 2013-03-25 19:15:04 -0700 Rename HTMLInputElement::isIndeterminate to Element::shouldAppearIndeterminate 2013-03-26 01:28:38 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tkent tkent aboxhall allan.jensen apinheiro cfleizach cmarcelo dmazzoni eric esprehn+autocc haraken jdiggs macpherson menard mifenton morrita ojan.autocc webkit.review.bot oldest_to_newest 863272 0 tkent 2013-03-25 19:15:04 -0700 HTMLInputElement has indeterminate() and isIndeterminate(). It's super confusing. 863277 1 194981 tkent 2013-03-25 19:25:35 -0700 Created attachment 194981 Patch 863369 2 194981 haraken 2013-03-25 22:32:18 -0700 Comment on attachment 194981 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=194981&action=review > Source/WebCore/html/HTMLProgressElement.cpp:173 > + return !isDeterminate(); As far as I see the removed code in SelectorChecker.cpp, it looks like that isDeterminate() is a negation of isIndeterminate(). In this patch, isIndeterminate() is remaned to shouldAppearIndeterminate(). Then, don't you want to rename isDeterminate() to something consistent as well (e.g. shouldAppearDeterminate()) ? 863381 3 194981 tkent 2013-03-25 22:54:59 -0700 Comment on attachment 194981 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=194981&action=review >> Source/WebCore/html/HTMLProgressElement.cpp:173 >> + return !isDeterminate(); > > As far as I see the removed code in SelectorChecker.cpp, it looks like that isDeterminate() is a negation of isIndeterminate(). In this patch, isIndeterminate() is remaned to shouldAppearIndeterminate(). Then, don't you want to rename isDeterminate() to something consistent as well (e.g. shouldAppearDeterminate()) ? I understand you think it's inconsistent, however I feel it's not inconsistent because their roles are different. shouldAppearDeterminate is a hook for CSS selector matching, isDeterminate represents "determinate" concept in the standard and it is just for HTMLProgressElement. 863392 4 194981 haraken 2013-03-25 23:24:11 -0700 Comment on attachment 194981 Patch Makes sense. Thanks for the clarification. 863451 5 194981 webkit.review.bot 2013-03-26 01:28:34 -0700 Comment on attachment 194981 Patch Clearing flags on attachment: 194981 Committed r146860: <http://trac.webkit.org/changeset/146860> 863452 6 webkit.review.bot 2013-03-26 01:28:38 -0700 All reviewed patches have been landed. Closing bug. 194981 2013-03-25 19:25:35 -0700 2013-03-26 01:28:34 -0700 Patch bug-113264-20130326112118.patch text/plain 9836 tkent U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ2ODM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWM5Yjc1ZGNjOWU3MmI3 YTNmODgzNzExZWI2ODRhMWM4ODdlZmQ2OC4uZjliY2QyYjBlMmI3NGZkZWVkZTA2YjJjYjQ1ZTg0 MGNkMjI4ODUxMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDQ1IEBACisyMDEzLTAzLTI1ICBLZW50 IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZW5hbWUgSFRNTElucHV0 RWxlbWVudDo6aXNJbmRldGVybWluYXRlIHRvIEVsZW1lbnQ6OnNob3VsZEFwcGVhckluZGV0ZXJt aW5hdGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEx MzI2NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEhU TUxJbnB1dEVsZW1lbnQgaGFkIGluZGV0ZXJtaW5hdGUoKSBhbmQgaXNJbmRldGVybWluYXRlKCku IEl0J3MgdmVyeQorICAgICAgICBjb25mdXNpbmcuCisKKyAgICAgICAgQmVjYXVzZSBpbmRldGVy bWluYXRlIGlzIGEgcHVibGljIERPTSBmdW5jdGlvbiBhbmQgaXNJbmRldGVybWluYXRlIGlzCisg ICAgICAgIGZvciBDU1MgYW5kIHJlbmRlcmluZywgd2UgcmVuYW1lIGlzSW5kZXRlcm1pYW50ZSB0 bworICAgICAgICBzaG91bGRBcHBlYXJJbmRldGVybWluYXRlLiBBbHNvLCBIVE1MUHJvZ3Jlc3NF bGVtZW50LCB3aGljaCBzdXBwb3J0CisgICAgICAgIDppbmRldGVybWluYXRlIHBzZXVkbyBjbGFz cywgc2hvdWxkIGZvbGxvdyBpdC4gV2UgYWRkCisgICAgICAgIHNob3VsZEFwcGVhckluZGV0ZXJt aW5hdGUgdG8gRWxlbWVudC4KKworICAgICAgICBObyBuZXcgdGVzdHMuIEp1c3QgYSByZWZhY3Rv cmluZy4KKworICAgICAgICAqIGRvbS9FbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkVs ZW1lbnQ6OnNob3VsZEFwcGVhckluZGV0ZXJtaW5hdGUpOiBBZGRlZC4gUmV0dXJucyBmYWxzZS4K KyAgICAgICAgKiBkb20vRWxlbWVudC5oOgorICAgICAgICAoRWxlbWVudCk6IERlY2xhcmUgc2hv dWxkQXBwZWFySW5kZXRlcm1pbmF0ZS4KKyAgICAgICAgKiBodG1sL0hUTUxJbnB1dEVsZW1lbnQu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTElucHV0RWxlbWVudDo6c2hvdWxkQXBwZWFySW5k ZXRlcm1pbmF0ZSk6CisgICAgICAgIFJlbmFtZWQgZnJvbSBpc0luZGV0ZXJtaW5hdGUuCisgICAg ICAgICogaHRtbC9IVE1MSW5wdXRFbGVtZW50Lmg6CisgICAgICAgIChIVE1MSW5wdXRFbGVtZW50 KTogUmVuYW1lIGlzSW5kZXRlcm1pbmF0ZSB0byBzaG91bGRBcHBlYXJJbmRldGVybWluYXRlLAor ICAgICAgICBhbmQgb3ZlcnJpZGVzIEVsZW1lbnQ6OnNob3VsZEFwcGVhckluZGV0ZXJtaW5hdGUu CisgICAgICAgICogaHRtbC9IVE1MUHJvZ3Jlc3NFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OkhUTUxQcm9ncmVzc0VsZW1lbnQ6OnNob3VsZEFwcGVhckluZGV0ZXJtaW5hdGUpOiBBZGRl ZC4KKyAgICAgICAgKiBodG1sL0hUTUxQcm9ncmVzc0VsZW1lbnQuaDogQWRkIHNob3VsZEFwcGVh ckluZGV0ZXJtaW5hdGUuCisKKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlO b2RlT2JqZWN0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkFjY2Vzc2liaWxpdHlOb2RlT2JqZWN0 Ojppc0luZGV0ZXJtaW5hdGUpOgorICAgICAgICBVc2Ugc2hvdWxkQXBwZWFySW5kZXRlcm1pbmF0 ZS4KKyAgICAgICAgKiBjc3MvU2VsZWN0b3JDaGVja2VyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OlNlbGVjdG9yQ2hlY2tlcjo6Y2hlY2tPbmUpOiBEaXR0by4KKyAgICAgICAgKiBjc3MvU3R5bGVS ZXNvbHZlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTdHlsZVJlc29sdmVyOjpjYW5TaGFyZVN0 eWxlV2l0aENvbnRyb2wpOiBEaXR0by4KKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyVGhlbWUu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVGhlbWU6OmlzSW5kZXRlcm1pbmF0ZSk6IERp dHRvLgorCiAyMDEzLTAzLTI1ICBUb255IENoYW5nICA8dG9ueUBjaHJvbWl1bS5vcmc+CiAKICAg ICAgICAgSW1hZ2UgYWx0IHRleHQgbm90IGluY2x1ZGVkIGluIHBsYWluLXRleHQgdmVyc2lvbiB3 aGVuIGNvcHlpbmcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNj ZXNzaWJpbGl0eU5vZGVPYmplY3QuY3BwIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9B Y2Nlc3NpYmlsaXR5Tm9kZU9iamVjdC5jcHAKaW5kZXggYTVjNmYxMTg5ODhkYzg0MDRkNGQzNWYz MjZiMjM1MjAxOWMzYmNkNy4uM2Q2ZTQzMjMwYTJmZDRlYjllZDJkNWQxZTEyZDQzNGM2YmU1Nzc1 NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5 Tm9kZU9iamVjdC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3Np YmlsaXR5Tm9kZU9iamVjdC5jcHAKQEAgLTYxMSw3ICs2MTEsNyBAQCBib29sIEFjY2Vzc2liaWxp dHlOb2RlT2JqZWN0Ojppc0luZGV0ZXJtaW5hdGUoKSBjb25zdAogICAgIGlmICghaW5wdXRFbGVt ZW50KQogICAgICAgICByZXR1cm4gZmFsc2U7CiAKLSAgICByZXR1cm4gaW5wdXRFbGVtZW50LT5p c0luZGV0ZXJtaW5hdGUoKTsKKyAgICByZXR1cm4gaW5wdXRFbGVtZW50LT5zaG91bGRBcHBlYXJJ bmRldGVybWluYXRlKCk7CiB9CiAKIGJvb2wgQWNjZXNzaWJpbGl0eU5vZGVPYmplY3Q6OmlzUHJl c3NlZCgpIGNvbnN0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvU2VsZWN0b3JDaGVj a2VyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9TZWxlY3RvckNoZWNrZXIuY3BwCmluZGV4IGY1 NDgzYjBlODY4NjgwYzBmNTk3YmYwOTBmNDQ3ODdkOWQ0YThkYjkuLjBiM2VkZjNhOWRjMGRlNzA5 MGJmZjY2MDMwN2JmYzc3ZGZkZjlhNzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9T ZWxlY3RvckNoZWNrZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9TZWxlY3RvckNoZWNr ZXIuY3BwCkBAIC02NDQsMjkgKzY0NCwxNCBAQCBib29sIFNlbGVjdG9yQ2hlY2tlcjo6Y2hlY2tP bmUoY29uc3QgU2VsZWN0b3JDaGVja2luZ0NvbnRleHQmIGNvbnRleHQsIGNvbnN0IFNpYgogICAg ICAgICAgICAgICAgIC8vIHlvdSBjYW4ndCBiZSBib3RoIGNoZWNrZWQgYW5kIGluZGV0ZXJtaW5h dGUuIFdlIHdpbGwgYmVoYXZlIGxpa2UgV2luSUUgYmVoaW5kIHRoZSBzY2VuZXMgYW5kIGp1c3QK ICAgICAgICAgICAgICAgICAvLyBvYmV5IHRoZSBDU1Mgc3BlYyBoZXJlIGluIHRoZSB0ZXN0IGZv ciBtYXRjaGluZyB0aGUgcHNldWRvLgogICAgICAgICAgICAgICAgIEhUTUxJbnB1dEVsZW1lbnQq IGlucHV0RWxlbWVudCA9IGVsZW1lbnQtPnRvSW5wdXRFbGVtZW50KCk7Ci0gICAgICAgICAgICAg ICAgaWYgKGlucHV0RWxlbWVudCAmJiBpbnB1dEVsZW1lbnQtPnNob3VsZEFwcGVhckNoZWNrZWQo KSAmJiAhaW5wdXRFbGVtZW50LT5pc0luZGV0ZXJtaW5hdGUoKSkKKyAgICAgICAgICAgICAgICBp ZiAoaW5wdXRFbGVtZW50ICYmIGlucHV0RWxlbWVudC0+c2hvdWxkQXBwZWFyQ2hlY2tlZCgpICYm ICFpbnB1dEVsZW1lbnQtPnNob3VsZEFwcGVhckluZGV0ZXJtaW5hdGUoKSkKICAgICAgICAgICAg ICAgICAgICAgcmV0dXJuIHRydWU7CiAgICAgICAgICAgICAgICAgaWYgKGVsZW1lbnQtPmhhc1Rh Z05hbWUob3B0aW9uVGFnKSAmJiB0b0hUTUxPcHRpb25FbGVtZW50KGVsZW1lbnQpLT5zZWxlY3Rl ZCgpKQogICAgICAgICAgICAgICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICAgICAgICAgICAgICBi cmVhazsKICAgICAgICAgICAgIH0KICAgICAgICAgY2FzZSBDU1NTZWxlY3Rvcjo6UHNldWRvSW5k ZXRlcm1pbmF0ZToKLSAgICAgICAgICAgIHsKLSAgICAgICAgICAgICAgICBpZiAoIWVsZW1lbnQp Ci0gICAgICAgICAgICAgICAgICAgIGJyZWFrOwotI2lmIEVOQUJMRShQUk9HUkVTU19FTEVNRU5U KQotICAgICAgICAgICAgICAgIGlmIChlbGVtZW50LT5oYXNUYWdOYW1lKHByb2dyZXNzVGFnKSkg ewotICAgICAgICAgICAgICAgICAgICBIVE1MUHJvZ3Jlc3NFbGVtZW50KiBwcm9ncmVzcyA9IHRv SFRNTFByb2dyZXNzRWxlbWVudChlbGVtZW50KTsKLSAgICAgICAgICAgICAgICAgICAgaWYgKHBy b2dyZXNzICYmICFwcm9ncmVzcy0+aXNEZXRlcm1pbmF0ZSgpKQotICAgICAgICAgICAgICAgICAg ICAgICAgcmV0dXJuIHRydWU7Ci0gICAgICAgICAgICAgICAgICAgIGJyZWFrOwotICAgICAgICAg ICAgICAgIH0KLSNlbmRpZgotICAgICAgICAgICAgICAgIEhUTUxJbnB1dEVsZW1lbnQqIGlucHV0 RWxlbWVudCA9IGVsZW1lbnQtPnRvSW5wdXRFbGVtZW50KCk7Ci0gICAgICAgICAgICAgICAgaWYg KGlucHV0RWxlbWVudCAmJiBpbnB1dEVsZW1lbnQtPmlzSW5kZXRlcm1pbmF0ZSgpKQotICAgICAg ICAgICAgICAgICAgICByZXR1cm4gdHJ1ZTsKLSAgICAgICAgICAgICAgICBicmVhazsKLSAgICAg ICAgICAgIH0KKyAgICAgICAgICAgIHJldHVybiBlbGVtZW50ICYmIGVsZW1lbnQtPnNob3VsZEFw cGVhckluZGV0ZXJtaW5hdGUoKTsKICAgICAgICAgY2FzZSBDU1NTZWxlY3Rvcjo6UHNldWRvUm9v dDoKICAgICAgICAgICAgIGlmIChlbGVtZW50ID09IGVsZW1lbnQtPmRvY3VtZW50KCktPmRvY3Vt ZW50RWxlbWVudCgpKQogICAgICAgICAgICAgICAgIHJldHVybiB0cnVlOwpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvY3NzL1N0eWxlUmVzb2x2ZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvY3Nz L1N0eWxlUmVzb2x2ZXIuY3BwCmluZGV4IGI4ODc0N2VlMTg2NzU2ZDIxOTE0ZmRmNDE1YTQzNjU5 MTE3MTA3ZTMuLjZkNDA1MzE3NjY4OWM1ZjYwZDc1YWM2NDY1NTU3NDkzNDlmY2VhNjUgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9TdHlsZVJlc29sdmVyLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9jc3MvU3R5bGVSZXNvbHZlci5jcHAKQEAgLTU0Myw3ICs1NDMsNyBAQCBib29sIFN0 eWxlUmVzb2x2ZXI6OmNhblNoYXJlU3R5bGVXaXRoQ29udHJvbChTdHlsZWRFbGVtZW50KiBlbGVt ZW50KSBjb25zdAogICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgaWYgKHRoaXNJbnB1dEVsZW1l bnQtPnNob3VsZEFwcGVhckNoZWNrZWQoKSAhPSBvdGhlcklucHV0RWxlbWVudC0+c2hvdWxkQXBw ZWFyQ2hlY2tlZCgpKQogICAgICAgICByZXR1cm4gZmFsc2U7Ci0gICAgaWYgKHRoaXNJbnB1dEVs ZW1lbnQtPmlzSW5kZXRlcm1pbmF0ZSgpICE9IG90aGVySW5wdXRFbGVtZW50LT5pc0luZGV0ZXJt aW5hdGUoKSkKKyAgICBpZiAodGhpc0lucHV0RWxlbWVudC0+c2hvdWxkQXBwZWFySW5kZXRlcm1p bmF0ZSgpICE9IG90aGVySW5wdXRFbGVtZW50LT5zaG91bGRBcHBlYXJJbmRldGVybWluYXRlKCkp CiAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICBpZiAodGhpc0lucHV0RWxlbWVudC0+aXNSZXF1 aXJlZCgpICE9IG90aGVySW5wdXRFbGVtZW50LT5pc1JlcXVpcmVkKCkpCiAgICAgICAgIHJldHVy biBmYWxzZTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmNwcCBiL1Nv dXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmNwcAppbmRleCA0YTE3MjEyNzg1YzUyNTQ1NjE1NDA1 Nzc0ZmIxNTRmNWY1YTk2OWFjLi43MGE3MTBhODhkMjZhMDM2MjY1NjM0YjVlZjkwMTBiNmE1MGIw ODQyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuY3BwCkBAIC0yMzgyLDYgKzIzODIsMTEgQEAgYm9vbCBF bGVtZW50Ojp3ZWJraXRNYXRjaGVzU2VsZWN0b3IoY29uc3QgU3RyaW5nJiBzZWxlY3RvciwgRXhj ZXB0aW9uQ29kZSYgZWMpCiAgICAgcmV0dXJuIHNlbGVjdG9yUXVlcnktPm1hdGNoZXModGhpcyk7 CiB9CiAKK2Jvb2wgRWxlbWVudDo6c2hvdWxkQXBwZWFySW5kZXRlcm1pbmF0ZSgpIGNvbnN0Cit7 CisgICAgcmV0dXJuIGZhbHNlOworfQorCiBET01Ub2tlbkxpc3QqIEVsZW1lbnQ6OmNsYXNzTGlz dCgpCiB7CiAgICAgRWxlbWVudFJhcmVEYXRhKiBkYXRhID0gZW5zdXJlRWxlbWVudFJhcmVEYXRh KCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5oIGIvU291cmNlL1dl YkNvcmUvZG9tL0VsZW1lbnQuaAppbmRleCBmNDg3MGQwYmQ4Mjc4NjM0MTNjMTEwMGU2ZjZlNGI0 ZDM5MGVlMzIzLi4wZGE2YmQyMzY0MDkyNmZiM2I5YTBjMjM0NmYxMDI2YjJhZWQ3ODMzIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5oCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2RvbS9FbGVtZW50LmgKQEAgLTUxMyw2ICs1MTMsNyBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCBi b29sIG1hdGNoZXNSZWFkT25seVBzZXVkb0NsYXNzKCkgY29uc3Q7CiAgICAgdmlydHVhbCBib29s IG1hdGNoZXNSZWFkV3JpdGVQc2V1ZG9DbGFzcygpIGNvbnN0OwogICAgIGJvb2wgd2Via2l0TWF0 Y2hlc1NlbGVjdG9yKGNvbnN0IFN0cmluZyYgc2VsZWN0b3JzLCBFeGNlcHRpb25Db2RlJik7Cisg ICAgdmlydHVhbCBib29sIHNob3VsZEFwcGVhckluZGV0ZXJtaW5hdGUoKSBjb25zdDsKIAogICAg IERPTVRva2VuTGlzdCogY2xhc3NMaXN0KCk7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2h0bWwvSFRNTElucHV0RWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxJbnB1 dEVsZW1lbnQuY3BwCmluZGV4IGNkNWNmMDk0NTdkODYwMmY2MjE4MjAyNTYxNjUxOTA1NDFhNmE2 MzMuLjZiYjQ5ZDQxOTAwYTY1ZTE5YTJlZTUzYzc0N2JmODlkYjNlYTQyNmEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvaHRtbC9IVE1MSW5wdXRFbGVtZW50LmNwcApAQCAtMTc5Nyw3ICsxNzk3LDcgQEAgU3Ry aW5nIEhUTUxJbnB1dEVsZW1lbnQ6OmRlZmF1bHRUb29sVGlwKCkgY29uc3QKICAgICByZXR1cm4g bV9pbnB1dFR5cGUtPmRlZmF1bHRUb29sVGlwKCk7CiB9CiAKLWJvb2wgSFRNTElucHV0RWxlbWVu dDo6aXNJbmRldGVybWluYXRlKCkgY29uc3QgCitib29sIEhUTUxJbnB1dEVsZW1lbnQ6OnNob3Vs ZEFwcGVhckluZGV0ZXJtaW5hdGUoKSBjb25zdCAKIHsKICAgICByZXR1cm4gbV9pbnB1dFR5cGUt PnN1cHBvcnRzSW5kZXRlcm1pbmF0ZUFwcGVhcmFuY2UoKSAmJiBpbmRldGVybWluYXRlKCk7CiB9 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxJbnB1dEVsZW1lbnQuaCBiL1Nv dXJjZS9XZWJDb3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5oCmluZGV4IGM5M2E4ZjhmZTMyY2Uw ZWVhYjM1MTkwZTIzNmIzY2NmYjc0YmM0NDguLjgzNmY5YzcxOWE5ZDRmYzNmZDkwZDc5NWU1ZmUz NDMxOGU0OTU4OGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTElucHV0RWxl bWVudC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5oCkBAIC0x NDYsNyArMTQ2LDcgQEAgcHVibGljOgogICAgIHZvaWQgc2V0SW5kZXRlcm1pbmF0ZShib29sKTsK ICAgICAvLyBzaG91bGRBcHBlYXJDaGVja2VkIGlzIHVzZWQgYnkgdGhlIHJlbmRlcmluZyB0cmVl L0NTUyB3aGlsZSBjaGVja2VkKCkgaXMgdXNlZCBieSBKUyB0byBkZXRlcm1pbmUgY2hlY2tlZCBz dGF0ZQogICAgIGJvb2wgc2hvdWxkQXBwZWFyQ2hlY2tlZCgpIGNvbnN0OwotICAgIHZpcnR1YWwg Ym9vbCBpc0luZGV0ZXJtaW5hdGUoKSBjb25zdDsKKyAgICB2aXJ0dWFsIGJvb2wgc2hvdWxkQXBw ZWFySW5kZXRlcm1pbmF0ZSgpIGNvbnN0IE9WRVJSSURFOwogCiAgICAgaW50IHNpemUoKSBjb25z dDsKICAgICBib29sIHNpemVTaG91bGRJbmNsdWRlRGVjb3JhdGlvbihpbnQmIHByZWZlcnJlZFNp emUpIGNvbnN0OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MUHJvZ3Jlc3NF bGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFByb2dyZXNzRWxlbWVudC5jcHAK aW5kZXggMzQwOWE4ZTIyZDZkOGI4ODhiYjUwZThiZmZiNTZhYWY3YWQzODFhNC4uNTNlZjI1Mjk5 NGIzOThmYmM5NzIxOTYwZTRiNWZlNWE1Y2NmZDg5NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvaHRtbC9IVE1MUHJvZ3Jlc3NFbGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1s L0hUTUxQcm9ncmVzc0VsZW1lbnQuY3BwCkBAIC0xNjgsNSArMTY4LDEwIEBAIHZvaWQgSFRNTFBy b2dyZXNzRWxlbWVudDo6ZGlkQWRkVXNlckFnZW50U2hhZG93Um9vdChTaGFkb3dSb290KiByb290 KQogICAgIGlubmVyLT5hcHBlbmRDaGlsZChiYXIsIEFTU0VSVF9OT19FWENFUFRJT04pOwogfQog Citib29sIEhUTUxQcm9ncmVzc0VsZW1lbnQ6OnNob3VsZEFwcGVhckluZGV0ZXJtaW5hdGUoKSBj b25zdAoreworICAgIHJldHVybiAhaXNEZXRlcm1pbmF0ZSgpOworfQorCiB9IC8vIG5hbWVzcGFj ZQogI2VuZGlmCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxQcm9ncmVzc0Vs ZW1lbnQuaCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFByb2dyZXNzRWxlbWVudC5oCmluZGV4 IDEyOTBhMDFhYzFkZmY4N2JjNGZkMjVhMjYyYTEyYjRkMjM0MWZiNTYuLmI3YzM5MGQ2OWQ2NTRk MGQ4NzZjZWQyMjZmOTBkODEwYWY0MzYzNDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0 bWwvSFRNTFByb2dyZXNzRWxlbWVudC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFBy b2dyZXNzRWxlbWVudC5oCkBAIC01Myw3ICs1Myw3IEBAIHByaXZhdGU6CiAgICAgdmlydHVhbCB+ SFRNTFByb2dyZXNzRWxlbWVudCgpOwogCiAgICAgdmlydHVhbCBib29sIGFyZUF1dGhvclNoYWRv d3NBbGxvd2VkKCkgY29uc3QgT1ZFUlJJREUgeyByZXR1cm4gZmFsc2U7IH0KLQorICAgIHZpcnR1 YWwgYm9vbCBzaG91bGRBcHBlYXJJbmRldGVybWluYXRlKCkgY29uc3QgT1ZFUlJJREU7CiAgICAg dmlydHVhbCBib29sIHN1cHBvcnRMYWJlbHMoKSBjb25zdCBPVkVSUklERSB7IHJldHVybiB0cnVl OyB9CiAKICAgICB2aXJ0dWFsIFJlbmRlck9iamVjdCogY3JlYXRlUmVuZGVyZXIoUmVuZGVyQXJl bmEqLCBSZW5kZXJTdHlsZSopOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlclRoZW1lLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZS5j cHAKaW5kZXggOTVmNjllNWEwZWUzZGUxMWQ0ZDlhYjAzZjQ4ZDhiOTUwMmZkNjg5MS4uZTQ1ZGUx NTc0MDIzYzYwNGE2MzQ1Nzc3NzUxZjFmMGMxZjA5NzVjZiAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyVGhlbWUuY3BwCkBAIC03ODAsNyArNzgwLDcgQEAgYm9vbCBSZW5kZXJUaGVt ZTo6aXNJbmRldGVybWluYXRlKGNvbnN0IFJlbmRlck9iamVjdCogbykgY29uc3QKICAgICBpZiAo IWlucHV0RWxlbWVudCkKICAgICAgICAgcmV0dXJuIGZhbHNlOwogCi0gICAgcmV0dXJuIGlucHV0 RWxlbWVudC0+aXNJbmRldGVybWluYXRlKCk7CisgICAgcmV0dXJuIGlucHV0RWxlbWVudC0+c2hv dWxkQXBwZWFySW5kZXRlcm1pbmF0ZSgpOwogfQogCiBib29sIFJlbmRlclRoZW1lOjppc0VuYWJs ZWQoY29uc3QgUmVuZGVyT2JqZWN0KiBvKSBjb25zdAo=