113261 2013-03-25 18:33:47 -0700 REGRESSION(r146657): NRWT shouldn't report image only failures when pixel tests are disabled 2013-03-25 20:21:27 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rniwa rniwa dpranke ojan ossy oldest_to_newest 863247 0 rniwa 2013-03-25 18:33:47 -0700 When a test failed flakily, we don't want to treat it as a failure or a flaky test even if the test failed with image only failure in retries. 863248 1 rniwa 2013-03-25 18:34:19 -0700 This bug was observed on http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK2%20(Tests)/r146827%20(7291)/results.html where a bunch of editing/unsupported-content/ tests were reported as failing even though they only had image only failures. 863271 2 194978 rniwa 2013-03-25 19:13:15 -0700 Created attachment 194978 Fixes the bug 863274 3 194980 rniwa 2013-03-25 19:16:54 -0700 Created attachment 194980 Rebaselined the test 863313 4 rniwa 2013-03-25 20:21:27 -0700 Committed r146846: <http://trac.webkit.org/changeset/146846> 194978 2013-03-25 19:13:15 -0700 2013-03-25 19:16:52 -0700 Fixes the bug bug-113261-20130325190903.patch text/plain 2575 rniwa SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDE0NjgzOCkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEzLTAzLTI1ICBSeW9zdWtlIE5pd2EgIDxy bml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFJFR1JFU1NJT04ocjE0NjY1Nyk6IE5SV1Qgc2hv dWxkbid0IHJlcG9ydCBpbWFnZSBvbmx5IGZhaWx1cmVzIHdoZW4gcGl4ZWwgdGVzdHMgYXJlIGRp c2FibGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MTMyNjEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBG aXhlZCB0aGUgYnVnIGJ5IHRyZWF0aW5nIFsnVEVYVCcsICdJTUFHRSddIGFzIGEgZmxha3kgcGFz cyB3aGVuIHRoZSBwaXhlbCB0ZXN0cyBpcyBkaXNhYmxlZAorICAgICAgICBzaW5jZSB0aGUgc2Vj b25kIHRva2VuIGltcGxpZXMgdGhhdCB3ZSd2ZSBmb3JjZWQgcGl4ZWwgdGVzdHMgaW4gcmV0cnkg YW5kIGRpZG4ndCBoYXZlIHRleHQgZmFpbHVyZXMuCisKKyAgICAgICAgKiBmYXN0L2hhcm5lc3Mv cmVzb3VyY2VzL3Jlc3VsdHMtdGVzdC5qczoKKyAgICAgICAgKiBmYXN0L2hhcm5lc3MvcmVzdWx0 cy5odG1sOgorCiAyMDEzLTAzLTI1ICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdt YWlsLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTQ2ODE2LCByMTQ2 ODIxLCBhbmQgcjE0NjgzMC4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvaGFybmVzcy9yZXN1bHRz Lmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9oYXJuZXNzL3Jlc3VsdHMuaHRt bAkocmV2aXNpb24gMTQ2ODE2KQorKysgTGF5b3V0VGVzdHMvZmFzdC9oYXJuZXNzL3Jlc3VsdHMu aHRtbAkod29ya2luZyBjb3B5KQpAQCAtNTA2LDcgKzUwNiw5IEBAIGZ1bmN0aW9uIHByb2Nlc3NH bG9iYWxTdGF0ZUZvcih0ZXN0T2JqZWMKICAgICAgICAgcmV0dXJuOwogICAgIH0KIAotICAgIGlm IChhY3R1YWwuaW5kZXhPZignICcpICE9IC0xICYmIGFjdHVhbC5pbmRleE9mKCdQQVNTJykgIT0g LTEpIHsKKyAgICB2YXIgYWN0dWFsVG9rZW5zID0gYWN0dWFsLnNwbGl0KCcgJyk7CisgICAgdmFy IHBhc3NlZFdpdGhJbWFnZU9ubHlGYWlsdXJlSW5SZXRyeSA9IGFjdHVhbFRva2Vuc1swXSA9PSAn VEVYVCcgJiYgYWN0dWFsVG9rZW5zWzFdID09ICdJTUFHRSc7CisgICAgaWYgKGFjdHVhbC5pbmRl eE9mKCcgJykgIT0gLTEgJiYgYWN0dWFsLmluZGV4T2YoJ1BBU1MnKSAhPSAtMSB8fCAoIWdsb2Jh bFN0YXRlKCkucmVzdWx0cy5waXhlbF90ZXN0c19lbmFibGVkICYmIHBhc3NlZFdpdGhJbWFnZU9u bHlGYWlsdXJlSW5SZXRyeSkpIHsKICAgICAgICAgZ2xvYmFsU3RhdGUoKS5mbGFreVBhc3NUZXN0 cy5wdXNoKHRlc3RPYmplY3QpOwogICAgICAgICByZXR1cm47CiAgICAgfQpJbmRleDogTGF5b3V0 VGVzdHMvZmFzdC9oYXJuZXNzL3Jlc291cmNlcy9yZXN1bHRzLXRlc3QuanMKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gTGF5b3V0VGVzdHMvZmFzdC9oYXJuZXNzL3Jlc291cmNlcy9yZXN1bHRzLXRlc3QuanMJKHJl dmlzaW9uIDE0NjgxNikKKysrIExheW91dFRlc3RzL2Zhc3QvaGFybmVzcy9yZXNvdXJjZXMvcmVz dWx0cy10ZXN0LmpzCSh3b3JraW5nIGNvcHkpCkBAIC03NzksNiArNzc5LDE0IEBAIGZ1bmN0aW9u IHJ1blRlc3RzKCkKICAgICAgICAgYXNzZXJ0VHJ1ZShkb2N1bWVudC5xdWVyeVNlbGVjdG9yKCd0 Ym9keSB0ZDpudGgtY2hpbGQoMykgYScpLmdldEF0dHJpYnV0ZSgnaHJlZicpID09ICdyZXRyaWVz L2Zvby9iYXItaW1hZ2UtZGlmZnMuaHRtbCcpOwogICAgIH0pOwogCisgICAgcmVzdWx0cyA9IG1v Y2tSZXN1bHRzKCk7CisgICAgcmVzdWx0cy50ZXN0c1snZm9vL2Jhci1pbWFnZS5odG1sJ10gPSBt b2NrRXhwZWN0YXRpb24oJ1BBU1MnLCAnVEVYVCBJTUFHRScpOworICAgIHJlc3VsdHMucGl4ZWxf dGVzdHNfZW5hYmxlZCA9IGZhbHNlOworICAgIHJ1blRlc3QocmVzdWx0cywgZnVuY3Rpb24oKSB7 CisgICAgICAgIGFzc2VydFRydWUoIWRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdyZXN1bHRzLXRh YmxlJykpOworICAgICAgICBhc3NlcnRUcnVlKGRvY3VtZW50LnF1ZXJ5U2VsZWN0b3IoJyNmbGFr eS10ZXN0cy10YWJsZSB0ZDpudGgtY2hpbGQoMykgYScpLmdldEF0dHJpYnV0ZSgnaHJlZicpID09 ICdyZXRyaWVzL2Zvby9iYXItaW1hZ2UtZGlmZnMuaHRtbCcpOworICAgIH0pOworCiAgICAgZG9j dW1lbnQuYm9keS5pbm5lckhUTUwgPSAnPHByZT4nICsgZ19sb2cuam9pbignXG4nKSArICc8L3By ZT4nOwogfQogCg== 194980 2013-03-25 19:16:54 -0700 2013-03-25 19:27:23 -0700 Rebaselined the test bug-113261-20130325191243.patch text/plain 2974 rniwa SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDE0NjgzOCkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEzLTAzLTI1ICBSeW9zdWtlIE5pd2EgIDxy bml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFJFR1JFU1NJT04ocjE0NjY1Nyk6IE5SV1Qgc2hv dWxkbid0IHJlcG9ydCBpbWFnZSBvbmx5IGZhaWx1cmVzIHdoZW4gcGl4ZWwgdGVzdHMgYXJlIGRp c2FibGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MTMyNjEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBG aXhlZCB0aGUgYnVnIGJ5IHRyZWF0aW5nIFsnVEVYVCcsICdJTUFHRSddIGFzIGEgZmxha3kgcGFz cyB3aGVuIHRoZSBwaXhlbCB0ZXN0cyBpcyBkaXNhYmxlZAorICAgICAgICBzaW5jZSB0aGUgc2Vj b25kIHRva2VuIGltcGxpZXMgdGhhdCB3ZSd2ZSBmb3JjZWQgcGl4ZWwgdGVzdHMgaW4gcmV0cnkg YW5kIGRpZG4ndCBoYXZlIHRleHQgZmFpbHVyZXMuCisKKyAgICAgICAgKiBmYXN0L2hhcm5lc3Mv cmVzb3VyY2VzL3Jlc3VsdHMtdGVzdC5qczoKKyAgICAgICAgKiBmYXN0L2hhcm5lc3MvcmVzdWx0 cy5odG1sOgorICAgICAgICAqIGZhc3QvaGFybmVzcy9yZXN1bHRzLWV4cGVjdGVkLnR4dDoKKwog MjAxMy0wMy0yNSAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CiAK ICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjE0NjgxNiwgcjE0NjgyMSwgYW5kIHIx NDY4MzAuCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2hhcm5lc3MvcmVzdWx0cy1leHBlY3RlZC50 eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9oYXJuZXNzL3Jlc3VsdHMtZXhwZWN0 ZWQudHh0CShyZXZpc2lvbiAxNDY4MTYpCisrKyBMYXlvdXRUZXN0cy9mYXN0L2hhcm5lc3MvcmVz dWx0cy1leHBlY3RlZC50eHQJKHdvcmtpbmcgY29weSkKQEAgLTI1MiwzICsyNTIsNSBAQCBURVNU LTQ1OiBQQVNTCiBURVNULTQ1OiBQQVNTCiBURVNULTQ1OiBQQVNTCiBURVNULTQ2OiBQQVNTCitU RVNULTQ3OiBQQVNTCitURVNULTQ3OiBQQVNTCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2hhcm5l c3MvcmVzdWx0cy5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvaGFybmVzcy9y ZXN1bHRzLmh0bWwJKHJldmlzaW9uIDE0NjgxNikKKysrIExheW91dFRlc3RzL2Zhc3QvaGFybmVz cy9yZXN1bHRzLmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTUwNiw3ICs1MDYsOSBAQCBmdW5jdGlv biBwcm9jZXNzR2xvYmFsU3RhdGVGb3IodGVzdE9iamVjCiAgICAgICAgIHJldHVybjsKICAgICB9 CiAKLSAgICBpZiAoYWN0dWFsLmluZGV4T2YoJyAnKSAhPSAtMSAmJiBhY3R1YWwuaW5kZXhPZign UEFTUycpICE9IC0xKSB7CisgICAgdmFyIGFjdHVhbFRva2VucyA9IGFjdHVhbC5zcGxpdCgnICcp OworICAgIHZhciBwYXNzZWRXaXRoSW1hZ2VPbmx5RmFpbHVyZUluUmV0cnkgPSBhY3R1YWxUb2tl bnNbMF0gPT0gJ1RFWFQnICYmIGFjdHVhbFRva2Vuc1sxXSA9PSAnSU1BR0UnOworICAgIGlmIChh Y3R1YWxUb2tlbnNbMV0gJiYgYWN0dWFsLmluZGV4T2YoJ1BBU1MnKSAhPSAtMSB8fCAoIWdsb2Jh bFN0YXRlKCkucmVzdWx0cy5waXhlbF90ZXN0c19lbmFibGVkICYmIHBhc3NlZFdpdGhJbWFnZU9u bHlGYWlsdXJlSW5SZXRyeSkpIHsKICAgICAgICAgZ2xvYmFsU3RhdGUoKS5mbGFreVBhc3NUZXN0 cy5wdXNoKHRlc3RPYmplY3QpOwogICAgICAgICByZXR1cm47CiAgICAgfQpJbmRleDogTGF5b3V0 VGVzdHMvZmFzdC9oYXJuZXNzL3Jlc291cmNlcy9yZXN1bHRzLXRlc3QuanMKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gTGF5b3V0VGVzdHMvZmFzdC9oYXJuZXNzL3Jlc291cmNlcy9yZXN1bHRzLXRlc3QuanMJKHJl dmlzaW9uIDE0NjgxNikKKysrIExheW91dFRlc3RzL2Zhc3QvaGFybmVzcy9yZXNvdXJjZXMvcmVz dWx0cy10ZXN0LmpzCSh3b3JraW5nIGNvcHkpCkBAIC03NzksNiArNzc5LDE0IEBAIGZ1bmN0aW9u IHJ1blRlc3RzKCkKICAgICAgICAgYXNzZXJ0VHJ1ZShkb2N1bWVudC5xdWVyeVNlbGVjdG9yKCd0 Ym9keSB0ZDpudGgtY2hpbGQoMykgYScpLmdldEF0dHJpYnV0ZSgnaHJlZicpID09ICdyZXRyaWVz L2Zvby9iYXItaW1hZ2UtZGlmZnMuaHRtbCcpOwogICAgIH0pOwogCisgICAgcmVzdWx0cyA9IG1v Y2tSZXN1bHRzKCk7CisgICAgcmVzdWx0cy50ZXN0c1snZm9vL2Jhci1pbWFnZS5odG1sJ10gPSBt b2NrRXhwZWN0YXRpb24oJ1BBU1MnLCAnVEVYVCBJTUFHRScpOworICAgIHJlc3VsdHMucGl4ZWxf dGVzdHNfZW5hYmxlZCA9IGZhbHNlOworICAgIHJ1blRlc3QocmVzdWx0cywgZnVuY3Rpb24oKSB7 CisgICAgICAgIGFzc2VydFRydWUoIWRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdyZXN1bHRzLXRh YmxlJykpOworICAgICAgICBhc3NlcnRUcnVlKGRvY3VtZW50LnF1ZXJ5U2VsZWN0b3IoJyNmbGFr eS10ZXN0cy10YWJsZSB0ZDpudGgtY2hpbGQoMykgYScpLmdldEF0dHJpYnV0ZSgnaHJlZicpID09 ICdyZXRyaWVzL2Zvby9iYXItaW1hZ2UtZGlmZnMuaHRtbCcpOworICAgIH0pOworCiAgICAgZG9j dW1lbnQuYm9keS5pbm5lckhUTUwgPSAnPHByZT4nICsgZ19sb2cuam9pbignXG4nKSArICc8L3By ZT4nOwogfQogCg==