113237 2013-03-25 13:06:08 -0700 Build failure when SVG is disabled 2013-03-25 13:16:29 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 113234 P2 Normal --- 0 rouslan+webkit webkit-unassigned apavlov rniwa rouslan+webkit tony webkit.review.bot oldest_to_newest 862999 0 rouslan+webkit 2013-03-25 13:06:08 -0700 Build failure when SVG is disabled 863002 1 194910 rouslan+webkit 2013-03-25 13:09:00 -0700 Created attachment 194910 Patch 863004 2 rouslan+webkit 2013-03-25 13:10:33 -0700 Build with disabled SVG generates the following error: ../../Source/WebCore/inspector/InspectorCSSAgent.cpp:1093:37: error: unknown type name 'SVGStyleElement'; did you mean 'StyleElement'? cssStyleSheet = static_cast<SVGStyleElement*>(styleElement.get())->sheet(); ^~~~~~~~~~~~~~~ StyleElement ../../Source/WebCore/dom/StyleElement.h:32:7: note: 'StyleElement' declared here class StyleElement { ^ ../../Source/WebCore/inspector/InspectorCSSAgent.cpp:1093:25: error: static_cast from 'WebCore::Element *' to 'WebCore::StyleElement *' is not allowed cssStyleSheet = static_cast<SVGStyleElement*>(styleElement.get())->sheet(); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../Source/WebCore/inspector/InspectorCSSAgent.cpp:1093:76: error: 'sheet' is a protected member of 'WebCore::StyleElement' cssStyleSheet = static_cast<SVGStyleElement*>(styleElement.get())->sheet(); ^ ../../Source/WebCore/dom/StyleElement.h:41:20: note: declared protected here CSSStyleSheet* sheet() const { return m_sheet.get(); } ^ 863005 3 tony 2013-03-25 13:12:53 -0700 Looks like this was added earlier today by apavlov. http://trac.webkit.org/changeset/146760 863009 4 tony 2013-03-25 13:14:29 -0700 Too slow! *** This bug has been marked as a duplicate of bug 113234 *** 863011 5 rouslan+webkit 2013-03-25 13:16:29 -0700 Khaaaaan! 194910 2013-03-25 13:09:00 -0700 2013-03-25 13:14:12 -0700 Patch bug-113237-20130325130444.patch text/plain 1635 rouslan+webkit U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ2Nzk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjczYWFlZTI3MGU1OGZh NTRiZDQ3ZDliYjc1MzQ3NGM5Mjc4NDA3Yy4uNzdjOWMzYTBlOWQ2ZDA4OTQ4MDYzY2IzMDI0MDM2 MmU0ZDhiY2I5OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTAzLTI1ICBSb3Vz bGFuIFNvbG9tYWtoaW4gIDxyb3VzbGFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBGaXggYnVp bGQgd2l0aCBkaXNhYmxlZCBTVkcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTExMzIzNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIERpc2FibGluZyBTVkcgYnJlYWtzIHRoZSBidWlsZCwgYmVjYXVzZSBJbnNw ZWN0b3JDU1NBZ2VudCB1c2VzCisgICAgICAgIFNWR1N0eWxlRWxlbWVudCB3aXRob3V0IGNoZWNr aW5nIHdoZXRoZXIgU1ZHIGlzIGVuYWJsZWQuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvSW5zcGVj dG9yQ1NTQWdlbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW5zcGVjdG9yQ1NTQWdlbnQ6OnZp YUluc3BlY3RvclN0eWxlU2hlZXQpOiBTa2lwIFNWRyBzcGVjaWZpYyBjb2RlIHdoZW4gU1ZHIGlz IGRpc2FibGVkLgorCiAyMDEzLTAzLTI1ICBUb255IENoYW5nICA8dG9ueUBjaHJvbWl1bS5vcmc+ CiAKICAgICAgICAgUmVtb3ZlIFRleHRJdGVyYXRvciBhcmd1bWVudGxlc3MgY29uc3RydWN0b3IK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JDU1NBZ2VudC5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yQ1NTQWdlbnQuY3BwCmluZGV4 IGYwMmMzNjY1NjA1NDQxNjAyYjY1ZGI4MDdkNWU1NWI0ZDRkNTFmOTAuLmE4YzkzMWVmMjViOGVi NjdkODAzZDdiYTAxNzZiNGM5ZDBmMTZkNmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2lu c3BlY3Rvci9JbnNwZWN0b3JDU1NBZ2VudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVj dG9yL0luc3BlY3RvckNTU0FnZW50LmNwcApAQCAtMTA4OSw4ICsxMDg5LDEwIEBAIEluc3BlY3Rv clN0eWxlU2hlZXQqIEluc3BlY3RvckNTU0FnZW50Ojp2aWFJbnNwZWN0b3JTdHlsZVNoZWV0KERv Y3VtZW50KiBkb2N1bWVuCiAgICAgQ1NTU3R5bGVTaGVldCogY3NzU3R5bGVTaGVldCA9IDA7CiAg ICAgaWYgKHN0eWxlRWxlbWVudC0+aXNIVE1MRWxlbWVudCgpKQogICAgICAgICBjc3NTdHlsZVNo ZWV0ID0gc3RhdGljX2Nhc3Q8SFRNTFN0eWxlRWxlbWVudCo+KHN0eWxlRWxlbWVudC5nZXQoKSkt PnNoZWV0KCk7CisjaWYgRU5BQkxFKFNWRykKICAgICBlbHNlIGlmIChzdHlsZUVsZW1lbnQtPmlz U1ZHRWxlbWVudCgpKQogICAgICAgICBjc3NTdHlsZVNoZWV0ID0gc3RhdGljX2Nhc3Q8U1ZHU3R5 bGVFbGVtZW50Kj4oc3R5bGVFbGVtZW50LmdldCgpKS0+c2hlZXQoKTsKKyNlbmRpZgogCiAgICAg aWYgKCFjc3NTdHlsZVNoZWV0KQogICAgICAgICByZXR1cm4gMDsK