113234 2013-03-25 12:45:25 -0700 Compile without SVG will fail 2013-03-26 02:04:26 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 savagobr webkit-unassigned apavlov keishi loislo pfeldman pmuellr rouslan+webkit vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 862978 0 savagobr 2013-03-25 12:45:25 -0700 Patch on changeset http://trac.webkit.org/changeset/146760 introduced the use of a SVG class into InspectorCSSAgent. Trying to compile WebKit without svg (--no-svg) will fail with: /******************************************************************************************/ [ 11%] Building CXX object Source/WebCore/CMakeFiles/webcore_efl.dir/inspector/InspectorCSSAgent.cpp.o /home/adenilson/apps/webkit/Webkit/Source/WebCore/inspector/InspectorCSSAgent.cpp: In member function ‘WebCore::InspectorStyleSheet* WebCore::InspectorCSSAgent::viaInspectorStyleSheet(WebCore::Document*, bool)’: /home/adenilson/apps/webkit/Webkit/Source/WebCore/inspector/InspectorCSSAgent.cpp:1093:37: error: expected type-specifier before ‘SVGStyleElement’ /home/adenilson/apps/webkit/Webkit/Source/WebCore/inspector/InspectorCSSAgent.cpp:1093:37: error: expected ‘>’ before ‘SVGStyleElement’ /******************************************************************************************/ This patch adds a test for SVG module in the new code. 862987 1 194907 savagobr 2013-03-25 12:53:07 -0700 Created attachment 194907 Test if we have SVG support built before casting block. 863010 2 tony 2013-03-25 13:14:29 -0700 *** Bug 113237 has been marked as a duplicate of this bug. *** 863012 3 194907 webkit.review.bot 2013-03-25 13:16:49 -0700 Comment on attachment 194907 Test if we have SVG support built before casting block. Clearing flags on attachment: 194907 Committed r146803: <http://trac.webkit.org/changeset/146803> 863013 4 webkit.review.bot 2013-03-25 13:16:52 -0700 All reviewed patches have been landed. Closing bug. 863473 5 194907 apavlov 2013-03-26 02:02:28 -0700 Comment on attachment 194907 Test if we have SVG support built before casting block. r=me. Thanks for fixing this. 863475 6 194907 apavlov 2013-03-26 02:04:26 -0700 Comment on attachment 194907 Test if we have SVG support built before casting block. Oops. For some reason, savagobr@yahoo.com restored the r? cq? flags on a committed patch. Resetting. 194907 2013-03-25 12:53:07 -0700 2013-03-26 02:04:26 -0700 Test if we have SVG support built before casting block. 0001-Fix.patch text/plain 1834 savagobr RnJvbSBjYWU5ZDNlNmZkMjlkNjUzMGU4OGZmYjA3N2NjY2JhYjQxMzQ2Mjc3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBZGVuaWxzb24gQ2F2YWxjYW50aSA8Y2F2YWxjYW50aWlAZ21h aWwuY29tPgpEYXRlOiBNb24sIDI1IE1hciAyMDEzIDE1OjQ2OjQ4IC0wNDAwClN1YmplY3Q6IFtQ QVRDSF0gRml4LgoKU2lnbmVkLW9mZi1ieTogQWRlbmlsc29uIENhdmFsY2FudGkgPGNhdmFsY2Fu dGlpQGdtYWlsLmNvbT4KLS0tCiBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAg ICAgICAgICAgIHwgICAxMiArKysrKysrKysrKysKIFNvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9J bnNwZWN0b3JDU1NBZ2VudC5jcHAgfCAgICAyICsrCiAyIGZpbGVzIGNoYW5nZWQsIDE0IGluc2Vy dGlvbnMoKykKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2Uv V2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmViYzczZi4uZDVjYWY0NiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAt MSwzICsxLDE1IEBACisyMDEzLTAzLTI1ICBBZGVuaWxzb24gQ2F2YWxjYW50aSAgPGNhdmFsY2Fu dGlpQGdtYWlsLmNvbT4KKworICAgICAgICBDb21waWxlIHdpdGhvdXQgU1ZHIHdpbGwgZmFpbAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEzMjM0CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgT25seSBtYWtl IHRoZSBjYXN0IHRvIFNWR1N0eWxlRWxlbWVudCBpZiB3ZSBoYXZlIFNWRyBzdXBwb3J0IGJ1aWx0 LgorCisgICAgICAgICogaW5zcGVjdG9yL0luc3BlY3RvckNTU0FnZW50LmNwcDoKKyAgICAgICAg KFdlYkNvcmU6Okluc3BlY3RvckNTU0FnZW50Ojp2aWFJbnNwZWN0b3JTdHlsZVNoZWV0KToKKwog MjAxMy0wMy0yNSAgUm9nZXIgRm9uZyAgPHJvZ2VyX2ZvbmdAYXBwbGUuY29tPgogCiAgICAgICAg IFVucmV2aWV3ZWQuIFJlbW92ZSBzb21lIHN1c3BpY2lvdXMgbG9va2luZyBjb2RlIGluIGFuIGF0 dGVtcHQgdG8gZml4IEVXUyBib3RzLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVj dG9yL0luc3BlY3RvckNTU0FnZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNw ZWN0b3JDU1NBZ2VudC5jcHAKaW5kZXggZjAyYzM2Ni4uYThjOTMxZSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckNTU0FnZW50LmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yQ1NTQWdlbnQuY3BwCkBAIC0xMDg5LDggKzEwODks MTAgQEAgSW5zcGVjdG9yU3R5bGVTaGVldCogSW5zcGVjdG9yQ1NTQWdlbnQ6OnZpYUluc3BlY3Rv clN0eWxlU2hlZXQoRG9jdW1lbnQqIGRvY3VtZW4KICAgICBDU1NTdHlsZVNoZWV0KiBjc3NTdHls ZVNoZWV0ID0gMDsKICAgICBpZiAoc3R5bGVFbGVtZW50LT5pc0hUTUxFbGVtZW50KCkpCiAgICAg ICAgIGNzc1N0eWxlU2hlZXQgPSBzdGF0aWNfY2FzdDxIVE1MU3R5bGVFbGVtZW50Kj4oc3R5bGVF bGVtZW50LmdldCgpKS0+c2hlZXQoKTsKKyNpZiBFTkFCTEUoU1ZHKQogICAgIGVsc2UgaWYgKHN0 eWxlRWxlbWVudC0+aXNTVkdFbGVtZW50KCkpCiAgICAgICAgIGNzc1N0eWxlU2hlZXQgPSBzdGF0 aWNfY2FzdDxTVkdTdHlsZUVsZW1lbnQqPihzdHlsZUVsZW1lbnQuZ2V0KCkpLT5zaGVldCgpOwor I2VuZGlmCiAKICAgICBpZiAoIWNzc1N0eWxlU2hlZXQpCiAgICAgICAgIHJldHVybiAwOwotLSAK MS43LjEwLjQKCg==