113226 2013-03-25 11:08:56 -0700 Remove TextIterator argumentless constructor 2013-03-25 12:18:38 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tony tony mifenton mitz rniwa webkit.review.bot oldest_to_newest 862921 0 tony 2013-03-25 11:08:56 -0700 Make TextIterator classes non-copyable 862940 1 194893 tony 2013-03-25 11:32:44 -0700 Created attachment 194893 Patch 862945 2 194893 rniwa 2013-03-25 11:38:57 -0700 Comment on attachment 194893 Patch r=me as long as everything builds. 862966 3 194893 webkit.review.bot 2013-03-25 12:18:34 -0700 Comment on attachment 194893 Patch Clearing flags on attachment: 194893 Committed r146796: <http://trac.webkit.org/changeset/146796> 862967 4 webkit.review.bot 2013-03-25 12:18:38 -0700 All reviewed patches have been landed. Closing bug. 194893 2013-03-25 11:32:44 -0700 2013-03-25 12:18:34 -0700 Patch bug-113226-20130325112828.patch text/plain 6076 tony U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ2NzgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWQ3ODkyNTNmNjZmOGMx YWFlZWM2OWYyZDc3YTA4NGExNjAyZTc4ZS4uZDdmMzljNGY1MmQ4YjA3YjFlMTUxMTE1NWNkZWE0 YjI3NTM4MjljMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEzLTAzLTI1ICBUb255 IENoYW5nICA8dG9ueUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmVtb3ZlIFRleHRJdGVyYXRv ciBhcmd1bWVudGxlc3MgY29uc3RydWN0b3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTExMzIyNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFRoZSBUZXh0SXRlcmF0b3IgYXJndW1lbnRsZXNzIGNvbnN0cnVj dG9ycyBhcmUgbmV2ZXIgdXNlZCBhbmQgd291bGRuJ3QgYmUgdXNlZnVsCisgICAgICAgIHNpbmNl IHlvdSBjYW4ndCBzcGVjaWZ5IGEgcmFuZ2UuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCByZW1v dmluZyBkZWFkIGNvZGUuIFRoZXJlIHNob3VsZCBiZSBubyBiZWhhdmlvciBjaGFuZ2UuCisKKyAg ICAgICAgKiBlZGl0aW5nL1RleHRJdGVyYXRvci5jcHA6IFJlbW92ZSBjb25zdHJ1Y3RvcnMuCisg ICAgICAgICogZWRpdGluZy9UZXh0SXRlcmF0b3IuaDoKKyAgICAgICAgKFRleHRJdGVyYXRvcik6 CisgICAgICAgIChTaW1wbGlmaWVkQmFja3dhcmRzVGV4dEl0ZXJhdG9yKToKKyAgICAgICAgKENo YXJhY3Rlckl0ZXJhdG9yKToKKyAgICAgICAgKEJhY2t3YXJkc0NoYXJhY3Rlckl0ZXJhdG9yKToK KyAgICAgICAgKFdvcmRBd2FyZUl0ZXJhdG9yKToKKwogMjAxMy0wMy0yNSAgVnNldm9sb2QgVmxh c292ICA8dnNldmlrQGNocm9taXVtLm9yZz4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBbUmVn cmVzc2lvbl0gUHJvdmlzaW9uYWwgYnJlYWtwb2ludHMgYXJlIG5vdCBzaG93biBvbiByZWxvYWQu CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL1RleHRJdGVyYXRvci5jcHAgYi9T b3VyY2UvV2ViQ29yZS9lZGl0aW5nL1RleHRJdGVyYXRvci5jcHAKaW5kZXggYTg1MDhjMjMyODQ5 NTVkNjllZTJjMDBlYTkzMzY3MzQxNDU4ZGVlZi4uM2U0NzFlMDg4NTUyMzI4ODU0Mjc2NTNlYWVh NzExODZkZWQ5ZmFlMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZWRpdGluZy9UZXh0SXRl cmF0b3IuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvVGV4dEl0ZXJhdG9yLmNwcApA QCAtMjQ2LDMwICsyNDYsNiBAQCBzdGF0aWMgdm9pZCBzZXRVcEZ1bGx5Q2xpcHBlZFN0YWNrKEJp dFN0YWNrJiBzdGFjaywgTm9kZSogbm9kZSkKIAogLy8gLS0tLS0tLS0KIAotVGV4dEl0ZXJhdG9y OjpUZXh0SXRlcmF0b3IoKQotICAgIDogbV9zdGFydENvbnRhaW5lcigwKQotICAgICwgbV9zdGFy dE9mZnNldCgwKQotICAgICwgbV9lbmRDb250YWluZXIoMCkKLSAgICAsIG1fZW5kT2Zmc2V0KDAp Ci0gICAgLCBtX3Bvc2l0aW9uTm9kZSgwKQotICAgICwgbV90ZXh0Q2hhcmFjdGVycygwKQotICAg ICwgbV90ZXh0TGVuZ3RoKDApCi0gICAgLCBtX3JlbWFpbmluZ1RleHRCb3goMCkKLSAgICAsIG1f Zmlyc3RMZXR0ZXJUZXh0KDApCi0gICAgLCBtX2xhc3RDaGFyYWN0ZXIoMCkKLSAgICAsIG1fc29y dGVkVGV4dEJveGVzUG9zaXRpb24oMCkKLSAgICAsIG1fZW1pdHNDaGFyYWN0ZXJzQmV0d2VlbkFs bFZpc2libGVQb3NpdGlvbnMoZmFsc2UpCi0gICAgLCBtX2VudGVyc1RleHRDb250cm9scyhmYWxz ZSkKLSAgICAsIG1fZW1pdHNUZXh0V2l0aG91dFRyYW5zY29kaW5nKGZhbHNlKQotICAgICwgbV9l bWl0c09yaWdpbmFsVGV4dChmYWxzZSkKLSAgICAsIG1faGFuZGxlZEZpcnN0TGV0dGVyKGZhbHNl KQotICAgICwgbV9pZ25vcmVzU3R5bGVWaXNpYmlsaXR5KGZhbHNlKQotICAgICwgbV9lbWl0c09i amVjdFJlcGxhY2VtZW50Q2hhcmFjdGVycyhmYWxzZSkKLSAgICAsIG1fc3RvcHNPbkZvcm1Db250 cm9scyhmYWxzZSkKLSAgICAsIG1fc2hvdWxkU3RvcChmYWxzZSkKLXsKLX0KLQogVGV4dEl0ZXJh dG9yOjpUZXh0SXRlcmF0b3IoY29uc3QgUmFuZ2UqIHIsIFRleHRJdGVyYXRvckJlaGF2aW9yIGJl aGF2aW9yKQogICAgIDogbV9zdGFydENvbnRhaW5lcigwKQogICAgICwgbV9zdGFydE9mZnNldCgw KQpAQCAtMTA4OCwzMSArMTA2NCw2IEBAIE5vZGUqIFRleHRJdGVyYXRvcjo6bm9kZSgpIGNvbnN0 CiAKIC8vIC0tLS0tLS0tCiAKLVNpbXBsaWZpZWRCYWNrd2FyZHNUZXh0SXRlcmF0b3I6OlNpbXBs aWZpZWRCYWNrd2FyZHNUZXh0SXRlcmF0b3IoKQotICAgIDogbV9ub2RlKDApCi0gICAgLCBtX29m ZnNldCgwKQotICAgICwgbV9oYW5kbGVkTm9kZShmYWxzZSkKLSAgICAsIG1faGFuZGxlZENoaWxk cmVuKGZhbHNlKQotICAgICwgbV9zdGFydE5vZGUoMCkKLSAgICAsIG1fc3RhcnRPZmZzZXQoMCkK LSAgICAsIG1fZW5kTm9kZSgwKQotICAgICwgbV9lbmRPZmZzZXQoMCkKLSAgICAsIG1fcG9zaXRp b25Ob2RlKDApCi0gICAgLCBtX3Bvc2l0aW9uU3RhcnRPZmZzZXQoMCkKLSAgICAsIG1fcG9zaXRp b25FbmRPZmZzZXQoMCkKLSAgICAsIG1fdGV4dENoYXJhY3RlcnMoMCkKLSAgICAsIG1fdGV4dExl bmd0aCgwKQotICAgICwgbV9sYXN0VGV4dE5vZGUoMCkKLSAgICAsIG1fbGFzdENoYXJhY3Rlcigw KQotICAgICwgbV9zaW5nbGVDaGFyYWN0ZXJCdWZmZXIoMCkKLSAgICAsIG1faGF2ZVBhc3NlZFN0 YXJ0Tm9kZShmYWxzZSkKLSAgICAsIG1fc2hvdWxkSGFuZGxlRmlyc3RMZXR0ZXIoZmFsc2UpCi0g ICAgLCBtX3N0b3BzT25Gb3JtQ29udHJvbHMoZmFsc2UpCi0gICAgLCBtX3Nob3VsZFN0b3AoZmFs c2UpCi0gICAgLCBtX2VtaXRzT3JpZ2luYWxUZXh0KGZhbHNlKQotewotfQotCiBTaW1wbGlmaWVk QmFja3dhcmRzVGV4dEl0ZXJhdG9yOjpTaW1wbGlmaWVkQmFja3dhcmRzVGV4dEl0ZXJhdG9yKGNv bnN0IFJhbmdlKiByLCBUZXh0SXRlcmF0b3JCZWhhdmlvciBiZWhhdmlvcikKICAgICA6IG1fbm9k ZSgwKQogICAgICwgbV9vZmZzZXQoMCkKQEAgLTEzOTMsMTMgKzEzNDQsNiBAQCBQYXNzUmVmUHRy PFJhbmdlPiBTaW1wbGlmaWVkQmFja3dhcmRzVGV4dEl0ZXJhdG9yOjpyYW5nZSgpIGNvbnN0CiAK IC8vIC0tLS0tLS0tCiAKLUNoYXJhY3Rlckl0ZXJhdG9yOjpDaGFyYWN0ZXJJdGVyYXRvcigpCi0g ICAgOiBtX29mZnNldCgwKQotICAgICwgbV9ydW5PZmZzZXQoMCkKLSAgICAsIG1fYXRCcmVhayh0 cnVlKQotewotfQotCiBDaGFyYWN0ZXJJdGVyYXRvcjo6Q2hhcmFjdGVySXRlcmF0b3IoY29uc3Qg UmFuZ2UqIHIsIFRleHRJdGVyYXRvckJlaGF2aW9yIGJlaGF2aW9yKQogICAgIDogbV9vZmZzZXQo MCkKICAgICAsIG1fcnVuT2Zmc2V0KDApCkBAIC0xNDk5LDEzICsxNDQzLDYgQEAgc3RhdGljIFBh c3NSZWZQdHI8UmFuZ2U+IGNoYXJhY3RlclN1YnJhbmdlKENoYXJhY3Rlckl0ZXJhdG9yJiBpdCwg aW50IG9mZnNldCwgaW4KICAgICAgICAgZW5kLT5lbmRDb250YWluZXIoKSwgZW5kLT5lbmRPZmZz ZXQoKSk7CiB9CiAKLUJhY2t3YXJkc0NoYXJhY3Rlckl0ZXJhdG9yOjpCYWNrd2FyZHNDaGFyYWN0 ZXJJdGVyYXRvcigpCi0gICAgOiBtX29mZnNldCgwKQotICAgICwgbV9ydW5PZmZzZXQoMCkKLSAg ICAsIG1fYXRCcmVhayh0cnVlKQotewotfQotCiBCYWNrd2FyZHNDaGFyYWN0ZXJJdGVyYXRvcjo6 QmFja3dhcmRzQ2hhcmFjdGVySXRlcmF0b3IoY29uc3QgUmFuZ2UqIHJhbmdlLCBUZXh0SXRlcmF0 b3JCZWhhdmlvciBiZWhhdmlvcikKICAgICA6IG1fb2Zmc2V0KDApCiAgICAgLCBtX3J1bk9mZnNl dCgwKQpAQCAtMTU3NCwxMiArMTUxMSw2IEBAIHZvaWQgQmFja3dhcmRzQ2hhcmFjdGVySXRlcmF0 b3I6OmFkdmFuY2UoaW50IGNvdW50KQogCiAvLyAtLS0tLS0tLQogCi1Xb3JkQXdhcmVJdGVyYXRv cjo6V29yZEF3YXJlSXRlcmF0b3IoKQotICAgIDogbV9wcmV2aW91c1RleHQoMCkKLSAgICAsIG1f ZGlkTG9va0FoZWFkKGZhbHNlKQotewotfQotCiBXb3JkQXdhcmVJdGVyYXRvcjo6V29yZEF3YXJl SXRlcmF0b3IoY29uc3QgUmFuZ2UqIHIpCiAgICAgOiBtX3ByZXZpb3VzVGV4dCgwKQogICAgICwg bV9kaWRMb29rQWhlYWQodHJ1ZSkgLy8gc28gd2UgY29uc2lkZXIgdGhlIGZpcnN0IGNodW5rIGZy b20gdGhlIHRleHQgaXRlcmF0b3IKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcv VGV4dEl0ZXJhdG9yLmggYi9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL1RleHRJdGVyYXRvci5oCmlu ZGV4IDY4ZDgwMTBkZDUxMjQ2ZDA3NmYwZDVlYWFkM2JlN2YxNDdjZWZmYWUuLjExOTkyYjM1NzBk YWFkN2QwMTU4ODJlZjczYmEwOGZkYjViNWEwYmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2VkaXRpbmcvVGV4dEl0ZXJhdG9yLmgKKysrIGIvU291cmNlL1dlYkNvcmUvZWRpdGluZy9UZXh0 SXRlcmF0b3IuaApAQCAtODUsOSArODUsOCBAQCBwcml2YXRlOgogCiBjbGFzcyBUZXh0SXRlcmF0 b3IgewogcHVibGljOgotICAgIFRleHRJdGVyYXRvcigpOwotICAgIH5UZXh0SXRlcmF0b3IoKTsK ICAgICBleHBsaWNpdCBUZXh0SXRlcmF0b3IoY29uc3QgUmFuZ2UqLCBUZXh0SXRlcmF0b3JCZWhh dmlvciA9IFRleHRJdGVyYXRvckRlZmF1bHRCZWhhdmlvcik7CisgICAgflRleHRJdGVyYXRvcigp OwogCiAgICAgYm9vbCBhdEVuZCgpIGNvbnN0IHsgcmV0dXJuICFtX3Bvc2l0aW9uTm9kZSB8fCBt X3Nob3VsZFN0b3A7IH0KICAgICB2b2lkIGFkdmFuY2UoKTsKQEAgLTIwMCw3ICsxOTksNiBAQCBw cml2YXRlOgogLy8gY2h1bmtzIHNvIGFzIHRvIG9wdGltaXplIGZvciBwZXJmb3JtYW5jZSBvZiB0 aGUgaXRlcmF0aW9uLgogY2xhc3MgU2ltcGxpZmllZEJhY2t3YXJkc1RleHRJdGVyYXRvciB7CiBw dWJsaWM6Ci0gICAgU2ltcGxpZmllZEJhY2t3YXJkc1RleHRJdGVyYXRvcigpOwogICAgIGV4cGxp Y2l0IFNpbXBsaWZpZWRCYWNrd2FyZHNUZXh0SXRlcmF0b3IoY29uc3QgUmFuZ2UqLCBUZXh0SXRl cmF0b3JCZWhhdmlvciA9IFRleHRJdGVyYXRvckRlZmF1bHRCZWhhdmlvcik7CiAgICAgCiAgICAg Ym9vbCBhdEVuZCgpIGNvbnN0IHsgcmV0dXJuICFtX3Bvc2l0aW9uTm9kZSB8fCBtX3Nob3VsZFN0 b3A7IH0KQEAgLTI2OSw3ICsyNjcsNiBAQCBwcml2YXRlOgogLy8gY2hhcmFjdGVyIGF0IGEgdGlt ZSwgb3IgZmFzdGVyLCBhcyBuZWVkZWQuIFVzZWZ1bCBmb3Igc2VhcmNoaW5nLgogY2xhc3MgQ2hh cmFjdGVySXRlcmF0b3IgewogcHVibGljOgotICAgIENoYXJhY3Rlckl0ZXJhdG9yKCk7CiAgICAg ZXhwbGljaXQgQ2hhcmFjdGVySXRlcmF0b3IoY29uc3QgUmFuZ2UqLCBUZXh0SXRlcmF0b3JCZWhh dmlvciA9IFRleHRJdGVyYXRvckRlZmF1bHRCZWhhdmlvcik7CiAgICAgCiAgICAgdm9pZCBhZHZh bmNlKGludCBudW1DaGFyYWN0ZXJzKTsKQEAgLTI5NCw3ICsyOTEsNiBAQCBwcml2YXRlOgogICAg IAogY2xhc3MgQmFja3dhcmRzQ2hhcmFjdGVySXRlcmF0b3IgewogcHVibGljOgotICAgIEJhY2t3 YXJkc0NoYXJhY3Rlckl0ZXJhdG9yKCk7CiAgICAgZXhwbGljaXQgQmFja3dhcmRzQ2hhcmFjdGVy SXRlcmF0b3IoY29uc3QgUmFuZ2UqLCBUZXh0SXRlcmF0b3JCZWhhdmlvciA9IFRleHRJdGVyYXRv ckRlZmF1bHRCZWhhdmlvcik7CiAKICAgICB2b2lkIGFkdmFuY2UoaW50KTsKQEAgLTMxNSw3ICsz MTEsNiBAQCBwcml2YXRlOgogLy8gbWVhbmluZyB0aGV5IG5ldmVyIGVuZCBzcGxpdCB1cCBhIHdv cmQuICBUaGlzIGlzIHVzZWZ1bCBmb3Igc3BlbGxjaGVjayBvciAocGVyaGFwcyBvbmUgZGF5KSBz ZWFyY2hpbmcuCiBjbGFzcyBXb3JkQXdhcmVJdGVyYXRvciB7CiBwdWJsaWM6Ci0gICAgV29yZEF3 YXJlSXRlcmF0b3IoKTsKICAgICBleHBsaWNpdCBXb3JkQXdhcmVJdGVyYXRvcihjb25zdCBSYW5n ZSopOwogICAgIH5Xb3JkQXdhcmVJdGVyYXRvcigpOwogCg==