<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>11322</bug_id>
          
          <creation_ts>2006-10-16 19:12:15 -0700</creation_ts>
          <short_desc>move-js-headers.sh causes unnecessary source rebuilds</short_desc>
          <delta_ts>2006-11-02 19:34:58 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>420+</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Kevin Ollivier">kevino</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>mrowe</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>52398</commentid>
    <comment_count>0</comment_count>
    <who name="Kevin Ollivier">kevino</who>
    <bug_when>2006-10-16 19:12:15 -0700</bug_when>
    <thetext>Since the cp operation in move-js-headers.sh does not use the -p option to preserve the modification time of the original file, make thinks that all the headers in WebCore/include/JavaScriptCore have been modified since the last build, and thus forces a rebuild of all sources that depend on them. The attached patch adds the -p option to stop this from happening.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>52399</commentid>
    <comment_count>1</comment_count>
      <attachid>11122</attachid>
    <who name="Kevin Ollivier">kevino</who>
    <bug_when>2006-10-16 19:14:09 -0700</bug_when>
    <thetext>Created attachment 11122
Preserve original modification time for copied headers.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>52354</commentid>
    <comment_count>2</comment_count>
      <attachid>11122</attachid>
    <who name="Geoffrey Garen">ggaren</who>
    <bug_when>2006-10-17 11:26:34 -0700</bug_when>
    <thetext>Comment on attachment 11122
Preserve original modification time for copied headers.

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>47594</commentid>
    <comment_count>3</comment_count>
    <who name="Anders Carlsson">andersca</who>
    <bug_when>2006-11-02 19:34:58 -0800</bug_when>
    <thetext>Committed revision 17557.
</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>11122</attachid>
            <date>2006-10-16 19:14:09 -0700</date>
            <delta_ts>2006-10-17 11:26:34 -0700</delta_ts>
            <desc>Preserve original modification time for copied headers.</desc>
            <filename>move-js-headers.patch</filename>
            <type>text/plain</type>
            <size>1051</size>
            <attacher name="Kevin Ollivier">kevino</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n
CShyZXZpc2lvbiAxNzA3NCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA
IC0xLDMgKzEsMTEgQEAKKzIwMDYtMTAtMTYgIEtldmluIE9sbGl2aWVyIDxrZXZpbm9AdGhlb2xs
aXZpZXJzLmNvbT4KKworICAgICAgICBGaXggZGVwZW5kZW5jeSBwcm9ibGVtcyBjYXVzZWQgd2hl
biBydW5uaW5nIG1vdmUtanMtaGVhZGVycy5zaAorICAgICAgICAKKyAgICAgICAgKiBtb3ZlLWpz
LWhlYWRlcnMuc2g6CisgICAgICAgIFVzZSBjcCAtcCBpbnN0ZWFkIG9mIGp1c3QgY3Agc28gdGhh
dCB0aGUgbW9kaWZpY2F0aW9uIHRpbWUKKyAgICAgICAgb2YgdGhlIG9yaWdpbmFsIGZpbGVzIGFy
ZSB1c2VkLgorCiAyMDA2LTEwLTEzICBKdXN0aW4gR2FyY2lhICA8anVzdGluLmdhcmNpYUBhcHBs
ZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgaGFycmlzb24KSW5kZXg6IFdlYkNvcmUvbW92
ZS1qcy1oZWFkZXJzLnNoCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvbW92ZS1qcy1oZWFkZXJzLnNo
CShyZXZpc2lvbiAxNzA3NCkKKysrIFdlYkNvcmUvbW92ZS1qcy1oZWFkZXJzLnNoCSh3b3JraW5n
IGNvcHkpCkBAIC0xLDYgKzEsNiBAQAogIyEvYmluL3NoCiAKIG1rZGlyIC1wIGluY2x1ZGUvSmF2
YVNjcmlwdENvcmUKLWZpbmQgLi4vSmF2YVNjcmlwdENvcmUvIC1uYW1lIFwqLmggLWV4ZWMgY3Ag
e30gaW5jbHVkZS9KYXZhU2NyaXB0Q29yZS8uIFw7CitmaW5kIC4uL0phdmFTY3JpcHRDb3JlLyAt
bmFtZSBcKi5oIC1leGVjIGNwIC1wIHt9IGluY2x1ZGUvSmF2YVNjcmlwdENvcmUvLiBcOwogcm0g
aW5jbHVkZS9KYXZhU2NyaXB0Q29yZS9jb25maWcuaAogcm0gaW5jbHVkZS9KYXZhU2NyaXB0Q29y
ZS9KYXZhU2NyaXB0Q29yZVByZWZpeC5oCg==
</data>
<flag name="review"
          id="3789"
          type_id="1"
          status="+"
          setter="ggaren"
    />
          </attachment>
      

    </bug>

</bugzilla>