113218 2013-03-25 10:26:02 -0700 [V8] exceptions are not checked after toInt32 calls in bindings. 2014-12-16 00:48:09 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 113538 1 a.renevier a.renevier ggaren haraken oliver simon.fraser webkit.review.bot oldest_to_newest 862887 0 194882 a.renevier 2013-03-25 10:26:02 -0700 Created attachment 194882 testcase: selectedIndex will be 2 with v8/javascript; 1 in gecko and -1 in ie Hi, in generated bindings, some values are converted to integers with toInt32. exceptions are not checked afterwards. But exceptions may occur if argument is an object with an valueOf method. 865703 1 195619 a.renevier 2013-03-28 12:26:37 -0700 Created attachment 195619 patch proposal: fixes the problem in v8 bindings 865704 2 195619 haraken 2013-03-28 12:29:02 -0700 Comment on attachment 195619 patch proposal: fixes the problem in v8 bindings great 865738 3 195619 webkit.review.bot 2013-03-28 13:06:53 -0700 Comment on attachment 195619 patch proposal: fixes the problem in v8 bindings Clearing flags on attachment: 195619 Committed r147149: <http://trac.webkit.org/changeset/147149> 865739 4 webkit.review.bot 2013-03-28 13:06:58 -0700 All reviewed patches have been landed. Closing bug. 865794 5 simon.fraser 2013-03-28 14:22:42 -0700 This broke binding generation tests on Mac: http://build.webkit.org/builders/Apple%20Lion%20Release%20WK1%20%28Tests%29/builds/10946/steps/bindings-generation-tests/logs/stdio Why is Mac code seeing a macro call V8TRYCATCH_VOID ? 865807 6 a.renevier 2013-03-28 14:37:15 -0700 (In reply to comment #5) > This broke binding generation tests on Mac: > http://build.webkit.org/builders/Apple%20Lion%20Release%20WK1%20%28Tests%29/builds/10946/steps/bindings-generation-tests/logs/stdio > > Why is Mac code seeing a macro call V8TRYCATCH_VOID ? Oups, I forgot to run run-bindings-tests --reset-results. What's the best way to handle that ? Submit a patch with just test results reseted, or resubmit the commited patch with the results reseted ? 865809 7 webkit.review.bot 2013-03-28 14:37:53 -0700 Re-opened since this is blocked by bug 113538 865843 8 haraken 2013-03-28 15:13:06 -0700 Would you re-upload a patch with binding-tests update? 865844 9 a.renevier 2013-03-28 15:14:01 -0700 (In reply to comment #8) > Would you re-upload a patch with binding-tests update? It's already been fixed in bug #113538 865845 10 haraken 2013-03-28 15:14:29 -0700 Ah, makes sense. Thanks! 1055930 11 burg 2014-12-16 00:48:09 -0800 Closing some V8-related work items. 194882 2013-03-25 10:26:02 -0700 2013-03-25 10:26:02 -0700 testcase: selectedIndex will be 2 with v8/javascript; 1 in gecko and -1 in ie index.html text/html 945 a.renevier PCFET0NUWVBFIGh0bWw+CjxodG1sPgogICAgPG1ldGEgaHR0cC1lcXVpdj0iQ29udGVudC1UeXBl IiBjb250ZW50PSJ0ZXh0L2h0bWw7IGNoYXJzZXQ9VVRGLTgiID4KICAgIDx0aXRsZT48L3RpdGxl PgogICAgPHNjcmlwdD4KCiAgICBmdW5jdGlvbiBzZXRJbmRleChzZWxlY3QpIHsKICAgICAgICB2 YXIgaW50ZWdlckxpa2UgPSB7CiAgICAgICAgICAgIHZhbHVlT2Y6IGZ1bmN0aW9uKCkgewogICAg ICAgICAgICAgICAgdGhyb3cgbmV3IEVycm9yKCJlcnJvciIpOwogICAgICAgICAgICAgICAgcmV0 dXJuIDI7CiAgICAgICAgICAgIH0KICAgICAgICB9OwogICAgICAgIHNlbGVjdC5zZWxlY3RlZElu ZGV4ID0gaW50ZWdlckxpa2U7CiAgICB9CgogICAgZnVuY3Rpb24gaW5pdCgpIHsKICAgICAgICB2 YXIgc2VsZWN0ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInNlbGVjdCIpOwogICAgICAgIHRy eSB7CiAgICAgICAgICAgIHNldEluZGV4KHNlbGVjdCk7CiAgICAgICAgfSBjYXRjaChlKSB7CiAg ICAgICAgfQoKICAgICAgICB2YXIgbWVzc2FnZSA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJt ZXNzYWdlIik7CiAgICAgICAgbWVzc2FnZS5pbm5lckhUTUwgPSAic2VsZWN0ZWRJbmRleCBpcyAi ICsgc2VsZWN0LnNlbGVjdGVkSW5kZXg7CiAgICB9CiAgICA8L3NjcmlwdD4KCgo8Ym9keSBvbmxv YWQ9ImluaXQoKSI+CiAgICA8c2VsZWN0IGlkPSJzZWxlY3QiIG5hbWU9InNlbGVjdCI+CiAgICAg ICAgPG9wdGlvbiB2YWx1ZT0idmFsdWUxIj5WYWx1ZSAxPC9vcHRpb24+CiAgICAgICAgPG9wdGlv biB2YWx1ZT0idmFsdWUyIiBzZWxlY3RlZD5WYWx1ZSAyPC9vcHRpb24+CiAgICAgICAgPG9wdGlv biB2YWx1ZT0idmFsdWUzIj5WYWx1ZSAzPC9vcHRpb24+CiAgICA8L3NlbGVjdD4KICAgIDxkaXYg aWQ9Im1lc3NhZ2UiPgogICAgPC9kaXY+CjwvYm9keT4K 195619 2013-03-28 12:26:37 -0700 2013-03-28 13:06:53 -0700 patch proposal: fixes the problem in v8 bindings bug-113218-20130328122634.patch text/plain 4318 a.renevier U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ3MTMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2UxYzVhYzA2MmU3NDM2 MTYwZmUwYzJhZjNmN2Y5N2YxYjk5ZGUzYi4uMjVhODAxODE2ODBiZjdiZGNlODczM2VmNjYyNWUx Y2E3MjY3YjAwZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI0IEBACiAyMDEzLTAzLTI4ICBBcm5h dWQgUmVuZXZpZXIgIDxhLnJlbmV2aWVyQHNpc2Euc2Ftc3VuZy5jb20+CiAKKyAgICAgICAgZXhj ZXB0aW9ucyBhcmUgbm90IGNoZWNrZWQgYWZ0ZXIgdG9JbnQzMiBjYWxscyBpbiBiaW5kaW5ncy4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMzIxOAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEluIGF0dHJp YnV0ZSBzZXR0ZXIsIHdyYXAgSlNWYWx1ZSB0byBuYXRpdmUgdmFsdWUgY29udmVyc2lvbiBpbiBh IHRyeQorICAgICAgICBjYXRjaCBibG9jay4KKworICAgICAgICBEZWZpbmUgYSBuZXcgbWFjcm8g YmluZGluZzogVjhUUllDQVRDSF9WT0lECisKKyAgICAgICAgTm8gbmV3IHRlc3RzOiBjb3ZlcmVk IGJ5IGZhc3QvZG9tL2V4Y2VwdGlvbi1pbi1iaW5kaW5nLmh0bWwKKworICAgICAgICAqIGJpbmRp bmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtOgorICAgICAgICAoR2VuZXJhdGVOb3JtYWxB dHRyU2V0dGVyKToKKyAgICAgICAgKiBiaW5kaW5ncy92OC9WOEJpbmRpbmdNYWNyb3MuaDoKKyAg ICAgICAgKFdlYkNvcmUpOgorCisyMDEzLTAzLTI4ICBBcm5hdWQgUmVuZXZpZXIgIDxhLnJlbmV2 aWVyQHNpc2Euc2Ftc3VuZy5jb20+CisKICAgICAgICAgdXNlIFhNTEh0dHBSZXF1ZXN0UmVzcG9u c2VUeXBlIGVudW1lcmF0aW9uIGluIFhNTEh0dHBSZXF1ZXN0LmlkbAogICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEzNTE4CiAKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtIGIvU291cmNl L1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG0KaW5kZXggODUxMzRl YTQ2MDIzMGFkM2RkYmNhMWE0NWM5OTM2MTAyMjM0NjEzYi4uYjNmMjVmNjE3OThhOTI2ZjIwODI2 OWI3OTUyNTNlMTk2Njc3MzU4OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mv c2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG0KKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mv c2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG0KQEAgLTEzOTgsNyArMTM5OCw3IEBAIEVORAogICAg ICAgICB9IGVsc2lmICgkYXR0cmlidXRlLT5zaWduYXR1cmUtPmV4dGVuZGVkQXR0cmlidXRlcy0+ eyJFbmZvcmNlUmFuZ2UifSkgewogICAgICAgICAgICAgcHVzaChAaW1wbENvbnRlbnRJbnRlcm5h bHMsICIgICAgVjhUUllDQVRDSF9XSVRIX1RZUEVDSEVDS19WT0lEKCRuYXRpdmVUeXBlLCB2LCAk dmFsdWUsIGluZm8uR2V0SXNvbGF0ZSgpKTtcbiIpOwogICAgICAgICB9IGVsc2UgewotICAgICAg ICAgICAgcHVzaChAaW1wbENvbnRlbnRJbnRlcm5hbHMsICIgICAgJG5hdGl2ZVR5cGUgdiA9ICR2 YWx1ZTtcbiIpOworICAgICAgICAgICAgcHVzaChAaW1wbENvbnRlbnRJbnRlcm5hbHMsICIgICAg VjhUUllDQVRDSF9WT0lEKCRuYXRpdmVUeXBlLCB2LCAkdmFsdWUpO1xuIik7CiAgICAgICAgIH0K ICAgICB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4QmluZGlu Z01hY3Jvcy5oIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhCaW5kaW5nTWFjcm9zLmgK aW5kZXggNDM2NmNkNDQxYjBhZjQ0MWE5NTFiNDI1ZmUxOGUzYzQ3MzJjYThkYi4uM2U5N2U0MjBi OTNiZGRkNDBlNjkzNDgxMzNhY2ZiNDFjMjY1MmRkNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvYmluZGluZ3MvdjgvVjhCaW5kaW5nTWFjcm9zLmgKKysrIGIvU291cmNlL1dlYkNvcmUvYmlu ZGluZ3MvdjgvVjhCaW5kaW5nTWFjcm9zLmgKQEAgLTQyLDYgKzQyLDE3IEBAIG5hbWVzcGFjZSBX ZWJDb3JlIHsKICAgICAgICAgICAgIHJldHVybiBibG9jay5SZVRocm93KCk7ICAgICAgIFwKICAg ICB9CiAKKyNkZWZpbmUgVjhUUllDQVRDSF9WT0lEKHR5cGUsIHZhciwgdmFsdWUpIFwKKyAgICB0 eXBlIHZhcjsgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFwKKyAgICB7ICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIFwKKyAgICAgICAgdjg6OlRyeUNhdGNoIGJsb2NrOyAg ICAgICAgICAgICAgIFwKKyAgICAgICAgdmFyID0gKHZhbHVlKTsgICAgICAgICAgICAgICAgICAg IFwKKyAgICAgICAgaWYgKGJsb2NrLkhhc0NhdWdodCgpKSB7ICAgICAgICAgIFwKKyAgICAgICAg ICAgIGJsb2NrLlJlVGhyb3coKTsgICAgICAgICAgICAgIFwKKyAgICAgICAgICAgIHJldHVybjsg ICAgICAgICAgICAgICAgICAgICAgIFwKKyAgICAgICAgfSAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIFwKKyAgICB9CisKICNkZWZpbmUgVjhUUllDQVRDSF9XSVRIX1RZUEVDSEVDSyh0 eXBlLCB2YXIsIHZhbHVlLCBpc29sYXRlKSBcCiAgICAgdHlwZSB2YXI7ICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXAogICAgIHsgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFwKZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBiM2VlMmI3 YmY3ZWY3NzEwMGEwODMwN2E5ZmY0MDFlZWRmOGJlNTUyLi5iNDg2ZDEyM2UyNTAzNjk0NDdmZDY2 ODMwNjhmODRkMzc3OGI3ZDM4IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysr IGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTQgQEAKIDIwMTMtMDMtMjggIEFy bmF1ZCBSZW5ldmllciAgPGEucmVuZXZpZXJAc2lzYS5zYW1zdW5nLmNvbT4KIAorICAgICAgICBl eGNlcHRpb25zIGFyZSBub3QgY2hlY2tlZCBhZnRlciB0b0ludDMyIGNhbGxzIGluIGJpbmRpbmdz LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEzMjE4 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0 Zm9ybS9jaHJvbWl1bS9UZXN0RXhwZWN0YXRpb25zOiBFbmFibGUgZmFzdC9kb20vZXhjZXB0aW9u LWluLWJpbmRpbmcuaHRtbAorCisyMDEzLTAzLTI4ICBBcm5hdWQgUmVuZXZpZXIgIDxhLnJlbmV2 aWVyQHNpc2Euc2Ftc3VuZy5jb20+CisKICAgICAgICAgdXNlIFhNTEh0dHBSZXF1ZXN0UmVzcG9u c2VUeXBlIGVudW1lcmF0aW9uIGluIFhNTEh0dHBSZXF1ZXN0LmlkbAogICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEzNTE4CiAKZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0 cy9wbGF0Zm9ybS9jaHJvbWl1bS9UZXN0RXhwZWN0YXRpb25zCmluZGV4IDE4NjAwMTA1NWExOGU4 MDMzMWYxOTFhNDIyMTFhODBjMGI1MGY1MzkuLmMxYjA4YjY3NThiNTRiNTkyNDBiNGZiOGUzYzQ5 ODMwYjI2YmE5ODIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL1Rl c3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vVGVzdEV4 cGVjdGF0aW9ucwpAQCAtMzgwMCw4ICszODAwLDYgQEAgY3JidWcuY29tLzIyMzMzMiBzdmcvY3Nz L3Jvb3Qtc2hhZG93LW9mZnNjcmVlbi5zdmcgWyBJbWFnZU9ubHlGYWlsdXJlIF0KIAogd2Via2l0 Lm9yZy9iLzExMzExNCBtZWRpYS92aWRlby1jb250cm9scy1jYXB0aW9ucy5odG1sIFsgVGltZW91 dCBdCiAKLXdlYmtpdC5vcmcvYi8xMTMyMTkgZmFzdC9kb20vZXhjZXB0aW9uLWluLWJpbmRpbmcu aHRtbCBbIEZhaWx1cmUgXQotCiB3ZWJraXQub3JnL2IvMTEzNDc0IGh0dHAvdGVzdHMvY2FjaGUv c3VicmVzb3VyY2UtZmFpbG92ZXItdG8tbmV0d29yay5odG1sIFsgUGFzcyBGYWlsdXJlIF0KIAog d2Via2l0Lm9yZy9iLzExMzQ4NyBbIERlYnVnIF0gcGx1Z2lucy9ucHJ1bnRpbWUvbnBydW50aW1l LWNhbGxzLXdpdGgtbnVsbC1ucHAuaHRtbCBbIFBhc3MgVGltZW91dCBdCg==