<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>113216</bug_id>
          
          <creation_ts>2013-03-25 09:48:11 -0700</creation_ts>
          <short_desc>[GTK] [gyp] Build the final piece of WebCore</short_desc>
          <delta_ts>2013-03-25 13:08:32 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKitGTK</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>113213</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Martin Robinson">mrobinson</reporter>
          <assigned_to name="Martin Robinson">mrobinson</assigned_to>
          <cc>dpranke</cc>
    
    <cc>gustavo</cc>
    
    <cc>thakis</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>862856</commentid>
    <comment_count>0</comment_count>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2013-03-25 09:48:11 -0700</bug_when>
    <thetext>Build the rest of the WebCore source files.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>862859</commentid>
    <comment_count>1</comment_count>
      <attachid>194874</attachid>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2013-03-25 09:51:38 -0700</bug_when>
    <thetext>Created attachment 194874
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>862991</commentid>
    <comment_count>2</comment_count>
      <attachid>194874</attachid>
    <who name="Nico Weber">thakis</who>
    <bug_when>2013-03-25 12:58:08 -0700</bug_when>
    <thetext>Comment on attachment 194874
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=194874&amp;action=review

&gt; Source/WebCore/WebCore.gyp/WebCoreGTK.gyp:904
&gt; +        [&apos;exclude&apos;, &apos;plugins/PluginPackageNone\\.cpp$&apos;],

fyi: You can also have a &apos;sources!&apos; section, which is a list of files to exclude, for things that don&apos;t need to be regex matches.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>863000</commentid>
    <comment_count>3</comment_count>
      <attachid>194874</attachid>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2013-03-25 13:08:28 -0700</bug_when>
    <thetext>Comment on attachment 194874
Patch

Clearing flags on attachment: 194874

Committed r146800: &lt;http://trac.webkit.org/changeset/146800&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>863001</commentid>
    <comment_count>4</comment_count>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2013-03-25 13:08:32 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>194874</attachid>
            <date>2013-03-25 09:51:38 -0700</date>
            <delta_ts>2013-03-25 13:08:28 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-113216-20130325094722.patch</filename>
            <type>text/plain</type>
            <size>2462</size>
            <attacher name="Martin Robinson">mrobinson</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ2Nzc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWQyOTRlNWE2Nzc1OWRj
MDg5N2Q0M2Y1YTk3MTllZjM3MmEyOTNkOS4uMzBhYTMwMGY1NDQyNGQzODg3YzVlZDFlMWJmZGM3
ODliMTA1NWYwZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDEzLTAzLTI1ICBNYXJ0
aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBbZ3lw
XSBCdWlsZCB0aGUgZmluYWwgcGllY2Ugb2YgV2ViQ29yZQorICAgICAgICBodHRwczovL2J1Z3Mu
d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEzMjE2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg
Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJDb3JlLmd5cC9XZWJDb3JlR1RLLmd5cDog
QWRkIHRoZSByZXN0IG9mIHRoZSBXZWJDb3JlIHNvdXJjZSBmaWxlcyB0byB0aGUgV2ViQ29yZSBi
dWlsZCB0YXJnZXQuCisKIDIwMTMtMDMtMjUgIEFuZHJleSBLb3N5YWtvdiAgPGNhc2VxQGNocm9t
aXVtLm9yZz4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBbVGltZWxpbmVdIHNldCBnbHVlIHJl
Y29yZHMgbW9kZSBvZmYgYnkgZGVmYXVsdApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvV2Vi
Q29yZS5neXAvV2ViQ29yZUdUSy5neXAgYi9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLmd5cC9XZWJD
b3JlR1RLLmd5cAppbmRleCBlZjE5MjBiOWI0MTQ2YTliNmU4ZDI3NzA2ZjNhNWIxMmM5NWUyMDc3
Li5kYTJlYjJlNzBiOWM2NTQyNWI1MTgzOTIxMWY1YmMwMDZiZDA2YzBmIDEwMDY0NAotLS0gYS9T
b3VyY2UvV2ViQ29yZS9XZWJDb3JlLmd5cC9XZWJDb3JlR1RLLmd5cAorKysgYi9Tb3VyY2UvV2Vi
Q29yZS9XZWJDb3JlLmd5cC9XZWJDb3JlR1RLLmd5cApAQCAtODc0LDYgKzg3NCwzNyBAQAogICAg
ICAgXSwKICAgICB9LAogICAgIHsKKyAgICAgICd0YXJnZXRfbmFtZSc6ICdXZWJDb3JlUmVtYWlu
aW5nJywKKyAgICAgICd0eXBlJzogJ3N0YXRpY19saWJyYXJ5JywKKyAgICAgICdkZXBlbmRlbmNp
ZXMnOiBbICdXZWJDb3JlRGVwZW5kZW5jaWVzJywgXSwKKyAgICAgICdpbmNsdWRlX2RpcnMnOiBb
ICc8QCh3ZWJjb3JlZ3RrX2luY2x1ZGVfZGlycyknLCBdLAorICAgICAgJ3NvdXJjZXMnOiBbICc8
QCh3ZWJjb3JlX2ZpbGVzKScsIF0sCisgICAgICAnc291cmNlcy8nOiBbCisgICAgICAgIFsnZXhj
bHVkZScsICdwbGF0Zm9ybS8nXSwKKyAgICAgICAgWydleGNsdWRlJywgJ3JlbmRlcmluZy8nXSwK
KworICAgICAgICAjIEV4Y2x1ZGUgbW9zdCBvZiBiaW5kaW5ncywgZXhjZXB0IG9mIHRoZSBKU0Mt
cmVsYXRlZCBwYXJ0cy4KKyAgICAgICAgWydleGNsdWRlJywgJ2JpbmRpbmdzL1teL10rLyddLAor
ICAgICAgICBbJ2luY2x1ZGUnLCAnYmluZGluZ3MvZ2VuZXJpYy8nXSwKKyAgICAgICAgWydpbmNs
dWRlJywgJ2JpbmRpbmdzL2pzLyddLAorICAgICAgICBbJ2luY2x1ZGUnLCAnYmluZGluZ3MvU2Ny
aXB0Q29udHJvbGxlckJhc2VcXC5jcHAkJ10sCisKKyAgICAgICAgIyBFeGNsdWRlIG1vc3Qgb2Yg
YnJpZGdlLCBleGNlcHQgZm9yIHRoZSBKU0MtcmVsYXRlZCBwYXJ0cy4KKyAgICAgICAgWydleGNs
dWRlJywgJ2JyaWRnZS92OCddLAorICAgICAgICBbJ2V4Y2x1ZGUnLCAnYnJpZGdlL29iamMnXSwK
KyAgICAgICAgWydleGNsdWRlJywgJ2JyaWRnZS9xdCddLAorICAgICAgICBbJ2V4Y2x1ZGUnLCAn
YnJpZGdlL3Rlc3RiaW5kaW5ncy4qJ10sCisKKyAgICAgICAgWydleGNsdWRlJywgJzwoZXhjbHVk
ZWRfZGlyZWN0b3JpZXNfcGF0dGVybiknXSwKKyAgICAgICAgWydleGNsdWRlJywgJzwoZXhjbHVk
ZWRfZmlsZXNfc3VmZml4ZXMpJ10sCisgICAgICAgIFsnZXhjbHVkZScsICc8KGV4Y2x1ZGVkX2Zp
bGVzX3BhdHRlcm5zKSddLAorICAgICAgICBbJ2V4Y2x1ZGUnLCAnQWxsSW5PbmVcXC5jcHAkJ10s
CisKKyAgICAgICAgWydleGNsdWRlJywgJ3BsdWdpbnMvUGx1Z2luRGF0YU5vbmVcXC5jcHAkJ10s
CisgICAgICAgIFsnZXhjbHVkZScsICdwbHVnaW5zL1BsdWdpblBhY2thZ2VOb25lXFwuY3BwJCdd
LAorICAgICAgXSwKKyAgICB9LAorICAgIHsKICAgICAgICd0YXJnZXRfbmFtZSc6ICdXZWJDb3Jl
JywKICAgICAgICd0eXBlJzogJ25vbmUnLAogICAgICAgJ2RlcGVuZGVuY2llcyc6IFsKQEAgLTg4
Miw2ICs5MTMsNyBAQAogICAgICAgICAnV2ViQ29yZUJpbmRpbmdzJywKICAgICAgICAgJ1dlYkNv
cmVQbGF0Zm9ybScsCiAgICAgICAgICdXZWJDb3JlUGxhdGZvcm1HZW9tZXRyeScsCisgICAgICAg
ICdXZWJDb3JlUmVtYWluaW5nJywKICAgICAgICAgJ1dlYkNvcmVSZW5kZXJpbmcnLAogICAgICAg
XSwKICAgICB9LAo=
</data>

          </attachment>
      

    </bug>

</bugzilla>