113215 2013-03-25 09:44:27 -0700 Convert WebInputEvent::GestureDoubleTap to PlatformEvent::NoType 2013-03-26 09:07:38 -0700 1 1 1 Unclassified WebKit UI Events 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 miletus miletus miletus mnaganov rbyers tonikitoo webkit.review.bot oldest_to_newest 862853 0 miletus 2013-03-25 09:44:27 -0700 In bug 93045 we removed PlatformEvent::GestureDoubleTap since now DoubleTap gesture is implemented as a Tap gesture with tap_count = 2. But in WebViewImpl::handleGestureEvent(), a PlatformEvent is built from the WebGestureEvent regardless, even though the PlatfromEvent will never reach the WebCore. (DoubleTap in our case, it is only handled in WebViewImpl for doube-tap-to-zoom). And WebInpuEventConversion.cpp::PlatformGestureEventBuilder() will reach ASSERT_NOT_REACHED() when WebInputEvent::GestureDoubleTap is passed in. So the cleanest solution to me is to convert the WebGestureEvent::DoubleTap to a PlatformEvent::NoType, this makes the conversion list from WebInputEvent to PlatformEvent complete and we don't need a special handling for the DoubleTap event in WebViewImpl::handleGestureEvent() 862884 1 194880 miletus 2013-03-25 10:24:09 -0700 Created attachment 194880 Patch 862888 2 miletus 2013-03-25 10:26:26 -0700 hi tonikitoo, would you mind taking a look at this ? 863714 3 194880 webkit.review.bot 2013-03-26 09:07:35 -0700 Comment on attachment 194880 Patch Clearing flags on attachment: 194880 Committed r146894: <http://trac.webkit.org/changeset/146894> 863715 4 webkit.review.bot 2013-03-26 09:07:38 -0700 All reviewed patches have been landed. Closing bug. 194880 2013-03-25 10:24:09 -0700 2013-03-26 09:07:34 -0700 Patch bug-113215-20130325131952.patch text/plain 2865 miletus U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ2Nzg2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDE4YmY1NGJjYWJkZjE1ZDhlYjA0ZDdmNDQwMjMxZjE1MzkzZTUxNDQuLjg4ZTc1YWY0MGY1ZDFk MWUyZGVhNzJjZWJkNWIyNzBhZjgzYjAxZWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjYgQEAKKzIwMTMtMDMtMjUgIFl1ZmVuZyBTaGVuICA8bWlsZXR1c0BjaHJvbWl1 bS5vcmc+CisKKyAgICAgICAgQ29udmVydCBXZWJJbnB1dEV2ZW50OjpHZXN0dXJlRG91YmxlVGFw IHRvICBQbGF0Zm9ybUV2ZW50OjpOb1R5cGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTExMzIxNQorCisgICAgICAgIEluIGJ1ZyA5MzA0NSB3ZSByZW1v dmVkIFBsYXRmb3JtRXZlbnQ6Okdlc3R1cmVEb3VibGVUYXAgc2luY2Ugbm93IERvdWJsZVRhcCBn ZXN0dXJlCisgICAgICAgIGlzIGltcGxlbWVudGVkIGFzIGEgVGFwIGdlc3R1cmUgd2l0aCB0YXBf Y291bnQgPSAyLgorCisgICAgICAgIEluIFdlYlZpZXdJbXBsOjpoYW5kbGVHZXN0dXJlRXZlbnQo KSwgYSBQbGF0Zm9ybUV2ZW50IGlzIGJ1aWx0IGZyb20gdGhlIFdlYkdlc3R1cmVFdmVudAorICAg ICAgICByZWdhcmRsZXNzLCBldmVuIHRob3VnaCB0aGUgUGxhdGZyb21FdmVudCB3aWxsIG5ldmVy IHJlYWNoIHRoZSBXZWJDb3JlLiBEb3VibGVUYXAsIGluCisgICAgICAgIG91ciBjYXNlLCBpcyBv bmx5IGhhbmRsZWQgaW4gV2ViVmlld0ltcGwgZm9yIGRvdWJlLXRhcC10by16b29tLCB3aWxsIGFs c28gZ28gdGhyb3VnaAorICAgICAgICBjb252ZXJzaW9uIGluIFdlYklucHVFdmVudENvbnZlcnNp b24uY3BwOjpQbGF0Zm9ybUdlc3R1cmVFdmVudEJ1aWxkZXIoKSBhbmQgcmVhY2gKKyAgICAgICAg QVNTRVJUX05PVF9SRUFDSEVEKCkKKworICAgICAgICBUaGlzIHBhdGNoIGNvbnZlcnRzIFdlYkdl c3R1cmVFdmVudDo6RG91YmxlVGFwIHRvIFBsYXRmb3JtRXZlbnQ6Ok5vVHlwZSwgdGhpcyBtYWtl cyB0aGUKKyAgICAgICAgY29udmVyc2lvbiBsaXN0IGZyb20gV2ViSW5wdXRFdmVudCB0byBQbGF0 Zm9ybUV2ZW50IGNvbXBsZXRlIGFuZCB3ZSBkb24ndCBuZWVkIGEgc3BlY2lhbAorICAgICAgICBo YW5kbGluZyBmb3IgdGhlIERvdWJsZVRhcCBldmVudCBpbiBXZWJWaWV3SW1wbDo6aGFuZGxlR2Vz dHVyZUV2ZW50KCkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIHNyYy9XZWJJbnB1dEV2ZW50Q29udmVyc2lvbi5jcHA6CisgICAgICAgIChXZWJLaXQ6 OlBsYXRmb3JtR2VzdHVyZUV2ZW50QnVpbGRlcjo6UGxhdGZvcm1HZXN0dXJlRXZlbnRCdWlsZGVy KToKKwogMjAxMy0wMy0yNSAgQWxleGVpIEZpbGlwcG92ICA8YWxwaEBjaHJvbWl1bS5vcmc+CiAK ICAgICAgICAgV2ViIEluc3BlY3RvcjogRm9udHMgcmVmYWN0b3JpbmcKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYklucHV0RXZlbnRDb252ZXJzaW9uLmNwcCBiL1Nv dXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYklucHV0RXZlbnRDb252ZXJzaW9uLmNwcAppbmRl eCA0NTM0MGJkMDQwNjBlYWU0MDY0YzE4YmViOTQ3NzAwYzc5MzNiNzhlLi4yZTMzMDUwMDUzYmI4 NzMyYmQxYzVjMmM5NDk2ZjhhYjgwM2NkMDAyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL3NyYy9XZWJJbnB1dEV2ZW50Q29udmVyc2lvbi5jcHAKKysrIGIvU291cmNlL1dlYktp dC9jaHJvbWl1bS9zcmMvV2ViSW5wdXRFdmVudENvbnZlcnNpb24uY3BwCkBAIC0xODYsNiArMTg2 LDEzIEBAIFBsYXRmb3JtR2VzdHVyZUV2ZW50QnVpbGRlcjo6UGxhdGZvcm1HZXN0dXJlRXZlbnRC dWlsZGVyKFdpZGdldCogd2lkZ2V0LCBjb25zdCBXCiAgICAgY2FzZSBXZWJJbnB1dEV2ZW50OjpH ZXN0dXJlVGFwQ2FuY2VsOgogICAgICAgICBtX3R5cGUgPSBQbGF0Zm9ybUV2ZW50OjpHZXN0dXJl VGFwRG93bkNhbmNlbDsKICAgICAgICAgYnJlYWs7CisgICAgY2FzZSBXZWJJbnB1dEV2ZW50OjpH ZXN0dXJlRG91YmxlVGFwOgorICAgICAgICAvLyBEb3VibGVUYXAgZ2VzdHVyZSBpcyBub3cgaGFu ZGxlZCBhcyBQbGF0Zm9ybUV2ZW50OjpHZXN0dXJlVGFwIHdpdGggdGFwX2NvdW50ID0gMi4gU28g bm8KKyAgICAgICAgLy8gbmVlZCB0byBjb252ZXJ0IHRvIGEgUGxhdGZyb20gRG91YmxlVGFwIGdl c3R1cmUuIEJ1dCBpbiBXZWJWaWV3SW1wbDo6aGFuZGxlR2VzdHVyZUV2ZW50CisgICAgICAgIC8v IGFsbCBXZWJHZXN0dXJlRXZlbnQgYXJlIGNvbnZlcnRlZCB0byBQbGF0Zm9ybUdlc3R1cmVFdmVu dCwgZm9yIGNvbXBsZXRlbmVzcyBhbmQgbm90IHJlYWNoCisgICAgICAgIC8vIHRoZSBBU1NFUlRf Tk9UX1JFQUNIRUQoKSBhdCB0aGUgZW5kLCBjb252ZXJ0IHRoZSBEb3VibGVUYXAgdG8gYSBOb1R5 cGUuCisgICAgICAgIG1fdHlwZSA9IFBsYXRmb3JtRXZlbnQ6Ok5vVHlwZTsKKyAgICAgICAgYnJl YWs7CiAgICAgY2FzZSBXZWJJbnB1dEV2ZW50OjpHZXN0dXJlVHdvRmluZ2VyVGFwOgogICAgICAg ICBtX3R5cGUgPSBQbGF0Zm9ybUV2ZW50OjpHZXN0dXJlVHdvRmluZ2VyVGFwOwogICAgICAgICBt X2FyZWEgPSBleHBhbmRlZEludFNpemUoRmxvYXRTaXplKGUuZGF0YS50d29GaW5nZXJUYXAuZmly c3RGaW5nZXJXaWR0aCAvIHNjYWxlLCBlLmRhdGEudHdvRmluZ2VyVGFwLmZpcnN0RmluZ2VySGVp Z2h0IC8gc2NhbGUpKTsK