<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>113212</bug_id>
          
          <creation_ts>2013-03-25 09:25:52 -0700</creation_ts>
          <short_desc>[GTK] [gyp] Add support for building the platform directory</short_desc>
          <delta_ts>2013-03-25 11:21:41 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKitGTK</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>113213</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Martin Robinson">mrobinson</reporter>
          <assigned_to name="Martin Robinson">mrobinson</assigned_to>
          <cc>dpranke</cc>
    
    <cc>gustavo</cc>
    
    <cc>thakis</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>862832</commentid>
    <comment_count>0</comment_count>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2013-03-25 09:25:52 -0700</bug_when>
    <thetext>The platform directory holds the implementation of the platform layer.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>862845</commentid>
    <comment_count>1</comment_count>
      <attachid>194871</attachid>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2013-03-25 09:35:14 -0700</bug_when>
    <thetext>Created attachment 194871
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>862913</commentid>
    <comment_count>2</comment_count>
      <attachid>194871</attachid>
    <who name="Nico Weber">thakis</who>
    <bug_when>2013-03-25 11:00:56 -0700</bug_when>
    <thetext>Comment on attachment 194871
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=194871&amp;action=review

&gt; Source/WebCore/ChangeLog:10
&gt; +        of Chromium.

FYI: We use so many platforms in chromium due to the windows linker running out of memory otherwise (we have to use the 32 bit linker).

If you don&apos;t need to support windows, you might be able to do with fewer targets if you like.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>862919</commentid>
    <comment_count>3</comment_count>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2013-03-25 11:05:09 -0700</bug_when>
    <thetext>(In reply to comment #2)

&gt; FYI: We use so many platforms in chromium due to the windows linker running out of memory otherwise (we have to use the 32 bit linker).
&gt; 
&gt; If you don&apos;t need to support windows, you might be able to do with fewer targets if you like.

We manage to have this same issue downstream on 32-bit systems as well. :(</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>862930</commentid>
    <comment_count>4</comment_count>
      <attachid>194871</attachid>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2013-03-25 11:21:39 -0700</bug_when>
    <thetext>Comment on attachment 194871
Patch

Clearing flags on attachment: 194871

Committed r146789: &lt;http://trac.webkit.org/changeset/146789&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>862931</commentid>
    <comment_count>5</comment_count>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2013-03-25 11:21:41 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>194871</attachid>
            <date>2013-03-25 09:35:14 -0700</date>
            <delta_ts>2013-03-25 11:21:38 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-113212-20130325093058.patch</filename>
            <type>text/plain</type>
            <size>2919</size>
            <attacher name="Martin Robinson">mrobinson</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ2Nzc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWQyOTRlNWE2Nzc1OWRj
MDg5N2Q0M2Y1YTk3MTllZjM3MmEyOTNkOS4uYTNlZmU5ZWNhNTAwMzJiOTk0YmU0ZjRhZmRkMmZk
MTFjZTBhODc5NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEzLTAzLTI1ICBNYXJ0
aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBbZ3lw
XSBBZGQgc3VwcG9ydCBmb3IgYnVpbGRpbmcgdGhlIHBsYXRmb3JtIGRpcmVjdG9yeQorICAgICAg
ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEzMjEyCisKKyAgICAg
ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJDb3JlLmd5cC9X
ZWJDb3JlR1RLLmd5cDogQWRkIHN1cHBvcnQgZm9yIGJ1aWxkaW5nIHRoZSBwbGF0Zm9ybSBkaXJl
Y3RvcnkgaW5jbHVkaW5nCisgICAgICAgIHR3byBsaWJyYXJpZXMsIG9uZSBmb3IgcGxhdGZvcm0g
YW5kIG9uZSBmb3IgZ2VvbWV0cnkgZmlsZXMuIFRoaXMgZm9sbG93cyB0aGUgYXBwcm9hY2gKKyAg
ICAgICAgb2YgQ2hyb21pdW0uCisKIDIwMTMtMDMtMjUgIEFuZHJleSBLb3N5YWtvdiAgPGNhc2Vx
QGNocm9taXVtLm9yZz4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBbVGltZWxpbmVdIHNldCBn
bHVlIHJlY29yZHMgbW9kZSBvZmYgYnkgZGVmYXVsdApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv
cmUvV2ViQ29yZS5neXAvV2ViQ29yZUdUSy5neXAgYi9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLmd5
cC9XZWJDb3JlR1RLLmd5cAppbmRleCA3ZDk2NjI2ZmY1ZDJjNGQzZGQxZDllOTlmZDgwMmY0MWZl
OTUzMWQyLi41MzA0Mzk3NzE0N2VmMTAwMDVhYzdmZTJiNjViNmJhOWNiZWQ4NWYxIDEwMDY0NAot
LS0gYS9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLmd5cC9XZWJDb3JlR1RLLmd5cAorKysgYi9Tb3Vy
Y2UvV2ViQ29yZS9XZWJDb3JlLmd5cC9XZWJDb3JlR1RLLmd5cApAQCAtODI0LDEyICs4MjQsNDgg
QEAKICAgICAgIF0sCiAgICAgfSwKICAgICB7CisgICAgICAndGFyZ2V0X25hbWUnOiAnV2ViQ29y
ZVBsYXRmb3JtJywKKyAgICAgICd0eXBlJzogJ3N0YXRpY19saWJyYXJ5JywKKyAgICAgICdkZXBl
bmRlbmNpZXMnOiBbICdXZWJDb3JlRGVwZW5kZW5jaWVzJywgXSwKKyAgICAgICdpbmNsdWRlX2Rp
cnMnOiBbICc8QCh3ZWJjb3JlZ3RrX2luY2x1ZGVfZGlycyknLCBdLAorICAgICAgJ3NvdXJjZXMn
OiBbCisgICAgICAgICc8QCh3ZWJjb3JlX3BsYXRmb3JtX2ZpbGVzKScsCisgICAgICAgICcuLi9Q
bGF0Zm9ybS9ndGsvR3RrVmVyc2lvbmluZy5oJywKKyAgICAgICBdLAorICAgICAgJ3NvdXJjZXMv
JzogWworICAgICAgICBbJ2V4Y2x1ZGUnLCAnLionXSwKKyAgICAgICAgWydpbmNsdWRlJywgJ3Bs
YXRmb3JtLyddLAorCisgICAgICAgIFsnZXhjbHVkZScsICc8KGV4Y2x1ZGVkX2RpcmVjdG9yaWVz
X3BhdHRlcm4pJ10sCisgICAgICAgIFsnZXhjbHVkZScsICc8KGV4Y2x1ZGVkX2ZpbGVzX3N1ZmZp
eGVzKSddLAorICAgICAgICBbJ2V4Y2x1ZGUnLCAnPChleGNsdWRlZF9maWxlc19wYXR0ZXJucykn
XSwKKyAgICAgICAgWydleGNsdWRlJywgJ3BsYXRmb3JtL1RoZW1lXFwuY3BwJCddLAorICAgICAg
ICBbJ2V4Y2x1ZGUnLCAncGxhdGZvcm0vaW1hZ2UtZW5jb2RlcnMvLipJbWFnZUVuY29kZXJcXC4o
Y3BwfGgpJCddLAorICAgICAgICBbJ2V4Y2x1ZGUnLCAncGxhdGZvcm0vdGV4dC9Mb2NhbGVUb1Nj
cmlwdE1hcHBpbmdJQ1VcXC5jcHAkJ10sCisgICAgICAgIFsnZXhjbHVkZScsICdwbGF0Zm9ybS90
ZXh0L1RleHRFbmNvZGluZ0RldGVjdG9yTm9uZVxcLmNwcCQnXSwKKyAgICAgICAgWydleGNsdWRl
JywgJ3BsYXRmb3JtL2dyYXBoaWNzL0ZvbnRQbGF0Zm9ybURhdGFcXC5jcHAkJ10sCisgICAgICAg
IFsnZXhjbHVkZScsICdwbGF0Zm9ybS9ncmFwaGljcy9oYXJmYnV6ei9Gb250SGFyZkJ1enpcXC5j
cHAkJ10sCisgICAgICAgIFsnZXhjbHVkZScsICdwbGF0Zm9ybS9ncmFwaGljcy9oYXJmYnV6ei9I
YXJmQnV6ekZhY2VDb3JlVGV4dFxcLmNwcCQnXSwKKyAgICAgICAgWydleGNsdWRlJywgJ3BsYXRm
b3JtL2dyYXBoaWNzL2hhcmZidXp6L0ZvbnRQbGF0Zm9ybURhdGFIYXJmQnV6elxcLmNwcCQnXSwK
KyAgICAgICAgWydleGNsdWRlJywgJ3BsYXRmb3JtL25ldHdvcmsvTmV0d29ya1N0b3JhZ2VTZXNz
aW9uU3R1YlxcLmNwcCQnXSwKKyAgICAgIF0sCisgICAgfSwKKyAgICB7CisgICAgICAndGFyZ2V0
X25hbWUnOiAnV2ViQ29yZVBsYXRmb3JtR2VvbWV0cnknLAorICAgICAgJ3R5cGUnOiAnc3RhdGlj
X2xpYnJhcnknLAorICAgICAgJ2RlcGVuZGVuY2llcyc6IFsgJ1dlYkNvcmVEZXBlbmRlbmNpZXMn
LCBdLAorICAgICAgJ2luY2x1ZGVfZGlycyc6IFsgJzxAKHdlYmNvcmVndGtfaW5jbHVkZV9kaXJz
KScsIF0sCisgICAgICAnc291cmNlcyc6IFsgJzxAKHdlYmNvcmVfcGxhdGZvcm1fZ2VvbWV0cnlf
ZmlsZXMpJywgXSwKKyAgICB9LAorICAgIHsKICAgICAgICd0YXJnZXRfbmFtZSc6ICdXZWJDb3Jl
JywKICAgICAgICd0eXBlJzogJ25vbmUnLAotICAgICAgJ2RlcGVuZGVuY2llcyc6IFsgCisgICAg
ICAnZGVwZW5kZW5jaWVzJzogWwogICAgICAgICAnV2ViQ29yZURPTScsCiAgICAgICAgICdXZWJD
b3JlSFRNTCcsCiAgICAgICAgICdXZWJDb3JlQmluZGluZ3MnLAorICAgICAgICAnV2ViQ29yZVBs
YXRmb3JtJywKKyAgICAgICAgJ1dlYkNvcmVQbGF0Zm9ybUdlb21ldHJ5JywKICAgICAgIF0sCiAg
ICAgfSwKICAgXSwK
</data>

          </attachment>
      

    </bug>

</bugzilla>