113181 2013-03-25 02:43:08 -0700 Remove unused code from Frame class destructor 2013-03-25 13:55:46 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mikhail.pozdnyakov mikhail.pozdnyakov kenneth mjs webkit.review.bot oldest_to_newest 862592 0 mikhail.pozdnyakov 2013-03-25 02:43:08 -0700 The following code snipped inside Frame::~Frame() if (m_view) { m_view->hide(); m_view->clearFrame(); } does not make sense as m_view had been already set to '0' within the same function 862601 1 194813 mikhail.pozdnyakov 2013-03-25 02:52:39 -0700 Created attachment 194813 patch 863039 2 194813 webkit.review.bot 2013-03-25 13:55:43 -0700 Comment on attachment 194813 patch Clearing flags on attachment: 194813 Committed r146815: <http://trac.webkit.org/changeset/146815> 863040 3 webkit.review.bot 2013-03-25 13:55:46 -0700 All reviewed patches have been landed. Closing bug. 194813 2013-03-25 02:52:39 -0700 2013-03-25 13:55:43 -0700 patch bug113181 text/plain 1512 mikhail.pozdnyakov Y29tbWl0IDkzZTUzNjE5OGNlMDAzMzY5NDY2MjZhYTRiNjgyNDAxYmU2YTFlNTQKQXV0aG9yOiBN aWtoYWlsIFBvemRueWFrb3YgPG1pa2hhaWwucG96ZG55YWtvdkBpbnRlbC5jb20+CkRhdGU6ICAg TW9uIE1hciAyNSAxMTo0NjoyNyAyMDEzICswMjAwCgogICAgYnVnMTEzMTgxCgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmlu ZGV4IGIwZTEzZTAuLjkzN2YxY2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxv ZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMy0w My0yNSAgTWlraGFpbCBQb3pkbnlha292ICA8bWlraGFpbC5wb3pkbnlha292QGludGVsLmNvbT4K KworICAgICAgICBSZW1vdmUgdW51c2VkIGNvZGUgZnJvbSBGcmFtZSBjbGFzcyBkZXN0cnVjdG9y CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTMxODEK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcg dGVzdHMuIE5vIG5ldyBmdW5jdGlvbmFsaXR5LgorCisgICAgICAgICogcGFnZS9GcmFtZS5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpGcmFtZTo6fkZyYW1lKToKKworICAgICAgICAgICAgUmVtb3Zl ZCB0aGUgY29kZSB3aGljaCBjb3VsZCBuZXZlciBoYXZlIGJlZW4gZXhlY3V0ZWQKKyAgICAgICAg ICAgIGFzIG1fdmlldyBoYWQgYmVlbiBzZXQgdG8gJzAnLgorCiAyMDEzLTAzLTI1ICBQaGlzdHVj SyAgPHBoaXN0dWNrQGNocm9taXVtLm9yZz4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBFeGNl cHRpb24gd2hlbiB0dXJuaW5nIG9uIHByZXR0eSBwcmludCB3aXRob3V0IGFueSBkaXNwbGF5ZWQg c291cmNlIGluIHRoZSBlZGl0b3IKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJh bWUuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZS5jcHAKaW5kZXggMjhmZGU0OS4uYWNk NzM0MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZS5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvcGFnZS9GcmFtZS5jcHAKQEAgLTIyNCwxMSArMjI0LDYgQEAgRnJhbWU6On5G cmFtZSgpCiAgICAgSGFzaFNldDxGcmFtZURlc3RydWN0aW9uT2JzZXJ2ZXIqPjo6aXRlcmF0b3Ig c3RvcCA9IG1fZGVzdHJ1Y3Rpb25PYnNlcnZlcnMuZW5kKCk7CiAgICAgZm9yIChIYXNoU2V0PEZy YW1lRGVzdHJ1Y3Rpb25PYnNlcnZlcio+OjppdGVyYXRvciBpdCA9IG1fZGVzdHJ1Y3Rpb25PYnNl cnZlcnMuYmVnaW4oKTsgaXQgIT0gc3RvcDsgKytpdCkKICAgICAgICAgKCppdCktPmZyYW1lRGVz dHJveWVkKCk7Ci0KLSAgICBpZiAobV92aWV3KSB7Ci0gICAgICAgIG1fdmlldy0+aGlkZSgpOwot ICAgICAgICBtX3ZpZXctPmNsZWFyRnJhbWUoKTsKLSAgICB9CiB9CiAKIGJvb2wgRnJhbWU6Omlu U2NvcGUoVHJlZVNjb3BlKiBzY29wZSkgY29uc3QK