113179 2013-03-25 02:23:06 -0700 [Qt] REGRESSION(r146630): 8 text related test asserts on debug builds 2013-03-25 06:09:33 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 79668 112668 1 zarvai allan.jensen allan.jensen jturcotte kadam noam webkit.review.bot oldest_to_newest 862579 0 zarvai 2013-03-25 02:23:06 -0700 After r146630 8 test asserts on Qt debug bots: fast/canvas/2d.text.draw.fill.maxWidth.veryLarge.html fast/canvas/2d.text.draw.fill.maxWidth.negative.html fast/canvas/2d.text.draw.fill.maxWidth.verySmall.html fast/canvas/2d.text.draw.fill.maxWidth.gradient.html fast/text/word-space-with-kerning-3.html fast/text/word-space-with-kerning.html fast/text/word-space-with-kerning-2.html fast/ruby/modify-positioned-ruby-text-crash.html A build before the patch: http://build.webkit.sed.hu/results/x86-32%20Linux%20Qt%20Debug/r146629%20%2825003%29/results.html An other build after the patch: http://build.webkit.sed.hu/results/x86-64%20Linux%20Qt%20Debug/r146630%20%2828242%29/results.html An example, fast/canvas/2d.text.draw.fill.maxWidth.veryLarge.html: crash log for DumpRenderTree (pid 22094): STDOUT: <empty> STDERR: ASSERTION FAILED: i < m_len STDERR: /home/webkitbuildbot/slaves/debug64bit/buildslave/qt-linux-64-debug/build/Source/WebCore/platform/graphics/TextRun.h(158) : UChar WebCore::TextRun::operator[](unsigned int) const STDERR: 1 0x7fce4d3f19e9 /home/webkitbuildbot/slaves/debug64bit/buildslave/qt-linux-64-debug/build/WebKitBuild/Debug/lib/libQt5WebKit.so.5(+0xe189e9) [0x7fce4d3f19e9] STDERR: 2 0x7fce4d43695d /home/webkitbuildbot/slaves/debug64bit/buildslave/qt-linux-64-debug/build/WebKitBuild/Debug/lib/libQt5WebKit.so.5(+0xe5d95d) [0x7fce4d43695d] STDERR: 3 0x7fce4d436015 /home/webkitbuildbot/slaves/debug64bit/buildslave/qt-linux-64-debug/build/WebKitBuild/Debug/lib/libQt5WebKit.so.5(+0xe5d015) [0x7fce4d436015] STDERR: 4 0x7fce4d3f2d9c /home/webkitbuildbot/slaves/debug64bit/buildslave/qt-linux-64-debug/build/WebKitBuild/Debug/lib/libQt5WebKit.so.5(+0xe19d9c) [0x7fce4d3f2d9c] STDERR: 5 0x7fce4d41c6c7 /home/webkitbuildbot/slaves/debug64bit/buildslave/qt-linux-64-debug/build/WebKitBuild/Debug/lib/libQt5WebKit.so.5(+0xe436c7) [0x7fce4d41c6c7] STDERR: 6 0x7fce4d0cd792 /home/webkitbuildbot/slaves/debug64bit/buildslave/qt-linux-64-debug/build/WebKitBuild/Debug/lib/libQt5WebKit.so.5(+0xaf4792) [0x7fce4d0cd792] STDERR: 7 0x7fce4d0ccd63 /home/webkitbuildbot/slaves/debug64bit/buildslave/qt-linux-64-debug/build/WebKitBuild/Debug/lib/libQt5WebKit.so.5(+0xaf3d63) [0x7fce4d0ccd63] STDERR: 8 0x7fce4dcb461f /home/webkitbuildbot/slaves/debug64bit/buildslave/qt-linux-64-debug/build/WebKitBuild/Debug/lib/libQt5WebKit.so.5(+0x16db61f) [0x7fce4dcb461f] STDERR: 9 0x7fcdf7fff0e5 [0x7fcdf7fff0e5] 862636 1 194824 allan.jensen 2013-03-25 04:15:06 -0700 Created attachment 194824 Patch 862683 2 194824 jturcotte 2013-03-25 06:04:17 -0700 Comment on attachment 194824 Patch Wow OK, I didn't see that one either. Thanks for catching this Zoltan. 862689 3 194824 allan.jensen 2013-03-25 06:09:27 -0700 Comment on attachment 194824 Patch Clearing flags on attachment: 194824 Committed r146761: <http://trac.webkit.org/changeset/146761> 862690 4 allan.jensen 2013-03-25 06:09:33 -0700 All reviewed patches have been landed. Closing bug. 194824 2013-03-25 04:15:06 -0700 2013-03-25 06:09:27 -0700 Patch bug-113179-20130325121049.patch text/plain 1951 allan.jensen U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ2NzUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzAxZjAwYjNiNzgzNDcy NDQ2MzRiYzc2NzkyZDVlYzg3NTZiNTVkMS4uYTA3MTRjZTU2Mjk5MWJkZGNkZmI1MTBhZDNmZGNl ZDE2MGY4ZmE0OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDEzLTAzLTI1ICBBbGxh biBTYW5kZmVsZCBKZW5zZW4gIDxhbGxhbi5qZW5zZW5AZGlnaWEuY29tPgogCisgICAgICAgIFtR dF0gUkVHUkVTU0lPTihyMTQ2NjMwKTogOCB0ZXh0IHJlbGF0ZWQgdGVzdCBhc3NlcnRzIG9uIGRl YnVnIGJ1aWxkcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTEzMTc5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgVGVzdCBpZiByYW5nZS5zdGFydCBpcyB3aXRoaW4gdGhlIHZhbGlkIHJhbmdlIGJlZm9yZSB0 ZXN0aW5nIHRoZSB2YWx1ZSBhdCB0aGF0IHBvaW50LgorCisgICAgICAgICogcGxhdGZvcm0vZ3Jh cGhpY3MvcXQvRm9udFF0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZvbnQ6OmluaXRGb3JtYXRG b3JUZXh0TGF5b3V0KToKKworMjAxMy0wMy0yNSAgQWxsYW4gU2FuZGZlbGQgSmVuc2VuICA8YWxs YW4uamVuc2VuQGRpZ2lhLmNvbT4KKwogICAgICAgICBbUXRdIGVkaXRpbmcvcGFzdGVib2FyZC9j YW4tcmVhZC1pbi1kcmFnc3RhcnQtZXZlbnQuaHRtbCBhbmQgL2Nhbi1yZWFkLWluLWNvcHktYW5k LWN1dC1ldmVudHMuaHRtbCBhcmUgY3Jhc2hpbmcKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTExMzEyNgogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9Gb250UXQuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvcXQvRm9udFF0LmNwcAppbmRleCA5NmRiNTVjOTJkODYzNDUyMjU4ZDRkZDI1 N2ZjZDcwNzc2NzgzNTBkLi4zYWZiYjM1MjhlOGY0NjVkOTExMmI4Y2RiMTFlYjAxYWEwYjUwZTdh IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9Gb250UXQu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0ZvbnRRdC5jcHAK QEAgLTI1Miw4ICsyNTIsOCBAQCB2b2lkIEZvbnQ6OmluaXRGb3JtYXRGb3JUZXh0TGF5b3V0KFFU ZXh0TGF5b3V0KiBsYXlvdXQsIGNvbnN0IFRleHRSdW4mIHJ1bikgY29ucwogICAgIC8vIFRvIGF2 b2lkIHdvcmQtc3BhY2luZyBvbiBhbnkgbGVhZGluZyBzcGFjZXMsIHdlIGV4Y2x1ZGUgdGhlbSBm cm9tIEZvcm1hdFJhbmdlIHdoaWNoCiAgICAgLy8gd29yZC1zcGFjaW5nIGFsb25nIHdpdGggb3Ro ZXIgb3B0aW9ucyB3b3VsZCBiZSBhcHBsaWVkIHRvLiBUaGlzIGlzIHNhZmUgc2luY2UgdGhlIG90 aGVyCiAgICAgLy8gZm9ybWF0dGluZyBvcHRpb25zIGRvZXMgbm90IGFmZmVjdCBzcGFjZXMuCi0g ICAgdW5zaWduZWQgbGVuZ3RoID0gbGF5b3V0LT50ZXh0KCkubGVuZ3RoKCk7Ci0gICAgZm9yIChy YW5nZS5zdGFydCA9IDA7IHRyZWF0QXNTcGFjZShydW5bcmFuZ2Uuc3RhcnRdKSAmJiByYW5nZS5z dGFydCA8IGxlbmd0aDsgKytyYW5nZS5zdGFydCkgeyB9CisgICAgdW5zaWduZWQgbGVuZ3RoID0g cnVuLmxlbmd0aCgpOworICAgIGZvciAocmFuZ2Uuc3RhcnQgPSAwOyByYW5nZS5zdGFydCA8IGxl bmd0aCAmJiB0cmVhdEFzU3BhY2UocnVuW3JhbmdlLnN0YXJ0XSk7ICsrcmFuZ2Uuc3RhcnQpIHsg fQogICAgIHJhbmdlLmxlbmd0aCA9IGxlbmd0aCAtIHJhbmdlLnN0YXJ0OwogCiAgICAgaWYgKG1f d29yZFNwYWNpbmcpCg==