113152 2013-03-24 06:07:15 -0700 [EFL] NetworkStateNotifier::updateState() is called too often 2013-03-24 07:47:24 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez gyuyoung.kim kenneth laszlo.gombos lucas.de.marchi webkit.review.bot oldest_to_newest 862354 0 cdumez 2013-03-24 06:07:15 -0700 On my machine, NetworkStateNotifier::updateState() is called about 20 times per minute even though my network online state is not changing. Calling NetworkStateNotifier::updateState() is a bit expensive as it uses udev to iterate through all the network interfaces and check if they have an IP address set. We should improve our NETLINK socket handling code a bit to avoid calling NetworkStateNotifier::updateState() uselessly as much as possible. 862356 1 194746 cdumez 2013-03-24 06:15:01 -0700 Created attachment 194746 Patch 862365 2 194746 webkit.review.bot 2013-03-24 07:47:20 -0700 Comment on attachment 194746 Patch Clearing flags on attachment: 194746 Committed r146728: <http://trac.webkit.org/changeset/146728> 862366 3 webkit.review.bot 2013-03-24 07:47:24 -0700 All reviewed patches have been landed. Closing bug. 194746 2013-03-24 06:15:01 -0700 2013-03-24 07:47:20 -0700 Patch 113152_netlink_perf.patch text/plain 2795 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBmN2FlZTkyLi45YzY0ZjFkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjYg QEAKKzIwMTMtMDMtMjQgIENocmlzdG9waGUgRHVtZXogIDxjaC5kdW1lekBzaXNhLnNhbXN1bmcu Y29tPgorCisgICAgICAgIFtFRkxdIE5ldHdvcmtTdGF0ZU5vdGlmaWVyOjp1cGRhdGVTdGF0ZSgp IGlzIGNhbGxlZCB0b28gb2Z0ZW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTExMzE1MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFdhaXQgdW50aWwgd2UgaGF2ZSByZWFkIGFsbCB0aGUgZGF0YSBvbiB0aGUg TmV0bGluayBzb2NrZXQgYmVmb3JlCisgICAgICAgIHJlcG9ydGluZyBhIHBvc3NpYmxlIG5ldHdv cmsgaW50ZXJmYWNlIGNoYW5nZS4gVGhpcyB3YXksIHdlIG1ha2UKKyAgICAgICAgc3VyZSB3ZSBk b24ndCBjYWxsIE5ldHdvcmtTdGF0ZU5vdGlmaWVyOjp1cGRhdGVTdGF0ZSgpIHNldmVyYWwKKyAg ICAgICAgdGltZXMgaW4gYSByb3cgZm9yIG5vIHJlYXNvbi4KKworICAgICAgICBXZSBhbHNvIGNh bGwgTmV0d29ya1N0YXRlTm90aWZpZXI6OnVwZGF0ZVN0YXRlKCkgb25seSBpZiB3ZSBnZXQgYQor ICAgICAgICBSVE1fTkVXQUREUiBldmVudCBhbmQgd2UgYXJlIGN1cnJlbnRseSBvZmZsaW5lLCBv ciBpZiB3ZSBnZXQgYQorICAgICAgICBSVE1fREVMQUREUiBhbmQgd2UgYXJlIGN1cnJlbnRseSBv bmxpbmUuIFRoaXMgYXZvaWRzIGNhbGxpbmcKKyAgICAgICAgTmV0d29ya1N0YXRlTm90aWZpZXI6 OnVwZGF0ZVN0YXRlKCkgdXNlbGVzc2x5IGFzIHRoZXJlIGlzIG5vIHdheQorICAgICAgICB0aGUg b25saW5lIHN0YXRlIGNhbiBjaGFuZ2Ugb3RoZXJ3aXNlLgorCisgICAgICAgIE5vIG5ldyB0ZXN0 cywgbm8gYmVoYXZpb3IgY2hhbmdlIGZvciBsYXlvdXQgdGVzdHMuCisKKyAgICAgICAgKiBwbGF0 Zm9ybS9uZXR3b3JrL2VmbC9OZXR3b3JrU3RhdGVOb3RpZmllckVmbC5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpOZXR3b3JrU3RhdGVOb3RpZmllcjo6cmVhZFNvY2tldENhbGxiYWNrKToKKwogMjAx My0wMy0yNCAgQ2hyaXMgRmxlaXphY2ggIDxjZmxlaXphY2hAYXBwbGUuY29tPgogCiAgICAgICAg IEFYOiBDcmFzaCBpbiBXZWJDb3JlOjpBY2Nlc3NpYmlsaXR5U3BpbkJ1dHRvbjo6aW5jcmVtZW50 QnV0dG9uKCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvZWZs L05ldHdvcmtTdGF0ZU5vdGlmaWVyRWZsLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25l dHdvcmsvZWZsL05ldHdvcmtTdGF0ZU5vdGlmaWVyRWZsLmNwcAppbmRleCBjNTBmODIyLi5mZGRj MjBkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2VmbC9OZXR3 b3JrU3RhdGVOb3RpZmllckVmbC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0 d29yay9lZmwvTmV0d29ya1N0YXRlTm90aWZpZXJFZmwuY3BwCkBAIC0xMDgsNiArMTA4LDggQEAg RWluYV9Cb29sIE5ldHdvcmtTdGF0ZU5vdGlmaWVyOjpyZWFkU29ja2V0Q2FsbGJhY2sodm9pZCog dXNlckRhdGEsIEVjb3JlX0ZkX0hhbmQKICAgICBpbnQgc29jayA9IGVjb3JlX21haW5fZmRfaGFu ZGxlcl9mZF9nZXQoaGFuZGxlcik7CiAgICAgY2hhciBidWZmZXJbYnVmZmVyU2l6ZV07CiAKKyAg ICBib29sIGRldGVjdGVkQ2hhbmdlID0gZmFsc2U7CisKICAgICBubG1zZ2hkciogbmxoID0gcmVp bnRlcnByZXRfY2FzdDxubG1zZ2hkcio+KGJ1ZmZlcik7CiAgICAgd2hpbGUgKHRydWUpIHsKICAg ICAgICAgc3NpemVfdCBsZW5ndGggPSByZWN2KHNvY2ssIG5saCwgYnVmZmVyU2l6ZSwgTVNHX0RP TlRXQUlUKTsKQEAgLTEzMSwxNCArMTMzLDE1IEBAIEVpbmFfQm9vbCBOZXR3b3JrU3RhdGVOb3Rp Zmllcjo6cmVhZFNvY2tldENhbGxiYWNrKHZvaWQqIHVzZXJEYXRhLCBFY29yZV9GZF9IYW5kCiAg ICAgICAgICAgICAgICAgbm90aWZpZXItPm1fZmRIYW5kbGVyID0gMDsKICAgICAgICAgICAgICAg ICByZXR1cm4gRUNPUkVfQ0FMTEJBQ0tfQ0FOQ0VMOwogICAgICAgICAgICAgfQotICAgICAgICAg ICAgaWYgKG5saC0+bmxtc2dfdHlwZSA9PSBSVE1fTkVXQUREUiB8fCBubGgtPm5sbXNnX3R5cGUg PT0gUlRNX0RFTEFERFIpIHsKLSAgICAgICAgICAgICAgICAvLyBXZSBkZXRlY3RlZCBhbiBJUCBh ZGRyZXNzIGNoYW5nZSwgcmVjaGVjayBvbkxpbmUgc3RhdGUuCi0gICAgICAgICAgICAgICAgbm90 aWZpZXItPm5ldHdvcmtJbnRlcmZhY2VDaGFuZ2VkKCk7Ci0gICAgICAgICAgICB9CisgICAgICAg ICAgICBpZiAoKG5saC0+bmxtc2dfdHlwZSA9PSBSVE1fTkVXQUREUiAmJiAhbm90aWZpZXItPm1f aXNPbkxpbmUpIHx8IChubGgtPm5sbXNnX3R5cGUgPT0gUlRNX0RFTEFERFIgJiYgbm90aWZpZXIt Pm1faXNPbkxpbmUpKQorICAgICAgICAgICAgICAgIGRldGVjdGVkQ2hhbmdlID0gdHJ1ZTsKICAg ICAgICAgICAgIG5saCA9IE5MTVNHX05FWFQobmxoLCBsZW5ndGgpOwogICAgICAgICB9CiAgICAg fQogCisgICAgaWYgKGRldGVjdGVkQ2hhbmdlKQorICAgICAgICBub3RpZmllci0+bmV0d29ya0lu dGVyZmFjZUNoYW5nZWQoKTsKKwogICAgIHJldHVybiBFQ09SRV9DQUxMQkFDS19SRU5FVzsKIH0K IAo=