113141 2013-03-23 17:26:23 -0700 GIFImageReader should reports parsing error to client 2013-03-24 17:38:43 -0700 1 1 1 Unclassified WebKit Images 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 hclam hclam inferno pkasting senorblanco webkit.review.bot oldest_to_newest 862276 0 hclam 2013-03-23 17:26:23 -0700 GIFImageReader hides parsing error and don't report to GIFImageDecoder. This was done to match older implementation. We shouldn't tighten up the tolerance and get rid of this complexity. 862277 1 194722 hclam 2013-03-23 17:34:47 -0700 Created attachment 194722 Patch 862278 2 194723 hclam 2013-03-23 17:50:24 -0700 Created attachment 194723 Patch 862288 3 hclam 2013-03-23 18:52:57 -0700 (In reply to comment #0) > GIFImageReader hides parsing error and don't report to GIFImageDecoder. This was done to match older implementation. We shouldn't tighten up the tolerance and get rid of this complexity. s/shouldn\'t/should/ 862363 4 194723 senorblanco 2013-03-24 07:45:13 -0700 Comment on attachment 194723 Patch Okie doke. r=me 862444 5 194723 webkit.review.bot 2013-03-24 17:38:40 -0700 Comment on attachment 194723 Patch Clearing flags on attachment: 194723 Committed r146737: <http://trac.webkit.org/changeset/146737> 862445 6 webkit.review.bot 2013-03-24 17:38:43 -0700 All reviewed patches have been landed. Closing bug. 194722 2013-03-23 17:34:47 -0700 2013-03-23 17:50:23 -0700 Patch bug-113141-20130323173033.patch text/plain 2122 hclam U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ2NzIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2I0ZjBkZTk0ZDFmMDc1 MDU5MGMzZjc1ODIwZTQ2MTdmZTUxNTY5MS4uNGJkZTVmNjMzOGVjZjZlNDI1NTU4MzQzY2M3MTQ3 Nzc2ZDBmOTRkOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTAzLTIzICBBbHBo YSBMYW0gIDxoY2xhbUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgR0lGSW1hZ2VSZWFkZXIgc2hv dWxkIHJlcG9ydHMgcGFyc2luZyBlcnJvciB0byBjbGllbnQKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMzE0MQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEdJRkltYWdlUmVhZGVyIG5vd3MgcmVwb3J0cyBw YXJzaW5nIGVycm9yIHRvIGNsaWVudCAoR0lGSW1hZ2VEZWNvZGVyKSBzdWNoIHRoYXQgZXJyb3Jz IGNhbiBiZSBoYW5kbGVkLgorICAgICAgICBJbiB0aGUgY2FzZSBvZiBjb3JydXB0ZWQgR0lGIGlt YWdlcyBHSUZJbWFnZVJlYWRlciB3aWxsIGJlIGRlbGV0ZWQgYW5kIGRlY29kaW5nIHdpbGwgZmFp bC4KKworICAgICAgICBObyBuZXcgdGVzdHMuIFRlc3RlZCB3aXRoIGEgbG9jYWwgY29ycHVzIHdo aWNoIHNob3dlZCBiZXR0ZXIgaGFuZGxpbmcgb2YgY29ycnVwdGVkIEdJRiBpbWFnZXMuCisKKyAg ICAgICAgKiBwbGF0Zm9ybS9pbWFnZS1kZWNvZGVycy9naWYvR0lGSW1hZ2VSZWFkZXIuY3BwOgor ICAgICAgICAoR0lGSW1hZ2VSZWFkZXI6OmRlY29kZSk6CisKIDIwMTMtMDMtMjMgIENhcmxvcyBH YXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdW1JlZ3Jl c3Npb25dIHdlYmtpdF9kb21faHRtbF90YWJsZV9lbGVtZW50X2luc2VydF9yb3cgcmV0dXJucyB2 YWx1ZSB0aGF0IGRvZXNuJ3QgcGFzcyBXRUJLSVRfRE9NX0lTX0hUTUxfVEFCTEVfUk9XX0VMRU1F TlQgbWFjcm8KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2ltYWdlLWRlY29k ZXJzL2dpZi9HSUZJbWFnZVJlYWRlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pbWFn ZS1kZWNvZGVycy9naWYvR0lGSW1hZ2VSZWFkZXIuY3BwCmluZGV4IDBiNzE5MjMyMmQ1YzI1ZWUy MjNjMTgzNTg1NzNkNjgxMGViNWQ3YTQuLjI0YzFlZWE5Zjc1MDFkMTZkY2E3ZDMyYWY3MzZlZjk2 NzBjNjRhOTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2ltYWdlLWRlY29k ZXJzL2dpZi9HSUZJbWFnZVJlYWRlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v aW1hZ2UtZGVjb2RlcnMvZ2lmL0dJRkltYWdlUmVhZGVyLmNwcApAQCAtMzU4LDEwICszNTgsMTAg QEAgYm9vbCBHSUZJbWFnZVJlYWRlcjo6ZGVjb2RlKEdJRkltYWdlRGVjb2Rlcjo6R0lGUXVlcnkg cXVlcnksIHVuc2lnbmVkIGhhbHRBdEZyYW0KIHsKICAgICBBU1NFUlQobV9ieXRlc1JlYWQgPD0g bV9kYXRhLT5zaXplKCkpOwogCi0gICAgLy8gVHJ5IHRvIGJlIHRvbGVyYW50IGFuZCBkb24ndCBy ZXBvcnQgcGFyc2luZyBlcnJvcnMgYnV0IHdlIHdpbGwgbm90IHBhcnNlIGFnYWluLgotICAgIC8v IFRPRE86IFJlcG9ydCBwYXJzaW5nIGVycm9ycyB0byBjbGllbnQuCi0gICAgaWYgKCFtX3BhcnNl RmFpbGVkICYmICFwYXJzZShtX2J5dGVzUmVhZCwgbV9kYXRhLT5zaXplKCkgLSBtX2J5dGVzUmVh ZCwgcXVlcnkgPT0gR0lGSW1hZ2VEZWNvZGVyOjpHSUZTaXplUXVlcnkpKQorICAgIGlmICghbV9w YXJzZUZhaWxlZCAmJiAhcGFyc2UobV9ieXRlc1JlYWQsIG1fZGF0YS0+c2l6ZSgpIC0gbV9ieXRl c1JlYWQsIHF1ZXJ5ID09IEdJRkltYWdlRGVjb2Rlcjo6R0lGU2l6ZVF1ZXJ5KSkgewogICAgICAg ICBtX3BhcnNlRmFpbGVkID0gdHJ1ZTsKKyAgICAgICAgcmV0dXJuIGZhbHNlOworICAgIH0KIAog ICAgIGlmIChxdWVyeSAhPSBHSUZJbWFnZURlY29kZXI6OkdJRkZ1bGxRdWVyeSkKICAgICAgICAg cmV0dXJuIHRydWU7Cg== 194723 2013-03-23 17:50:24 -0700 2013-03-24 17:38:40 -0700 Patch bug-113141-20130323174610.patch text/plain 4191 hclam U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ2NzIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2I0ZjBkZTk0ZDFmMDc1 MDU5MGMzZjc1ODIwZTQ2MTdmZTUxNTY5MS4uODRjMmUwMTczYmIyYTIwYjQ5NmZiMzI0YzM3ODZi ZjQ2NGRkZDY2NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTAzLTIzICBBbHBo YSBMYW0gIDxoY2xhbUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgR0lGSW1hZ2VSZWFkZXIgc2hv dWxkIHJlcG9ydHMgcGFyc2luZyBlcnJvciB0byBjbGllbnQKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMzE0MQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEdJRkltYWdlUmVhZGVyIG5vd3MgcmVwb3J0cyBw YXJzaW5nIGVycm9yIHRvIGNsaWVudCAoR0lGSW1hZ2VEZWNvZGVyKSBzdWNoIHRoYXQgZXJyb3Jz IGNhbiBiZSBoYW5kbGVkLgorICAgICAgICBJbiB0aGUgY2FzZSBvZiBjb3JydXB0ZWQgR0lGIGlt YWdlcyBHSUZJbWFnZVJlYWRlciB3aWxsIGJlIGRlbGV0ZWQgYW5kIGRlY29kaW5nIHdpbGwgZmFp bC4KKworICAgICAgICBVbml0IHRlc3QgaXMgdXBkYXRlZCB0byByZWZsZWN0IGNoYW5nZSBpbiBi ZWhhdmlvci4KKyAgICAgICAgVGVzdGVkIHdpdGggYSBsb2NhbCBjb3JwdXMgd2hpY2ggc2hvd2Vk IGJldHRlciBoYW5kbGluZyBvZiBjb3JydXB0ZWQgR0lGIGltYWdlcy4KKworICAgICAgICAqIHBs YXRmb3JtL2ltYWdlLWRlY29kZXJzL2dpZi9HSUZJbWFnZVJlYWRlci5jcHA6CisgICAgICAgIChH SUZJbWFnZVJlYWRlcjo6ZGVjb2RlKToKKwogMjAxMy0wMy0yMyAgQ2FybG9zIEdhcmNpYSBDYW1w b3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS11bUmVncmVzc2lvbl0gd2Vi a2l0X2RvbV9odG1sX3RhYmxlX2VsZW1lbnRfaW5zZXJ0X3JvdyByZXR1cm5zIHZhbHVlIHRoYXQg ZG9lc24ndCBwYXNzIFdFQktJVF9ET01fSVNfSFRNTF9UQUJMRV9ST1dfRUxFTUVOVCBtYWNybwpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi S2l0L2Nocm9taXVtL0NoYW5nZUxvZwppbmRleCBiOWZkMjg3Mzg0YTk1NGQzN2VhNTgzNjQ4ZjM2 MjUwNTRhZWU1MTM5Li43NDI3YTViNTA0MzYzNTE2ODdjZjg0ZDg0MzJlYjA4ZmE3MzhkNDgzIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZworKysgYi9Tb3VyY2Uv V2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTAzLTIzICBB bHBoYSBMYW0gIDxoY2xhbUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgR0lGSW1hZ2VSZWFkZXIg c2hvdWxkIHJlcG9ydHMgcGFyc2luZyBlcnJvciB0byBjbGllbnQKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMzE0MQorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVwZGF0ZWQgdW5pdCB0ZXN0IHRoYXQgcnVu cyBvbiBhIGJyb2tlbiBHSUYgaW1hZ2UgZmlsZSwgZGVjb2Rpbmcgc2hvdWxkIGZhaWwuCisKKyAg ICAgICAgKiB0ZXN0cy9HSUZJbWFnZURlY29kZXJUZXN0LmNwcDoKKyAgICAgICAgKFdlYktpdDo6 VEVTVCk6CisKIDIwMTMtMDMtMjIgIERhbmUgV2FsbGluZ2EgIDxkZ3dhbGxpbmdhQGNocm9taXVt Lm9yZz4KIAogICAgICAgICBBZGQgY2xpZW50IGNhbGxiYWNrcyB0byBub3RpZnkgb2YgY2hhbmdl cyBvZiBhc3NvY2lhdGVkIGZyb20gY29udHJvbHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2ltYWdlLWRlY29kZXJzL2dpZi9HSUZJbWFnZVJlYWRlci5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9pbWFnZS1kZWNvZGVycy9naWYvR0lGSW1hZ2VSZWFkZXIuY3BwCmlu ZGV4IDBiNzE5MjMyMmQ1YzI1ZWUyMjNjMTgzNTg1NzNkNjgxMGViNWQ3YTQuLjI0YzFlZWE5Zjc1 MDFkMTZkY2E3ZDMyYWY3MzZlZjk2NzBjNjRhOTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2ltYWdlLWRlY29kZXJzL2dpZi9HSUZJbWFnZVJlYWRlci5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMvZ2lmL0dJRkltYWdlUmVhZGVyLmNw cApAQCAtMzU4LDEwICszNTgsMTAgQEAgYm9vbCBHSUZJbWFnZVJlYWRlcjo6ZGVjb2RlKEdJRklt YWdlRGVjb2Rlcjo6R0lGUXVlcnkgcXVlcnksIHVuc2lnbmVkIGhhbHRBdEZyYW0KIHsKICAgICBB U1NFUlQobV9ieXRlc1JlYWQgPD0gbV9kYXRhLT5zaXplKCkpOwogCi0gICAgLy8gVHJ5IHRvIGJl IHRvbGVyYW50IGFuZCBkb24ndCByZXBvcnQgcGFyc2luZyBlcnJvcnMgYnV0IHdlIHdpbGwgbm90 IHBhcnNlIGFnYWluLgotICAgIC8vIFRPRE86IFJlcG9ydCBwYXJzaW5nIGVycm9ycyB0byBjbGll bnQuCi0gICAgaWYgKCFtX3BhcnNlRmFpbGVkICYmICFwYXJzZShtX2J5dGVzUmVhZCwgbV9kYXRh LT5zaXplKCkgLSBtX2J5dGVzUmVhZCwgcXVlcnkgPT0gR0lGSW1hZ2VEZWNvZGVyOjpHSUZTaXpl UXVlcnkpKQorICAgIGlmICghbV9wYXJzZUZhaWxlZCAmJiAhcGFyc2UobV9ieXRlc1JlYWQsIG1f ZGF0YS0+c2l6ZSgpIC0gbV9ieXRlc1JlYWQsIHF1ZXJ5ID09IEdJRkltYWdlRGVjb2Rlcjo6R0lG U2l6ZVF1ZXJ5KSkgewogICAgICAgICBtX3BhcnNlRmFpbGVkID0gdHJ1ZTsKKyAgICAgICAgcmV0 dXJuIGZhbHNlOworICAgIH0KIAogICAgIGlmIChxdWVyeSAhPSBHSUZJbWFnZURlY29kZXI6OkdJ RkZ1bGxRdWVyeSkKICAgICAgICAgcmV0dXJuIHRydWU7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0L2Nocm9taXVtL3Rlc3RzL0dJRkltYWdlRGVjb2RlclRlc3QuY3BwIGIvU291cmNlL1dlYktp dC9jaHJvbWl1bS90ZXN0cy9HSUZJbWFnZURlY29kZXJUZXN0LmNwcAppbmRleCBiYzZlODExMTU5 YzM3ZTkyMjA0ZDIzZmRmYzNhYzdlOGIxYWRmMWEyLi44ZTJiZDE1N2E2YjY5OGQ3OTZiNDE3NWM1 M2Y0OGQ1N2ZmZDUzZGExIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3Rz L0dJRkltYWdlRGVjb2RlclRlc3QuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVz dHMvR0lGSW1hZ2VEZWNvZGVyVGVzdC5jcHAKQEAgLTE3OCw3ICsxNzgsNiBAQCBURVNUKEdJRklt YWdlRGVjb2RlclRlc3QsIHBhcnNlQW5kRGVjb2RlQnl0ZUJ5Qnl0ZSkKICAgICBFWFBFQ1RfRVEo Y0FuaW1hdGlvbkxvb3BJbmZpbml0ZSwgZGVjb2Rlci0+cmVwZXRpdGlvbkNvdW50KCkpOwogfQog Ci0vLyBTZWNvbmQgZnJhbWUgaW4gdGhlIGZpbGUgaXMgYnJva2VuIGJ1dCB0ZXN0IHRoYXQgZmly c3QgZnJhbWUgY2FuIGJlIGRlY29kZWQuCiBURVNUKEdJRkltYWdlRGVjb2RlclRlc3QsIGJyb2tl blNlY29uZEZyYW1lKQogewogICAgIE93blB0cjxHSUZJbWFnZURlY29kZXI+IGRlY29kZXIoY3Jl YXRlRGVjb2RlcigpKTsKQEAgLTE4NywxNCArMTg2LDggQEAgVEVTVChHSUZJbWFnZURlY29kZXJU ZXN0LCBicm9rZW5TZWNvbmRGcmFtZSkKICAgICBBU1NFUlRfVFJVRShkYXRhLmdldCgpKTsKICAg ICBkZWNvZGVyLT5zZXREYXRhKGRhdGEuZ2V0KCksIHRydWUpOwogCi0gICAgRVhQRUNUX0VRKDF1 LCBkZWNvZGVyLT5mcmFtZUNvdW50KCkpOwotCisgICAgRVhQRUNUX0VRKDB1LCBkZWNvZGVyLT5m cmFtZUNvdW50KCkpOwogICAgIEltYWdlRnJhbWUqIGZyYW1lID0gZGVjb2Rlci0+ZnJhbWVCdWZm ZXJBdEluZGV4KDApOwotICAgIEVYUEVDVF9FUShJbWFnZUZyYW1lOjpGcmFtZUNvbXBsZXRlLCBm cmFtZS0+c3RhdHVzKCkpOwotICAgIEVYUEVDVF9FUSgxNiwgZnJhbWUtPmdldFNrQml0bWFwKCku d2lkdGgoKSk7Ci0gICAgRVhQRUNUX0VRKDE2LCBmcmFtZS0+Z2V0U2tCaXRtYXAoKS5oZWlnaHQo KSk7Ci0KLSAgICBmcmFtZSA9IGRlY29kZXItPmZyYW1lQnVmZmVyQXRJbmRleCgxKTsKICAgICBF WFBFQ1RfRkFMU0UoZnJhbWUpOwogICAgIEVYUEVDVF9FUShjQW5pbWF0aW9uTG9vcE9uY2UsIGRl Y29kZXItPnJlcGV0aXRpb25Db3VudCgpKTsKIH0K