11314 2006-10-16 07:24:27 -0700 Fix build when XSLT_SUPPORT is not defined 2006-10-24 06:20:57 -0700 1 1 1 Unclassified WebKit New Bugs 420+ PC OS X 10.4 RESOLVED FIXED P2 Normal --- 1 kkowalczyk webkit-unassigned oldest_to_newest 52471 0 kkowalczyk 2006-10-16 07:24:27 -0700 Currently XSLT_SUPPORT is forced by WebCore\config.h, which defeats the purpose of having it configurable (should be passed from a Makefile) and one place unconditionally uses xslt support. 52445 1 11110 kkowalczyk 2006-10-16 07:26:27 -0700 Created attachment 11110 fix build when XSLT_SUPPORT is not defined * remove #define XSLT_SUPPORT from WebCore\config.h, because it defeats the purpose of having it configurable (should be passed from a Makefile) * fix on place in XMLTokenizer that was using xslt support unconditionally 52386 2 11110 aroben 2006-10-16 14:17:35 -0700 Comment on attachment 11110 fix build when XSLT_SUPPORT is not defined If you're going to make this change to config.h, you'll need to change the build configurations on Mac (at least). 52388 3 kkowalczyk 2006-10-16 14:24:43 -0700 I can't do it since I have no access to Mac. I was hoping that a mac-owning commiter could do it. 52403 4 11123 kkowalczyk 2006-10-17 06:24:50 -0700 Created attachment 11123 fix unconditional use of XSLT Updated the patch to not modify config.h. I would still like this change to be made but if submitting a change to xcode project files is a requirement for the patch, then unfortunately I can't do it because I don't have access to mac/xcode. For someone having an apple, it should be trivial. 50835 5 sam 2006-10-24 06:20:57 -0700 Landed in r17252. 11110 2006-10-16 07:26:27 -0700 2006-10-17 06:24:50 -0700 fix build when XSLT_SUPPORT is not defined patch.txt text/plain 1567 kkowalczyk SW5kZXg6IFdlYkNvcmUvY29uZmlnLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9jb25maWcuaAko cmV2aXNpb24gMTcwNjgpCisrKyBXZWJDb3JlL2NvbmZpZy5oCSh3b3JraW5nIGNvcHkpCkBAIC0y MCw3ICsyMCw2IEBACiAKICNpbmNsdWRlIDx3dGYvUGxhdGZvcm0uaD4KIAotI2RlZmluZSBYU0xU X1NVUFBPUlQgMQogI2RlZmluZSBNT0JJTEUgMAogCiAjaWYgX19BUFBMRV9fCkluZGV4OiBXZWJD b3JlL2RvbS9YTUxUb2tlbml6ZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvZG9tL1hNTFRv a2VuaXplci5jcHAJKHJldmlzaW9uIDE3MDY4KQorKysgV2ViQ29yZS9kb20vWE1MVG9rZW5pemVy LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTIxNSw2ICsxMjE1LDcgQEAKIAogdm9pZCBYTUxUb2tl bml6ZXI6OmVuZCgpCiB7CisjaWZkZWYgWFNMVF9TVVBQT1JUCiAgICAgaWYgKG1fc2F3WFNMVHJh bnNmb3JtKSB7CiAgICAgICAgIG1fZG9jLT5zZXRUcmFuc2Zvcm1Tb3VyY2UoeG1sRG9jUHRyRm9y U3RyaW5nKG1fZG9jLT5kb2NMb2FkZXIoKSwgbV9vcmlnaW5hbFNvdXJjZUZvclRyYW5zZm9ybSwg bV9kb2MtPlVSTCgpKSk7CiAgICAgICAgIApAQCAtMTIyMyw3ICsxMjI0LDggQEAKICAgICAgICAg bV9kb2MtPnNldFBhcnNpbmcodHJ1ZSk7CiAgICAgICAgIG1fcGFyc2VyU3RvcHBlZCA9IHRydWU7 CiAgICAgfQotICAgIAorI2VuZGlmCisKICAgICBpZiAobV9jb250ZXh0KSB7CiAgICAgICAgIC8v IFRlbGwgbGlieG1sIHdlJ3JlIGRvbmUuCiAgICAgICAgIHhtbFBhcnNlQ2h1bmsobV9jb250ZXh0 LCAwLCAwLCAxKTsKSW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNv cmUvQ2hhbmdlTG9nCShyZXZpc2lvbiAxNzA2OCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDYtMTAtMTYgIEtyenlzenRvZiBLb3dhbGN6 eWssICA8a2tvd2FsY3p5a0BnbWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgV0FSTklORzogTk8gVEVTVCBDQVNFUyBBRERFRCBPUiBDSEFO R0VECisKKyAgICAgICAgRml4IGJ1aWxkIHdoZW4gWFNMVF9TVVBQT1JUIGlzIG5vdCBkZWZpbmVk LgorCisgICAgICAgICogY29uZmlnLmg6CisgICAgICAgICogZG9tL1hNTFRva2VuaXplci5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpYTUxUb2tlbml6ZXI6OmVuZCk6CisKIDIwMDYtMTAtMTYgIERh dmlkIEh5YXR0ICA8aHlhdHRAYXBwbGUuY29tPgogCiAgICAgICAgIEZpeCBmb3IgYnVnIDkzNDcs IHBvc2l0aW9uZWQgZWxlbWVudHMgaGF2ZSB0aGUgd3JvbmcgY29udGFpbmluZyBibG9jay4gIFRo aXMgaXMgYSBjaGFuZ2UgZnJvbSBDU1MyIHRvCg== 11123 2006-10-17 06:24:50 -0700 2006-10-17 08:21:39 -0700 fix unconditional use of XSLT patch.txt text/plain 1259 kkowalczyk SW5kZXg6IFdlYkNvcmUvZG9tL1hNTFRva2VuaXplci5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29y ZS9kb20vWE1MVG9rZW5pemVyLmNwcAkocmV2aXNpb24gMTcwNzYpCisrKyBXZWJDb3JlL2RvbS9Y TUxUb2tlbml6ZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMjE1LDYgKzEyMTUsNyBAQAogCiB2 b2lkIFhNTFRva2VuaXplcjo6ZW5kKCkKIHsKKyNpZmRlZiBYU0xUX1NVUFBPUlQKICAgICBpZiAo bV9zYXdYU0xUcmFuc2Zvcm0pIHsKICAgICAgICAgbV9kb2MtPnNldFRyYW5zZm9ybVNvdXJjZSh4 bWxEb2NQdHJGb3JTdHJpbmcobV9kb2MtPmRvY0xvYWRlcigpLCBtX29yaWdpbmFsU291cmNlRm9y VHJhbnNmb3JtLCBtX2RvYy0+VVJMKCkpKTsKICAgICAgICAgCkBAIC0xMjIzLDcgKzEyMjQsOCBA QAogICAgICAgICBtX2RvYy0+c2V0UGFyc2luZyh0cnVlKTsKICAgICAgICAgbV9wYXJzZXJTdG9w cGVkID0gdHJ1ZTsKICAgICB9Ci0gICAgCisjZW5kaWYKKwogICAgIGlmIChtX2NvbnRleHQpIHsK ICAgICAgICAgLy8gVGVsbCBsaWJ4bWwgd2UncmUgZG9uZS4KICAgICAgICAgeG1sUGFyc2VDaHVu ayhtX2NvbnRleHQsIDAsIDAsIDEpOwpJbmRleDogV2ViQ29yZS9DaGFuZ2VMb2cKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gV2ViQ29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3MDc2KQorKysgV2ViQ29yZS9DaGFu Z2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNCBAQAorMjAwNi0xMC0xNyAgS3J6eXN6 dG9mIEtvd2FsY3p5ayAgPGtrb3dhbGN6eWtAZ21haWwuY29tPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdBUk5JTkc6IE5PIFRFU1QgQ0FTRVMgQURE RUQgT1IgQ0hBTkdFRAorCisgICAgICAgIEZpeCB1bmNvbmRpdGlvbmFsIHVzZSBvZiBYU0xUIHN1 cHBvcnQuCisKKyAgICAgICAgKiBkb20vWE1MVG9rZW5pemVyLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OlhNTFRva2VuaXplcjo6ZW5kKToKKwogMjAwNi0xMC0xNyAgRGF2aWQgSHlhdHQgIDxoeWF0 dEBhcHBsZS5jb20+CiAKICAgICAgICAgRml4ICJmbGFzaCB0byB3aGl0ZScgcHJvYmxlbSBvbiB5 YWhvby5jb20gYXMgaXQgZmluaXNoZXMgbG9hZGluZy4gIFJlZmluZSB0aGUgRk9VQyBzdXBwcmVz c2lvbgo=