113138 2013-03-23 09:51:03 -0700 Web Inspector: OverviewGrid. Dragged window may change its width due to accumulating rounding error 2013-03-26 04:26:06 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 loislo loislo apavlov keishi loislo pfeldman pmuellr vsevik web-inspector-bugs yurys oldest_to_newest 862208 0 loislo 2013-03-23 09:51:03 -0700 use case: record a timeline select small window in overview pane drag it slowly patch to follow 862210 1 194709 loislo 2013-03-23 09:57:48 -0700 Created attachment 194709 Patch 862544 2 194709 pfeldman 2013-03-25 01:07:53 -0700 Comment on attachment 194709 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=194709&action=review > Source/WebCore/ChangeLog:8 > + The old version had problem with rounding because it recalculates the window size on each event. Why would this be a problem? > Source/WebCore/inspector/front-end/OverviewGrid.js:320 > + var delta = (event.pageX - this._dragStartPoint) / this._parentElement.clientWidth; I am not sure we need more complexity in this code. 863435 3 195025 loislo 2013-03-26 01:06:13 -0700 Created attachment 195025 Patch 863444 4 loislo 2013-03-26 01:16:33 -0700 (In reply to comment #2) > (From update of attachment 194709 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=194709&action=review > > > Source/WebCore/ChangeLog:8 > > + The old version had problem with rounding because it recalculates the window size on each event. > > Why would this be a problem? As we found in the offline discussion the rounding was the root of problem. > > > Source/WebCore/inspector/front-end/OverviewGrid.js:320 > > + var delta = (event.pageX - this._dragStartPoint) / this._parentElement.clientWidth; > > I am not sure we need more complexity in this code. I eliminated moveWindow code so the code became clear. 863546 5 loislo 2013-03-26 04:26:06 -0700 Committed r146866: <http://trac.webkit.org/changeset/146866> 194709 2013-03-23 09:57:48 -0700 2013-03-26 01:06:05 -0700 Patch bug-113138-20130323205334.patch text/plain 2826 loislo U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ2NzIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWYzMDNkOTMxNjVlMmVi YWM1MTdjN2M1NDhiY2RiMmVmMDFlYzJjYS4uNmU3NWQ2OGZhZWRlMTIyMDhjMzNiN2E5ZThkOTQ5 ZGQ5OGMxYzZjOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTAzLTIzICBJbHlh IFRpa2hvbm92c2t5ICA8bG9pc2xvQGNocm9taXVtLm9yZz4KKworICAgICAgICBXZWIgSW5zcGVj dG9yOiBPdmVydmlld0dyaWQuIERyYWdnZWQgd2luZG93IG1heSBjaGFuZ2UgaXRzIHdpZHRoIGR1 ZSB0byBhY2N1bXVsYXRpbmcgcm91bmRpbmcgZXJyb3IuCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTMxMzgKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgb2xkIHZlcnNpb24gaGFkIHByb2JsZW0gd2l0 aCByb3VuZGluZyBiZWNhdXNlIGl0IHJlY2FsY3VsYXRlcyB0aGUgd2luZG93IHNpemUgb24gZWFj aCBldmVudC4KKyAgICAgICAgVGhlIG5ldyB2ZXJzaW9uIGp1c3QgY2FsY3VsYXRlcyB0aGUgZHJh Z2dpbmcgZGVsdGEgYW5kIG1vdmVzIHRoZSB3aW5kb3cKKyAgICAgICAgdG8gdGhlIG5ldyBwb3Np dGlvbiBiYXNlZCBvbiB0aGUgaW5pdGlhbCB2YWx1ZXMgYW5kIHRoZSBkZWx0YS4KKworICAgICAg ICAqIGluc3BlY3Rvci9mcm9udC1lbmQvT3ZlcnZpZXdHcmlkLmpzOgorICAgICAgICAoV2ViSW5z cGVjdG9yLk92ZXJ2aWV3R3JpZC5XaW5kb3cucHJvdG90eXBlLl9zdGFydFdpbmRvd0RyYWdnaW5n KToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5PdmVydmlld0dyaWQuV2luZG93LnByb3RvdHlwZS5f d2luZG93RHJhZ2dpbmcpOgorCiAyMDEzLTAzLTIzICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBh cHBsZS5jb20+CiAKICAgICAgICAgUmV2ZXJ0ICJCVUlMRCBGSVggKHIxNDY2NjcpOiBSZXNvdXJj ZVJlcXVlc3QgY29uc3RydWN0b3IgaW4gU3luY2hyb25vdXNMb2FkZXJDbGllbnQuY3BwIGlzIGFt YmlndW91cyBvbiBpT1MiCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJv bnQtZW5kL092ZXJ2aWV3R3JpZC5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1l bmQvT3ZlcnZpZXdHcmlkLmpzCmluZGV4IGIyMGFiYTc3NzJmZWEwMzc4NTEwZDE4ODE5Y2YxZTJh YjUwOWRjMGQuLmY3NmE0MDI3ODI2NWFiMzI5MTQxN2NhYmZlZTQyOGNkODAzOTRiMWMgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvT3ZlcnZpZXdHcmlkLmpz CisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvT3ZlcnZpZXdHcmlkLmpz CkBAIC0zMDUsOCArMzA1LDkgQEAgV2ViSW5zcGVjdG9yLk92ZXJ2aWV3R3JpZC5XaW5kb3cucHJv dG90eXBlID0gewogICAgICAqLwogICAgIF9zdGFydFdpbmRvd0RyYWdnaW5nOiBmdW5jdGlvbihl dmVudCkKICAgICB7Ci0gICAgICAgIHZhciB3aW5kb3dMZWZ0ID0gdGhpcy5fbGVmdFJlc2l6ZUVs ZW1lbnQub2Zmc2V0TGVmdCArIFdlYkluc3BlY3Rvci5PdmVydmlld0dyaWQuUmVzaXplck9mZnNl dDsKLSAgICAgICAgdGhpcy5fZHJhZ09mZnNldCA9IHdpbmRvd0xlZnQgLSBldmVudC5wYWdlWDsK KyAgICAgICAgdGhpcy5fZHJhZ1N0YXJ0UG9pbnQgPSBldmVudC5wYWdlWDsKKyAgICAgICAgdGhp cy5fZHJhZ1N0YXJ0TGVmdCA9IHRoaXMud2luZG93TGVmdDsKKyAgICAgICAgdGhpcy5fZHJhZ1N0 YXJ0UmlnaHQgPSB0aGlzLndpbmRvd1JpZ2h0OwogICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICB9 LAogCkBAIC0zMTUsMTAgKzMxNiwxOSBAQCBXZWJJbnNwZWN0b3IuT3ZlcnZpZXdHcmlkLldpbmRv dy5wcm90b3R5cGUgPSB7CiAgICAgICovCiAgICAgX3dpbmRvd0RyYWdnaW5nOiBmdW5jdGlvbihl dmVudCkKICAgICB7Ci0gICAgICAgIHZhciB3aW5kb3dMZWZ0ID0gdGhpcy5fbGVmdFJlc2l6ZUVs ZW1lbnQub2Zmc2V0TGVmdCArIFdlYkluc3BlY3Rvci5PdmVydmlld0dyaWQuUmVzaXplck9mZnNl dDsKLSAgICAgICAgdmFyIHN0YXJ0ID0gdGhpcy5fZHJhZ09mZnNldCArIGV2ZW50LnBhZ2VYOwot ICAgICAgICB0aGlzLl9tb3ZlV2luZG93KHN0YXJ0KTsKICAgICAgICAgZXZlbnQucHJldmVudERl ZmF1bHQoKTsKKyAgICAgICAgdmFyIGRlbHRhID0gKGV2ZW50LnBhZ2VYIC0gdGhpcy5fZHJhZ1N0 YXJ0UG9pbnQpIC8gdGhpcy5fcGFyZW50RWxlbWVudC5jbGllbnRXaWR0aDsKKyAgICAgICAgaWYg KHRoaXMuX2RyYWdTdGFydExlZnQgKyBkZWx0YSA8IDApIHsKKyAgICAgICAgICAgIGlmICh0aGlz LndpbmRvd0xlZnQgPT09IDApCisgICAgICAgICAgICAgICAgcmV0dXJuOworICAgICAgICAgICAg ZGVsdGEgPSAtdGhpcy5fZHJhZ1N0YXJ0TGVmdDsKKyAgICAgICAgfQorICAgICAgICBpZiAodGhp cy5fZHJhZ1N0YXJ0UmlnaHQgKyBkZWx0YSA+IDEpIHsKKyAgICAgICAgICAgIGlmICh0aGlzLndp bmRvd1JpZ2h0ID09PSAxKQorICAgICAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgICAgIGRl bHRhID0gMSAtIHRoaXMuX2RyYWdTdGFydFJpZ2h0OworICAgICAgICB9CisgICAgICAgIHRoaXMu X3NldFdpbmRvdyh0aGlzLl9kcmFnU3RhcnRMZWZ0ICsgZGVsdGEsIHRoaXMuX2RyYWdTdGFydFJp Z2h0ICsgZGVsdGEpOwogICAgIH0sCiAKICAgICAvKioK 195025 2013-03-26 01:06:13 -0700 2013-03-26 04:20:22 -0700 Patch bug-113138-20130326120156.patch text/plain 4718 loislo U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ2ODU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2U3YzI0OGQxOTdmNTQ3 YTQzMWI1MzVhNmU0MGNiNjQ0NTZkNDBiNC4uYTNkODQ3MDU4MzYzMzVkODcyMTZjZGRjYzk5Yjhl ZWRmMjk0MDA5MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTAzLTI2ICBJbHlh IFRpa2hvbm92c2t5ICA8bG9pc2xvQGNocm9taXVtLm9yZz4KKworICAgICAgICBXZWIgSW5zcGVj dG9yOiBPdmVydmlld0dyaWQuIERyYWdnZWQgd2luZG93IG1heSBjaGFuZ2UgaXRzIHdpZHRoIGR1 ZSB0byBhY2N1bXVsYXRpbmcgcm91bmRpbmcgZXJyb3IuCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTMxMzgKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgb2xkIHZlcnNpb24gaGFkIHByb2JsZW0gd2l0 aCByb3VuZGluZyBiZWNhdXNlIGl0IHJlY2FsY3VsYXRlcyB0aGUgd2luZG93IHNpemUgb24gZWFj aCBldmVudC4KKyAgICAgICAgVGhlIG5ldyB2ZXJzaW9uIGp1c3QgY2FsY3VsYXRlcyB0aGUgZHJh Z2dpbmcgZGVsdGEgYW5kIG1vdmVzIHRoZSB3aW5kb3cKKyAgICAgICAgdG8gdGhlIG5ldyBwb3Np dGlvbiBiYXNlZCBvbiB0aGUgaW5pdGlhbCB2YWx1ZXMgYW5kIHRoZSBkZWx0YS4KKworICAgICAg ICAqIGluc3BlY3Rvci9mcm9udC1lbmQvT3ZlcnZpZXdHcmlkLmpzOgorICAgICAgICAoV2ViSW5z cGVjdG9yLk92ZXJ2aWV3R3JpZC5XaW5kb3cucHJvdG90eXBlLl9zdGFydFdpbmRvd0RyYWdnaW5n KToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5PdmVydmlld0dyaWQuV2luZG93LnByb3RvdHlwZS5f d2luZG93RHJhZ2dpbmcpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLk92ZXJ2aWV3R3JpZC5XaW5k b3cucHJvdG90eXBlLl9vbk1vdXNlV2hlZWwpOgorCiAyMDEzLTAzLTI2ICBNaWhuZWEgT3ZpZGVu aWUgIDxtaWhuZWFAYWRvYmUuY29tPgogCiAgICAgICAgIFtDU1NSZWdpb25zXTogQ3Jhc2ggYWNj ZXNzaW5nIG9mZnNldFBhcmVudCBmb3IgY29udGVudE5vZGVzIGluc2lkZSBhIGZsb3cgdGhyZWFk CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL092ZXJ2aWV3 R3JpZC5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvT3ZlcnZpZXdHcmlk LmpzCmluZGV4IGE5Nzg0ZmZiOTBiZTRjZWZiOGJiMmY2Mjc3MTdlMGU5NGMxNmIwNWMuLjE5YTU0 NWEzZDQ2MDVhYTkyNGU3YTkwY2JhMDQ2NjgyMjNjMTZkYmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvT3ZlcnZpZXdHcmlkLmpzCisrKyBiL1NvdXJjZS9X ZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvT3ZlcnZpZXdHcmlkLmpzCkBAIC0zMDUsOCArMzA1 LDkgQEAgV2ViSW5zcGVjdG9yLk92ZXJ2aWV3R3JpZC5XaW5kb3cucHJvdG90eXBlID0gewogICAg ICAqLwogICAgIF9zdGFydFdpbmRvd0RyYWdnaW5nOiBmdW5jdGlvbihldmVudCkKICAgICB7Ci0g ICAgICAgIHZhciB3aW5kb3dMZWZ0ID0gdGhpcy5fbGVmdFJlc2l6ZUVsZW1lbnQub2Zmc2V0TGVm dCArIFdlYkluc3BlY3Rvci5PdmVydmlld0dyaWQuUmVzaXplck9mZnNldDsKLSAgICAgICAgdGhp cy5fZHJhZ09mZnNldCA9IHdpbmRvd0xlZnQgLSBldmVudC5wYWdlWDsKKyAgICAgICAgdGhpcy5f ZHJhZ1N0YXJ0UG9pbnQgPSBldmVudC5wYWdlWDsKKyAgICAgICAgdGhpcy5fZHJhZ1N0YXJ0TGVm dCA9IHRoaXMud2luZG93TGVmdDsKKyAgICAgICAgdGhpcy5fZHJhZ1N0YXJ0UmlnaHQgPSB0aGlz LndpbmRvd1JpZ2h0OwogICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICB9LAogCkBAIC0zMTUsMTAg KzMxNiwxNSBAQCBXZWJJbnNwZWN0b3IuT3ZlcnZpZXdHcmlkLldpbmRvdy5wcm90b3R5cGUgPSB7 CiAgICAgICovCiAgICAgX3dpbmRvd0RyYWdnaW5nOiBmdW5jdGlvbihldmVudCkKICAgICB7Ci0g ICAgICAgIHZhciB3aW5kb3dMZWZ0ID0gdGhpcy5fbGVmdFJlc2l6ZUVsZW1lbnQub2Zmc2V0TGVm dCArIFdlYkluc3BlY3Rvci5PdmVydmlld0dyaWQuUmVzaXplck9mZnNldDsKLSAgICAgICAgdmFy IHN0YXJ0ID0gdGhpcy5fZHJhZ09mZnNldCArIGV2ZW50LnBhZ2VYOwotICAgICAgICB0aGlzLl9t b3ZlV2luZG93KHN0YXJ0KTsKICAgICAgICAgZXZlbnQucHJldmVudERlZmF1bHQoKTsKKyAgICAg ICAgdmFyIGRlbHRhID0gKGV2ZW50LnBhZ2VYIC0gdGhpcy5fZHJhZ1N0YXJ0UG9pbnQpIC8gdGhp cy5fcGFyZW50RWxlbWVudC5jbGllbnRXaWR0aDsKKyAgICAgICAgaWYgKHRoaXMuX2RyYWdTdGFy dExlZnQgKyBkZWx0YSA8IDApCisgICAgICAgICAgICBkZWx0YSA9IC10aGlzLl9kcmFnU3RhcnRM ZWZ0OworCisgICAgICAgIGlmICh0aGlzLl9kcmFnU3RhcnRSaWdodCArIGRlbHRhID4gMSkKKyAg ICAgICAgICAgIGRlbHRhID0gMSAtIHRoaXMuX2RyYWdTdGFydFJpZ2h0OworCisgICAgICAgIHRo aXMuX3NldFdpbmRvdyh0aGlzLl9kcmFnU3RhcnRMZWZ0ICsgZGVsdGEsIHRoaXMuX2RyYWdTdGFy dFJpZ2h0ICsgZGVsdGEpOwogICAgIH0sCiAKICAgICAvKioKQEAgLTMzMiwyOCArMzM4LDYgQEAg V2ViSW5zcGVjdG9yLk92ZXJ2aWV3R3JpZC5XaW5kb3cucHJvdG90eXBlID0gewogICAgIC8qKgog ICAgICAqIEBwYXJhbSB7bnVtYmVyfSBzdGFydAogICAgICAqLwotICAgIF9tb3ZlV2luZG93OiBm dW5jdGlvbihzdGFydCkKLSAgICB7Ci0gICAgICAgIHZhciB3aW5kb3dMZWZ0ID0gdGhpcy5fbGVm dFJlc2l6ZUVsZW1lbnQub2Zmc2V0TGVmdCArIFdlYkluc3BlY3Rvci5PdmVydmlld0dyaWQuUmVz aXplck9mZnNldDsKLSAgICAgICAgdmFyIHdpbmRvd1JpZ2h0ID0gdGhpcy5fcmlnaHRSZXNpemVF bGVtZW50Lm9mZnNldExlZnQgKyBXZWJJbnNwZWN0b3IuT3ZlcnZpZXdHcmlkLlJlc2l6ZXJPZmZz ZXQ7Ci0gICAgICAgIHZhciB3aW5kb3dTaXplID0gd2luZG93UmlnaHQgLSB3aW5kb3dMZWZ0Owot ICAgICAgICB2YXIgZW5kID0gc3RhcnQgKyB3aW5kb3dTaXplOwotCi0gICAgICAgIGlmIChzdGFy dCA8IDApIHsKLSAgICAgICAgICAgIHN0YXJ0ID0gMDsKLSAgICAgICAgICAgIGVuZCA9IHdpbmRv d1NpemU7Ci0gICAgICAgIH0KLQotICAgICAgICBpZiAoZW5kID4gdGhpcy5fcGFyZW50RWxlbWVu dC5jbGllbnRXaWR0aCkgewotICAgICAgICAgICAgZW5kID0gdGhpcy5fcGFyZW50RWxlbWVudC5j bGllbnRXaWR0aDsKLSAgICAgICAgICAgIHN0YXJ0ID0gZW5kIC0gd2luZG93U2l6ZTsKLSAgICAg ICAgfQotICAgICAgICB0aGlzLl9zZXRXaW5kb3dQb3NpdGlvbihzdGFydCwgZW5kKTsKLSAgICB9 LAotCi0gICAgLyoqCi0gICAgICogQHBhcmFtIHtudW1iZXJ9IHN0YXJ0Ci0gICAgICovCiAgICAg X3Jlc2l6ZVdpbmRvd0xlZnQ6IGZ1bmN0aW9uKHN0YXJ0KQogICAgIHsKICAgICAgICAgLy8gR2x1 ZSB0byBlZGdlLgpAQCAtNDI4LDkgKzQxMiwxOCBAQCBXZWJJbnNwZWN0b3IuT3ZlcnZpZXdHcmlk LldpbmRvdy5wcm90b3R5cGUgPSB7CiAgICAgICAgICAgICB0aGlzLl96b29tKE1hdGgucG93KHpv b21GYWN0b3IsIC1ldmVudC53aGVlbERlbHRhWSAqIG1vdXNlV2hlZWxab29tU3BlZWQpLCByZWZl cmVuY2VQb2ludCk7CiAgICAgICAgIH0KICAgICAgICAgaWYgKHR5cGVvZiBldmVudC53aGVlbERl bHRhWCA9PT0gIm51bWJlciIgJiYgZXZlbnQud2hlZWxEZWx0YVgpIHsKKyAgICAgICAgICAgIHZh ciBvZmZzZXQgPSBNYXRoLnJvdW5kKGV2ZW50LndoZWVsRGVsdGFYICogV2ViSW5zcGVjdG9yLk92 ZXJ2aWV3R3JpZC5XaW5kb3dTY3JvbGxTcGVlZEZhY3Rvcik7CiAgICAgICAgICAgICB2YXIgd2lu ZG93TGVmdCA9IHRoaXMuX2xlZnRSZXNpemVFbGVtZW50Lm9mZnNldExlZnQgKyBXZWJJbnNwZWN0 b3IuT3ZlcnZpZXdHcmlkLlJlc2l6ZXJPZmZzZXQ7Ci0gICAgICAgICAgICB2YXIgc3RhcnQgPSB3 aW5kb3dMZWZ0IC0gTWF0aC5yb3VuZChldmVudC53aGVlbERlbHRhWCAqIFdlYkluc3BlY3Rvci5P dmVydmlld0dyaWQuV2luZG93U2Nyb2xsU3BlZWRGYWN0b3IpOwotICAgICAgICAgICAgdGhpcy5f bW92ZVdpbmRvdyhzdGFydCk7CisgICAgICAgICAgICB2YXIgd2luZG93UmlnaHQgPSB0aGlzLl9y aWdodFJlc2l6ZUVsZW1lbnQub2Zmc2V0TGVmdCArIFdlYkluc3BlY3Rvci5PdmVydmlld0dyaWQu UmVzaXplck9mZnNldDsKKworICAgICAgICAgICAgaWYgKHdpbmRvd0xlZnQgLSBvZmZzZXQgPCAw KQorICAgICAgICAgICAgICAgIG9mZnNldCA9IHdpbmRvd0xlZnQ7CisKKyAgICAgICAgICAgIGlm ICh3aW5kb3dSaWdodCAtIG9mZnNldCA+IHRoaXMuX3BhcmVudEVsZW1lbnQuY2xpZW50V2lkdGgp CisgICAgICAgICAgICAgICAgb2Zmc2V0ID0gd2luZG93UmlnaHQgLSB0aGlzLl9wYXJlbnRFbGVt ZW50LmNsaWVudFdpZHRoOworCisgICAgICAgICAgICB0aGlzLl9zZXRXaW5kb3dQb3NpdGlvbih3 aW5kb3dMZWZ0IC0gb2Zmc2V0LCB3aW5kb3dSaWdodCAtIG9mZnNldCk7CisKICAgICAgICAgICAg IGV2ZW50LnByZXZlbnREZWZhdWx0KCk7CiAgICAgICAgIH0KICAgICB9LAo=