113136 2013-03-23 08:57:59 -0700 Web Inspector: Exception when turning on pretty print without any displayed source in the editor 2013-03-25 01:57:57 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 phistuck webkit-unassigned apavlov keishi loislo pfeldman pmuellr vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 862198 0 phistuck 2013-03-23 08:57:59 -0700 Clicking on the pretty print button throws a TypeError when no source is displayed within the Sources editor. This happens because we try to get the URL of the currently edited source when notifying the user metrics about turning on pretty print, without checking whether there actually is one. 862199 1 194704 phistuck 2013-03-23 09:08:31 -0700 Created attachment 194704 Added an existence check. 862201 2 webkit.review.bot 2013-03-23 09:11:45 -0700 Attachment 194704 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/inspector/front-end/ScriptsPanel.js']" exit_code: 1 Source/WebCore/ChangeLog:11: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 862203 3 194706 phistuck 2013-03-23 09:12:53 -0700 Created attachment 194706 Fixed the change log. 862564 4 194706 webkit.review.bot 2013-03-25 01:57:53 -0700 Comment on attachment 194706 Fixed the change log. Clearing flags on attachment: 194706 Committed r146749: <http://trac.webkit.org/changeset/146749> 862565 5 webkit.review.bot 2013-03-25 01:57:57 -0700 All reviewed patches have been landed. Closing bug. 194704 2013-03-23 09:08:31 -0700 2013-03-23 09:12:53 -0700 Added an existence check. fix-exception.patch text/plain 1719 phistuck SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZw0KPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIFNvdXJjZS9X ZWJDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTQ2NzIwKQ0KKysrIFNvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwkod29ya2luZyBjb3B5KQ0KQEAgLTEsMyArMSwxNiBAQA0KKzIwMTMtMDMtMjMgIFBo aXN0dWNLICA8cGhpc3R1Y2tAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6 IEV4Y2VwdGlvbiB3aGVuIHR1cm5pbmcgb24gcHJldHR5IHByaW50IHdpdGhvdXQgYW55IGRpc3Bs YXllZCBzb3VyY2UgaW4gdGhlIGVkaXRvcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTEzMTM2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLgorICAgICAgICBBZGRlZCBhIGNoZWNrIGZv ciB0aGUgZXhpc3RlbmNlIG9mIGN1cnJlbnRseSBlZGl0ZWQgZG9jdW1lbnQuCisKKyAgICAgICAg KiBpbnNwZWN0b3IKKyAgICAgICAgKFdlYkluc3BlY3Rvci5TY3JpcHRzUGFuZWwucHJvdG90eXBl Ll90b2dnbGVGb3JtYXRTb3VyY2UpOgorCiAyMDEzLTAzLTIzICBEYXZpZCBLaWx6ZXIgIDxkZGtp bHplckBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2ZXJ0ICJCVUlMRCBGSVggKHIxNDY2NjcpOiBS ZXNvdXJjZVJlcXVlc3QgY29uc3RydWN0b3IgaW4gU3luY2hyb25vdXNMb2FkZXJDbGllbnQuY3Bw IGlzIGFtYmlndW91cyBvbiBpT1MiCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJv bnQtZW5kL1NjcmlwdHNQYW5lbC5qcw0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIFNvdXJjZS9XZWJDb3JlL2lu c3BlY3Rvci9mcm9udC1lbmQvU2NyaXB0c1BhbmVsLmpzCShyZXZpc2lvbiAxNDY3MjApDQorKysg U291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9TY3JpcHRzUGFuZWwuanMJKHdvcmtp bmcgY29weSkNCkBAIC05NjcsMTAgKzk2NywxMiBAQA0KICAgICAgICAgZm9yICh2YXIgaSA9IDA7 IGkgPCB1aVNvdXJjZUNvZGVzLmxlbmd0aDsgKytpKQogICAgICAgICAgICAgdWlTb3VyY2VDb2Rl c1tpXS5zZXRGb3JtYXR0ZWQodGhpcy5fdG9nZ2xlRm9ybWF0U291cmNlQnV0dG9uLnRvZ2dsZWQp OwogCisgICAgICAgIHZhciBjdXJyZW50RmlsZSA9IHRoaXMuX2VkaXRvckNvbnRhaW5lci5jdXJy ZW50RmlsZSgpOworCiAgICAgICAgIFdlYkluc3BlY3Rvci5ub3RpZmljYXRpb25zLmRpc3BhdGNo RXZlbnRUb0xpc3RlbmVycyhXZWJJbnNwZWN0b3IuVXNlck1ldHJpY3MuVXNlckFjdGlvbiwgewog ICAgICAgICAgICAgYWN0aW9uOiBXZWJJbnNwZWN0b3IuVXNlck1ldHJpY3MuVXNlckFjdGlvbk5h bWVzLlRvZ2dsZVByZXR0eVByaW50LAogICAgICAgICAgICAgZW5hYmxlZDogdGhpcy5fdG9nZ2xl Rm9ybWF0U291cmNlQnV0dG9uLnRvZ2dsZWQsCi0gICAgICAgICAgICB1cmw6IHRoaXMuX2VkaXRv ckNvbnRhaW5lci5jdXJyZW50RmlsZSgpLm9yaWdpblVSTCgpCisgICAgICAgICAgICB1cmw6IGN1 cnJlbnRGaWxlID8gY3VycmVudEZpbGUub3JpZ2luVVJMKCkgOiBudWxsCiAgICAgICAgIH0pOwog ICAgIH0sCiAK 194706 2013-03-23 09:12:53 -0700 2013-03-25 01:57:53 -0700 Fixed the change log. fix-exception.patch text/plain 1736 phistuck SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZw0KPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIFNvdXJjZS9X ZWJDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTQ2NzIwKQ0KKysrIFNvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwkod29ya2luZyBjb3B5KQ0KQEAgLTEsMyArMSwxNiBAQA0KKzIwMTMtMDMtMjMgIFBo aXN0dWNLICA8cGhpc3R1Y2tAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6 IEV4Y2VwdGlvbiB3aGVuIHR1cm5pbmcgb24gcHJldHR5IHByaW50IHdpdGhvdXQgYW55IGRpc3Bs YXllZCBzb3VyY2UgaW4gdGhlIGVkaXRvcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTEzMTM2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLgorICAgICAgICBBZGRlZCBhIGNoZWNrIGZv ciB0aGUgZXhpc3RlbmNlIG9mIGN1cnJlbnRseSBlZGl0ZWQgZG9jdW1lbnQuCisKKyAgICAgICAg KiBpbnNwZWN0b3IvU2NyaXB0c1BhbmVsLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlNjcmlw dHNQYW5lbC5wcm90b3R5cGUuX3RvZ2dsZUZvcm1hdFNvdXJjZSk6CisKIDIwMTMtMDMtMjMgIERh dmlkIEtpbHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZlcnQgIkJVSUxE IEZJWCAocjE0NjY2Nyk6IFJlc291cmNlUmVxdWVzdCBjb25zdHJ1Y3RvciBpbiBTeW5jaHJvbm91 c0xvYWRlckNsaWVudC5jcHAgaXMgYW1iaWd1b3VzIG9uIGlPUyIKSW5kZXg6IFNvdXJjZS9XZWJD b3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU2NyaXB0c1BhbmVsLmpzDQo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0g U291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9TY3JpcHRzUGFuZWwuanMJKHJldmlz aW9uIDE0NjcyMCkNCisrKyBTb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1Njcmlw dHNQYW5lbC5qcwkod29ya2luZyBjb3B5KQ0KQEAgLTk2NywxMCArOTY3LDEyIEBADQogICAgICAg ICBmb3IgKHZhciBpID0gMDsgaSA8IHVpU291cmNlQ29kZXMubGVuZ3RoOyArK2kpCiAgICAgICAg ICAgICB1aVNvdXJjZUNvZGVzW2ldLnNldEZvcm1hdHRlZCh0aGlzLl90b2dnbGVGb3JtYXRTb3Vy Y2VCdXR0b24udG9nZ2xlZCk7CiAKKyAgICAgICAgdmFyIGN1cnJlbnRGaWxlID0gdGhpcy5fZWRp dG9yQ29udGFpbmVyLmN1cnJlbnRGaWxlKCk7CisKICAgICAgICAgV2ViSW5zcGVjdG9yLm5vdGlm aWNhdGlvbnMuZGlzcGF0Y2hFdmVudFRvTGlzdGVuZXJzKFdlYkluc3BlY3Rvci5Vc2VyTWV0cmlj cy5Vc2VyQWN0aW9uLCB7CiAgICAgICAgICAgICBhY3Rpb246IFdlYkluc3BlY3Rvci5Vc2VyTWV0 cmljcy5Vc2VyQWN0aW9uTmFtZXMuVG9nZ2xlUHJldHR5UHJpbnQsCiAgICAgICAgICAgICBlbmFi bGVkOiB0aGlzLl90b2dnbGVGb3JtYXRTb3VyY2VCdXR0b24udG9nZ2xlZCwKLSAgICAgICAgICAg IHVybDogdGhpcy5fZWRpdG9yQ29udGFpbmVyLmN1cnJlbnRGaWxlKCkub3JpZ2luVVJMKCkKKyAg ICAgICAgICAgIHVybDogY3VycmVudEZpbGUgPyBjdXJyZW50RmlsZS5vcmlnaW5VUkwoKSA6IG51 bGwKICAgICAgICAgfSk7CiAgICAgfSwKIAo=