11313 2006-10-15 23:20:20 -0700 REGRESSION: Textareas do not respond to scroll wheel/trackpad 2006-12-18 17:14:24 -0800 1 1 1 Unclassified WebKit Forms 420+ Mac OS X 10.4 RESOLVED FIXED HasReduction, InRadar, Regression P1 Major --- 1 dev+webkit adele adele daniele.metilli ddkilzer hlwebkit kbennis oldest_to_newest 52461 0 dev+webkit 2006-10-15 23:20:20 -0700 Textareas should respond to input from the scroll wheel/track pad but do not in ToT. Scrolling over a textarea does not move the text at all. Also, scrolling past a textarea in a page in shipping Safari scrolls the page up to the textarea, scrolls the content in the textarea, then when it reaches the end of the content in the textarea, it continues scrolling the rest of the page - this does not happen in ToT, the textarea simply scrolls by. Testcase in a minute. 52463 1 11108 dev+webkit 2006-10-15 23:27:39 -0700 Created attachment 11108 testcase 49035 2 dev+webkit 2006-10-27 18:00:05 -0700 Filed as <rdar://problem/4808089> 45986 3 dev+webkit 2006-11-12 01:11:27 -0800 *** Bug 11578 has been marked as a duplicate of this bug. *** 45925 4 kbennis 2006-11-12 11:24:01 -0800 Any fix for this yet? 45585 5 dev+webkit 2006-11-16 15:15:05 -0800 This seems to have regressed even further since I first reported it. Originally, scroll wheel input was ignored, but the scroll bar/arrows on the textbox worked correctly. Now the scroll bar/arrows are ignored as if they aren't there, the only way to shift what content is displayed in a textarea is to highlight and select up/down. 45621 6 mitz 2006-11-17 08:46:29 -0800 (In reply to comment #5) > Now the scroll bar/arrows are ignored as if they > aren't there, the only way to shift what content is displayed in a textarea is > to highlight and select up/down. Filed bug 11632 on scrollbars not responding to events since r17770. 42346 7 hlwebkit 2006-12-12 13:27:35 -0800 This appears to be because the code in RenderObject::scroll is not finding the RenderTextControl's internal m_div's layer, but rather is just seeing that RenderTextControl itself has no layer and giving up without scrolling. I'm not sure what the right fix is here - it seems like overriding |scroll| on RenderTextControl might be safest? 42347 8 ggaren 2006-12-12 14:14:21 -0800 Adele, this looks like a shadow DOM issue. 42348 9 hyatt 2006-12-12 14:15:04 -0800 Overriding sounds pretty good. I did something similar for the impl of scrollLeft and scrollTop etc. 42349 10 adele 2006-12-12 14:31:12 -0800 I'm rewriting the shadow DOM for this control right now. I'll work on this after I've checked that in. 42325 11 11827 hlwebkit 2006-12-12 15:47:49 -0800 Created attachment 11827 patch (what I had) Hi Adele, in case it helps here's what I had for this. 42318 12 11827 adele 2006-12-12 15:58:07 -0800 Comment on attachment 11827 patch (what I had) actually that looks nice and easy to merge with what I have. 41691 13 ap 2006-12-16 03:02:51 -0800 Committed revision 18253. 41246 14 dev+webkit 2006-12-18 17:14:24 -0800 *** Bug 10747 has been marked as a duplicate of this bug. *** 11108 2006-10-15 23:27:39 -0700 2006-10-15 23:27:39 -0700 testcase 11313_testcase.html text/html 1556 dev+webkit PGh0bWw+Cgo8Ym9keT4KPHRleHRhcmVhIHJvd3M9IjEwIiBjb2xzPSI1MCI+TG9yZW0gaXBzdW0g ZG9sb3Igc2l0IGFtZXQsIGNvbnNlY3RldHVlciBhZGlwaXNjaW5nIGVsaXQuIE51bGxhbSBwcmV0 aXVtIG51bmMgcXVpcyBqdXN0by4gTnVsbGFtIG1hc3NhLiBQZWxsZW50ZXNxdWUgdmVsaXQgcHVy dXMsIHRyaXN0aXF1ZSBldCwgbGFjaW5pYSBzZWQsIHZlaGljdWxhIGV1LCByaXN1cy4gUXVpc3F1 ZSBiaWJlbmR1bSB1cm5hIGV1IG5lcXVlLiBQcm9pbiB2ZXN0aWJ1bHVtLiBTZWQgdnVscHV0YXRl IHByZXRpdW0gaXBzdW0uIER1aXMgc2VkIG1hZ25hLiBJbnRlZ2VyIG9yY2kuIFZpdmFtdXMgbWF0 dGlzIG51bmMgc2VkIG9yY2kuIFBlbGxlbnRlc3F1ZSBoYWJpdGFudCBtb3JiaSB0cmlzdGlxdWUg c2VuZWN0dXMgZXQgbmV0dXMgZXQgbWFsZXN1YWRhIGZhbWVzIGFjIHR1cnBpcyBlZ2VzdGFzLiBT dXNwZW5kaXNzZSBlZ2V0IGxlY3R1cy4gTnVsbGFtIGxhb3JlZXQuIE51bGxhIGFjIGZlbGlzLiBJ biB0dXJwaXMgdHVycGlzLCBiaWJlbmR1bSBsdWN0dXMsIHRpbmNpZHVudCBldSwgY29uc2VjdGV0 dWVyIHZlbCwgbmlzaS4gTnVsbGFtIG5lYyBuaWJoIGVnZXQgbnVuYyBkaWN0dW0gc3VzY2lwaXQu IE51bmMgc3VzY2lwaXQgbW9sZXN0aWUgYW50ZS4gQ3VyYWJpdHVyIGFjIGxlY3R1cyBldCB0dXJw aXMgdnVscHV0YXRlIHB1bHZpbmFyLiBOdWxsYW0gcHJldGl1bSBqdXN0byBuZWMgYXVndWUuIERv bmVjIGlkIG5lcXVlIHNhZ2l0dGlzIGZlbGlzIGN1cnN1cyB2dWxwdXRhdGUuIExvcmVtIGlwc3Vt IGRvbG9yIHNpdCBhbWV0LCBjb25zZWN0ZXR1ZXIgYWRpcGlzY2luZyBlbGl0LiBOdWxsYW0gcHJl dGl1bSBudW5jIHF1aXMganVzdG8uIE51bGxhbSBtYXNzYS4gUGVsbGVudGVzcXVlIHZlbGl0IHB1 cnVzLCB0cmlzdGlxdWUgZXQsIGxhY2luaWEgc2VkLCB2ZWhpY3VsYSBldSwgcmlzdXMuIFF1aXNx dWUgYmliZW5kdW0gdXJuYSBldSBuZXF1ZS4gUHJvaW4gdmVzdGlidWx1bS4gU2VkIHZ1bHB1dGF0 ZSBwcmV0aXVtIGlwc3VtLiBEdWlzIHNlZCBtYWduYS4gSW50ZWdlciBvcmNpLiBWaXZhbXVzIG1h dHRpcyBudW5jIHNlZCBvcmNpLiBQZWxsZW50ZXNxdWUgaGFiaXRhbnQgbW9yYmkgdHJpc3RpcXVl IHNlbmVjdHVzIGV0IG5ldHVzIGV0IG1hbGVzdWFkYSBmYW1lcyBhYyB0dXJwaXMgZWdlc3Rhcy4g U3VzcGVuZGlzc2UgZWdldCBsZWN0dXMuIE51bGxhbSBsYW9yZWV0LiBOdWxsYSBhYyBmZWxpcy4g SW4gdHVycGlzIHR1cnBpcywgYmliZW5kdW0gbHVjdHVzLCB0aW5jaWR1bnQgZXUsIGNvbnNlY3Rl dHVlciB2ZWwsIG5pc2kuIE51bGxhbSBuZWMgbmliaCBlZ2V0IG51bmMgZGljdHVtIHN1c2NpcGl0 LiBOdW5jIHN1c2NpcGl0IG1vbGVzdGllIGFudGUuIEN1cmFiaXR1ciBhYyBsZWN0dXMgZXQgdHVy cGlzIHZ1bHB1dGF0ZSBwdWx2aW5hci4gTnVsbGFtIHByZXRpdW0ganVzdG8gbmVjIGF1Z3VlLiBE b25lYyBpZCBuZXF1ZSBzYWdpdHRpcyBmZWxpcyBjdXJzdXMgdnVscHV0YXRlLjwvdGV4dGFyZWE+ CjwvYm9keT4KCjwvaHRtbD4= 11827 2006-12-12 15:47:49 -0800 2006-12-12 15:58:07 -0800 patch (what I had) webkit-11313.diff text/plain 1824 hlwebkit SW5kZXg6IHJlbmRlcmluZy9SZW5kZXJUZXh0Q29udHJvbC5jcHANCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBy ZW5kZXJpbmcvUmVuZGVyVGV4dENvbnRyb2wuY3BwCShyZXZpc2lvbiAxODE2MikNCisrKyByZW5k ZXJpbmcvUmVuZGVyVGV4dENvbnRyb2wuY3BwCSh3b3JraW5nIGNvcHkpDQpAQCAtNDgzLDQgKzQ4 MywxMiBAQA0KICAgICAgICAgbV9kaXYtPnNldFNjcm9sbFRvcChuZXdUb3ApOwogfQogCitib29s IFJlbmRlclRleHRDb250cm9sOjpzY3JvbGwoU2Nyb2xsRGlyZWN0aW9uIGRpcmVjdGlvbiwgU2Ny b2xsR3JhbnVsYXJpdHkgZ3JhbnVsYXJpdHksIGZsb2F0IG11bHRpcGxpZXIpCit7CisgICAgUmVu ZGVyTGF5ZXIgKmwgPSBtX2Rpdi0+cmVuZGVyZXIoKS0+bGF5ZXIoKTsKKyAgICBpZiAobCAmJiBs LT5zY3JvbGwoZGlyZWN0aW9uLCBncmFudWxhcml0eSwgbXVsdGlwbGllcikpCisgICAgICAgIHJl dHVybiB0cnVlOworICAgIHJldHVybiBSZW5kZXJPYmplY3Q6OnNjcm9sbChkaXJlY3Rpb24sIGdy YW51bGFyaXR5LCBtdWx0aXBsaWVyKTsKIH0KKworfQpJbmRleDogcmVuZGVyaW5nL1JlbmRlclRl eHRDb250cm9sLmgNCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSByZW5kZXJpbmcvUmVuZGVyVGV4dENvbnRyb2wu aAkocmV2aXNpb24gMTgxNjIpDQorKysgcmVuZGVyaW5nL1JlbmRlclRleHRDb250cm9sLmgJKHdv cmtpbmcgY29weSkNCkBAIC03MSw2ICs3MSw3IEBADQogICAgIHZpcnR1YWwgaW50IHNjcm9sbEhl aWdodCgpIGNvbnN0OwogICAgIHZpcnR1YWwgdm9pZCBzZXRTY3JvbGxMZWZ0KGludCk7CiAgICAg dmlydHVhbCB2b2lkIHNldFNjcm9sbFRvcChpbnQpOworICAgIHZpcnR1YWwgYm9vbCBzY3JvbGwo U2Nyb2xsRGlyZWN0aW9uIGRpcmVjdGlvbiwgU2Nyb2xsR3JhbnVsYXJpdHkgZ3JhbnVsYXJpdHks IGZsb2F0IG11bHRpcGxpZXIgPSAxLjApOwogCiAgICAgVmlzaWJsZVBvc2l0aW9uIHZpc2libGVQ b3NpdGlvbkZvckluZGV4KGludCBpbmRleCk7CiAgICAgaW50IGluZGV4Rm9yVmlzaWJsZVBvc2l0 aW9uKGNvbnN0IFZpc2libGVQb3NpdGlvbiYpOwpJbmRleDogQ2hhbmdlTG9nDQo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 DQotLS0gQ2hhbmdlTG9nCShyZXZpc2lvbiAxODE4NCkNCisrKyBDaGFuZ2VMb2cJKHdvcmtpbmcg Y29weSkNCkBAIC0xLDMgKzEsMTQgQEANCisyMDA2LTEyLTEyICBIdW50ZXIgTC4gV2lsbGlhbXMg PGhsd2Via2l0QGdtYWlsLmNvbT4NCisNCisgICAgICAgIFJldmlld2VkIGJ5IFNvbWVib2R5Lg0K Kw0KKyAgICAgICAgRml4IG1vdXNlIHdoZWVsIHNjcm9sbGluZyBpbiA8dGV4dGFyZWE+IGNvbnRy b2xzLg0KKw0KKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyVGV4dENvbnRyb2wuY3BwOg0KKyAg ICAgICAgKiByZW5kZXJpbmcvUmVuZGVyVGV4dENvbnRyb2wuaDoNCisgICAgICAgIE92ZXJyaWRl IHxzY3JvbGx8IG9uIFJlbmRlclRleHRDb250cm9sIHRvIGZvcndhcmQgdGhlIGNhbGwgdG8gdGhl IFJlbmRlck9iamVjdCBvZiB0aGUgDQorICAgICAgICBpbm5lciBtX2Rpdiwgd2hpY2ggaGFzIGEg bGF5ZXIgdGhhdCBjYW4gYmUgc2Nyb2xsZWQuDQorDQogMjAwNi0xMi0xMiAgQW5kZXJzIENhcmxz c29uICA8YWNhcmxzc29uQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbi4K