<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>113109</bug_id>
          
          <creation_ts>2013-03-22 15:41:40 -0700</creation_ts>
          <short_desc>[GTK] [gyp] Expose a few more compiler defines for the gyp build</short_desc>
          <delta_ts>2013-03-22 16:31:40 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKitGTK</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Martin Robinson">mrobinson</reporter>
          <assigned_to name="Martin Robinson">mrobinson</assigned_to>
          
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>861920</commentid>
    <comment_count>0</comment_count>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2013-03-22 15:41:40 -0700</bug_when>
    <thetext>There are a few more compiler defines required for the gyp build.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>861929</commentid>
    <comment_count>1</comment_count>
      <attachid>194649</attachid>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2013-03-22 15:53:31 -0700</bug_when>
    <thetext>Created attachment 194649
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>861937</commentid>
    <comment_count>2</comment_count>
      <attachid>194649</attachid>
    <who name="Gustavo Noronha (kov)">gustavo</who>
    <bug_when>2013-03-22 16:03:32 -0700</bug_when>
    <thetext>Comment on attachment 194649
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=194649&amp;action=review

&gt; Source/WebKit/gtk/gyp/Configuration.gypi.in:23
&gt; +      &apos;DATA_DIR=\&quot;@prefix@/share\&quot;&apos;,

I think that is pretty good enough! =P</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>861959</commentid>
    <comment_count>3</comment_count>
      <attachid>194649</attachid>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2013-03-22 16:31:38 -0700</bug_when>
    <thetext>Comment on attachment 194649
Patch

Clearing flags on attachment: 194649

Committed r146676: &lt;http://trac.webkit.org/changeset/146676&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>861960</commentid>
    <comment_count>4</comment_count>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2013-03-22 16:31:40 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>194649</attachid>
            <date>2013-03-22 15:53:31 -0700</date>
            <delta_ts>2013-03-22 16:31:38 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-113109-20130322154918.patch</filename>
            <type>text/plain</type>
            <size>1639</size>
            <attacher name="Martin Robinson">mrobinson</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ2NDAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2d0
ay9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKaW5kZXggOGJhNzMwYjQ3
Njg0Nzc5ZDMxNzdiOWQ5MzlmZTM1MTNhODBiZTZmZC4uYWZjNGI1NTk4ZTI2ZDFkZjkxYzZkYWM0
YWMwMWM1YjRlNThiOTUwNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9n
CisrKyBiL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE1IEBACiAyMDEz
LTAzLTIyICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KIAorICAgICAg
ICBbR1RLXSBbZ3lwXSBFeHBvc2UgYSBmZXcgbW9yZSBjb21waWxlciBkZWZpbmVzIGZvciB0aGUg
Z3lwIGJ1aWxkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p
ZD0xMTMxMDkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg
ICAqIGd5cC9Db25maWd1cmF0aW9uLmd5cGkuaW46IEV4cG9zZSB0aGUgdmVyc2lvbiBudW1iZXIg
c3RyaW5nIGFuZCBkYXRhCisgICAgICAgIGRpcmVjdG9yeSB0byB0aGUgZ3lwIGJ1aWxkIGFzIGNv
bW1hbmQtbGluZSBhcmd1bWVudHMuCisKKzIwMTMtMDMtMjIgIE1hcnRpbiBSb2JpbnNvbiAgPG1y
b2JpbnNvbkBpZ2FsaWEuY29tPgorCiAgICAgICAgIFtHVEtdIFtneXBdIEZlYXR1cmUgZGVmaW5l
cyBhcmUgbm90IHNwYWNlIHNlcGFyYXRlZAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y
Zy9zaG93X2J1Zy5jZ2k/aWQ9MTEzMTA4CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZ3Rr
L2d5cC9Db25maWd1cmF0aW9uLmd5cGkuaW4gYi9Tb3VyY2UvV2ViS2l0L2d0ay9neXAvQ29uZmln
dXJhdGlvbi5neXBpLmluCmluZGV4IDlkNDE4ZDllZGRmOTQ2YzhlMGI1ZTZkYjE1NWExZGMwMGJh
YjQxMzAuLmRjMjI1Y2RiZGY2MThmMDE2YTViMTQ4NGUwNjBiMTJmMGZlY2VhMjQgMTAwNjQ0Ci0t
LSBhL1NvdXJjZS9XZWJLaXQvZ3RrL2d5cC9Db25maWd1cmF0aW9uLmd5cGkuaW4KKysrIGIvU291
cmNlL1dlYktpdC9ndGsvZ3lwL0NvbmZpZ3VyYXRpb24uZ3lwaS5pbgpAQCAtMTYsNiArMTYsMTEg
QEAKICAgICAgICdCVUlMRElOR19HVEtfXz0xJywKICAgICAgICdCVUlMRElOR19XRUJLSVQ9MScs
CiAgICAgICAnSEFWRV9DT05GSUdfSCcsCisgICAgICAnV0VCS0lUR1RLX0FQSV9WRVJTSU9OX1NU
UklORz1cIjwoYXBpX3ZlcnNpb24pXCInLAorCisgICAgICAjIFRPRE86IFdlIHNob3VsZCByZWFs
bHkgdXNlIGRhdGFkaXIsIGJ1dCBpdCB0eXBpY2FsbHkgcmVxdWlyZXMgbXVsdGlwbGUgc2hlbGwg
ZXZhbHVhdGlvbnMuCisgICAgICAjIFNlZSBodHRwOi8vd3d3LmdudS5vcmcvc2F2YW5uYWgtY2hl
Y2tvdXRzL2dudS9hdXRvY29uZi9tYW51YWwvYXV0b2NvbmYtMi42OS9odG1sX25vZGUvSW5zdGFs
bGF0aW9uLURpcmVjdG9yeS1WYXJpYWJsZXMuaHRtbAorICAgICAgJ0RBVEFfRElSPVwiQHByZWZp
eEAvc2hhcmVcIicsCiAgICAgXSwKIAogICAgICMgV2UgcGFzcyB0aGlzIGFzIGEgY2ZsYWcgaW5z
dGVhZCBvZiBhbiBpbmNsdWRlIHNvIHRoYXQgd2UgY2FuIHBvaW50IHRvCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>