113107 2013-03-22 15:22:45 -0700 [WK2][GTK] MiniBrowser won't display video controls in <embed> tag 2013-04-30 11:24:26 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED https://git.gnome.org/browse/totem/plain/browser-plugin/tests/1.html P2 Normal --- 1 pnormand webkit-unassigned andersca benjamin bugzilla cgarcia sam oldest_to_newest 861903 0 pnormand 2013-03-22 15:22:45 -0700 Linked page displays fine in ephy/wk1 but nothing in ephy/wk2, the plugin process successfully scans the NPAPI Totem plugins though. 861907 1 pnormand 2013-03-22 15:27:02 -0700 In my ephy/wk2 about:plugins page I can see a plugin handling video/divx so it should be used. 862349 2 cgarcia 2013-03-24 05:52:01 -0700 I can see the totem player, but not the media controls, it seems like the clip rectangle is wrong. 862374 3 194754 cgarcia 2013-03-24 09:25:08 -0700 Created attachment 194754 Patch I'm not sure this patch fixes this bug because the summary and description are a bit confusing to me. The summary says the video doesn't play and the description says nothing is shown. I can see the totem window in MiniBrowser, but the media controls are not rendered because it's clipped. With this patch, the right clip region is used and I can see the media controls and play the content (content doesn't really play for me because I don't have the required codecs for the test case, though) 862375 4 194755 cgarcia 2013-03-24 09:27:24 -0700 Created attachment 194755 Fixed a typo in the ChangeLog 862379 5 194755 mrobinson 2013-03-24 10:01:15 -0700 Comment on attachment 194755 Fixed a typo in the ChangeLog Looks good to me. 863539 6 pnormand 2013-03-26 04:15:39 -0700 The issue I have here is that the PluginProcess crashes: Thread 1 (Thread 0x7f56bf6199c0 (LWP 33581)): #0 0x0000000000dbd72c in WebCore::PluginView::getValue(NPNVariable, void*) () #1 0x00007f567cb02efb in totemPlugin::Init(char*, unsigned short, short, char**, char**, _NPSavedData*) () from /usr/lib/mozilla/plugins/libtotem-mully-plugin.so #2 0x00007f567cb00527 in ?? () from /usr/lib/mozilla/plugins/libtotem-mully-plugin.so #3 0x0000000000a67103 in WebKit::NetscapePlugin::initialize(WebKit::Plugin::Parameters const&) () #4 0x0000000000a46df5 in WebKit::PluginControllerProxy::initialize(WebKit::PluginCreationParameters const&) () #5 0x0000000000a49eb3 in WebKit::WebProcessConnection::createPluginInternal(WebKit::PluginCreationParameters const&, bool&, bool&, unsigned int&) () #6 0x0000000000a4a367 in WebKit::WebProcessConnection::createPlugin(WebKit::PluginCreationParameters const&, WTF::PassRefPtr<Messages::WebProcessConnection::CreatePlugin::DelayedReply>) () #7 0x0000000000a6ec22 in void CoreIPC::handleMessageDelayed<Messages::WebProcessConnection::CreatePlugin, WebKit::WebProcessConnection, void (WebKit::WebProcessConnection::*)(WebKit::PluginCreationParameters const&, WTF::PassRefPtr<Messages::WebProcessConnection::CreatePlugin::DelayedReply>)>(CoreIPC::Connection*, CoreIPC::MessageDecoder&, WTF::OwnPtr<CoreIPC::MessageEncoder>&, WebKit::WebProcessConnection*, void (WebKit::WebProcessConnection::*)(WebKit::PluginCreationParameters const&, WTF::PassRefPtr<Messages::WebProcessConnection::CreatePlugin::DelayedReply>)) () #8 0x0000000000a6e9c3 in WebKit::WebProcessConnection::didReceiveSyncWebProcessConnectionMessage(CoreIPC::Connection*, CoreIPC::MessageDecoder&, WTF::OwnPtr<CoreIPC::MessageEncoder>&) () #9 0x0000000000a49bab in WebKit::WebProcessConnection::didReceiveSyncMessage(CoreIPC::Connection*, CoreIPC::MessageDecoder&, WTF::OwnPtr<CoreIPC::MessageEncoder>&) () #10 0x0000000000a3c017 in CoreIPC::Connection::dispatchSyncMessage(CoreIPC::MessageDecoder&) () #11 0x0000000000a3c17b in CoreIPC::Connection::dispatchMessage(WTF::PassOwnPtr<CoreIPC::MessageDecoder>) () #12 0x0000000000a3cdbe in CoreIPC::Connection::SyncMessageState::dispatchMessages(CoreIPC::Connection*) () #13 0x0000000001bbc5bb in WebCore::RunLoop::performWork() () #14 0x0000000001c21269 in WebCore::RunLoop::queueWork(WebCore::RunLoop*) () #15 0x00007f56c7779f25 in g_main_dispatch (context=0x37b7df0) at gmain.c:3054 #16 g_main_context_dispatch (context=context@entry=0x37b7df0) at gmain.c:3630 #17 0x00007f56c777a268 in g_main_context_iterate (context=0x37b7df0, block=block@entry=1, dispatch=dispatch@entry=1, self=<error reading variable: Unhandled dwarf expression opcode 0xfa>) at gmain.c:3701 #18 0x00007f56c777a6da in g_main_loop_run (loop=0x38091a0) at gmain.c:3895 #19 0x0000000000a4b89c in PluginProcessMainUnix () #20 0x00007f56c3deca55 in __libc_start_main () from /lib/x86_64-linux-gnu/libc.so.6 #21 0x0000000000a3a199 in _start () The parameters and mimetype are correctly passed to NPP_New, I'd need a debug build to continue to investigate this further... 883176 7 cgarcia 2013-04-30 11:24:26 -0700 Committed r149384: <http://trac.webkit.org/changeset/149384> 194754 2013-03-24 09:25:08 -0700 2013-03-24 09:27:24 -0700 Patch wk2-windowed-clip.diff text/plain 1781 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBkNDkwN2M0Zi4uYTY2MTJlNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dDIvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDEzLTAzLTI0ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNv bT4KKworICAgICAgICBbV0syXVtHVEtdIE1pbmlCcm93c2VyIHdvbid0IHBsYXkgdmlkZW8gaW4g PGVtYmVkPiB0YWcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTExMzEwNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFRoZSB3cm9uZyBjbGlwIHJlZ2lvbiBpcyB1c2VkIGZvciB3aW5kb3dlZCBwbHVnaW5zLCBi ZWNhdXNlIGl0J3MKKyAgICAgICAgdHJhbnNsYXRlZCB0byB3aW5kbyBmcmFtZSBjb29yZHMgYWdh aW4uCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1BsdWdpbnMvTmV0c2NhcGUveDExL05ldHNjYXBl UGx1Z2luWDExLmNwcDoKKyAgICAgICAgKFdlYktpdDo6TmV0c2NhcGVQbHVnaW46OnBsYXRmb3Jt R2VvbWV0cnlEaWRDaGFuZ2UpOiBEbyBub3QgbW92ZQorICAgICAgICB0aGUgY3VycmVudCBjbGlw IHJlZ2lvbi4KKwogMjAxMy0wMy0xOSAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGln YWxpYS5jb20+CiAKICAgICAgICAgW0dUS10gQWRkIHBhZGRpbmcgdG8gYWxsIHB1YmxpYyBjbGFz cyBzdHJ1Y3RzIGZvciBmdXR1cmUgZXhwYW5zaW9uIHdpdGhvdXQgYnJlYWtpbmcgQUJJCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvTmV0c2NhcGUveDExL05l dHNjYXBlUGx1Z2luWDExLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9O ZXRzY2FwZS94MTEvTmV0c2NhcGVQbHVnaW5YMTEuY3BwCmluZGV4IGExODQ2ODcuLmRlY2RmMjgg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9OZXRzY2FwZS94 MTEvTmV0c2NhcGVQbHVnaW5YMTEuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3Mv UGx1Z2lucy9OZXRzY2FwZS94MTEvTmV0c2NhcGVQbHVnaW5YMTEuY3BwCkBAIC0zMTIsOSArMzEy LDcgQEAgdm9pZCBOZXRzY2FwZVBsdWdpbjo6cGxhdGZvcm1HZW9tZXRyeURpZENoYW5nZSgpCiAj aWYgUExBVEZPUk0oR1RLKQogICAgICAgICB3aW5kb3dJRCA9IHN0YXRpY19jYXN0PHVpbnQ2NF90 PihHREtfV0lORE9XX1hJRChndGtfcGx1Z19nZXRfc29ja2V0X3dpbmRvdyhHVEtfUExVRyhtX3Bs YXRmb3JtUGx1Z2luV2lkZ2V0KSkpKTsKICNlbmRpZgotICAgICAgICBJbnRSZWN0IGNsaXBSZWN0 KG1fY2xpcFJlY3QpOwotICAgICAgICBjbGlwUmVjdC5tb3ZlKC1tX2ZyYW1lUmVjdEluV2luZG93 Q29vcmRpbmF0ZXMueCgpLCAtbV9mcmFtZVJlY3RJbldpbmRvd0Nvb3JkaW5hdGVzLnkoKSk7Ci0g ICAgICAgIGNvbnRyb2xsZXIoKS0+d2luZG93ZWRQbHVnaW5HZW9tZXRyeURpZENoYW5nZShtX2Zy YW1lUmVjdEluV2luZG93Q29vcmRpbmF0ZXMsIGNsaXBSZWN0LCB3aW5kb3dJRCk7CisgICAgICAg IGNvbnRyb2xsZXIoKS0+d2luZG93ZWRQbHVnaW5HZW9tZXRyeURpZENoYW5nZShtX2ZyYW1lUmVj dEluV2luZG93Q29vcmRpbmF0ZXMsIG1fY2xpcFJlY3QsIHdpbmRvd0lEKTsKICAgICAgICAgcmV0 dXJuOwogICAgIH0KIAo= 194755 2013-03-24 09:27:24 -0700 2013-04-30 08:34:06 -0700 Fixed a typo in the ChangeLog wk2-windowed-clip.diff text/plain 1782 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBkNDkwN2M0Zi4uZWRkODllOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dDIvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDEzLTAzLTI0ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNv bT4KKworICAgICAgICBbV0syXVtHVEtdIE1pbmlCcm93c2VyIHdvbid0IHBsYXkgdmlkZW8gaW4g PGVtYmVkPiB0YWcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTExMzEwNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFRoZSB3cm9uZyBjbGlwIHJlZ2lvbiBpcyB1c2VkIGZvciB3aW5kb3dlZCBwbHVnaW5zLCBi ZWNhdXNlIGl0J3MKKyAgICAgICAgdHJhbnNsYXRlZCB0byB3aW5kb3cgZnJhbWUgY29vcmRzIGFn YWluLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9QbHVnaW5zL05ldHNjYXBlL3gxMS9OZXRzY2Fw ZVBsdWdpblgxMS5jcHA6CisgICAgICAgIChXZWJLaXQ6Ok5ldHNjYXBlUGx1Z2luOjpwbGF0Zm9y bUdlb21ldHJ5RGlkQ2hhbmdlKTogRG8gbm90IG1vdmUKKyAgICAgICAgdGhlIGN1cnJlbnQgY2xp cCByZWdpb24uCisKIDIwMTMtMDMtMTkgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBp Z2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIEFkZCBwYWRkaW5nIHRvIGFsbCBwdWJsaWMgY2xh c3Mgc3RydWN0cyBmb3IgZnV0dXJlIGV4cGFuc2lvbiB3aXRob3V0IGJyZWFraW5nIEFCSQpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL05ldHNjYXBlL3gxMS9O ZXRzY2FwZVBsdWdpblgxMS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMv TmV0c2NhcGUveDExL05ldHNjYXBlUGx1Z2luWDExLmNwcAppbmRleCBhMTg0Njg3Li5kZWNkZjI4 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvTmV0c2NhcGUv eDExL05ldHNjYXBlUGx1Z2luWDExLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNz L1BsdWdpbnMvTmV0c2NhcGUveDExL05ldHNjYXBlUGx1Z2luWDExLmNwcApAQCAtMzEyLDkgKzMx Miw3IEBAIHZvaWQgTmV0c2NhcGVQbHVnaW46OnBsYXRmb3JtR2VvbWV0cnlEaWRDaGFuZ2UoKQog I2lmIFBMQVRGT1JNKEdUSykKICAgICAgICAgd2luZG93SUQgPSBzdGF0aWNfY2FzdDx1aW50NjRf dD4oR0RLX1dJTkRPV19YSUQoZ3RrX3BsdWdfZ2V0X3NvY2tldF93aW5kb3coR1RLX1BMVUcobV9w bGF0Zm9ybVBsdWdpbldpZGdldCkpKSk7CiAjZW5kaWYKLSAgICAgICAgSW50UmVjdCBjbGlwUmVj dChtX2NsaXBSZWN0KTsKLSAgICAgICAgY2xpcFJlY3QubW92ZSgtbV9mcmFtZVJlY3RJbldpbmRv d0Nvb3JkaW5hdGVzLngoKSwgLW1fZnJhbWVSZWN0SW5XaW5kb3dDb29yZGluYXRlcy55KCkpOwot ICAgICAgICBjb250cm9sbGVyKCktPndpbmRvd2VkUGx1Z2luR2VvbWV0cnlEaWRDaGFuZ2UobV9m cmFtZVJlY3RJbldpbmRvd0Nvb3JkaW5hdGVzLCBjbGlwUmVjdCwgd2luZG93SUQpOworICAgICAg ICBjb250cm9sbGVyKCktPndpbmRvd2VkUGx1Z2luR2VvbWV0cnlEaWRDaGFuZ2UobV9mcmFtZVJl Y3RJbldpbmRvd0Nvb3JkaW5hdGVzLCBtX2NsaXBSZWN0LCB3aW5kb3dJRCk7CiAgICAgICAgIHJl dHVybjsKICAgICB9CiAK