113103 2013-03-22 15:11:19 -0700 [EFL] Add support to check for current Drawable. 2013-03-24 09:21:30 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 105659 1 kalyan.kondapally kalyan.kondapally dino kenneth lucas.de.marchi noam sergio webkit.review.bot oldest_to_newest 861887 0 kalyan.kondapally 2013-03-22 15:11:19 -0700 In MakeCurrent we do an early return if it is the current GL context but ignore Surface. We should also check if the surface is current drawable or not. 862173 1 194695 kalyan.kondapally 2013-03-23 02:26:02 -0700 Created attachment 194695 patch 862346 2 194695 kenneth 2013-03-24 05:21:26 -0700 Comment on attachment 194695 patch View in context: https://bugs.webkit.org/attachment.cgi?id=194695&action=review > Source/WebCore/platform/graphics/opengl/GLPlatformContext.cpp:245 > + if (this == m_currentContext) { I like this the other way around, but anyway you are just moving it 862372 3 194695 webkit.review.bot 2013-03-24 09:00:10 -0700 Comment on attachment 194695 patch Clearing flags on attachment: 194695 Committed r146730: <http://trac.webkit.org/changeset/146730> 862373 4 webkit.review.bot 2013-03-24 09:00:14 -0700 All reviewed patches have been landed. Closing bug. 194695 2013-03-23 02:26:02 -0700 2013-03-24 09:00:10 -0700 patch makecurrentfix.patch text/plain 4797 kalyan.kondapally ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA4Njc4ZjMxLi5mOTg0YzhkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjgg QEAKKzIwMTMtMDMtMjIgIEtvbmRhcGFsbHlLYWx5YW4gIDxrYWx5YW4ua29uZGFwYWxseUBpbnRl bC5jb20+CisKKyAgICAgICAgW0VGTF0gQWRkIHN1cHBvcnQgdG8gY2hlY2sgZm9yIGN1cnJlbnQg RHJhd2FibGUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMTMxMDMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBDb3ZlcmVkIGJ5IGV4aXN0aW5nIFdlYkdMIHRlc3RzLgorCisgICAgICAgIEluIE1ha2VDdXJy ZW50IHdlIGRvIGFuIGVhcmx5IHJldHVybiBpZiBpdCBpcworICAgICAgICB0aGUgY3VycmVudCBH TCBjb250ZXh0IGJ1dCBpZ25vcmUgU3VyZmFjZS4gVGhpcworICAgICAgICBwYXRjaCBmaXhlcyB0 aGUgaXNzdWUsIHdlIG5vdyBjaGVjayBmb3IgYm90aAorICAgICAgICBjb250ZXh0IGFuZCBzdXJm YWNlIGJlZm9yZSBkb2luZyBhbiBlYXJseSByZXR1cm4KKyAgICAgICAgaW4gTWFrZUN1cnJlbnQu CisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvR0xQbGF0Zm9ybUNvbnRleHQu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6R0xQbGF0Zm9ybUNvbnRleHQ6Om1ha2VDdXJyZW50KToK KyAgICAgICAgKFdlYkNvcmU6OkdMUGxhdGZvcm1Db250ZXh0OjpyZWxlYXNlQ3VycmVudCk6Cisg ICAgICAgIChXZWJDb3JlOjpHTFBsYXRmb3JtQ29udGV4dDo6ZGVzdHJveSk6CisgICAgICAgICog cGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbmdsL0dMUGxhdGZvcm1TdXJmYWNlLmNwcDoKKyAgICAgICAg KFdlYkNvcmUpOgorICAgICAgICAoV2ViQ29yZTo6R0xQbGF0Zm9ybVN1cmZhY2U6OmlzQ3VycmVu dERyYXdhYmxlKToKKyAgICAgICAgKFdlYkNvcmU6OkdMUGxhdGZvcm1TdXJmYWNlOjpvbk1ha2VD dXJyZW50KToKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvR0xQbGF0Zm9ybVN1 cmZhY2UuaDoKKwogMjAxMy0wMy0yMiAgS29uZGFwYWxseSBLYWx5YW4gIDxrYWx5YW4ua29uZGFw YWxseUBpbnRlbC5jb20+CiAKICAgICAgICAgW0VGTF0gRml4IGJ1aWxkIGlzc3VlcyB0byBlbmFi bGUgQ1NTIEZpbHRlciBhbmQgU2hhZGVycyBzdXBwb3J0LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbmdsL0dMUGxhdGZvcm1Db250ZXh0LmNwcCBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL29wZW5nbC9HTFBsYXRmb3JtQ29udGV4dC5j cHAKaW5kZXggYmNlMDQyNS4uODllZTZiMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3Mvb3BlbmdsL0dMUGxhdGZvcm1Db250ZXh0LmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvR0xQbGF0Zm9ybUNvbnRleHQuY3BwCkBA IC0xOTcsMTUgKzE5NywxNyBAQCBib29sIEdMUGxhdGZvcm1Db250ZXh0OjptYWtlQ3VycmVudChH TFBsYXRmb3JtU3VyZmFjZSogc3VyZmFjZSkKIHsKICAgICBtX2NvbnRleHRMb3N0ID0gZmFsc2U7 CiAKLSAgICBpZiAoaXNDdXJyZW50Q29udGV4dCgpKQorICAgIGlmIChtX2N1cnJlbnRDb250ZXh0 ID09IHRoaXMgJiYgKCFzdXJmYWNlIHx8IHN1cmZhY2UtPmlzQ3VycmVudERyYXdhYmxlKCkpKQog ICAgICAgICByZXR1cm4gdHJ1ZTsKIAogICAgIG1fY3VycmVudENvbnRleHQgPSAwOwogCiAgICAg aWYgKCFzdXJmYWNlIHx8IChzdXJmYWNlICYmICFzdXJmYWNlLT5kcmF3YWJsZSgpKSkKICAgICAg ICAgcGxhdGZvcm1SZWxlYXNlQ3VycmVudCgpOwotICAgIGVsc2UgaWYgKHBsYXRmb3JtTWFrZUN1 cnJlbnQoc3VyZmFjZSkpCisgICAgZWxzZSBpZiAocGxhdGZvcm1NYWtlQ3VycmVudChzdXJmYWNl KSkgewogICAgICAgICBtX2N1cnJlbnRDb250ZXh0ID0gdGhpczsKKyAgICAgICAgc3VyZmFjZS0+ b25NYWtlQ3VycmVudCgpOworICAgIH0KIAogICAgIGlmIChtX3Jlc2V0TG9zdENvbnRleHQpIHsK ICAgICAgICAgcmVzb2x2ZVJlc2V0U3RhdHVzRXh0ZW5zaW9uKCk7CkBAIC0yNDAsMTEgKzI0Miwx MCBAQCBib29sIEdMUGxhdGZvcm1Db250ZXh0Ojppc1ZhbGlkKCkgY29uc3QKIAogdm9pZCBHTFBs YXRmb3JtQ29udGV4dDo6cmVsZWFzZUN1cnJlbnQoKQogewotICAgIGlmICghaXNDdXJyZW50Q29u dGV4dCgpKQotICAgICAgICByZXR1cm47Ci0KLSAgICBtX2N1cnJlbnRDb250ZXh0ID0gMDsKLSAg ICBwbGF0Zm9ybVJlbGVhc2VDdXJyZW50KCk7CisgICAgaWYgKHRoaXMgPT0gbV9jdXJyZW50Q29u dGV4dCkgeworICAgICAgICBtX2N1cnJlbnRDb250ZXh0ID0gMDsKKyAgICAgICAgcGxhdGZvcm1S ZWxlYXNlQ3VycmVudCgpOworICAgIH0KIH0KIAogUGxhdGZvcm1Db250ZXh0IEdMUGxhdGZvcm1D b250ZXh0OjpoYW5kbGUoKSBjb25zdApAQCAtMjgxLDkgKzI4Miw2IEBAIHZvaWQgR0xQbGF0Zm9y bUNvbnRleHQ6OmRlc3Ryb3koKQogewogICAgIG1fY29udGV4dEhhbmRsZSA9IDA7CiAgICAgbV9y ZXNldExvc3RDb250ZXh0ID0gZmFsc2U7Ci0KLSAgICBpZiAodGhpcyA9PSBtX2N1cnJlbnRDb250 ZXh0KQotICAgICAgICBtX2N1cnJlbnRDb250ZXh0ID0gMDsKIH0KIAogfSAvLyBuYW1lc3BhY2Ug V2ViQ29yZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvb3Bl bmdsL0dMUGxhdGZvcm1TdXJmYWNlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL29wZW5nbC9HTFBsYXRmb3JtU3VyZmFjZS5jcHAKaW5kZXggMGRiODBlMC4uOTE3OGZlZSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbmdsL0dMUGxh dGZvcm1TdXJmYWNlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9v cGVuZ2wvR0xQbGF0Zm9ybVN1cmZhY2UuY3BwCkBAIC00MCw2ICs0MCw4IEBACiAKIG5hbWVzcGFj ZSBXZWJDb3JlIHsKIAorc3RhdGljIEdMUGxhdGZvcm1TdXJmYWNlKiBtX2N1cnJlbnREcmF3YWJs ZSA9IDA7CisKIFBhc3NPd25QdHI8R0xQbGF0Zm9ybVN1cmZhY2U+IEdMUGxhdGZvcm1TdXJmYWNl OjpjcmVhdGVPZmZTY3JlZW5TdXJmYWNlKFN1cmZhY2VBdHRyaWJ1dGVzIGF0dHJpYnV0ZXMpCiB7 CiAjaWYgVVNFKEdMWCkKQEAgLTYzLDYgKzY1LDggQEAgR0xQbGF0Zm9ybVN1cmZhY2U6OkdMUGxh dGZvcm1TdXJmYWNlKFN1cmZhY2VBdHRyaWJ1dGVzKQogCiBHTFBsYXRmb3JtU3VyZmFjZTo6fkdM UGxhdGZvcm1TdXJmYWNlKCkKIHsKKyAgICBpZiAobV9jdXJyZW50RHJhd2FibGUgPT0gdGhpcykK KyAgICAgICAgbV9jdXJyZW50RHJhd2FibGUgPSAwOwogfQogCiBQbGF0Zm9ybUJ1ZmZlckhhbmRs ZSBHTFBsYXRmb3JtU3VyZmFjZTo6aGFuZGxlKCkgY29uc3QKQEAgLTk1LDYgKzk5LDE2IEBAIHZv aWQgR0xQbGF0Zm9ybVN1cmZhY2U6OnN3YXBCdWZmZXJzKCkKICAgICBub3RJbXBsZW1lbnRlZCgp OwogfQogCitib29sIEdMUGxhdGZvcm1TdXJmYWNlOjppc0N1cnJlbnREcmF3YWJsZSgpIGNvbnN0 Cit7CisgICAgcmV0dXJuIG1fY3VycmVudERyYXdhYmxlID09IHRoaXM7Cit9CisKK3ZvaWQgR0xQ bGF0Zm9ybVN1cmZhY2U6Om9uTWFrZUN1cnJlbnQoKQoreworICAgIG1fY3VycmVudERyYXdhYmxl ID0gdGhpczsKK30KKwogdm9pZCBHTFBsYXRmb3JtU3VyZmFjZTo6dXBkYXRlQ29udGVudHMoY29u c3QgdWludDMyX3QpCiB7CiB9CkBAIC0xMDUsNiArMTE5LDggQEAgdm9pZCBHTFBsYXRmb3JtU3Vy ZmFjZTo6c2V0R2VvbWV0cnkoY29uc3QgSW50UmVjdCYpCiAKIHZvaWQgR0xQbGF0Zm9ybVN1cmZh Y2U6OmRlc3Ryb3koKQogeworICAgIGlmIChtX2N1cnJlbnREcmF3YWJsZSA9PSB0aGlzKQorICAg ICAgICBtX2N1cnJlbnREcmF3YWJsZSA9IDA7CiB9CiAKIEdMUGxhdGZvcm1TdXJmYWNlOjpTdXJm YWNlQXR0cmlidXRlcyBHTFBsYXRmb3JtU3VyZmFjZTo6YXR0cmlidXRlcygpIGNvbnN0CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvR0xQbGF0Zm9y bVN1cmZhY2UuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL29wZW5nbC9HTFBs YXRmb3JtU3VyZmFjZS5oCmluZGV4IDU0M2I2NzUuLmQyNzZmYTUgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL29wZW5nbC9HTFBsYXRmb3JtU3VyZmFjZS5oCisr KyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL29wZW5nbC9HTFBsYXRmb3JtU3Vy ZmFjZS5oCkBAIC02Nyw2ICs2Nyw5IEBAIHB1YmxpYzoKIAogICAgIHZpcnR1YWwgdm9pZCBzd2Fw QnVmZmVycygpOwogCisgICAgdmlydHVhbCBib29sIGlzQ3VycmVudERyYXdhYmxlKCkgY29uc3Q7 CisgICAgdmlydHVhbCB2b2lkIG9uTWFrZUN1cnJlbnQoKTsKKwogICAgIC8vIENvbnZlbmllbmNl IEZ1bmN0aW9uIHRvIHVwZGF0ZSBzdXJmYWNlIGJhY2tidWZmZXIgd2l0aCB0ZXh0dXJlIGNvbnRl bnRzLgogICAgIC8vIE5vdGUgdGhhdCB0aGUgZnVuY3Rpb24gZG9lc24ndCB0cmFjayBvciByZXN0 b3JlIGFueSBHTCBzdGF0ZXMuCiAgICAgLy8gRnVuY3Rpb24gZG9lcyB0aGUgZm9sbG93aW5nKGlu IG9yZGVyKToK