113090 2013-03-22 12:21:50 -0700 Web Inspector: Page crash in ScriptPreprocessor if content scripts are present 2014-02-07 12:36:40 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED INVALID P2 Normal --- 0 johnjbarton webkit-unassigned abarth apavlov bburg haraken japhet keishi loislo pfeldman pmuellr vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 861756 0 johnjbarton 2013-03-22 12:21:50 -0700 Regarding ScriptPreprocessor see also bug 111889 Bug 80992 and Bug 104384 Bug 112926 When the script preprocessor is active and we have Chrome extensions with content scripts, we crash. Here is some tracing output. First we enter the preprocessor code, then, in V8 we print the script just before the onBeforeCompile() call, using: -------------------- script->Print(stdout); // Notify debugger isolate->debugger()->OnBeforeCompile(script); printf("----- return from OnBeforeCompile -----\n"); ----------------- Notice that we are recursing, we are in the onBeforeCompile event for the preprocessor itself. The crash occurs because we are trying to lookup the World for the utility context set up for the preprocessor, see v8/bindings/V8Binding.cpp WrapperWorldType worldTypeInMainThread(v8::Isolate* isolate) { if (!DOMWrapperWorld::isolatedWorldsExist()) return MainWorld; ASSERT(!v8::Context::GetEntered().IsEmpty()); DOMWrapperWorld* isolatedWorld = DOMWrapperWorld::isolatedWorld(v8::Context::GetEntered()); if (isolatedWorld) return IsolatedWorld; return MainWorld; } In particular, without content scripts we'll take the first return and never call DOMWrapperWorld::isolatedWorld(). ERROR: setScriptPreprocessor: ------------------------------ preprocessor clear ------------------------------ ../../third_party/WebKit/Source/WebCore/bindings/v8/ScriptDebugServer.cpp(405) : void WebCore::ScriptDebugServer::setScriptPreprocessor(const WTF::String&, WebCore::DOMWindow*) 0x256b47cdc089: [Script] - source: 0x2ba751f04101 <Very long string[876129]> - name: 0x2ba751fd9f81 <String[23]: $preprocessingScript.js> - line_offset: 0 - column_offset: 0 - type: 2 - id: 67 - data: 0x258114804121 <undefined> - context data: 0x258114804121 <undefined> - wrapper: 0x25229152fb51 <Foreign> - compilation type: 0 - line ends: 0x258114804121 <undefined> - eval from shared: 0x258114804121 <undefined> - eval from instructions offset: 0 ASSERTION FAILED: contextHasCorrectPrototype(context) ../../third_party/WebKit/Source/WebCore/bindings/v8/DOMWrapperWorld.h(67) : static WebCore::DOMWrapperWorld* WebCore::DOMWrapperWorld::isolatedWorld(v8::Handle<v8::Context>) 1 0x7f8898b7c62f 2 0x7f8898bc99ae 3 0x7f8898b98586 4 0x7f8898b99313 5 0x7f8898ba7c8e 6 0x7f8898ba7b56 7 0x7f889aa3b4b1 8 0x7f889aa3b3f7 9 0x7f889aa3b2c7 10 0x7f889aa3acaf 11 0x7f889aa25bfd 12 0x7f889aa2663d 13 0x7f889a9ce7bb 14 0x7f889a9ceab4 15 0x7f8898baa70f 16 0x7f8898ba7436 17 0x7f8898e563de 18 0x7f8898df1d79 19 0x7f8898e96b36 20 0x7f8898e94c29 21 0x7f8898e94b1a 22 0x7f8898e88a21 23 0x7f8898e6af34 24 0x7f88979bdc55 25 0x7f8897a31ebe 26 0x7f8898e6ad73 27 0x7f8898e6b674 28 0x7f8898ea857e 29 0x7f8898ed4425 30 0x7f8898ebad0d 31 0x7f8898ebaad3 Received signal 11 SEGV_MAPERR 0000bbadbeef [0x7f8897cb43e8] base::debug::StackTrace::StackTrace() [0x7f8897cb3cef] base::debug::(anonymous namespace)::StackDumpSignalHandler() [0x7f8892145cb0] <unknown> [0x7f8898b7c639] WebCore::DOMWrapperWorld::isolatedWorld() [0x7f8898bc99ae] WebCore::worldTypeInMainThread() [0x7f8898b98586] WebCore::retrieveFrameWithGlobalObjectCheck() [0x7f8898b99313] WebCore::PageScriptDebugServer::getDebugListenerForContext() [0x7f8898ba7c8e] WebCore::ScriptDebugServer::handleV8DebugEvent() [0x7f8898ba7b56] WebCore::ScriptDebugServer::v8DebugEventCallback() [0x7f889aa3b4b1] v8::internal::Debugger::CallCEventCallback() [0x7f889aa3b3f7] v8::internal::Debugger::CallEventCallback() [0x7f889aa3b2c7] v8::internal::Debugger::ProcessDebugEvent() [0x7f889aa3acaf] v8::internal::Debugger::OnBeforeCompile() [0x7f889aa25bfd] v8::internal::MakeFunctionInfo() [0x7f889aa2663d] v8::internal::Compiler::Compile() [0x7f889a9ce7bb] v8::Script::New() [0x7f889a9ceab4] v8::Script::Compile() [0x7f8898baa70f] WebCore::ScriptDebugServer::ScriptPreprocessor::ScriptPreprocessor() [0x7f8898ba7436] WebCore::ScriptDebugServer::setScriptPreprocessor() [0x7f8898e563de] WebCore::PageDebuggerAgent::didClearMainFrameWindowObject() [0x7f8898df1d79] WebCore::InspectorInstrumentation::didClearWindowObjectInWorldImpl() [0x7f8898e96b36] WebCore::InspectorInstrumentation::didClearWindowObjectInWorld() [0x7f8898e94c29] WebCore::FrameLoader::dispatchDidClearWindowObjectInWorld() [0x7f8898e94b1a] WebCore::FrameLoader::dispatchDidClearWindowObjectsInAllWorlds() [0x7f8898e88a21] WebCore::FrameLoader::receivedFirstData() [0x7f8898e6af34] WebCore::DocumentLoader::commitData() [0x7f88979bdc55] WebKit::WebFrameImpl::commitDocumentData() [0x7f8897a31ebe] WebKit::FrameLoaderClientImpl::committedLoad() [0x7f8898e6ad73] WebCore::DocumentLoader::commitLoad() [0x7f8898e6b674] WebCore::DocumentLoader::receivedData() [0x7f8898ea857e] WebCore::MainResourceLoader::dataReceived() [0x7f8898ed4425] WebCore::CachedRawResource::data() [0x7f8898ebad0d] WebCore::SubresourceLoader::sendDataToResource() [0x7f8898ebaad3] WebCore::SubresourceLoader::didReceiveDataOrBuffer() [0x7f8898eba80b] WebCore::SubresourceLoader::didReceiveData() [0x7f8898eb624f] WebCore::ResourceLoader::didReceiveData() [0x7f889a8a084c] WebCore::ResourceHandleInternal::didReceiveData() [0x7f889b1b9718] webkit_glue::WebURLLoaderImpl::Context::OnReceivedData() [0x7f889984316c] content::ResourceDispatcher::OnReceivedData() [0x7f8899846143] ResourceMsg_DataReceived::Dispatch<>() [0x7f889984444c] content::ResourceDispatcher::DispatchMessage() [0x7f8899842951] content::ResourceDispatcher::OnMessageReceived() [0x7f8899747931] content::ChildThread::OnMessageReceived() [0x7f889766d125] IPC::ChannelProxy::Context::OnDispatchMessage() [0x7f8897670812] base::internal::RunnableAdapter<>::Run() [0x7f88976702f0] base::internal::InvokeHelper<>::MakeItSo() [0x7f889766fbba] base::internal::Invoker<>::Run() [0x7f8896bbb7a5] base::Callback<>::Run() [0x7f8897ce49c7] MessageLoop::RunTask() [0x7f8897ce4ade] MessageLoop::DeferOrRunPendingTask() [0x7f8897ce5345] MessageLoop::DoWork() [0x7f8897cece0a] base::MessagePumpDefault::Run() [0x7f8897ce45cf] MessageLoop::RunInternal() [0x7f8897ce448a] MessageLoop::RunHandler() [0x7f8897d0c270] base::RunLoop::Run() [0x7f8897ce3dc2] MessageLoop::Run() [0x7f889a06ee92] content::RendererMain() [0x7f889a0098c5] content::RunZygote() [0x7f889a009ae6] content::RunNamedProcessTypeMain() [0x7f889a00a8f8] content::ContentMainRunnerImpl::Run() [0x7f889a009043] content::ContentMain() [0x7f8896b3694d] ChromeMain r8: 00007f88962fd980 r9: 00007f88963422d0 r10: 000000000601fa4d r11: 0000000000000000 r12: 000001e148156020 r13: 00007fff43ad3980 r14: 0000000000000000 r15: 0000000000000000 di: 0000000000000000 si: 00000000efcdab90 bp: 00007fff43acf090 bx: 000001e14814d0e0 dx: 00007f889050daa0 ax: 00000000bbadbeef cx: 00007f889023991d sp: 00007fff43acf020 ip: 00007f8898b7c639 efl: 0000000000010246 cgf: 0000000000000033 erf: 0000000000000006 trp: 000000000000000e msk: 0000000000000000 cr2: 00000000bbadbeef [27709:27723:0322/120735:WARNING:crl_set_fetcher.cc(182)] Failed to parse delta CRL set 861888 1 194639 johnjbarton 2013-03-22 15:11:50 -0700 Created attachment 194639 Patch 861890 2 johnjbarton 2013-03-22 15:13:21 -0700 TODO figure out how to test preprocessor in the presence of content-scripts. 864931 3 johnjbarton 2013-03-27 15:45:16 -0700 Filtering out content scripts was necessary but not sufficient. The Inspector adds scripts for several reasons and none of these should go thru the preprocessor. (Another cool way to crash here is to report an error while preprocessing the Inspector's console support script (injectedscript) since reporting an error requires the console support script...). So I now have additional cases waiting in a patch built this bug and on Bug 113331. 194639 2013-03-22 15:11:50 -0700 2013-04-08 16:10:50 -0700 Patch bug-113090-20130322150737.patch text/plain 4123 johnjbarton U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ2MDcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjQwNDc4ZmJkMjAzY2I1 NTIwNzEyNjg1OTBlNGIwZWQ1ZTUxNGY0Mi4uODEwYTRmYTQ0M2JhY2Q4YTI2NzA1N2M4Y2ZhYWMx MDZjOGM2MTU2ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEzLTAzLTIyICBKb2hu IEouIEJhcnRvbiAgPGpvaG5qYmFydG9uQGNocm9taXVtLm9yZz4KKworICAgICAgICBXZWIgSW5z cGVjdG9yOiBQYWdlIGNyYXNoIGluIFNjcmlwdFByZXByb2Nlc3NvciBpZiBjb250ZW50IHNjcmlw dHMgYXJlIHByZXNlbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTExMzA5MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIE5vIG5ldyB0ZXN0cyAoT09QUyEpLgorCisgICAgICAgIERlZmluZSBlbnVtIGNvbnRl eHRLaW5kIHZhbHVlcyBmb3IgQ29udGV4dHMsCisgICAgICAgIGFuYWx5emUgdGhlIGNvbnRleHQn cyBlbWJlZGRlZCBkYXRhIHRvIGV4dHJhY3QgYSBraW5kIHZhbHVlLAorICAgICAgICB1c2UgdGhl IGtpbmQgdmFsdWUgdG8gYXZvaWQgY3Jhc2hpbmcgb24gbm9uLW1haW5Xb3JsZCBjb25uZWN0ZWQK KyAgICAgICAgY29udGV4dHMgYW5kIHRvIGF2b2lkIHByZXByb2Nlc3NpbmcgY29udGVudCBzY3Jp cHRzLgorCisKKyAgICAgICAgKiBiaW5kaW5ncy92OC9TY3JpcHREZWJ1Z1NlcnZlci5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpTY3JpcHREZWJ1Z1NlcnZlcjo6U2NyaXB0UHJlcHJvY2Vzc29yOjpn ZXRDb250ZXh0S2luZCk6CisgICAgICAgIChTY3JpcHREZWJ1Z1NlcnZlcjo6U2NyaXB0UHJlcHJv Y2Vzc29yKToKKyAgICAgICAgKFdlYkNvcmU6OlNjcmlwdERlYnVnU2VydmVyOjpoYW5kbGVWOERl YnVnRXZlbnQpOgorCiAyMDEzLTAzLTE4ICBFbWlsIEEgRWtsdW5kICA8ZWFlQGNocm9taXVtLm9y Zz4KIAogICAgICAgICBDaGFuZ2UgUmVuZGVyVGFibGVDZWxsIHRvIHVzZSBwaXhlbFNuYXBwZWRT aXplIHdoZW4gcGFpbnRpbmcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4 L1NjcmlwdERlYnVnU2VydmVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Njcmlw dERlYnVnU2VydmVyLmNwcAppbmRleCBlNDA0OTVmMjQ4NTVjOWYxY2M4YjAzMzhiMTg4MzcyNGUw YjU5ZTE2Li5mYTEwOTA3YzE5ZmRmNTFmMDg1ZTAwOTQ1YzQ4ZWUzZjg0OTE3ZDg2IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9TY3JpcHREZWJ1Z1NlcnZlci5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0RGVidWdTZXJ2ZXIuY3BwCkBAIC00 Miw2ICs0Miw3IEBACiAjaW5jbHVkZSAiVjhKYXZhU2NyaXB0Q2FsbEZyYW1lLmgiCiAjaW5jbHVk ZSAiVjhSZWN1cnNpb25TY29wZS5oIgogI2luY2x1ZGUgPHd0Zi9TdGRMaWJFeHRyYXMuaD4KKyNp bmNsdWRlIDx3dGYvU3RyaW5nRXh0cmFzLmg+CiAjaW5jbHVkZSA8d3RmL1ZlY3Rvci5oPgogCiBu YW1lc3BhY2UgV2ViQ29yZSB7CkBAIC04Niw2ICs4NywzNiBAQCB2ODo6TG9jYWw8djg6OlZhbHVl PiBTY3JpcHREZWJ1Z1NlcnZlcjo6Y2FsbERlYnVnZ2VyTWV0aG9kKGNvbnN0IGNoYXIqIGZ1bmN0 aW9uTgogY2xhc3MgU2NyaXB0RGVidWdTZXJ2ZXI6OlNjcmlwdFByZXByb2Nlc3NvciB7CiAgICAg V1RGX01BS0VfTk9OQ09QWUFCTEUoU2NyaXB0UHJlcHJvY2Vzc29yKTsKIHB1YmxpYzoKKyAgICBl bnVtIGNvbnRleHRLaW5kIHsKKyAgICAgICAgTm9Db250ZXh0ID0gLTEsCisgICAgICAgIE90aGVy Q29udGV4dCA9IDAsCisgICAgICAgIFBhZ2VDb250ZXh0ID0gMSwKKyAgICAgICAgQ29udGVudFNj cmlwdENvbnRleHQgPSAyLAorICAgICAgICBXb3JrZXJDb250ZXh0ID0gMworICAgIH07CisKKyAg ICBzdGF0aWMgaW50IGdldENvbnRleHRLaW5kKHY4OjpIYW5kbGU8djg6OkNvbnRleHQ+IGNvbnRl eHQpCisgICAgeworICAgICAgICB2ODo6SGFuZGxlU2NvcGUgc2NvcGU7CisgICAgICAgIGlmICgh Y29udGV4dC0+R2V0RW1iZWRkZXJEYXRhKDApLT5Jc1N0cmluZygpKQorICAgICAgICAgICAgcmV0 dXJuIFNjcmlwdFByZXByb2Nlc3Nvcjo6Tm9Db250ZXh0OworICAgICAgICB2ODo6U3RyaW5nOjpB c2NpaVZhbHVlIGFzY2lpKGNvbnRleHQtPkdldEVtYmVkZGVyRGF0YSgwKSk7CisKKyAgICAgICAg Y2hhciogcGFnZSA9IHN0cm5zdHIoKmFzY2lpLCAicGFnZSIsIGFzY2lpLmxlbmd0aCgpKTsKKyAg ICAgICAgaWYgKHBhZ2UpIAorICAgICAgICAgICAgcmV0dXJuIFNjcmlwdFByZXByb2Nlc3Nvcjo6 UGFnZUNvbnRleHQ7CisKKyAgICAgICAgY2hhciogaW5qZWN0ZWQgPSBzdHJuc3RyKCphc2NpaSwg ImluamVjdGVkIiwgYXNjaWkubGVuZ3RoKCkpOworICAgICAgICBpZiAoaW5qZWN0ZWQpCisgICAg ICAgICAgICByZXR1cm4gU2NyaXB0UHJlcHJvY2Vzc29yOjpDb250ZW50U2NyaXB0Q29udGV4dDsK KworICAgICAgICBjaGFyKiB3b3JrZXIgPSBzdHJuc3RyKCphc2NpaSwgIndvcmtlciIsIGFzY2lp Lmxlbmd0aCgpKTsKKyAgICAgICAgaWYgKHdvcmtlcikKKyAgICAgICAgICAgIHJldHVybiBTY3Jp cHRQcmVwcm9jZXNzb3I6OldvcmtlckNvbnRleHQ7CisKKyAgICAgICAgcmV0dXJuIFNjcmlwdFBy ZXByb2Nlc3Nvcjo6T3RoZXJDb250ZXh0OworICAgIH0KKwogICAgIGV4cGxpY2l0IFNjcmlwdFBy ZXByb2Nlc3Nvcihjb25zdCBTdHJpbmcmIHByZXByb2Nlc3NvclNjcmlwdCkKICAgICB7CiAgICAg ICAgIHY4OjpIYW5kbGVTY29wZSBzY29wZTsKQEAgLTQ1Niw2ICs0ODcsMTEgQEAgdm9pZCBTY3Jp cHREZWJ1Z1NlcnZlcjo6aGFuZGxlVjhEZWJ1Z0V2ZW50KGNvbnN0IHY4OjpEZWJ1Zzo6RXZlbnRE ZXRhaWxzJiBldmVudEQKICAgICB2ODo6SGFuZGxlPHY4OjpDb250ZXh0PiBldmVudENvbnRleHQg PSBldmVudERldGFpbHMuR2V0RXZlbnRDb250ZXh0KCk7CiAgICAgQVNTRVJUKCFldmVudENvbnRl eHQuSXNFbXB0eSgpKTsKIAorICAgIGludCBraW5kID0gU2NyaXB0UHJlcHJvY2Vzc29yOjpnZXRD b250ZXh0S2luZChldmVudENvbnRleHQpOworICAgIC8vIE91ciBsaXN0ZW5lciBvbmx5IHdvcmtz IG9uIGNvbnRleHRzIGJlbG9uZ2luZyB0byBtYWluV29ybGQtY29ubmVjdGVkIGNvbnRleHRzLgor ICAgIGlmIChraW5kID09IFNjcmlwdFByZXByb2Nlc3Nvcjo6Tm9Db250ZXh0IHx8IGtpbmQgPT0g U2NyaXB0UHJlcHJvY2Vzc29yOjpPdGhlckNvbnRleHQpCisgICAgICAgIHJldHVybjsKKwogICAg IFNjcmlwdERlYnVnTGlzdGVuZXIqIGxpc3RlbmVyID0gZ2V0RGVidWdMaXN0ZW5lckZvckNvbnRl eHQoZXZlbnRDb250ZXh0KTsKICAgICBpZiAobGlzdGVuZXIpIHsKICAgICAgICAgdjg6OkhhbmRs ZVNjb3BlIHNjb3BlOwpAQCAtNDY0LDYgKzUwMCwxMCBAQCB2b2lkIFNjcmlwdERlYnVnU2VydmVy OjpoYW5kbGVWOERlYnVnRXZlbnQoY29uc3Qgdjg6OkRlYnVnOjpFdmVudERldGFpbHMmIGV2ZW50 RAogICAgICAgICAgICAgaWYgKCFtX3NjcmlwdFByZXByb2Nlc3NvcikKICAgICAgICAgICAgICAg ICByZXR1cm47CiAKKyAgICAgICAgICAgIC8vIERvbid0IHByZXByb2Nlc3MgY29udGVudCBzY3Jp cHRzCisgICAgICAgICAgICBpZiAoa2luZCAhPSBTY3JpcHRQcmVwcm9jZXNzb3I6OlBhZ2VDb250 ZXh0ICYmIGtpbmQgIT0gU2NyaXB0UHJlcHJvY2Vzc29yOjpXb3JrZXJDb250ZXh0KQorICAgICAg ICAgICAgICAgIHJldHVybjsKKwogICAgICAgICAgICAgT3duUHRyPFNjcmlwdFByZXByb2Nlc3Nv cj4gcHJlcHJvY2Vzc29yKG1fc2NyaXB0UHJlcHJvY2Vzc29yLnJlbGVhc2UoKSk7CiAgICAgICAg ICAgICB2ODo6TG9jYWw8djg6OkNvbnRleHQ+IGRlYnVnQ29udGV4dCA9IHY4OjpEZWJ1Zzo6R2V0 RGVidWdDb250ZXh0KCk7CiAgICAgICAgICAgICB2ODo6Q29udGV4dDo6U2NvcGUgY29udGV4dFNj b3BlKGRlYnVnQ29udGV4dCk7Cg==