113083 2013-03-22 11:02:53 -0700 REGRESSION(r146380): media/track/track-user-preferences.html 2013-03-25 13:13:37 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rniwa webkit-unassigned dino eric.carlson esprehn+autocc feature-media-reviews jer.noble ojan.autocc webkit-bug-importer webkit.review.bot oldest_to_newest 861680 0 rniwa 2013-03-22 11:02:53 -0700 --- /Volumes/Data/slave/lion-release-tests-wk1/build/layout-test-results/media/track/track-user-preferences-expected.txt +++ /Volumes/Data/slave/lion-release-tests-wk1/build/layout-test-results/media/track/track-user-preferences-actual.txt @@ -1,3 +1,4 @@ +FAIL: Timed out waiting for notifyDone to be called Test track user preferences. @@ -5,44 +6,4 @@ Test 1: 'no' track selected because of user preferred language - creating tracks for: [en,fr,no]. -EVENT(load) -EXPECTED (event.target.srclang == 'no') OK -EXPECTED (event.target.readyState == '2') OK -Test 2: 'no' track still selected because of language, overriding 'default' attribute -- creating tracks for: [fr,en,no]. --- 'en' track marked as default. -EVENT(load) -EXPECTED (event.target.srclang == 'no') OK -EXPECTED (event.target.readyState == '2') OK - -Test 3: select 'fr' track from menu -- show captions menu. -EXPECTED (trackMenuItems[menuIndexForLanguage('French')].className == '') OK -EXPECTED (trackMenuItems[menuIndexForLanguage('English')].className == '') OK -EXPECTED (trackMenuItems[menuIndexForLanguage('Norwegian')].className == 'selected') OK -- click on 'French' menu item. -EVENT(load) -EXPECTED (event.target.srclang == 'fr') OK -EXPECTED (event.target.readyState == '2') OK -EXPECTED (video.textTracks[0].mode == 'showing') OK -EXPECTED (video.textTracks[0].language == 'fr') OK - -Test 4: preferred language was changed to 'fr' by selecting track from menu -- creating tracks for: [ru,en,fr]. -EVENT(load) -EXPECTED (event.target.srclang == 'fr') OK -EXPECTED (event.target.readyState == '2') OK -EXPECTED (video.textTracks[2].mode == 'showing') OK -EXPECTED (video.textTracks[2].language == 'fr') OK - -Test 5: turning captions off from menu disables caption selection -- show captions menu. -- click on 'Off' menu item. -- creating tracks for: [ru,jp,en]. -EXPECTED (video.textTracks[0].mode == 'disabled') OK -EXPECTED (video.textTracks[1].mode == 'disabled') OK -EXPECTED (video.textTracks[2].mode == 'disabled') OK - -END OF TEST - e.g. http://build.webkit.org/results/Apple%20Lion%20Release%20WK1%20(Tests)/r146619%20(10721)/results.html 862869 1 194876 eric.carlson 2013-03-25 10:00:57 -0700 Created attachment 194876 Speculative fix. Not flagging for review, this is just so the bots can test. 862984 2 194876 eric.carlson 2013-03-25 12:50:54 -0700 Comment on attachment 194876 Speculative fix. Looks like this fixes the test on the bots. 862989 3 194876 jer.noble 2013-03-25 12:54:11 -0700 Comment on attachment 194876 Speculative fix. View in context: https://bugs.webkit.org/attachment.cgi?id=194876&action=review r+, with nit. > Source/WebCore/ChangeLog:10 > + No new tests, this fixes an existing test. > + > + * html/HTMLMediaElement.cpp: Nit: a note here about why the test was failing would be nice. 862995 4 webkit-bug-importer 2013-03-25 13:02:16 -0700 <rdar://problem/13498100> 863006 5 eric.carlson 2013-03-25 13:13:30 -0700 https://trac.webkit.org/r146801 194876 2013-03-25 10:00:57 -0700 2013-03-25 13:13:37 -0700 Speculative fix. patch_2.txt text/plain 3376 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0Njc4NSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDEzLTAzLTI1ICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04ocjE0 NjM4MCk6IG1lZGlhL3RyYWNrL3RyYWNrLXVzZXItcHJlZmVyZW5jZXMuaHRtbAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEzMDgzCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCB0aGlz IGZpeGVzIGFuIGV4aXN0aW5nIHRlc3QuCisKKyAgICAgICAgKiBodG1sL0hUTUxNZWRpYUVsZW1l bnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTE1lZGlhRWxlbWVudDo6Y29uZmlndXJlVGV4 dFRyYWNrR3JvdXApOiBDbGVhciBtX3Byb2Nlc3NpbmdQcmVmZXJlbmNlQ2hhbmdlIGFmdGVyIGFs bAorICAgICAgICAgICAgdHJhY2sgY29uZmlndXJhdGlvbiBpcyBmaW5pc2hlZC4KKyAgICAgICAg KFdlYkNvcmU6OkhUTUxNZWRpYUVsZW1lbnQ6OmNvbmZpZ3VyZVRleHRUcmFja0Rpc3BsYXkpOiBE byBub3RoaW5nIGlmIG1fcHJvY2Vzc2luZ1ByZWZlcmVuY2VDaGFuZ2UKKyAgICAgICAgICAgIGlz IHRydWUuCisKIDIwMTMtMDMtMjUgIE1hcmphIEjDtmx0dMOkICA8bWFyamFAY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIFtWOF0gR2VuZXJhdGUgc3BlY2lhbGl6ZWQgY2FsbGJhY2tzIGZvciB0aGUg bWFpbiB3b3JsZApJbmRleDogU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3Bw CShyZXZpc2lvbiAxNDY3MzApCisrKyBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1l bnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMTM1LDcgKzMxMzUsNiBAQCB2b2lkIEhUTUxNZWRp YUVsZW1lbnQ6OmNvbmZpZ3VyZVRleHRUcmFjCiAgICAgICAgIHRyYWNrVG9FbmFibGUgPSBmYWxs YmFja1RyYWNrOwogCiAgICAgaWYgKGN1cnJlbnRseUVuYWJsZWRUcmFja3Muc2l6ZSgpKSB7Ci0g ICAgICAgIG1fcHJvY2Vzc2luZ1ByZWZlcmVuY2VDaGFuZ2UgPSBmYWxzZTsKICAgICAgICAgZm9y IChzaXplX3QgaSA9IDA7IGkgPCBjdXJyZW50bHlFbmFibGVkVHJhY2tzLnNpemUoKTsgKytpKSB7 CiAgICAgICAgICAgICBSZWZQdHI8VGV4dFRyYWNrPiB0ZXh0VHJhY2sgPSBjdXJyZW50bHlFbmFi bGVkVHJhY2tzW2ldOwogICAgICAgICAgICAgaWYgKHRleHRUcmFjayAhPSB0cmFja1RvRW5hYmxl KQpAQCAtMzE0NSw2ICszMTQ0LDggQEAgdm9pZCBIVE1MTWVkaWFFbGVtZW50Ojpjb25maWd1cmVU ZXh0VHJhYwogCiAgICAgaWYgKHRyYWNrVG9FbmFibGUpCiAgICAgICAgIHRyYWNrVG9FbmFibGUt PnNldE1vZGUoVGV4dFRyYWNrOjpzaG93aW5nS2V5d29yZCgpKTsKKworICAgIG1fcHJvY2Vzc2lu Z1ByZWZlcmVuY2VDaGFuZ2UgPSBmYWxzZTsKIH0KIAogdm9pZCBIVE1MTWVkaWFFbGVtZW50Ojpz ZXRTZWxlY3RlZFRleHRUcmFjayhUZXh0VHJhY2sqIHRyYWNrVG9TZWxlY3QpCkBAIC00NDYzLDYg KzQ0NjQsOSBAQCB2b2lkIEhUTUxNZWRpYUVsZW1lbnQ6OmNvbmZpZ3VyZVRleHRUcmFjCiB7CiAg ICAgQVNTRVJUKG1fdGV4dFRyYWNrcyk7CiAKKyAgICBpZiAobV9wcm9jZXNzaW5nUHJlZmVyZW5j ZUNoYW5nZSkKKyAgICAgICAgcmV0dXJuOworCiAgICAgYm9vbCBoYXZlVmlzaWJsZVRleHRUcmFj ayA9IGZhbHNlOwogICAgIGZvciAodW5zaWduZWQgaSA9IDA7IGkgPCBtX3RleHRUcmFja3MtPmxl bmd0aCgpOyArK2kpIHsKICAgICAgICAgaWYgKG1fdGV4dFRyYWNrcy0+aXRlbShpKS0+bW9kZSgp ID09IFRleHRUcmFjazo6c2hvd2luZ0tleXdvcmQoKSkgewpJbmRleDogTGF5b3V0VGVzdHMvQ2hh bmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gMTQ2 Nzg1KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEs MTIgQEAKKzIwMTMtMDMtMjUgIEVyaWMgQ2FybHNvbiAgPGVyaWMuY2FybHNvbkBhcHBsZS5jb20+ CisKKyAgICAgICAgUkVHUkVTU0lPTihyMTQ2MzgwKTogbWVkaWEvdHJhY2svdHJhY2stdXNlci1w cmVmZXJlbmNlcy5odG1sCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMTMwODMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIHBsYXRmb3JtL21hYy9UZXN0RXhwZWN0YXRpb25zOiBSZW1vdmUgdGVzdCBmcm9t IGV4cGVjdGF0aW9ucy4KKwogMjAxMy0wMy0yNSAgUGhpbGlwIFJvZ2VycyAgPHBkckBnb29nbGUu Y29tPgogCiAgICAgICAgIFtDaHJvbWl1bV0gUmViYXNlbGluZSBzdmcvY3VzdG9tL21hcmtlci1v cmllbnQtYXV0bwpJbmRleDogTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL1Rlc3RFeHBlY3RhdGlv bnMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL1Rlc3RFeHBlY3RhdGlv bnMJKHJldmlzaW9uIDE0NjczMCkKKysrIExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9UZXN0RXhw ZWN0YXRpb25zCSh3b3JraW5nIGNvcHkpCkBAIC0xNDcxLDcgKzE0NzEsNSBAQCB3ZWJraXQub3Jn L2IvOTE2MTEgbWVkaWEvbWVkaWEtaGlnaGVyLXByCiAjIFNuYXBzaG90dGVkIHBsdWdpbnMgbm90 IGVuYWJsZWQgb24gV0sxCiBwbHVnaW5zL3NuYXBzaG90dGluZyBbIFNraXAgXQogCi13ZWJraXQu b3JnL2IvMTEzMDgzIG1lZGlhL3RyYWNrL3RyYWNrLXVzZXItcHJlZmVyZW5jZXMuaHRtbCBbIEZh aWx1cmUgXQotCiB3ZWJraXQub3JnL2IvMTEzMDk0IGVkaXRpbmcvcGFzdGVib2FyZC9jYW4tcmVh ZC1pbi1jb3B5LWFuZC1jdXQtZXZlbnRzLmh0bWwgWyBGYWlsdXJlIF0KIHdlYmtpdC5vcmcvYi8x MTMwOTQgZWRpdGluZy9wYXN0ZWJvYXJkL2Nhbi1yZWFkLWluLWRyYWdzdGFydC1ldmVudC5odG1s IFsgRmFpbHVyZSBdCg==