113069 2013-03-22 09:06:17 -0700 [BlackBerry] Selection overlay clipped incorrectly 2013-03-22 10:14:21 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 anlo anlo anilsson mifenton rwlbuis tonikitoo webkit.review.bot oldest_to_newest 861534 0 anlo 2013-03-22 09:06:17 -0700 As a follow-up to http://trac.webkit.org/changeset/146278, we also need to adjust the clip rect by offsetFromRenderer when drawing the text selection overlay. 861544 1 194565 anlo 2013-03-22 09:17:48 -0700 Created attachment 194565 Patch 861616 2 194565 webkit.review.bot 2013-03-22 10:14:18 -0700 Comment on attachment 194565 Patch Clearing flags on attachment: 194565 Committed r146627: <http://trac.webkit.org/changeset/146627> 861617 3 webkit.review.bot 2013-03-22 10:14:21 -0700 All reviewed patches have been landed. Closing bug. 194565 2013-03-22 09:17:48 -0700 2013-03-22 10:14:18 -0700 Patch bug-113069-20130322121356.patch text/plain 2346 anlo U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ2MzQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCAwMTkzOWU1ODc1NWVjZmE1MGJiZTFhNDBkNTVhOGNjMDQzOTZiMGYxLi5kNmY2ZTMxMjI4 NGY1N2YyZGFhN2ZlN2E5ZjRmMDllZGZmYTk4ZmQ4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMy0wMy0yMiAgQW5kcmV3IExvICA8YW5sb0ByaW0u Y29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBTZWxlY3Rpb24gb3ZlcmxheSBjbGlwcGVkIGlu Y29ycmVjdGx5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMTMwNjkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAg SW50ZXJuYWxseSByZXZpZXdlZCBieSBBcnZpZCBOaWxzc29uLgorCisgICAgICAgIEFzIGEgZm9s bG93LXVwIHRvIHIxNDYyNzgsIHRoZSBjbGlwIHJlY3QgYWxzbyBuZWVkcyB0byBiZQorICAgICAg ICBhZGp1c3RlZCBieSB0aGUgcGFyZW50J3Mgb2Zmc2V0IHdoZW4gZHJhd2luZyB0aGUKKyAgICAg ICAgc2VsZWN0aW9uIG92ZXJsYXkuCisKKyAgICAgICAgKiBXZWJLaXRTdXBwb3J0L1NlbGVjdGlv bk92ZXJsYXkuY3BwOgorICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpTZWxlY3Rpb25PdmVy bGF5OjpwYWludENvbnRlbnRzKToKKwogMjAxMy0wMy0xOSAgQW5kcmV3IExvICA8YW5sb0ByaW0u Y29tPgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBTZWxlY3Rpb24gb3ZlcmxheSBpcyBzb21ldGlt ZXMgaW4gd3JvbmcgcG9zaXRpb24uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVy cnkvV2ViS2l0U3VwcG9ydC9TZWxlY3Rpb25PdmVybGF5LmNwcCBiL1NvdXJjZS9XZWJLaXQvYmxh Y2tiZXJyeS9XZWJLaXRTdXBwb3J0L1NlbGVjdGlvbk92ZXJsYXkuY3BwCmluZGV4IGNlOGRlOGFk NWJiMjc0ZDdiMzMxMzBlNWJiY2EwOWI0NDFlOGU4M2EuLmM2N2M3YzQ1YTJhMTIwYjQ5YWQ2NmVm ZTYyYWU0NTY1ZTU5M2EwY2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9X ZWJLaXRTdXBwb3J0L1NlbGVjdGlvbk92ZXJsYXkuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxh Y2tiZXJyeS9XZWJLaXRTdXBwb3J0L1NlbGVjdGlvbk92ZXJsYXkuY3BwCkBAIC04Nyw3ICs4Nyw3 IEBAIHZvaWQgU2VsZWN0aW9uT3ZlcmxheTo6bm90aWZ5U3luY1JlcXVpcmVkKGNvbnN0IEdyYXBo aWNzTGF5ZXIqIGxheWVyKQogICAgIG1fcGFnZS0+bm90aWZ5U3luY1JlcXVpcmVkKGxheWVyKTsK IH0KIAotdm9pZCBTZWxlY3Rpb25PdmVybGF5OjpwYWludENvbnRlbnRzKGNvbnN0IEdyYXBoaWNz TGF5ZXIqIGxheWVyLCBHcmFwaGljc0NvbnRleHQmIGMsIEdyYXBoaWNzTGF5ZXJQYWludGluZ1Bo YXNlLCBjb25zdCBJbnRSZWN0JiBjbGlwKQordm9pZCBTZWxlY3Rpb25PdmVybGF5OjpwYWludENv bnRlbnRzKGNvbnN0IEdyYXBoaWNzTGF5ZXIqIGxheWVyLCBHcmFwaGljc0NvbnRleHQmIGMsIEdy YXBoaWNzTGF5ZXJQYWludGluZ1BoYXNlLCBjb25zdCBJbnRSZWN0JiBpbkNsaXApCiB7CiAgICAg aWYgKCFsYXllci0+cGxhdGZvcm1MYXllcigpLT5zdXBlcmxheWVyKCkpCiAgICAgICAgIHJldHVy bjsKQEAgLTk3LDEwICs5NywxMyBAQCB2b2lkIFNlbGVjdGlvbk92ZXJsYXk6OnBhaW50Q29udGVu dHMoY29uc3QgR3JhcGhpY3NMYXllciogbGF5ZXIsIEdyYXBoaWNzQ29udGV4dAogICAgICAgICBy ZXR1cm47CiAKICAgICBjb25zdCBWZWN0b3I8V2ViQ29yZTo6RmxvYXRRdWFkPiYgcXVhZHMgPSBp dC0+dmFsdWU7CisgICAgR3JhcGhpY3NMYXllciogcGFyZW50ID0gaXQtPmtleTsKKworICAgIElu dFJlY3QgY2xpcChpbkNsaXApOworICAgIGNsaXAubW92ZShwYXJlbnQtPm9mZnNldEZyb21SZW5k ZXJlcigpLndpZHRoKCksIHBhcmVudC0+b2Zmc2V0RnJvbVJlbmRlcmVyKCkuaGVpZ2h0KCkpOwog CiAgICAgYy5zYXZlKCk7CiAKLSAgICBHcmFwaGljc0xheWVyKiBwYXJlbnQgPSBpdC0+a2V5Owog ICAgIGMudHJhbnNsYXRlKC1wYXJlbnQtPm9mZnNldEZyb21SZW5kZXJlcigpLndpZHRoKCksIC1w YXJlbnQtPm9mZnNldEZyb21SZW5kZXJlcigpLmhlaWdodCgpKTsKIAogICAgIENvbG9yIGNvbG9y ID0gUmVuZGVyVGhlbWU6OmRlZmF1bHRUaGVtZSgpLT5hY3RpdmVTZWxlY3Rpb25CYWNrZ3JvdW5k Q29sb3IoKTsK