113056 2013-03-22 07:27:00 -0700 [Qt] Fix build with OpenCL 1.2 2013-03-22 11:29:55 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 allan.jensen allan.jensen tonikitoo webkit.review.bot oldest_to_newest 861432 0 allan.jensen 2013-03-22 07:27:00 -0700 We have an experiment compile setting to enable OpenCL for some SVG filters. Unfortunately it uses old build-system style and fails to build due to warning over using deprecated OpenCL 1.1 methods (we escalate warnings to errors). 861437 1 194538 allan.jensen 2013-03-22 07:30:14 -0700 Created attachment 194538 Patch 861441 2 194538 kenneth 2013-03-22 07:31:30 -0700 Comment on attachment 194538 Patch Nice 861473 3 194538 webkit.review.bot 2013-03-22 08:06:34 -0700 Comment on attachment 194538 Patch Clearing flags on attachment: 194538 Committed r146613: <http://trac.webkit.org/changeset/146613> 861474 4 webkit.review.bot 2013-03-22 08:06:38 -0700 All reviewed patches have been landed. Closing bug. 194538 2013-03-22 07:30:14 -0700 2013-03-22 08:06:34 -0700 Patch bug-113056-20130322152601.patch text/plain 4864 allan.jensen U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ2NDYxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzI5YThhZjczNTJiYWFj MDU4NDk3NTQwNzg0ZWU2OWQ3MGY3NTNmYy4uNzFhZTRiOWQ0MGYwZGJlMDI4YzE1NWM3ZGZmMWNm Zjg1ODAzMDhjYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEzLTAzLTIyICBBbGxh biBTYW5kZmVsZCBKZW5zZW4gIDxhbGxhbi5qZW5zZW5AZGlnaWEuY29tPgorCisgICAgICAgIFtR dF0gRml4IGJ1aWxkIHdpdGggT1BFTkNMIDEuMgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEzMDU2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgU3dpdGNoIHFtYWtlIGNoZWNrcyB0byB0aGUgbW9kZXJuIHN0 eWxlIHdoaWNoIG1lYW5zIHdlIGNhbiBlbmFibGUgT3BlbkNMIHdpdGgKKyAgICAgICAgV0VCS0lU X0NPTkZJRys9b3BlbmNsLiAKKworICAgICAgICBVcGdyYWRlIE9wZW5DTCAxLjEgY2xDcmVhdGVJ bWFnZTJEIHRvIE9wZW5DTCAxLjIgY2xDcmVhdGVJbWFnZSBjYWxscy4KKworICAgICAgICAqIFRh cmdldC5wcmk6CisgICAgICAgICogV2ViQ29yZS5wcmk6CisgICAgICAgICogcGxhdGZvcm0vZ3Jh cGhpY3MvZmlsdGVycy9GaWx0ZXJFZmZlY3QuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RmlsdGVy RWZmZWN0OjpjcmVhdGVPcGVuQ0xJbWFnZVJlc3VsdCk6CisgICAgICAgICogcGxhdGZvcm0vZ3Jh cGhpY3MvZ3B1L29wZW5jbC9GaWx0ZXJDb250ZXh0T3BlbkNMLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OkZpbHRlckNvbnRleHRPcGVuQ0w6OmNyZWF0ZU9wZW5DTEltYWdlKToKKwogMjAxMy0wMy0y MSAgS29uZGFwYWxseSBLYWx5YW4gIDxrYWx5YW4ua29uZGFwYWxseUBpbnRlbC5jb20+CiAKICAg ICAgICAgW0VGTF1bV2ViR0xdIEltcGxlbWVudCBhIGNvbW1vbiBHcmFwaGljc1N1cmZhY2UgSW1w bGVtZW50YXRpb24uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9UYXJnZXQucHJpIGIvU291 cmNlL1dlYkNvcmUvVGFyZ2V0LnByaQppbmRleCA3MmI2MGFkZmNlYTBlZWIwZTE4YWE5MzdiZTk3 MzBhZDhhZWY0YjgwLi5jNTk4ZjA5ODNlMTc3YmFkZGQxMWNjZjUwM2YxZWE1NTg5OTQzMzBiIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9UYXJnZXQucHJpCisrKyBiL1NvdXJjZS9XZWJDb3Jl L1RhcmdldC5wcmkKQEAgLTQyNTIsNyArNDI1Miw3IEBAIGNvbnRhaW5zKENPTkZJRywgb3Blbmds LXNoaW1zKSB7CiAgICAgREVGSU5FUyArPSBRVF9PUEVOR0xfU0hJTVM9MQogfQogCi1jb250YWlu cyhERUZJTkVTLCBFTkFCTEVfT1BFTkNMPTEpIHsKK2VuYWJsZT8ob3BlbmNsKSB7CiAgICAgSEVB REVSUyArPSBcCiAgICAgICAgIHBsYXRmb3JtL2dyYXBoaWNzL2dwdS9vcGVuY2wvT3BlbkNMSGFu ZGxlLmggXAogICAgICAgICBwbGF0Zm9ybS9ncmFwaGljcy9ncHUvb3BlbmNsL0ZpbHRlckNvbnRl eHRPcGVuQ0wuaApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvV2ViQ29yZS5wcmkgYi9Tb3Vy Y2UvV2ViQ29yZS9XZWJDb3JlLnByaQppbmRleCBlOTY1MGUzY2I1NjBiZTc5NmU1N2MxOTM5NTgy NTgzNWYzM2VhMWFlLi5hNWRiZmVjMjU1MTg2YTExNDZlNDc0ZGVmNGQ0ZmM2Zjk4YWIzMDhlIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLnByaQorKysgYi9Tb3VyY2UvV2ViQ29y ZS9XZWJDb3JlLnByaQpAQCAtMjczLDYgKzI3MywxMSBAQCB1c2U/KGxpYmpwZWcpOiBMSUJTICs9 IC1sanBlZwogdXNlPyhsaWJwbmcpOiBMSUJTICs9IC1scG5nCiB1c2U/KHdlYnApOiBMSUJTICs9 IC1sd2VicAogCitlbmFibGU/KG9wZW5jbCkgeworICAgIExJQlMgKz0gLWxPcGVuQ0wKKyAgICBJ TkNMVURFUEFUSCArPSAkJFNPVVJDRV9ESVIvcGxhdGZvcm0vZ3JhcGhpY3MvZ3B1L29wZW5jbAor fQorCiBtYWMgewogICAgIExJQlMgKz0gLWZyYW1ld29yayBDYXJib24gLWZyYW1ld29yayBBcHBL aXQgLWZyYW1ld29yayBJT0tpdAogfQpAQCAtMzIwLDEyICszMjUsNiBAQCB1bml4OiFtYWM6Ki1n KysqOlFNQUtFX0NYWEZMQUdTICs9IC1mZGF0YS1zZWN0aW9ucwogdW5peDohbWFjOiotZysrKjpR TUFLRV9MRkxBR1MgKz0gLVdsLC0tZ2Mtc2VjdGlvbnMKIGxpbnV4Ki1nKysqOlFNQUtFX0xGTEFH UyArPSAkJFFNQUtFX0xGTEFHU19OT1VOREVGCiAKLWNvbnRhaW5zKERFRklORVMsIEVOQUJMRV9P UEVOQ0w9MSkgewotICAgIExJQlMgKz0gLWxPcGVuQ0wKLQotICAgIElOQ0xVREVQQVRIICs9ICQk U09VUkNFX0RJUi9wbGF0Zm9ybS9ncmFwaGljcy9ncHUvb3BlbmNsCi19Ci0KIGVuYWJsZV9mYXN0 X21vYmlsZV9zY3JvbGxpbmc6IERFRklORVMgKz0gRU5BQkxFX0ZBU1RfTU9CSUxFX1NDUk9MTElO Rz0xCiAKICFwcm9kdWN0aW9uX2J1aWxkOmhhdmU/KEZPTlRDT05GSUcpOiBQS0dDT05GSUcgKz0g Zm9udGNvbmZpZwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv ZmlsdGVycy9GaWx0ZXJFZmZlY3QuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvZmlsdGVycy9GaWx0ZXJFZmZlY3QuY3BwCmluZGV4IGMzMWUxYjFkOGIwMWY2ZDYyOGQxZDhi YWY2NDM5Y2U5ZTRkNTY4OTEuLmY3OGRkMWY2NmJkYjE0YmRhZWU4ZTg5ZDBlM2ViMzAzMTA3ODFm YjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2ZpbHRlcnMv RmlsdGVyRWZmZWN0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9m aWx0ZXJzL0ZpbHRlckVmZmVjdC5jcHAKQEAgLTQ3NCw4ICs0NzQsMTQgQEAgT3BlbkNMSGFuZGxl IEZpbHRlckVmZmVjdDo6Y3JlYXRlT3BlbkNMSW1hZ2VSZXN1bHQodWludDhfdCogc291cmNlKQog ICAgIGNsSW1hZ2VGb3JtYXQuaW1hZ2VfY2hhbm5lbF9kYXRhX3R5cGUgPSBDTF9VTk9STV9JTlQ4 OwogCiAgICAgaW50IGVycm9yQ29kZSA9IDA7CisjaWZkZWYgQ0xfQVBJX1NVRkZJWF9fVkVSU0lP Tl8xXzIKKyAgICBjbF9pbWFnZV9kZXNjIGltYWdlRGVzY3JpcHRvciA9IHsgQ0xfTUVNX09CSkVD VF9JTUFHRTJELCBtX2Fic29sdXRlUGFpbnRSZWN0LndpZHRoKCksIG1fYWJzb2x1dGVQYWludFJl Y3QuaGVpZ2h0KCksIDAsIDAsIDAsIDAsIDAsIDAsIDB9OworICAgIG1fb3BlbkNMSW1hZ2VSZXN1 bHQgPSBjbENyZWF0ZUltYWdlKGNvbnRleHQtPmRldmljZUNvbnRleHQoKSwgQ0xfTUVNX1JFQURf V1JJVEUgfCAoc291cmNlID8gQ0xfTUVNX0NPUFlfSE9TVF9QVFIgOiAwKSwKKyAgICAgICAgJmNs SW1hZ2VGb3JtYXQsICZpbWFnZURlc2NyaXB0b3IsIHNvdXJjZSwgJmVycm9yQ29kZSk7CisjZWxz ZQogICAgIG1fb3BlbkNMSW1hZ2VSZXN1bHQgPSBjbENyZWF0ZUltYWdlMkQoY29udGV4dC0+ZGV2 aWNlQ29udGV4dCgpLCBDTF9NRU1fUkVBRF9XUklURSB8IChzb3VyY2UgPyBDTF9NRU1fQ09QWV9I T1NUX1BUUiA6IDApLAogICAgICAgICAmY2xJbWFnZUZvcm1hdCwgbV9hYnNvbHV0ZVBhaW50UmVj dC53aWR0aCgpLCBtX2Fic29sdXRlUGFpbnRSZWN0LmhlaWdodCgpLCAwLCBzb3VyY2UsICZlcnJv ckNvZGUpOworI2VuZGlmCiAgICAgaWYgKGNvbnRleHQtPmlzRmFpbGVkKGVycm9yQ29kZSkpCiAg ICAgICAgIHJldHVybiAwOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9ncHUvb3BlbmNsL0ZpbHRlckNvbnRleHRPcGVuQ0wuY3BwIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3B1L29wZW5jbC9GaWx0ZXJDb250ZXh0T3BlbkNMLmNwcApp bmRleCA3MmY1OGRlNmFhNWE0MGFkZDZjZWFkZmNkZGY4MWM4YWExZTAyZTk3Li5jYmE2NjY5ODU1 ZmMxYWJlMDI2Y2M5OGFkNzZmMzFkNDY5Y2FlNDdiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9ncHUvb3BlbmNsL0ZpbHRlckNvbnRleHRPcGVuQ0wuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dwdS9vcGVuY2wvRmlsdGVyQ29u dGV4dE9wZW5DTC5jcHAKQEAgLTEzNiw4ICsxMzYsMTMgQEAgT3BlbkNMSGFuZGxlIEZpbHRlckNv bnRleHRPcGVuQ0w6OmNyZWF0ZU9wZW5DTEltYWdlKEludFNpemUgcGFpbnRTaXplKQogICAgIGNs SW1hZ2VGb3JtYXQuaW1hZ2VfY2hhbm5lbF9vcmRlciA9IENMX1JHQkE7CiAgICAgY2xJbWFnZUZv cm1hdC5pbWFnZV9jaGFubmVsX2RhdGFfdHlwZSA9IENMX1VOT1JNX0lOVDg7CiAKKyNpZmRlZiBD TF9BUElfU1VGRklYX19WRVJTSU9OXzFfMgorICAgIGNsX2ltYWdlX2Rlc2MgaW1hZ2VEZXNjcmlw dG9yID0geyBDTF9NRU1fT0JKRUNUX0lNQUdFMkQsIHBhaW50U2l6ZS53aWR0aCgpLCBwYWludFNp emUuaGVpZ2h0KCksIDAsIDAsIDAsIDAsIDAsIDAsIDB9OworICAgIE9wZW5DTEhhbmRsZSBpbWFn ZSA9IGNsQ3JlYXRlSW1hZ2UoY29udGV4dC0+ZGV2aWNlQ29udGV4dCgpLCBDTF9NRU1fUkVBRF9X UklURSwgJmNsSW1hZ2VGb3JtYXQsICZpbWFnZURlc2NyaXB0b3IsIDAsIDApOworI2Vsc2UKICAg ICBPcGVuQ0xIYW5kbGUgaW1hZ2UgPSBjbENyZWF0ZUltYWdlMkQoY29udGV4dC0+ZGV2aWNlQ29u dGV4dCgpLCBDTF9NRU1fUkVBRF9XUklURSwgJmNsSW1hZ2VGb3JtYXQsCiAgICAgICAgIHBhaW50 U2l6ZS53aWR0aCgpLCBwYWludFNpemUuaGVpZ2h0KCksIDAsIDAsIDApOworI2VuZGlmCiAgICAg cmV0dXJuIGltYWdlOwogfQogCg==