113054 2013-03-22 07:12:08 -0700 -[TinyDOMNode dealloc] should call [super dealloc] when ARC is not enabled 2013-03-22 17:23:50 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 112608 1 ddkilzer mhahnenberg webkit.review.bot oldest_to_newest 861424 0 ddkilzer 2013-03-22 07:12:08 -0700 * SUMMARY -[TinyDOMNode dealloc] should call [super dealloc] when ARC is not enabled. 861880 1 194637 mhahnenberg 2013-03-22 15:05:21 -0700 Created attachment 194637 Patch 861900 2 194637 ggaren 2013-03-22 15:19:14 -0700 Comment on attachment 194637 Patch Do we ever compile in non-ARC mode? 861910 3 mhahnenberg 2013-03-22 15:28:22 -0700 (In reply to comment #2) > (From update of attachment 194637 [details]) > Do we ever compile in non-ARC mode? I believe it's possible with GCC. I think that's where ddkilzer ran into it. 862014 4 194637 webkit.review.bot 2013-03-22 17:23:47 -0700 Comment on attachment 194637 Patch Clearing flags on attachment: 194637 Committed r146688: <http://trac.webkit.org/changeset/146688> 862015 5 webkit.review.bot 2013-03-22 17:23:50 -0700 All reviewed patches have been landed. Closing bug. 194637 2013-03-22 15:05:21 -0700 2013-03-22 17:23:47 -0700 Patch bug-113054-20130322150108.patch text/plain 1234 mhahnenberg SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTQ2NjU5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBA CisyMDEzLTAzLTIyICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CisK KyAgICAgICAgLVtUaW55RE9NTm9kZSBkZWFsbG9jXSBzaG91bGQgY2FsbCBbc3VwZXIgZGVhbGxv Y10gd2hlbiBBUkMgaXMgbm90IGVuYWJsZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTExMzA1NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogQVBJL3Rlc3RzL3Rlc3RhcGkubW06CisgICAgICAgICgtW1Rp bnlET01Ob2RlIGRlYWxsb2NdKToKKwogMjAxMy0wMy0yMiAgRmlsaXAgUGl6bG8gIDxmcGl6bG9A YXBwbGUuY29tPgogCiAgICAgICAgIERGRyBmb2xkaW5nIG9mIFB1dEJ5SWQgdG8gU2ltcGxlUmVw bGFjZSBzaG91bGQgY29uc2lkZXIgdGhlIHNwZWNpYWxpemVkIGZ1bmN0aW9uIGNhc2UKSW5kZXg6 IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvdGVzdHMvdGVzdGFwaS5tbQo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL3Rlc3RzL3Rlc3RhcGkubW0JKHJldmlzaW9uIDE0 NjY1OSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvdGVzdHMvdGVzdGFwaS5tbQkod29y a2luZyBjb3B5KQpAQCAtMjAyLDYgKzIwMiwxMCBAQCAtICh2b2lkKWRlYWxsb2MKICAgICBpZCBu ZXh0Q2hpbGQ7CiAgICAgd2hpbGUgKChuZXh0Q2hpbGQgPSBbZW51bWVyYXRvciBuZXh0T2JqZWN0 XSkpCiAgICAgICAgIFtbVGlueURPTU5vZGUgc2hhcmVkVmlydHVhbE1hY2hpbmVdIHJlbW92ZU1h bmFnZWRSZWZlcmVuY2U6bmV4dENoaWxkIHdpdGhPd25lcjpzZWxmXTsKKworI2lmICFfX2hhc19m ZWF0dXJlKG9iamNfYXJjKQorICAgIFtzdXBlciBkZWFsbG9jXTsKKyNlbmRpZgogfQogCiAtICh2 b2lkKWFwcGVuZENoaWxkOihUaW55RE9NTm9kZSAqKWNoaWxkCg==