113037 2013-03-22 03:17:20 -0700 removeAllEventListeners() should be called to shadow trees 2013-03-26 10:25:15 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 morrita morrita cmarcelo esprehn+autocc mkwst ojan.autocc webcomponents-bugzilla webkit.review.bot oldest_to_newest 861302 0 morrita 2013-03-22 03:17:20 -0700 This is a followup of Bug 113035. 861314 1 194499 morrita 2013-03-22 03:45:25 -0700 Created attachment 194499 Patch 861318 2 194499 mkwst 2013-03-22 03:57:44 -0700 Comment on attachment 194499 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=194499&action=review Two quick drive-by comments: > Source/WebCore/ChangeLog:11 > + No new tests. This is rather a defensive change. If we're not currently clearing event listeners on the shadow tree, it seems like this change will produce some web-visible differences in behavior. It would be good to add a test to ensure that the behavior doesn't regress. > Source/WebCore/dom/ElementShadow.cpp:126 > +void ElementShadow::removeAllEventListenersFromShadowTrees() The name seems slightly redundant: I'd suggest sticking to "removeAllEventListeners" here as well, as calling this on an ElementShadow seems to already imply that we'll be removing listeners from shadow-land. :) 861332 3 194499 morrita 2013-03-22 04:11:41 -0700 Comment on attachment 194499 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=194499&action=review Thanks for the comment, Mike. >> Source/WebCore/ChangeLog:11 >> + No new tests. This is rather a defensive change. > > If we're not currently clearing event listeners on the shadow tree, it seems like this change will produce some web-visible differences in behavior. It would be good to add a test to ensure that the behavior doesn't regress. Hmm. Since the clearance happens in the destructor and there is no way to refer event target from the listener, I have no idea how to do it for now. i needs fresh brain. Will attack next week. >> Source/WebCore/dom/ElementShadow.cpp:126 >> +void ElementShadow::removeAllEventListenersFromShadowTrees() > > The name seems slightly redundant: I'd suggest sticking to "removeAllEventListeners" here as well, as calling this on an ElementShadow seems to already imply that we'll be removing listeners from shadow-land. :) Makes sense. will do. 863493 4 195042 morrita 2013-03-26 02:39:24 -0700 Created attachment 195042 Patch 863674 5 195042 webkit.review.bot 2013-03-26 08:09:31 -0700 Comment on attachment 195042 Patch Clearing flags on attachment: 195042 Committed r146882: <http://trac.webkit.org/changeset/146882> 863675 6 webkit.review.bot 2013-03-26 08:09:35 -0700 All reviewed patches have been landed. Closing bug. 863796 7 195042 rniwa 2013-03-26 10:25:15 -0700 Comment on attachment 195042 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=195042&action=review > Source/WebCore/ChangeLog:3 > + remoeveAllEventListeners() should be called to shadow trees Nit: remoeve. 194499 2013-03-22 03:45:25 -0700 2013-03-26 02:39:21 -0700 Patch bug-113037-20130322194112.patch text/plain 4083 morrita U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ2NTg1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDljMjk3NjU4N2VkZTI0 ZWNiMzdjNGJhMDY5ZjY2MGI2MzM5NTAyOS4uMWRlMzgwOTMzYThlMzk3YmQ1YjNmZmJkN2MxZTA3 ZTc2YmY5NGMxNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDEzLTAzLTIyICBIYWpp bWUgTW9ycml0YSAgPG1vcnJpdGFAZ29vZ2xlLmNvbT4KKworICAgICAgICByZW1vZXZlQWxsRXZl bnRMaXN0ZW5lcnMoKSBzaG91bGQgYmUgY2FsbGVkIHRvIHNoYWRvdyB0cmVlcworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEzMDM3CisKKyAgICAgICAg RG9jdW1lbnQ6OnJlbW92ZUFsbEV2ZW50TGlzdGVuZXJzKCkgZG9lc24ndCB0cmF2ZXJzZSBzaGFk b3cgdHJlZSwgYnV0IHdlIHNob3VsZC4KKyAgICAgICAgVGhpcyBjaGFuZ2Ugb3ZlcnJpZGUgcmVt b3ZlQWxsRXZlbnRMaXN0ZW5lcnMoKSBzbyB0aGF0IGl0IGdvZXMgaW50byBpdHMgc2hhZG93IHRy ZWVzLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5v IG5ldyB0ZXN0cy4gVGhpcyBpcyByYXRoZXIgYSBkZWZlbnNpdmUgY2hhbmdlLgorCisgICAgICAg ICogZG9tL0VsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RWxlbWVudDo6cmVtb3ZlQWxs RXZlbnRMaXN0ZW5lcnMpOiBBZGRlZAorICAgICAgICAoV2ViQ29yZSk6CisgICAgICAgICogZG9t L0VsZW1lbnQuaDoKKyAgICAgICAgKEVsZW1lbnQpOgorICAgICAgICAqIGRvbS9FbGVtZW50U2hh ZG93LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkVsZW1lbnRTaGFkb3c6OnJlbW92ZUFsbEV2ZW50 TGlzdGVuZXJzRnJvbVNoYWRvd1RyZWVzKTogQWRkZWQuCisgICAgICAgIChXZWJDb3JlKToKKyAg ICAgICAgKiBkb20vRWxlbWVudFNoYWRvdy5oOgorICAgICAgICAoRWxlbWVudFNoYWRvdyk6CisK IDIwMTMtMDMtMjIgIFN0ZXZlIEJsb2NrICA8c3RldmVibG9ja0BjaHJvbWl1bS5vcmc+CiAKICAg ICAgICAgVXNlIGdlbmVyYXRlZCBiaW5kaW5ncyBmb3IgdGhlIENvb3JkaW5hdGVzIHR5cGUgdXNl ZCBieSBHZW9sb2NhdGlvbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQu Y3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuY3BwCmluZGV4IDMyNTRlYzU0N2UxZTg2 ZmI4NDRjNGVkYWUwZDhmN2QwZTEyZmRkMWIuLjIzMzNmNmRjZDA3ODI0OGYyMTBiNWFhNDM1NmNl YzA4YWJhM2ViYmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5jcHAKQEAgLTE2NzQsNiArMTY3NCwxMyBA QCB2b2lkIEVsZW1lbnQ6OmNoaWxkcmVuQ2hhbmdlZChib29sIGNoYW5nZWRCeVBhcnNlciwgTm9k ZSogYmVmb3JlQ2hhbmdlLCBOb2RlKiBhZgogICAgICAgICBzaGFkb3ctPmludmFsaWRhdGVEaXN0 cmlidXRpb24oKTsKIH0KIAordm9pZCBFbGVtZW50OjpyZW1vdmVBbGxFdmVudExpc3RlbmVycygp Cit7CisgICAgQ29udGFpbmVyTm9kZTo6cmVtb3ZlQWxsRXZlbnRMaXN0ZW5lcnMoKTsKKyAgICBp ZiAoRWxlbWVudFNoYWRvdyogc2hhZG93ID0gdGhpcy0+c2hhZG93KCkpCisgICAgICAgIHNoYWRv dy0+cmVtb3ZlQWxsRXZlbnRMaXN0ZW5lcnNGcm9tU2hhZG93VHJlZXMoKTsKK30KKwogdm9pZCBF bGVtZW50OjpiZWdpblBhcnNpbmdDaGlsZHJlbigpCiB7CiAgICAgY2xlYXJJc1BhcnNpbmdDaGls ZHJlbkZpbmlzaGVkKCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5o IGIvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuaAppbmRleCBkMDdjOTUxNTNkODUyNjZmZTI2 MmE3NDE5YzVjYzgyNzgwMDc3NTU1Li5hYWNiYjNiOGRiZGVlYzQ1NmM4NmI2ZTBjY2YwZTlkMjVh YzFjMjU5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5oCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmgKQEAgLTYxOCw2ICs2MTgsNyBAQCBwcm90ZWN0ZWQ6 CiAgICAgdmlydHVhbCBJbnNlcnRpb25Ob3RpZmljYXRpb25SZXF1ZXN0IGluc2VydGVkSW50byhD b250YWluZXJOb2RlKikgT1ZFUlJJREU7CiAgICAgdmlydHVhbCB2b2lkIHJlbW92ZWRGcm9tKENv bnRhaW5lck5vZGUqKSBPVkVSUklERTsKICAgICB2aXJ0dWFsIHZvaWQgY2hpbGRyZW5DaGFuZ2Vk KGJvb2wgY2hhbmdlZEJ5UGFyc2VyID0gZmFsc2UsIE5vZGUqIGJlZm9yZUNoYW5nZSA9IDAsIE5v ZGUqIGFmdGVyQ2hhbmdlID0gMCwgaW50IGNoaWxkQ291bnREZWx0YSA9IDApOworICAgIHZpcnR1 YWwgdm9pZCByZW1vdmVBbGxFdmVudExpc3RlbmVycygpIE9WRVJSSURFOwogCiAgICAgdmlydHVh bCBib29sIHdpbGxSZWNhbGNTdHlsZShTdHlsZUNoYW5nZSk7CiAgICAgdmlydHVhbCB2b2lkIGRp ZFJlY2FsY1N0eWxlKFN0eWxlQ2hhbmdlKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Rv bS9FbGVtZW50U2hhZG93LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50U2hhZG93LmNw cAppbmRleCA4MmQ0YTg3MTQyYTNhMmMxZDlhMjEzNTI4NDQ0YjM5ZDg0YjgyNzMzLi5lYWNjMTlm MWJiMGIzNzI4MjIwOWJjMWVjYTlkNzQ0YWY2YjU2OTMyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9kb20vRWxlbWVudFNoYWRvdy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1l bnRTaGFkb3cuY3BwCkBAIC0xMjMsNiArMTIzLDE0IEBAIHZvaWQgRWxlbWVudFNoYWRvdzo6cmVj YWxjU3R5bGUoTm9kZTo6U3R5bGVDaGFuZ2UgY2hhbmdlKQogICAgICAgICByb290LT5yZWNhbGNT dHlsZShjaGFuZ2UpOwogfQogCit2b2lkIEVsZW1lbnRTaGFkb3c6OnJlbW92ZUFsbEV2ZW50TGlz dGVuZXJzRnJvbVNoYWRvd1RyZWVzKCkKK3sKKyAgICBmb3IgKFNoYWRvd1Jvb3QqIHJvb3QgPSB5 b3VuZ2VzdFNoYWRvd1Jvb3QoKTsgcm9vdDsgcm9vdCA9IHJvb3QtPm9sZGVyU2hhZG93Um9vdCgp KSB7CisgICAgICAgIGZvciAoTm9kZSogbm9kZSA9IHJvb3Q7IG5vZGU7IG5vZGUgPSBOb2RlVHJh dmVyc2FsOjpuZXh0KG5vZGUpKQorICAgICAgICAgICAgbm9kZS0+cmVtb3ZlQWxsRXZlbnRMaXN0 ZW5lcnMoKTsKKyAgICB9Cit9CisKIHZvaWQgRWxlbWVudFNoYWRvdzo6cmVwb3J0TWVtb3J5VXNh Z2UoTWVtb3J5T2JqZWN0SW5mbyogbWVtb3J5T2JqZWN0SW5mbykgY29uc3QKIHsKICAgICBNZW1v cnlDbGFzc0luZm8gaW5mbyhtZW1vcnlPYmplY3RJbmZvLCB0aGlzLCBXZWJDb3JlTWVtb3J5VHlw ZXM6OkRPTSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudFNoYWRvdy5o IGIvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnRTaGFkb3cuaAppbmRleCBiNWE0YjdjNjY4ZWE0 NjFlOTlkN2FhNjkyOTU5ZmVhYjZlNmUwMDRkLi41YTU1OTcyYzg3M2M1NWJlMDZjYmFlNjgyOWVj NDA1ZmRjOTJiNDk3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudFNoYWRv dy5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50U2hhZG93LmgKQEAgLTY0LDYgKzY0 LDcgQEAgcHVibGljOgogICAgIGJvb2wgY2hpbGROZWVkc1N0eWxlUmVjYWxjKCkgY29uc3Q7CiAg ICAgYm9vbCBuZWVkc1N0eWxlUmVjYWxjKCkgY29uc3Q7CiAgICAgdm9pZCByZWNhbGNTdHlsZShO b2RlOjpTdHlsZUNoYW5nZSk7CisgICAgdm9pZCByZW1vdmVBbGxFdmVudExpc3RlbmVyc0Zyb21T aGFkb3dUcmVlcygpOwogCiAgICAgdm9pZCBpbnZhbGlkYXRlRGlzdHJpYnV0aW9uKCkgeyBtX2Rp c3RyaWJ1dG9yLmludmFsaWRhdGVEaXN0cmlidXRpb24oaG9zdCgpKTsgfQogICAgIHZvaWQgZGlk QWZmZWN0U2VsZWN0b3IoQWZmZWN0ZWRTZWxlY3Rvck1hc2sgbWFzaykgeyBtX2Rpc3RyaWJ1dG9y LmRpZEFmZmVjdFNlbGVjdG9yKGhvc3QoKSwgbWFzayk7IH0K 195042 2013-03-26 02:39:24 -0700 2013-03-26 10:25:15 -0700 Patch bug-113037-20130326183507.patch text/plain 7337 morrita U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ2ODYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWNjOWEzNTg4MDU1Mzdm NmU4NDc1N2E0Y2Y2NDUzZjllNGZiZmU5Yy4uODUwODM2ZWQwNjA3ODE2MGNiY2ZhZWNiYTBhZWRh ZjYzMzBjNzNkNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDEzLTAzLTI2ICBIYWpp bWUgTW9ycml0YSAgPG1vcnJpdGFAZ29vZ2xlLmNvbT4KKworICAgICAgICByZW1vZXZlQWxsRXZl bnRMaXN0ZW5lcnMoKSBzaG91bGQgYmUgY2FsbGVkIHRvIHNoYWRvdyB0cmVlcworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEzMDM3CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRG9jdW1lbnQ6OnJlbW92ZUFs bEV2ZW50TGlzdGVuZXJzKCkgZG9lc24ndCB0cmF2ZXJzZSBzaGFkb3cgdHJlZSwgYnV0IHdlIHNo b3VsZC4KKyAgICAgICAgVGhpcyBjaGFuZ2Ugb3ZlcnJpZGUgRWxlbWVudDo6cmVtb3ZlQWxsRXZl bnRMaXN0ZW5lcnMoKSBzbyB0aGF0IGl0IGNsZWFucyBpdHMgc2hhZG93IHRyZWVzIHVwLgorCisg ICAgICAgIFRlc3Q6IGZhc3QvZG9tL3NoYWRvdy9zaGFkb3ctdHJlZS1saXN0ZW5lci1jbGVhcmFu Y2UuaHRtbAorCisgICAgICAgICogZG9tL0VsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 RWxlbWVudDo6cmVtb3ZlQWxsRXZlbnRMaXN0ZW5lcnMpOgorICAgICAgICAoV2ViQ29yZSk6Cisg ICAgICAgICogZG9tL0VsZW1lbnQuaDoKKyAgICAgICAgKEVsZW1lbnQpOgorICAgICAgICAqIGRv bS9FbGVtZW50U2hhZG93LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkVsZW1lbnRTaGFkb3c6OnJl bW92ZUFsbEV2ZW50TGlzdGVuZXJzKTogQWRkZWQuCisgICAgICAgIChXZWJDb3JlKToKKyAgICAg ICAgKiBkb20vRWxlbWVudFNoYWRvdy5oOgorICAgICAgICAoRWxlbWVudFNoYWRvdyk6CisKIDIw MTMtMDMtMjYgIEtlbnQgVGFtdXJhICA8dGtlbnRAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJl bmFtZSBIVE1MSW5wdXRFbGVtZW50Ojppc0luZGV0ZXJtaW5hdGUgdG8gRWxlbWVudDo6c2hvdWxk QXBwZWFySW5kZXRlcm1pbmF0ZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1l bnQuY3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuY3BwCmluZGV4IDcwYTcxMGE4OGQy NmEwMzYyNjU2MzRiNWVmOTAxMGI2YTUwYjA4NDIuLjQzNzQ3MWQ4MzY1ZGUxYjE5NGZkZjA4MTkz NTg2ZTg4MDZkY2I0MjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5jcHAKQEAgLTE2OTMsNiArMTY5Mywx MyBAQCB2b2lkIEVsZW1lbnQ6OmNoaWxkcmVuQ2hhbmdlZChib29sIGNoYW5nZWRCeVBhcnNlciwg Tm9kZSogYmVmb3JlQ2hhbmdlLCBOb2RlKiBhZgogICAgICAgICBzaGFkb3ctPmludmFsaWRhdGVE aXN0cmlidXRpb24oKTsKIH0KIAordm9pZCBFbGVtZW50OjpyZW1vdmVBbGxFdmVudExpc3RlbmVy cygpCit7CisgICAgQ29udGFpbmVyTm9kZTo6cmVtb3ZlQWxsRXZlbnRMaXN0ZW5lcnMoKTsKKyAg ICBpZiAoRWxlbWVudFNoYWRvdyogc2hhZG93ID0gdGhpcy0+c2hhZG93KCkpCisgICAgICAgIHNo YWRvdy0+cmVtb3ZlQWxsRXZlbnRMaXN0ZW5lcnMoKTsKK30KKwogdm9pZCBFbGVtZW50OjpiZWdp blBhcnNpbmdDaGlsZHJlbigpCiB7CiAgICAgY2xlYXJJc1BhcnNpbmdDaGlsZHJlbkZpbmlzaGVk KCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5oIGIvU291cmNlL1dl YkNvcmUvZG9tL0VsZW1lbnQuaAppbmRleCAwZGE2YmQyMzY0MDkyNmZiM2I5YTBjMjM0NmYxMDI2 YjJhZWQ3ODMzLi5kZDg2MGYwNmM2NDdlNmU3ZDkzMDMxNDlhNDM0OTM0MmU5Zjk1OWZmIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5oCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2RvbS9FbGVtZW50LmgKQEAgLTYyNyw2ICs2MjcsNyBAQCBwcm90ZWN0ZWQ6CiAgICAgdmlydHVh bCBJbnNlcnRpb25Ob3RpZmljYXRpb25SZXF1ZXN0IGluc2VydGVkSW50byhDb250YWluZXJOb2Rl KikgT1ZFUlJJREU7CiAgICAgdmlydHVhbCB2b2lkIHJlbW92ZWRGcm9tKENvbnRhaW5lck5vZGUq KSBPVkVSUklERTsKICAgICB2aXJ0dWFsIHZvaWQgY2hpbGRyZW5DaGFuZ2VkKGJvb2wgY2hhbmdl ZEJ5UGFyc2VyID0gZmFsc2UsIE5vZGUqIGJlZm9yZUNoYW5nZSA9IDAsIE5vZGUqIGFmdGVyQ2hh bmdlID0gMCwgaW50IGNoaWxkQ291bnREZWx0YSA9IDApOworICAgIHZpcnR1YWwgdm9pZCByZW1v dmVBbGxFdmVudExpc3RlbmVycygpIE9WRVJSSURFOwogCiAgICAgdmlydHVhbCBib29sIHdpbGxS ZWNhbGNTdHlsZShTdHlsZUNoYW5nZSk7CiAgICAgdmlydHVhbCB2b2lkIGRpZFJlY2FsY1N0eWxl KFN0eWxlQ2hhbmdlKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50U2hh ZG93LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50U2hhZG93LmNwcAppbmRleCA4MmQ0 YTg3MTQyYTNhMmMxZDlhMjEzNTI4NDQ0YjM5ZDg0YjgyNzMzLi40Mzg4YjBiMThiMzFiODFjZGFj Y2IzOTUxYTliNWZmZjYxM2Y0Y2IyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRWxl bWVudFNoYWRvdy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnRTaGFkb3cuY3Bw CkBAIC0xMjMsNiArMTIzLDE0IEBAIHZvaWQgRWxlbWVudFNoYWRvdzo6cmVjYWxjU3R5bGUoTm9k ZTo6U3R5bGVDaGFuZ2UgY2hhbmdlKQogICAgICAgICByb290LT5yZWNhbGNTdHlsZShjaGFuZ2Up OwogfQogCit2b2lkIEVsZW1lbnRTaGFkb3c6OnJlbW92ZUFsbEV2ZW50TGlzdGVuZXJzKCkKK3sK KyAgICBmb3IgKFNoYWRvd1Jvb3QqIHJvb3QgPSB5b3VuZ2VzdFNoYWRvd1Jvb3QoKTsgcm9vdDsg cm9vdCA9IHJvb3QtPm9sZGVyU2hhZG93Um9vdCgpKSB7CisgICAgICAgIGZvciAoTm9kZSogbm9k ZSA9IHJvb3Q7IG5vZGU7IG5vZGUgPSBOb2RlVHJhdmVyc2FsOjpuZXh0KG5vZGUpKQorICAgICAg ICAgICAgbm9kZS0+cmVtb3ZlQWxsRXZlbnRMaXN0ZW5lcnMoKTsKKyAgICB9Cit9CisKIHZvaWQg RWxlbWVudFNoYWRvdzo6cmVwb3J0TWVtb3J5VXNhZ2UoTWVtb3J5T2JqZWN0SW5mbyogbWVtb3J5 T2JqZWN0SW5mbykgY29uc3QKIHsKICAgICBNZW1vcnlDbGFzc0luZm8gaW5mbyhtZW1vcnlPYmpl Y3RJbmZvLCB0aGlzLCBXZWJDb3JlTWVtb3J5VHlwZXM6OkRPTSk7CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9kb20vRWxlbWVudFNoYWRvdy5oIGIvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1l bnRTaGFkb3cuaAppbmRleCBiNWE0YjdjNjY4ZWE0NjFlOTlkN2FhNjkyOTU5ZmVhYjZlNmUwMDRk Li5lOGQ2M2QxMWJiNDhkN2FiM2UwY2JjZWI1MzZiNjQ5Mzc0MWJjNjBkIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudFNoYWRvdy5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Rv bS9FbGVtZW50U2hhZG93LmgKQEAgLTY0LDYgKzY0LDcgQEAgcHVibGljOgogICAgIGJvb2wgY2hp bGROZWVkc1N0eWxlUmVjYWxjKCkgY29uc3Q7CiAgICAgYm9vbCBuZWVkc1N0eWxlUmVjYWxjKCkg Y29uc3Q7CiAgICAgdm9pZCByZWNhbGNTdHlsZShOb2RlOjpTdHlsZUNoYW5nZSk7CisgICAgdm9p ZCByZW1vdmVBbGxFdmVudExpc3RlbmVycygpOwogCiAgICAgdm9pZCBpbnZhbGlkYXRlRGlzdHJp YnV0aW9uKCkgeyBtX2Rpc3RyaWJ1dG9yLmludmFsaWRhdGVEaXN0cmlidXRpb24oaG9zdCgpKTsg fQogICAgIHZvaWQgZGlkQWZmZWN0U2VsZWN0b3IoQWZmZWN0ZWRTZWxlY3Rvck1hc2sgbWFzaykg eyBtX2Rpc3RyaWJ1dG9yLmRpZEFmZmVjdFNlbGVjdG9yKGhvc3QoKSwgbWFzayk7IH0KZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRl eCAzYTllNTAwN2NjNTFiMjQ0NTE0MDRiZGRhMzBjYzE3M2EzOGE2ZTk1Li5jY2FkNmFjZGExNTNh NzRjY2NkNjgxZTRkMWEwNjI5ZjQwODgwMTFkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTMt MDMtMjYgIEhhamltZSBNb3JyaXRhICA8bW9ycml0YUBnb29nbGUuY29tPgorCisgICAgICAgIHJl bW9ldmVBbGxFdmVudExpc3RlbmVycygpIHNob3VsZCBiZSBjYWxsZWQgdG8gc2hhZG93IHRyZWVz CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTMwMzcK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGZhc3Qv ZG9tL3NoYWRvdy9yZXNvdXJjZXMvc2hhZG93LXRyZWUtbGlzdGVuZXItY2xlYXJhbmNlLWZyYW1l Lmh0bWw6IEFkZGVkLgorICAgICAgICAqIGZhc3QvZG9tL3NoYWRvdy9zaGFkb3ctdHJlZS1saXN0 ZW5lci1jbGVhcmFuY2UtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2RvbS9z aGFkb3cvc2hhZG93LXRyZWUtbGlzdGVuZXItY2xlYXJhbmNlLmh0bWw6IEFkZGVkLgorCiAyMDEz LTAzLTI2ICBab2x0YW4gQXJ2YWkgIDx6YXJ2YWlAaW5mLnUtc3plZ2VkLmh1PgogCiAgICAgICAg IFtRdF0gVW5yZXZpZXdlZCBnYXJkZW5pbmcuIFJlYmFzZWxpbmluZyBhZnRlciByMTQ2ODE0Lgpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9kb20vc2hhZG93L3Jlc291cmNlcy9zaGFkb3ct dHJlZS1saXN0ZW5lci1jbGVhcmFuY2UtZnJhbWUuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvZG9t L3NoYWRvdy9yZXNvdXJjZXMvc2hhZG93LXRyZWUtbGlzdGVuZXItY2xlYXJhbmNlLWZyYW1lLmh0 bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMC4uOTRkM2IwYjdkNDI4ZmM0YTNhYmRlMzNiMDBhMWUwOTlkNjA4NTQwZQot LS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZG9tL3NoYWRvdy9yZXNvdXJjZXMv c2hhZG93LXRyZWUtbGlzdGVuZXItY2xlYXJhbmNlLWZyYW1lLmh0bWwKQEAgLTAsMCArMSwxMyBA QAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKzxib2R5PgorPGRpdiBpZD0iaG9zdCI+PC9kaXY+ Cis8c2NyaXB0PgorKGZ1bmN0aW9uKCkgeworICAgIHZhciBzaGFkb3cgPSBkb2N1bWVudC5nZXRF bGVtZW50QnlJZCgiaG9zdCIpLndlYmtpdENyZWF0ZVNoYWRvd1Jvb3QoKTsKKyAgICBzaGFkb3cu aW5uZXJIVE1MID0gIjxhcnRpY2xlIGlkPSd0YXJnZXQnPjwvYXJ0aWNsZT4iOworICAgIGRvY3Vt ZW50LnRhcmdldEluU2hhZG93ID0gc2hhZG93LmdldEVsZW1lbnRCeUlkKCJ0YXJnZXQiKTsKK30p KCk7Cis8L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L2Zhc3QvZG9tL3NoYWRvdy9zaGFkb3ctdHJlZS1saXN0ZW5lci1jbGVhcmFuY2UtZXhwZWN0ZWQu dHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vc2hhZG93L3NoYWRvdy10cmVlLWxpc3RlbmVyLWNs ZWFyYW5jZS1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uZWNiZGQ4ZmUzOGJhZTJiZDc5MzIyOWRm OGMyMjFmZDZlOGQxODQ4YQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZG9t L3NoYWRvdy9zaGFkb3ctdHJlZS1saXN0ZW5lci1jbGVhcmFuY2UtZXhwZWN0ZWQudHh0CkBAIC0w LDAgKzEsNiBAQAorUEFTUyBmaXJlZENvdW50IGlzIDEKK1BBU1MgZmlyZWRDb3VudCBpcyAxCitQ QVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1QgQ09NUExFVEUKKwpkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9kb20vc2hhZG93L3NoYWRvdy10cmVlLWxpc3RlbmVyLWNs ZWFyYW5jZS5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vc2hhZG93L3NoYWRvdy10cmVlLWxp c3RlbmVyLWNsZWFyYW5jZS5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjE1OWRkMWU2MmFkNWFkYTljYTVlYTVk MDBmNWZjM2FjMzU3NmQ1YTAKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2Rv bS9zaGFkb3cvc2hhZG93LXRyZWUtbGlzdGVuZXItY2xlYXJhbmNlLmh0bWwKQEAgLTAsMCArMSwz NyBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKzxib2R5PgorPHNjcmlwdCBzcmM9Ii4uLy4u L2pzL3Jlc291cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+Cis8aWZyYW1lIGlkPSJjaGls ZEZyYW1lIiBzcmM9Ii4vcmVzb3VyY2VzL3NoYWRvdy10cmVlLWxpc3RlbmVyLWNsZWFyYW5jZS1m cmFtZS5odG1sIj48L2lmcmFtZT4KKzxzY3JpcHQ+CisKK3ZhciBjaGlsZCA9IGRvY3VtZW50Lmdl dEVsZW1lbnRCeUlkKCJjaGlsZEZyYW1lIik7Cit2YXIgZmlyZWRDb3VudCA9IDA7CisKK2Z1bmN0 aW9uIGdldENoaWxkVGFyZ2V0KCkKK3sKKyAgICByZXR1cm4gY2hpbGQuY29udGVudERvY3VtZW50 LnRhcmdldEluU2hhZG93OworfQorCitmdW5jdGlvbiB0ZXN0KCkKK3sKKyAgICB2YXIgdG9CZUxp c3RlbmVkID0gZ2V0Q2hpbGRUYXJnZXQoKTsKKyAgICB0b0JlTGlzdGVuZWQuYWRkRXZlbnRMaXN0 ZW5lcigidGVzdCIsIGZ1bmN0aW9uKGV2ZW50KSB7IGZpcmVkQ291bnQrKzsgfSk7CisKKyAgICB0 b0JlTGlzdGVuZWQuZGlzcGF0Y2hFdmVudChuZXcgQ3VzdG9tRXZlbnQoInRlc3QiKSk7CisgICAg c2hvdWxkQmUoImZpcmVkQ291bnQiLCAiMSIpOworCisgICAgd2luZG93LmNoaWxkLmNvbnRlbnRE b2N1bWVudC5vcGVuKCk7IC8vIFRoaXMgc2hvdWxkIGNsZWFyIGV2ZW50IGxpc3RlbmVycworICAg IHRvQmVMaXN0ZW5lZC5kaXNwYXRjaEV2ZW50KG5ldyBDdXN0b21FdmVudCgidGVzdCIpKTsKKyAg ICBzaG91bGRCZSgiZmlyZWRDb3VudCIsICIxIik7CisKKyAgICBmaW5pc2hKU1Rlc3QoKTsKK30K KworanNUZXN0SXNBc3luYyA9IHRydWU7CitjaGlsZC5hZGRFdmVudExpc3RlbmVyKCJsb2FkIiwg dGVzdCk7CisKKzwvc2NyaXB0PgorPHNjcmlwdCBzcmM9Ii4uLy4uL2pzL3Jlc291cmNlcy9qcy10 ZXN0LXBvc3QuanMiPjwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgo=