113036 2013-03-22 03:11:54 -0700 E: webkitgtk3 missing-sentinel Source/[...]/TestMain.cpp:47 2014-09-10 13:26:53 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 111848 0 dimstar webkit-unassigned cgarcia gustavo zan oldest_to_newest 861300 0 dimstar 2013-03-22 03:11:54 -0700 the open Build Service cancels the build of webkitgtk 1.11.92 (raising known compiler errors causing larger issues or security issues) with: E: webkitgtk3 missing-sentinel Source/WebKit2/UIProcess/API/gtk/tests/TestMain.cpp:47 The compiler output for this build-root check was: [24320s] Source/WebKit2/UIProcess/API/gtk/tests/TestMain.cpp: In function 'void removeNonEmptyDirectory(const char*)': [24320s] Source/WebKit2/UIProcess/API/gtk/tests/TestMain.cpp:47:75: warning: missing sentinel in function call [-Wformat] The code in question is: GOwnPtr<char> filePath(g_build_filename(directoryPath, fileName, 0)); => (int) 0 is not to be used as sentinel in this case, but NULL should be the sentinel (see also https://developer.gnome.org/glib/2.34/glib-Miscellaneous-Utility-Functions.html#g-build-filename : gchar * g_build_filename (const gchar *first_element, ...); ... : remaining elements in path, terminated by NULL The commit introducing this warning into webkitgtk was: http://trac.webkit.org/changeset/145528 861305 1 zan 2013-03-22 03:24:09 -0700 Dominique will provide the patch. 861352 2 cgarcia 2013-03-22 04:52:05 -0700 I blame the style checker :-/ sorry :-( 861386 3 194524 dimstar 2013-03-22 06:00:18 -0700 Created attachment 194524 Patch 862348 4 194524 cgarcia 2013-03-24 05:42:57 -0700 Comment on attachment 194524 Patch This doesn't apply on trunk, because it depends on other patches not landed yet. I'll commit it manually in the stable branch. 1034384 5 dimstar 2014-09-10 13:26:53 -0700 These seems obsolete for a long time.. 194524 2013-03-22 06:00:18 -0700 2013-03-24 05:42:57 -0700 Patch bug-113036-20130322135605.patch text/plain 1392 dimstar SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0NjU5NikKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEzLTAzLTIyICBEb21pbmlx dWUgTGV1ZW5iZXJnZXIgIDxkaW1zdGFyQG9wZW5zdXNlLm9yZz4KKworICAgICAgICBFOiB3ZWJr aXRndGszIG1pc3Npbmctc2VudGluZWwgU291cmNlL1suLi5dL1Rlc3RNYWluLmNwcDo0NworCWdf YnVpbGRfZmlsZW5hbWUgdGFrZXMgYSBOVUxMIHNlbnRpbmVsLgorCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTMwMzYKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZ3RrL3Rlc3Rz L1Rlc3RNYWluLmNwcDoKKyAgICAgICAgKHJlbW92ZU5vbkVtcHR5RGlyZWN0b3J5KToKKwogMjAx My0wMy0xOSAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAg ICAgICAgW0dUS10gQWRkIHBhZGRpbmcgdG8gYWxsIHB1YmxpYyBjbGFzcyBzdHJ1Y3RzIGZvciBm dXR1cmUgZXhwYW5zaW9uIHdpdGhvdXQgYnJlYWtpbmcgQUJJCkluZGV4OiBTb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvQVBJL2d0ay90ZXN0cy9UZXN0TWFpbi5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvdGVzdHMvVGVzdE1haW4uY3BwCShyZXZpc2lv biAxNDY1OTYpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay90ZXN0cy9UZXN0 TWFpbi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ0LDcgKzQ0LDcgQEAgc3RhdGljIHZvaWQgcmVt b3ZlTm9uRW1wdHlEaXJlY3RvcnkoY29ucwogICAgIGdfYXNzZXJ0KGRpcmVjdG9yeSk7CiAgICAg Y29uc3QgY2hhciogZmlsZU5hbWU7CiAgICAgd2hpbGUgKChmaWxlTmFtZSA9IGdfZGlyX3JlYWRf bmFtZShkaXJlY3RvcnkpKSkgewotICAgICAgICBHT3duUHRyPGNoYXI+IGZpbGVQYXRoKGdfYnVp bGRfZmlsZW5hbWUoZGlyZWN0b3J5UGF0aCwgZmlsZU5hbWUsIDApKTsKKyAgICAgICAgR093blB0 cjxjaGFyPiBmaWxlUGF0aChnX2J1aWxkX2ZpbGVuYW1lKGRpcmVjdG9yeVBhdGgsIGZpbGVOYW1l LCBOVUxMKSk7CiAgICAgICAgIGdfdW5saW5rKGZpbGVQYXRoLmdldCgpKTsKICAgICB9CiAgICAg Z19kaXJfY2xvc2UoZGlyZWN0b3J5KTsK