113034 2013-03-22 02:52:28 -0700 [GTK] Include the right GL header for GLES2 2013-03-22 11:50:03 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 mario mario alex mrobinson oldest_to_newest 861285 0 mario 2013-03-22 02:52:28 -0700 It's currently an issue in the following two files: Source/WebKit/gtk/WebCoreSupport/AcceleratedCompositingContextGL.cpp Source/WebKit2/WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp Patch will follow 861297 1 194494 mario 2013-03-22 03:10:21 -0700 Created attachment 194494 Patch proposal Here comes the patch 861423 2 194494 mrobinson 2013-03-22 07:10:50 -0700 Comment on attachment 194494 Patch proposal Do you mind moving the conditional includes to separate block below from the main section? For instance: #include "stuff.h" #include <a.h> #include <b.h> #if USE(OPENGL_ES_2) #include <c.h> #else #include <d.h> #endif 861712 3 mario 2013-03-22 11:40:05 -0700 (In reply to comment #2) > (From update of attachment 194494 [details]) > Do you mind moving the conditional includes to separate block below from > the main section? Not a problem at all, I'll do it. Thanks 861722 4 mario 2013-03-22 11:50:03 -0700 Committed r146637: <http://trac.webkit.org/changeset/146637> 194494 2013-03-22 03:10:21 -0700 2013-03-22 07:10:49 -0700 Patch proposal bug-113034-20130322100659.patch text/plain 2733 mario U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ2NTgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2d0 ay9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKaW5kZXggMDc5NGQ4ZGNk YzhlM2ZiZGQ1NTJhNDIwODFlOTMxOTNlNTQ0NTYwNi4uZmY4NTBjMTUzZGRiMDA2MjQ2YmIzYmMy ZjM4MzJiNjVjZWQ4ZTc0NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEz LTAzLTIyICBNYXJpbyBTYW5jaGV6IFByYWRhICA8bWFyaW8ucHJhZGFAc2Ftc3VuZy5jb20+CisK KyAgICAgICAgW0dUS10gSW5jbHVkZSB0aGUgcmlnaHQgR0wgaGVhZGVyIGZvciBHTEVTMgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEzMDM0CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW5jbHVkZSBHTEVT Mi9nbDIuaCB3aGVuIHVzaW5nIEdMRVMyLgorCisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvQWNj ZWxlcmF0ZWRDb21wb3NpdGluZ0NvbnRleHRHTC5jcHA6CisKIDIwMTMtMDMtMjAgIFphbiBEb2Jl cnNlayAgPHpkb2JlcnNla0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIEJ1aWxkIEFOR0xF IHNvdXJjZXMgaW50byBhIHNlcGFyYXRlIGxpYnJhcnkgZnJvbSBsaWJXZWJDb3JlLmxhCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VM b2cKaW5kZXggYWFjYjIyMjI1YzhlZDA0Y2ZjZWY2OTYxZTEyMzBkODUzNTQ2MDdkZC4uNTQ0MmVh YWM2YWRjMTU1ZjU3YjUxZjRiYjlmNTY3NWViZDZlMDg1NyAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdDIvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsx LDE0IEBACisyMDEzLTAzLTIyICBNYXJpbyBTYW5jaGV6IFByYWRhICA8bWFyaW8ucHJhZGFAc2Ft c3VuZy5jb20+CisKKyAgICAgICAgW0dUS10gSW5jbHVkZSB0aGUgcmlnaHQgR0wgaGVhZGVyIGZv ciBHTEVTMgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTEzMDM0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg SW5jbHVkZSBHTEVTMi9nbDIuaCB3aGVuIHVzaW5nIEdMRVMyLgorCisgICAgICAgICogV2ViUHJv Y2Vzcy9XZWJQYWdlL2d0ay9MYXllclRyZWVIb3N0R3RrLmNwcDoKKwogMjAxMy0wMy0yMSAgVGlt IEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KIAogICAgICAgICBbd2syXSBQYWdl IE92ZXJsYXlzOiBEb24ndCBjcmVhdGUgYmFja2luZyBzdG9yZSB1bnRpbCB0aGUgY2xpZW50IGFz a3MgdXMgdG8gcGFpbnQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBw b3J0L0FjY2VsZXJhdGVkQ29tcG9zaXRpbmdDb250ZXh0R0wuY3BwIGIvU291cmNlL1dlYktpdC9n dGsvV2ViQ29yZVN1cHBvcnQvQWNjZWxlcmF0ZWRDb21wb3NpdGluZ0NvbnRleHRHTC5jcHAKaW5k ZXggOTJhMDUyZDNhOGNjZDAwZDk1MWUwYjBlYWFhNjI5YmNiZTcxYzE3Ny4uMzkzMTg4YjEwYTM0 ZWJhZTQ1ODU4N2M2YWIwOTJlZDJiMGU5OTMwZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9n dGsvV2ViQ29yZVN1cHBvcnQvQWNjZWxlcmF0ZWRDb21wb3NpdGluZ0NvbnRleHRHTC5jcHAKKysr IGIvU291cmNlL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvQWNjZWxlcmF0ZWRDb21wb3NpdGlu Z0NvbnRleHRHTC5jcHAKQEAgLTMyLDcgKzMyLDEyIEBACiAjaW5jbHVkZSAiVGV4dHVyZU1hcHBl ckdMLmgiCiAjaW5jbHVkZSAiVGV4dHVyZU1hcHBlckxheWVyLmgiCiAjaW5jbHVkZSAid2Via2l0 d2Vidmlld3ByaXZhdGUuaCIKKworI2lmIFVTRShPUEVOR0xfRVNfMikKKyNpbmNsdWRlIDxHTEVT Mi9nbDIuaD4KKyNlbHNlCiAjaW5jbHVkZSA8R0wvZ2wuaD4KKyNlbmRpZgogI2luY2x1ZGUgPGNh aXJvLmg+CiAjaW5jbHVkZSA8Z2RrL2dkay5oPgogI2luY2x1ZGUgPGd0ay9ndGsuaD4KZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9ndGsvTGF5ZXJUcmVlSG9z dEd0ay5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvZ3RrL0xheWVyVHJl ZUhvc3RHdGsuY3BwCmluZGV4IGY3ZTU4NTAxN2U4YTBjMDcyOGY1ZWQ3NjYyODFjMWM5MDExNTVm MzEuLmMxMmM1ZmE2ZDU5MWE3YjZmMGRjMDliN2IwZWVkNjVjNzEwY2E4MjcgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9ndGsvTGF5ZXJUcmVlSG9zdEd0ay5j cHAKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL2d0ay9MYXllclRyZWVI b3N0R3RrLmNwcApAQCAtMzMsNyArMzMsMTIgQEAKICNpbmNsdWRlICJUZXh0dXJlTWFwcGVyR0wu aCIKICNpbmNsdWRlICJXZWJQYWdlLmgiCiAjaW5jbHVkZSAiV2ViUHJvY2Vzcy5oIgorCisjaWYg VVNFKE9QRU5HTF9FU18yKQorI2luY2x1ZGUgPEdMRVMyL2dsMi5oPgorI2Vsc2UKICNpbmNsdWRl IDxHTC9nbC5oPgorI2VuZGlmCiAjaW5jbHVkZSA8V2ViQ29yZS9GcmFtZS5oPgogI2luY2x1ZGUg PFdlYkNvcmUvRnJhbWVWaWV3Lmg+CiAjaW5jbHVkZSA8V2ViQ29yZS9HTENvbnRleHQuaD4K