113023 2013-03-22 02:02:40 -0700 [Curl] Performance fix, avoid loading cookie file on every request. 2013-03-22 16:11:16 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 peavo webkit-unassigned bfulgham webkit.review.bot oldest_to_newest 861238 0 peavo 2013-03-22 02:02:40 -0700 We currently load the cookie file on every request, and when reading cookies from JavaScript, by using the option CURLOPT_COOKIEFILE. This is very inefficient as the cookie file can get quite large, and file I/O is slow. It is sufficient to load the cookie file on startup, as we use a shared cookie database between the requests. 861256 1 194481 peavo 2013-03-22 02:21:07 -0700 Created attachment 194481 Patch 861547 2 194481 bfulgham 2013-03-22 09:20:52 -0700 Comment on attachment 194481 Patch r=me 861554 3 194481 webkit.review.bot 2013-03-22 09:24:52 -0700 Comment on attachment 194481 Patch Clearing flags on attachment: 194481 Committed r146621: <http://trac.webkit.org/changeset/146621> 861555 4 webkit.review.bot 2013-03-22 09:24:55 -0700 All reviewed patches have been landed. Closing bug. 861940 5 peavo 2013-03-22 16:11:16 -0700 (In reply to comment #2) > (From update of attachment 194481 [details]) > r=me Thanks for reviewing ;) 194481 2013-03-22 02:21:07 -0700 2013-03-22 09:24:52 -0700 Patch bug-113023-20130322101638.patch text/plain 3215 peavo SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0NjU3NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDEzLTAzLTIyICBwZWF2b0Bv dXRsb29rLmNvbSAgPHBlYXZvQG91dGxvb2suY29tPgorCisgICAgICAgIFtDdXJsXSBQZXJmb3Jt YW5jZSBmaXgsIGF2b2lkIGxvYWRpbmcgY29va2llIGZpbGUgb24gZXZlcnkgcmVxdWVzdC4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMzAyMworCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlIGN1cnJlbnRs eSBsb2FkIHRoZSBjb29raWUgZmlsZSBvbiBldmVyeSByZXF1ZXN0LCBhbmQgd2hlbiBzZXR0aW5n IGNvb2tpZXMgZnJvbSBKYXZhU2NyaXB0LCBieSB1c2luZyB0aGUgb3B0aW9uIENVUkxPUFRfQ09P S0lFRklMRS4KKyAgICAgICAgVGhpcyBpcyB2ZXJ5IGluZWZmaWNpZW50IGFzIHRoZSBjb29raWUg ZmlsZSBjYW4gZ2V0IHF1aXRlIGxhcmdlLCBhbmQgZmlsZSBJL08gaXMgc2xvdy4KKyAgICAgICAg SXQgaXMgc3VmZmljaWVudCB0byBsb2FkIHRoZSBjb29raWUgZmlsZSBvbiBzdGFydHVwLCBhcyB3 ZSB1c2UgYSBzaGFyZWQgY29va2llIGRhdGFiYXNlIGJldHdlZW4gdGhlIHJlcXVlc3RzLgorCisg ICAgICAgICogcGxhdGZvcm0vbmV0d29yay9jdXJsL0Nvb2tpZUphckN1cmwuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6c2V0Q29va2llc0Zyb21ET00pOiBBdm9pZCBsb2FkaW5nIGNvb2tpZSBmaWxl IHdoZW4gc2V0dGluZyBjb29raWVzIGZyb20gSmF2YVNjcmlwdC4KKyAgICAgICAgKiBwbGF0Zm9y bS9uZXR3b3JrL2N1cmwvUmVzb3VyY2VIYW5kbGVNYW5hZ2VyLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OlJlc291cmNlSGFuZGxlTWFuYWdlcjo6aW5pdGlhbGl6ZUhhbmRsZSk6IEF2b2lkIGxvYWRp bmcgY29va2llIGZpbGUgb24gZXZlcnkgcmVxdWVzdC4KKyAgICAgICAgKFdlYkNvcmU6OlJlc291 cmNlSGFuZGxlTWFuYWdlcjo6aW5pdENvb2tpZVNlc3Npb24pOiBMb2FkIHRoZSBjb29raWUgZmls ZSB0byBzaGFyZWQgZGF0YWJhc2Ugb24gc3RhcnR1cC4KKwogMjAxMy0wMy0yMiAgSWx5YSBUaWto b25vdnNreSAgPGxvaXNsb0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3BlY3Rvcjog RmxhbWUgQ2hhcnQuIG1vdmUgb3ZlcnZpZXcgd2luZG93IHdoZW4gdXNlciBzY3JvbGxzIHRoZSBj aGFydC4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY3VybC9Db29raWVK YXJDdXJsLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3Jr L2N1cmwvQ29va2llSmFyQ3VybC5jcHAJKHJldmlzaW9uIDE0NjQ0NykKKysrIFNvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL25ldHdvcmsvY3VybC9Db29raWVKYXJDdXJsLmNwcAkod29ya2luZyBjb3B5 KQpAQCAtMjE2LDcgKzIxNiw2IEBAIHZvaWQgc2V0Q29va2llc0Zyb21ET00oY29uc3QgTmV0d29y a1N0b3IKICAgICBDVVJMU0gqIGN1cmxzaCA9IFJlc291cmNlSGFuZGxlTWFuYWdlcjo6c2hhcmVk SW5zdGFuY2UoKS0+Z2V0Q3VybFNoYXJlSGFuZGxlKCk7CiAKICAgICBjdXJsX2Vhc3lfc2V0b3B0 KGN1cmwsIENVUkxPUFRfQ09PS0lFSkFSLCBjb29raWVKYXJGaWxlTmFtZSk7Ci0gICAgY3VybF9l YXN5X3NldG9wdChjdXJsLCBDVVJMT1BUX0NPT0tJRUZJTEUsIGNvb2tpZUphckZpbGVOYW1lKTsK ICAgICBjdXJsX2Vhc3lfc2V0b3B0KGN1cmwsIENVUkxPUFRfU0hBUkUsIGN1cmxzaCk7CiAKICAg ICAvLyBDVVJMIGFjY2VwdHMgY29va2llcyBpbiBlaXRoZXIgU2V0LUNvb2tpZSBvciBOZXRzY2Fw ZSBmaWxlIGZvcm1hdC4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY3Vy bC9SZXNvdXJjZUhhbmRsZU1hbmFnZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL25ldHdvcmsvY3VybC9SZXNvdXJjZUhhbmRsZU1hbmFnZXIuY3BwCShyZXZpc2lv biAxNDY0NDcpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2N1cmwvUmVzb3Vy Y2VIYW5kbGVNYW5hZ2VyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNzEzLDEwICs3MTMsOCBAQCB2 b2lkIFJlc291cmNlSGFuZGxlTWFuYWdlcjo6aW5pdGlhbGl6ZUhhCiAgICAgZC0+bV91cmwgPSBm YXN0U3RyRHVwKHVybC5sYXRpbjEoKS5kYXRhKCkpOwogICAgIGN1cmxfZWFzeV9zZXRvcHQoZC0+ bV9oYW5kbGUsIENVUkxPUFRfVVJMLCBkLT5tX3VybCk7CiAKLSAgICBpZiAobV9jb29raWVKYXJG aWxlTmFtZSkgewotICAgICAgICBjdXJsX2Vhc3lfc2V0b3B0KGQtPm1faGFuZGxlLCBDVVJMT1BU X0NPT0tJRUZJTEUsIG1fY29va2llSmFyRmlsZU5hbWUpOworICAgIGlmIChtX2Nvb2tpZUphckZp bGVOYW1lKQogICAgICAgICBjdXJsX2Vhc3lfc2V0b3B0KGQtPm1faGFuZGxlLCBDVVJMT1BUX0NP T0tJRUpBUiwgbV9jb29raWVKYXJGaWxlTmFtZSk7Ci0gICAgfQogCiAgICAgc3RydWN0IGN1cmxf c2xpc3QqIGhlYWRlcnMgPSAwOwogICAgIGlmIChqb2ItPmZpcnN0UmVxdWVzdCgpLmh0dHBIZWFk ZXJGaWVsZHMoKS5zaXplKCkgPiAwKSB7CkBAIC03NjksNiArNzY3LDggQEAgdm9pZCBSZXNvdXJj ZUhhbmRsZU1hbmFnZXI6OmluaXRDb29raWVTZQogICAgIGlmICghY3VybCkKICAgICAgICAgcmV0 dXJuOwogCisgICAgY3VybF9lYXN5X3NldG9wdChjdXJsLCBDVVJMT1BUX1NIQVJFLCBtX2N1cmxT aGFyZUhhbmRsZSk7CisKICAgICBpZiAobV9jb29raWVKYXJGaWxlTmFtZSkgewogICAgICAgICBj dXJsX2Vhc3lfc2V0b3B0KGN1cmwsIENVUkxPUFRfQ09PS0lFRklMRSwgbV9jb29raWVKYXJGaWxl TmFtZSk7CiAgICAgICAgIGN1cmxfZWFzeV9zZXRvcHQoY3VybCwgQ1VSTE9QVF9DT09LSUVKQVIs IG1fY29va2llSmFyRmlsZU5hbWUpOwo=