113008 2013-03-21 23:18:03 -0700 Web Inspector: [Settings] Use registry to track settings objects. 2013-03-25 00:48:18 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 eustas eustas apavlov keishi loislo pfeldman pmuellr vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 861133 0 eustas 2013-03-21 23:18:03 -0700 Currently .createSetting creates new instance any time it is invoked. When one instance saves value, the other instance do not know about it. To resolve this issue we can use registry to make .createSetting return same object for specific key. 861138 1 194450 eustas 2013-03-21 23:21:15 -0700 Created attachment 194450 Patch 862537 2 194450 webkit.review.bot 2013-03-25 00:48:14 -0700 Comment on attachment 194450 Patch Clearing flags on attachment: 194450 Committed r146745: <http://trac.webkit.org/changeset/146745> 862538 3 webkit.review.bot 2013-03-25 00:48:18 -0700 All reviewed patches have been landed. Closing bug. 194450 2013-03-21 23:21:15 -0700 2013-03-25 00:48:14 -0700 Patch bug-113008-20130322101702.patch text/plain 4217 eustas U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ2NTYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjZhZTI0ZTEzNmU3ODQ3 MGFjYjdiYjYwYzhkOTZkMjAxZjg5ZDYzZS4uZGUxYTBjNWQ1YTI3YmE2NDlmZjMwMmIyMjQ3NjYx OTcyODkwYTU1ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTAzLTIxICBFdWdl bmUgS2x5dWNobmlrb3YgIDxldXN0YXNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNw ZWN0b3I6IFtTZXR0aW5nc10gVXNlIHJlZ2lzdHJ5IHRvIHRyYWNrIHNldHRpbmdzIG9iamVjdHMu CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTMwMDgK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDdXJyZW50 bHkgLmNyZWF0ZVNldHRpbmcgY3JlYXRlcyBuZXcgaW5zdGFuY2UgYW55IHRpbWUgaXQgaXMgaW52 b2tlZC4KKyAgICAgICAgV2hlbiBvbmUgaW5zdGFuY2Ugc2F2ZXMgdmFsdWUsIHRoZSBvdGhlciBp bnN0YW5jZSBkbyBub3Qga25vdyBhYm91dCBpdC4KKworICAgICAgICBUbyByZXNvbHZlIHRoaXMg aXNzdWUgd2UgY2FuIHVzZSByZWdpc3RyeSB0byBtYWtlIC5jcmVhdGVTZXR0aW5nIHJldHVybgor ICAgICAgICBzYW1lIG9iamVjdCBmb3Igc3BlY2lmaWMga2V5LgorCisgICAgICAgICogaW5zcGVj dG9yL2Zyb250LWVuZC9TZXR0aW5ncy5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5TZXR0aW5n cy5wcm90b3R5cGUuY3JlYXRlU2V0dGluZyk6IFVzZSByZWdpc3RyeS4KKwogMjAxMy0wMy0yMSAg VGFrYXNoaSBTYWthbW90byAgPHRhc2FrQGdvb2dsZS5jb20+CiAKICAgICAgICAgWE1MRG9jdW1l bnRQYXJzZXIgZG9lc24ndCBwYXJzZSA8dGVtcGxhdGU+IGNvcnJlY3RseS4KZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU2V0dGluZ3MuanMgYi9Tb3VyY2Uv V2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1NldHRpbmdzLmpzCmluZGV4IDhlNmZjNDFkNjFj ODk2Njg0NGY2MzQ1M2EwMjFiNWFiN2M0NmNjOWIuLjM4MzQ4YjZhNGY2N2Q4ZTM4OGUyODFlMzgz YzZkNWRkMWY2NGUwMTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9u dC1lbmQvU2V0dGluZ3MuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVu ZC9TZXR0aW5ncy5qcwpAQCAtNzIsNiArNzIsNyBAQCB2YXIgQ2FwYWJpbGl0aWVzID0gewogV2Vi SW5zcGVjdG9yLlNldHRpbmdzID0gZnVuY3Rpb24oKQogewogICAgIHRoaXMuX2V2ZW50U3VwcG9y dCA9IG5ldyBXZWJJbnNwZWN0b3IuT2JqZWN0KCk7CisgICAgdGhpcy5fcmVnaXN0cnkgPSAvKiog QHR5cGUgeyFPYmplY3QuPHN0cmluZywgIVdlYkluc3BlY3Rvci5TZXR0aW5nPn0gKi8gKHt9KTsK IAogICAgIHRoaXMuY29sb3JGb3JtYXQgPSB0aGlzLmNyZWF0ZVNldHRpbmcoImNvbG9yRm9ybWF0 IiwgIm9yaWdpbmFsIik7CiAgICAgdGhpcy5jb25zb2xlSGlzdG9yeSA9IHRoaXMuY3JlYXRlU2V0 dGluZygiY29uc29sZUhpc3RvcnkiLCBbXSk7CkBAIC0xMzIsMTEgKzEzMywxNSBAQCBXZWJJbnNw ZWN0b3IuU2V0dGluZ3MgPSBmdW5jdGlvbigpCiAKIFdlYkluc3BlY3Rvci5TZXR0aW5ncy5wcm90 b3R5cGUgPSB7CiAgICAgLyoqCi0gICAgICogQHJldHVybiB7V2ViSW5zcGVjdG9yLlNldHRpbmd9 CisgICAgICogQHBhcmFtIHtzdHJpbmd9IGtleQorICAgICAqIEBwYXJhbSB7Kn0gZGVmYXVsdFZh bHVlCisgICAgICogQHJldHVybiB7IVdlYkluc3BlY3Rvci5TZXR0aW5nfQogICAgICAqLwogICAg IGNyZWF0ZVNldHRpbmc6IGZ1bmN0aW9uKGtleSwgZGVmYXVsdFZhbHVlKQogICAgIHsKLSAgICAg ICAgcmV0dXJuIG5ldyBXZWJJbnNwZWN0b3IuU2V0dGluZyhrZXksIGRlZmF1bHRWYWx1ZSwgdGhp cy5fZXZlbnRTdXBwb3J0LCB3aW5kb3cubG9jYWxTdG9yYWdlKTsKKyAgICAgICAgaWYgKCF0aGlz Ll9yZWdpc3RyeVtrZXldKQorICAgICAgICAgICAgdGhpcy5fcmVnaXN0cnlba2V5XSA9IG5ldyBX ZWJJbnNwZWN0b3IuU2V0dGluZyhrZXksIGRlZmF1bHRWYWx1ZSwgdGhpcy5fZXZlbnRTdXBwb3J0 LCB3aW5kb3cubG9jYWxTdG9yYWdlKTsKKyAgICAgICAgcmV0dXJuIHRoaXMuX3JlZ2lzdHJ5W2tl eV07CiAgICAgfQogfQogCkBAIC0yMDksNyArMjE0LDcgQEAgV2ViSW5zcGVjdG9yLkV4cGVyaW1l bnRzU2V0dGluZ3MgPSBmdW5jdGlvbigpCiAgICAgdGhpcy5fc2V0dGluZyA9IFdlYkluc3BlY3Rv ci5zZXR0aW5ncy5jcmVhdGVTZXR0aW5nKCJleHBlcmltZW50cyIsIHt9KTsKICAgICB0aGlzLl9l eHBlcmltZW50cyA9IFtdOwogICAgIHRoaXMuX2VuYWJsZWRGb3JUZXN0ID0ge307Ci0gICAgCisK ICAgICAvLyBBZGQgY3VycmVudGx5IHJ1bm5pbmcgZXhwZXJpbWVudHMgaGVyZS4KICAgICB0aGlz LnNuaXBwZXRzU3VwcG9ydCA9IHRoaXMuX2NyZWF0ZUV4cGVyaW1lbnQoInNuaXBwZXRzU3VwcG9y dCIsICJTbmlwcGV0cyBzdXBwb3J0Iik7CiAgICAgdGhpcy5uYXRpdmVNZW1vcnlTbmFwc2hvdHMg PSB0aGlzLl9jcmVhdGVFeHBlcmltZW50KCJuYXRpdmVNZW1vcnlTbmFwc2hvdHMiLCAiTmF0aXZl IG1lbW9yeSBwcm9maWxpbmciKTsKQEAgLTIzOCw3ICsyNDMsNyBAQCBXZWJJbnNwZWN0b3IuRXhw ZXJpbWVudHNTZXR0aW5ncy5wcm90b3R5cGUgPSB7CiAgICAgewogICAgICAgICByZXR1cm4gdGhp cy5fZXhwZXJpbWVudHMuc2xpY2UoKTsKICAgICB9LAotICAgIAorCiAgICAgLyoqCiAgICAgICog QHJldHVybiB7Ym9vbGVhbn0KICAgICAgKi8KQEAgLTI0Niw3ICsyNTEsNyBAQCBXZWJJbnNwZWN0 b3IuRXhwZXJpbWVudHNTZXR0aW5ncy5wcm90b3R5cGUgPSB7CiAgICAgewogICAgICAgICByZXR1 cm4gUHJlZmVyZW5jZXMuZXhwZXJpbWVudHNFbmFibGVkIHx8ICgiZXhwZXJpbWVudHMiIGluIFdl Ykluc3BlY3Rvci5xdWVyeVBhcmFtc09iamVjdCk7CiAgICAgfSwKLSAgICAKKwogICAgIC8qKgog ICAgICAqIEBwYXJhbSB7c3RyaW5nfSBleHBlcmltZW50TmFtZQogICAgICAqIEBwYXJhbSB7c3Ry aW5nfSBleHBlcmltZW50VGl0bGUKQEAgLTI1OCw3ICsyNjMsNyBAQCBXZWJJbnNwZWN0b3IuRXhw ZXJpbWVudHNTZXR0aW5ncy5wcm90b3R5cGUgPSB7CiAgICAgICAgIHRoaXMuX2V4cGVyaW1lbnRz LnB1c2goZXhwZXJpbWVudCk7CiAgICAgICAgIHJldHVybiBleHBlcmltZW50OwogICAgIH0sCi0g ICAgCisKICAgICAvKioKICAgICAgKiBAcGFyYW0ge3N0cmluZ30gZXhwZXJpbWVudE5hbWUKICAg ICAgKiBAcmV0dXJuIHtib29sZWFufQpAQCAtMjc0LDcgKzI3OSw3IEBAIFdlYkluc3BlY3Rvci5F eHBlcmltZW50c1NldHRpbmdzLnByb3RvdHlwZSA9IHsKICAgICAgICAgdmFyIGV4cGVyaW1lbnRz U2V0dGluZyA9IHRoaXMuX3NldHRpbmcuZ2V0KCk7CiAgICAgICAgIHJldHVybiBleHBlcmltZW50 c1NldHRpbmdbZXhwZXJpbWVudE5hbWVdOwogICAgIH0sCi0gICAgCisKICAgICAvKioKICAgICAg KiBAcGFyYW0ge3N0cmluZ30gZXhwZXJpbWVudE5hbWUKICAgICAgKiBAcGFyYW0ge2Jvb2xlYW59 IGVuYWJsZWQKQEAgLTMyOCw3ICszMzMsNyBAQCBXZWJJbnNwZWN0b3IuRXhwZXJpbWVudC5wcm90 b3R5cGUgPSB7CiAgICAgewogICAgICAgICByZXR1cm4gdGhpcy5fbmFtZTsKICAgICB9LAotICAg IAorCiAgICAgLyoqCiAgICAgICogQHJldHVybiB7c3RyaW5nfQogICAgICAqLwpAQCAtMzM2LDcg KzM0MSw3IEBAIFdlYkluc3BlY3Rvci5FeHBlcmltZW50LnByb3RvdHlwZSA9IHsKICAgICB7CiAg ICAgICAgIHJldHVybiB0aGlzLl90aXRsZTsKICAgICB9LAotICAgIAorCiAgICAgLyoqCiAgICAg ICogQHJldHVybiB7Ym9vbGVhbn0KICAgICAgKi8KQEAgLTM0NCw3ICszNDksNyBAQCBXZWJJbnNw ZWN0b3IuRXhwZXJpbWVudC5wcm90b3R5cGUgPSB7CiAgICAgewogICAgICAgICByZXR1cm4gdGhp cy5fZXhwZXJpbWVudHNTZXR0aW5ncy5pc0VuYWJsZWQodGhpcy5fbmFtZSk7CiAgICAgfSwKLSAg ICAKKwogICAgIC8qKgogICAgICAqIEBwYXJhbSB7Ym9vbGVhbn0gZW5hYmxlZAogICAgICAqLwo=