<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>113000</bug_id>
          
          <creation_ts>2013-03-21 21:18:39 -0700</creation_ts>
          <short_desc>Name correctly the argument of StringImpl::setIsAtomic()</short_desc>
          <delta_ts>2013-03-22 15:51:51 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Benjamin Poulain">benjamin</reporter>
          <assigned_to name="Benjamin Poulain">benjamin</assigned_to>
          <cc>cmarcelo</cc>
    
    <cc>ojan.autocc</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>861067</commentid>
    <comment_count>0</comment_count>
    <who name="Benjamin Poulain">benjamin</who>
    <bug_when>2013-03-21 21:18:39 -0700</bug_when>
    <thetext>Name correclty the argument of StringImpl::setIsAtomic</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>861069</commentid>
    <comment_count>1</comment_count>
      <attachid>194436</attachid>
    <who name="Benjamin Poulain">benjamin</who>
    <bug_when>2013-03-21 21:21:18 -0700</bug_when>
    <thetext>Created attachment 194436
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>861081</commentid>
    <comment_count>2</comment_count>
      <attachid>194436</attachid>
    <who name="Geoffrey Garen">ggaren</who>
    <bug_when>2013-03-21 21:37:35 -0700</bug_when>
    <thetext>Comment on attachment 194436
Patch

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>861925</commentid>
    <comment_count>3</comment_count>
      <attachid>194436</attachid>
    <who name="Benjamin Poulain">benjamin</who>
    <bug_when>2013-03-22 15:51:49 -0700</bug_when>
    <thetext>Comment on attachment 194436
Patch

Clearing flags on attachment: 194436

Committed r146668: &lt;http://trac.webkit.org/changeset/146668&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>861926</commentid>
    <comment_count>4</comment_count>
    <who name="Benjamin Poulain">benjamin</who>
    <bug_when>2013-03-22 15:51:51 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>194436</attachid>
            <date>2013-03-21 21:21:18 -0700</date>
            <delta_ts>2013-03-22 15:51:49 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-113000-20130321211706.patch</filename>
            <type>text/plain</type>
            <size>1507</size>
            <attacher name="Benjamin Poulain">benjamin</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ2NTU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n
ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGUzNGJjMjg5YWMwOTVmNTlkZDk3NTk5
OTgzNTRhN2MyZjY0Mjc2ZDkuLmQzMmE0YjhkYzgzMmFkMGE2NWMzNDRkZGIxNTYxYmI1ZWFiZDNi
NTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh
bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTMtMDMtMjEgIEJlbmphbWluIFBvdWxhaW4gIDxi
cG91bGFpbkBhcHBsZS5jb20+CisKKyAgICAgICAgTmFtZSBjb3JyZWN0bHkgdGhlIGFyZ3VtZW50
IG9mIFN0cmluZ0ltcGw6OnNldElzQXRvbWljKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp
dC5vcmcvc2hvd19idWcuY2dpP2lkPTExMzAwMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E
WSAoT09QUyEpLgorCisgICAgICAgICogd3RmL3RleHQvU3RyaW5nSW1wbC5oOgorICAgICAgICAo
V1RGOjpTdHJpbmdJbXBsOjpzZXRJc0F0b21pYyk6CisgICAgICAgIFRoZSBhcmd1bWVudCB3YXMg
cHJvYmFibHkgYW4gdW5mb3J0dW5hdGUgY29weS1wYXN0ZSBmcm9tIHNldElzSWRlbnRpZmllcigp
LgorICAgICAgICBGaXggdGhlIG5hbWUuCisKIDIwMTMtMDMtMjEgIE1hcmsgTGFtICA8bWFyay5s
YW1AYXBwbGUuY29tPgogCiAgICAgICAgIEludHJvZHVjaW5nIFN0cmluZzo6ZmluZE5leHRMaW5l
U3RhcnQoKS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL3RleHQvU3RyaW5nSW1wbC5oIGIv
U291cmNlL1dURi93dGYvdGV4dC9TdHJpbmdJbXBsLmgKaW5kZXggMzc5OTVhZDg4ZmNlMTg3NDFj
MzgxNWUzODE1ZDkyOWQxYzUxN2YwMS4uMWU0NDNhN2JlYTA0YzQzZjAyMzhlNmMwYWRmZjk1MDJj
YTAwNzJmOSAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvdGV4dC9TdHJpbmdJbXBsLmgKKysr
IGIvU291cmNlL1dURi93dGYvdGV4dC9TdHJpbmdJbXBsLmgKQEAgLTUxOCwxMCArNTE4LDEwIEBA
IHB1YmxpYzoKICAgICBib29sIGhhc1Rlcm1pbmF0aW5nTnVsbENoYXJhY3RlcigpIGNvbnN0IHsg
cmV0dXJuIG1faGFzaEFuZEZsYWdzICYgc19oYXNoRmxhZ0hhc1Rlcm1pbmF0aW5nTnVsbENoYXJh
Y3RlcjsgfQogCiAgICAgYm9vbCBpc0F0b21pYygpIGNvbnN0IHsgcmV0dXJuIG1faGFzaEFuZEZs
YWdzICYgc19oYXNoRmxhZ0lzQXRvbWljOyB9Ci0gICAgdm9pZCBzZXRJc0F0b21pYyhib29sIGlz
SWRlbnRpZmllcikKKyAgICB2b2lkIHNldElzQXRvbWljKGJvb2wgaXNBdG9taWMpCiAgICAgewog
ICAgICAgICBBU1NFUlQoIWlzU3RhdGljKCkpOwotICAgICAgICBpZiAoaXNJZGVudGlmaWVyKQor
ICAgICAgICBpZiAoaXNBdG9taWMpCiAgICAgICAgICAgICBtX2hhc2hBbmRGbGFncyB8PSBzX2hh
c2hGbGFnSXNBdG9taWM7CiAgICAgICAgIGVsc2UKICAgICAgICAgICAgIG1faGFzaEFuZEZsYWdz
ICY9IH5zX2hhc2hGbGFnSXNBdG9taWM7Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>