112998 2013-03-21 20:22:34 -0700 [BlackBerry] Memory leak in UserMediaClientImpl 2013-03-26 03:46:52 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 0 xiaobwang webkit-unassigned eric.carlson feature-media-reviews jer.noble mifenton rwlbuis tonikitoo webkit.review.bot oldest_to_newest 861042 0 xiaobwang 2013-03-21 20:22:34 -0700 Should destroy itself in UserMediaClientImpl::pageDestroyed(), as other XXClientBlackBerry did, like GeolocationClientBlackBerry::geolocationDestroyed(). 861061 1 194433 xiaobwang 2013-03-21 21:09:21 -0700 Created attachment 194433 patch 861064 2 webkit.review.bot 2013-03-21 21:13:23 -0700 Attachment 194433 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/blackberry/ChangeLog', u'Source/WebKit/blackberry/WebCoreSupport/UserMediaClientImpl.cpp']" exit_code: 1 Source/WebKit/blackberry/WebCoreSupport/UserMediaClientImpl.cpp:113: Tab found; better to use spaces [whitespace/tab] [1] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 861068 3 194435 xiaobwang 2013-03-21 21:20:09 -0700 Created attachment 194435 patch Tab replaced. 861070 4 194433 xiaobwang 2013-03-21 21:21:21 -0700 Comment on attachment 194433 patch OK 861071 5 194433 xiaobwang 2013-03-21 21:21:42 -0700 Comment on attachment 194433 patch OK 861377 6 194435 rwlbuis 2013-03-22 05:39:42 -0700 Comment on attachment 194435 patch LGTM. 863516 7 194435 charles.wei 2013-03-26 03:40:28 -0700 Comment on attachment 194435 patch commit it. 863525 8 194435 webkit.review.bot 2013-03-26 03:46:48 -0700 Comment on attachment 194435 patch Clearing flags on attachment: 194435 Committed r146865: <http://trac.webkit.org/changeset/146865> 863526 9 webkit.review.bot 2013-03-26 03:46:52 -0700 All reviewed patches have been landed. Closing bug. 194433 2013-03-21 21:09:21 -0700 2013-03-21 21:21:42 -0700 patch 0001-BlackBerry-Memory-leak-in-UserMediaClientImpl.patch text/plain 2386 xiaobwang RnJvbSA2MDU1YmJmZjcyNjI4M2MyZDU0MmQ3ZDc1OTc4ZTk1MWI2MTVmMmI2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBYaWFvYm8gV2FuZyA8eGJ3YW5nQHRvcmNobW9iaWxlLmNvbS5j bj4KRGF0ZTogRnJpLCAyMiBNYXIgMjAxMyAxMjowNDoyNiArMDgwMApTdWJqZWN0OiBbUEFUQ0hd IFtCbGFja0JlcnJ5XSBNZW1vcnkgbGVhayBpbiBVc2VyTWVkaWFDbGllbnRJbXBsCiBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEyOTk4CgpSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KClBSIDMxMjU1OQpJbnRlcm5hbGx5IFJldmlld2VkIGJ5IEFudGhvbnkgU2Np YW4uCgpTaG91bGQgZGVzdHJveSBpdHNlbGYgaW4gVXNlck1lZGlhQ2xpZW50SW1wbDo6cGFnZURl c3Ryb3llZCgpLCBhcyBvdGhlcgpYWENsaWVudEJsYWNrQmVycnkgZGlkLCBsaWtlIEdlb2xvY2F0 aW9uQ2xpZW50QmxhY2tCZXJyeTo6Z2VvbG9jYXRpb25EZXN0cm95ZWQoKS4KCiogV2ViQ29yZVN1 cHBvcnQvVXNlck1lZGlhQ2xpZW50SW1wbC5jcHA6CihXZWJDb3JlOjpVc2VyTWVkaWFDbGllbnRJ bXBsOjpwYWdlRGVzdHJveWVkKToKLS0tCiBTb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdl TG9nICAgICAgICAgICAgICAgICB8ICAgMTYgKysrKysrKysrKysrKysrKwogLi4uL1dlYkNvcmVT dXBwb3J0L1VzZXJNZWRpYUNsaWVudEltcGwuY3BwICAgICAgICAgfCAgICAxICsKIDIgZmlsZXMg Y2hhbmdlZCwgMTcgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxh Y2tiZXJyeS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nCmlu ZGV4IGM4NTgwMTAuLjE2ZjViNjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJy eS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpAQCAt MSw1ICsxLDIxIEBACiAyMDEzLTAzLTIxICBYaWFvYm8gV2FuZyAgPHhid2FuZ0B0b3JjaG1vYmls ZS5jb20uY24+CiAKKyAgICAgICAgW0JsYWNrQmVycnldIE1lbW9yeSBsZWFrIGluIFVzZXJNZWRp YUNsaWVudEltcGwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTExMjk5OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFBSIDMxMjU1OQorICAgICAgICBJbnRlcm5hbGx5IFJldmlld2VkIGJ5IEFudGhvbnkgU2Np YW4uCisKKyAgICAgICAgU2hvdWxkIGRlc3Ryb3kgaXRzZWxmIGluIFVzZXJNZWRpYUNsaWVudElt cGw6OnBhZ2VEZXN0cm95ZWQoKSwgYXMgb3RoZXIKKyAgICAgICAgWFhDbGllbnRCbGFja0JlcnJ5 IGRpZCwgbGlrZSBHZW9sb2NhdGlvbkNsaWVudEJsYWNrQmVycnk6Omdlb2xvY2F0aW9uRGVzdHJv eWVkKCkuCisKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9Vc2VyTWVkaWFDbGllbnRJbXBsLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OlVzZXJNZWRpYUNsaWVudEltcGw6OnBhZ2VEZXN0cm95ZWQp OgorCisyMDEzLTAzLTIxICBYaWFvYm8gV2FuZyAgPHhid2FuZ0B0b3JjaG1vYmlsZS5jb20uY24+ CisKICAgICAgICAgW0JsYWNrQmVycnldIE1lbW9yeSBsZWFrIGluIFdlYlBhZ2VQcml2YXRlLmNw cCAtIE5hdmlnYXRvckNvbnRlbnRVdGlsc0NsaWVudEJsYWNrQmVycnkKICAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMjk5NgogCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViQ29yZVN1cHBvcnQvVXNlck1lZGlhQ2xpZW50SW1w bC5jcHAgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViQ29yZVN1cHBvcnQvVXNlck1lZGlh Q2xpZW50SW1wbC5jcHAKaW5kZXggOTVkMmMyMy4uNTcwMTAwMiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L1VzZXJNZWRpYUNsaWVudEltcGwuY3Bw CisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJDb3JlU3VwcG9ydC9Vc2VyTWVkaWFD bGllbnRJbXBsLmNwcApAQCAtMTEwLDYgKzExMCw3IEBAIFVzZXJNZWRpYUNsaWVudEltcGw6On5V c2VyTWVkaWFDbGllbnRJbXBsKCkKIAogdm9pZCBVc2VyTWVkaWFDbGllbnRJbXBsOjpwYWdlRGVz dHJveWVkKCkKIHsKKwlkZWxldGUgdGhpczsKIH0KIAogdm9pZCBVc2VyTWVkaWFDbGllbnRJbXBs OjpyZXF1ZXN0VXNlck1lZGlhKFBhc3NSZWZQdHI8VXNlck1lZGlhUmVxdWVzdD4gcHJwUmVxdWVz dCwgY29uc3QgTWVkaWFTdHJlYW1Tb3VyY2VWZWN0b3ImIGF1ZGlvU291cmNlcywgY29uc3QgTWVk aWFTdHJlYW1Tb3VyY2VWZWN0b3ImIHZpZGVvU291cmNlcykKLS0gCjEuNy45LjUKCg== 194435 2013-03-21 21:20:09 -0700 2013-03-26 03:46:47 -0700 patch 0001-BlackBerry-Memory-leak-in-UserMediaClientImpl.patch text/plain 2389 xiaobwang RnJvbSAzNDM3MGQ1NTY2OTYyMjE1M2IzOWIxZjI0ZjI1NWY5MWQ4YzhiMGE4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBYaWFvYm8gV2FuZyA8eGJ3YW5nQHRvcmNobW9iaWxlLmNvbS5j bj4KRGF0ZTogRnJpLCAyMiBNYXIgMjAxMyAxMjowNDoyNiArMDgwMApTdWJqZWN0OiBbUEFUQ0hd IFtCbGFja0JlcnJ5XSBNZW1vcnkgbGVhayBpbiBVc2VyTWVkaWFDbGllbnRJbXBsCiBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEyOTk4CgpSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KClBSIDMxMjU1OQpJbnRlcm5hbGx5IFJldmlld2VkIGJ5IEFudGhvbnkgU2Np YW4uCgpTaG91bGQgZGVzdHJveSBpdHNlbGYgaW4gVXNlck1lZGlhQ2xpZW50SW1wbDo6cGFnZURl c3Ryb3llZCgpLCBhcyBvdGhlcgpYWENsaWVudEJsYWNrQmVycnkgZGlkLCBsaWtlIEdlb2xvY2F0 aW9uQ2xpZW50QmxhY2tCZXJyeTo6Z2VvbG9jYXRpb25EZXN0cm95ZWQoKS4KCiogV2ViQ29yZVN1 cHBvcnQvVXNlck1lZGlhQ2xpZW50SW1wbC5jcHA6CihXZWJDb3JlOjpVc2VyTWVkaWFDbGllbnRJ bXBsOjpwYWdlRGVzdHJveWVkKToKLS0tCiBTb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdl TG9nICAgICAgICAgICAgICAgICB8ICAgMTYgKysrKysrKysrKysrKysrKwogLi4uL1dlYkNvcmVT dXBwb3J0L1VzZXJNZWRpYUNsaWVudEltcGwuY3BwICAgICAgICAgfCAgICAxICsKIDIgZmlsZXMg Y2hhbmdlZCwgMTcgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxh Y2tiZXJyeS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nCmlu ZGV4IGM4NTgwMTAuLjE2ZjViNjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJy eS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpAQCAt MSw1ICsxLDIxIEBACiAyMDEzLTAzLTIxICBYaWFvYm8gV2FuZyAgPHhid2FuZ0B0b3JjaG1vYmls ZS5jb20uY24+CiAKKyAgICAgICAgW0JsYWNrQmVycnldIE1lbW9yeSBsZWFrIGluIFVzZXJNZWRp YUNsaWVudEltcGwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTExMjk5OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFBSIDMxMjU1OQorICAgICAgICBJbnRlcm5hbGx5IFJldmlld2VkIGJ5IEFudGhvbnkgU2Np YW4uCisKKyAgICAgICAgU2hvdWxkIGRlc3Ryb3kgaXRzZWxmIGluIFVzZXJNZWRpYUNsaWVudElt cGw6OnBhZ2VEZXN0cm95ZWQoKSwgYXMgb3RoZXIKKyAgICAgICAgWFhDbGllbnRCbGFja0JlcnJ5 IGRpZCwgbGlrZSBHZW9sb2NhdGlvbkNsaWVudEJsYWNrQmVycnk6Omdlb2xvY2F0aW9uRGVzdHJv eWVkKCkuCisKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9Vc2VyTWVkaWFDbGllbnRJbXBsLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OlVzZXJNZWRpYUNsaWVudEltcGw6OnBhZ2VEZXN0cm95ZWQp OgorCisyMDEzLTAzLTIxICBYaWFvYm8gV2FuZyAgPHhid2FuZ0B0b3JjaG1vYmlsZS5jb20uY24+ CisKICAgICAgICAgW0JsYWNrQmVycnldIE1lbW9yeSBsZWFrIGluIFdlYlBhZ2VQcml2YXRlLmNw cCAtIE5hdmlnYXRvckNvbnRlbnRVdGlsc0NsaWVudEJsYWNrQmVycnkKICAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMjk5NgogCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViQ29yZVN1cHBvcnQvVXNlck1lZGlhQ2xpZW50SW1w bC5jcHAgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViQ29yZVN1cHBvcnQvVXNlck1lZGlh Q2xpZW50SW1wbC5jcHAKaW5kZXggOTVkMmMyMy4uYTdiYWYyMCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L1VzZXJNZWRpYUNsaWVudEltcGwuY3Bw CisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJDb3JlU3VwcG9ydC9Vc2VyTWVkaWFD bGllbnRJbXBsLmNwcApAQCAtMTEwLDYgKzExMCw3IEBAIFVzZXJNZWRpYUNsaWVudEltcGw6On5V c2VyTWVkaWFDbGllbnRJbXBsKCkKIAogdm9pZCBVc2VyTWVkaWFDbGllbnRJbXBsOjpwYWdlRGVz dHJveWVkKCkKIHsKKyAgICBkZWxldGUgdGhpczsKIH0KIAogdm9pZCBVc2VyTWVkaWFDbGllbnRJ bXBsOjpyZXF1ZXN0VXNlck1lZGlhKFBhc3NSZWZQdHI8VXNlck1lZGlhUmVxdWVzdD4gcHJwUmVx dWVzdCwgY29uc3QgTWVkaWFTdHJlYW1Tb3VyY2VWZWN0b3ImIGF1ZGlvU291cmNlcywgY29uc3Qg TWVkaWFTdHJlYW1Tb3VyY2VWZWN0b3ImIHZpZGVvU291cmNlcykKLS0gCjEuNy45LjUKCg==